Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232366/?format=api
{ "id": 2232366, "url": "http://patchwork.ozlabs.org/api/patches/2232366/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-38-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260504-qom-tests-v2-38-ef7e3dc94f7a@redhat.com>", "list_archive_url": null, "date": "2026-05-04T11:35:26", "name": "[v2,38/46] hw/arm/virt: free flash devices and OEM strings on finalization", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "609c2487f62b9bc85a099e058191f698caeef9db", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-38-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232366/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dk7RY4ev;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KSy5WLRz1y04\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:40:18 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrdc-0000SN-H6; Mon, 04 May 2026 07:39:00 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrdb-0000Ja-4F\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:59 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrdZ-0001Mq-Kr\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:38:58 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-sRnLC6nFNxKppvSnhqseyA-1; Mon,\n 04 May 2026 07:38:55 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B116E195609D; Mon, 4 May 2026 11:38:54 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B5E5D180045E; Mon, 4 May 2026 11:38:53 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894737;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9KEGTmyxrc7XP1G2EZKa1n2uGmD818fX8zVRKUr15Fg=;\n b=dk7RY4evrTiFQSCO2SHDTa3A55oVMOzdBiByDajppbP0t6boDqUBt5NtqbcJ1cGzwc3z2H\n tqmFgSGg81e6vlbfkfHEVygJoJoC8C7HOLNHh9cEU4EiXJ6IvF/tuaBoKJzAN4BECDtz2J\n pS4MOcOXAzD6Q5WsA7f71cmQUQHZFmY=", "X-MC-Unique": "sRnLC6nFNxKppvSnhqseyA-1", "X-Mimecast-MFC-AGG-ID": "sRnLC6nFNxKppvSnhqseyA_1777894734", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:26 +0400", "Subject": "[PATCH v2 38/46] hw/arm/virt: free flash devices and OEM strings\n on finalization", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-38-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1696;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=GsOgr5n9WQyuSxd7SPoMPhp96GkvsouIHeYWWY0Z4NY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRtSd3cW5fVMopqWZ6WH+5cYZt5gx9n1TDp0\n oWm94/m/W2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbQAKCRDa6OEJdZac\n 5W6kD/43TeJjjgdu+X5R0pWhIhGDM2jPxwvb8YNHtKy6qqS3bmx+sK3JJyruznthCwQDbh+kG9G\n 1S4ifsokqBH3kXAC01h+HumUFy2BIfura09GtVyvHcOPhFBbyBB9WYsY0SuDp7D/7kg1m8bek7Y\n 7Tu1lSs36XtbUQ+gLeLPGu0zFYfbga75MadukDyVXbnzD2uiyxNgXhM63imLrBpExJYaNtHE5yk\n ug6PogyFrME9AyGrSTdjjP717YR27nAPbJmvKRHocN+emvfLDGIVdme92AO6SVXsQ+Ldr57x/ga\n JY2BRC6z4JxrNoQztiiNg37waRm1ZRPFnGvNK5YcpJI4cm7rJiybRm6aR6U9VqYK7VWi++lxmE/\n VVVKZXucl9lQy9cNLLLdUvFKzqft6Yp3dkAa2/nHNXyTDaNiMz2Mkj5y4sPiWtmCKA1MGh8fr+B\n GrVAQIxlGGKh9tGW70BUYF3Q07hHhnfcgu6br7rVBldWypKR1+qAMtQxYLBHcSUX57OSkvYxagO\n lU5LlP+XQOuqs1SqCzLrksIqQS4MNFoC7Aac8eC29OTgsQ32yP8S37GuPByFT/EeTSvdOpon7Jc\n OCkMurnWCFZbyoAS+XT0a7GcdSJKlPusP6O5XB1BFCHeu21QidovuEsBTBy20FkOKYHZk6j14/R\n 7RSJSrEcjp31CWw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Flash devices created in instance_init via qdev_new() hold an extra\nreference that is only dropped on sysbus_realize_and_unref(). When the\nmachine is destroyed before realization, the flash objects leak. Also,\nthe oem_id and oem_table_id strings from g_strndup() are never freed.\n\nFixes: 602b458201ff (\"acpi: Permit OEM ID and OEM table ID fields to be changed\")\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/arm/virt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/hw/arm/virt.c b/hw/arm/virt.c\nindex 77891f08200..9510d9eea73 100644\n--- a/hw/arm/virt.c\n+++ b/hw/arm/virt.c\n@@ -4031,6 +4031,19 @@ static void virt_instance_init(Object *obj)\n cxl_machine_init(obj, &vms->cxl_devices_state);\n }\n \n+static void virt_instance_finalize(Object *obj)\n+{\n+ VirtMachineState *vms = VIRT_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(vms->flash); i++) {\n+ if (vms->flash[i] && !qdev_is_realized(DEVICE(vms->flash[i]))) {\n+ object_unref(OBJECT(vms->flash[i]));\n+ }\n+ }\n+ g_free(vms->oem_id);\n+ g_free(vms->oem_table_id);\n+}\n+\n static const TypeInfo virt_machine_info = {\n .name = TYPE_VIRT_MACHINE,\n .parent = TYPE_MACHINE,\n@@ -4039,6 +4052,7 @@ static const TypeInfo virt_machine_info = {\n .class_size = sizeof(VirtMachineClass),\n .class_init = virt_machine_class_init,\n .instance_init = virt_instance_init,\n+ .instance_finalize = virt_instance_finalize,\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_HOTPLUG_HANDLER },\n { }\n", "prefixes": [ "v2", "38/46" ] }