Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232351/?format=api
{ "id": 2232351, "url": "http://patchwork.ozlabs.org/api/patches/2232351/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-19-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260504-qom-tests-v2-19-ef7e3dc94f7a@redhat.com>", "list_archive_url": null, "date": "2026-05-04T11:35:07", "name": "[v2,19/46] hw/core/machine: free shim_filename on finalization", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b631f9782fb932fd7623e01122f2a6324ea3c173", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-19-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232351/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232351/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BImmZ+gs;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KR04PBbz1yKW\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:38:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrcE-0001YY-Os; Mon, 04 May 2026 07:37:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbn-0000q3-Oe\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:08 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbl-00012L-Ox\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:07 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-RyWBl1BlNaeLXqANzqKcgA-1; Mon,\n 04 May 2026 07:37:04 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2EC0E1800578\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:37:03 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id CB7051800669; Mon, 4 May 2026 11:37:01 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894625;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8YvsVsIi/1TFcOv3yrrnCyz6XIRwOmOuXGjMWoQQNxM=;\n b=BImmZ+gsjt0fdtjn/XsHeoo5FkgNUkb5yvjKLmdSqcpF7e6hBQi9U7pzB8SHPAksJjlZ0I\n qJSAdXWAKT4NyvGV9VEET+a/j/keLkKZWWywneDILkfFr39ZbnwnG8Oco8BWW5jHHYcDwF\n 1GkvYRCUIG7ZsHNm23Hj7NAUA3a8NTQ=", "X-MC-Unique": "RyWBl1BlNaeLXqANzqKcgA-1", "X-Mimecast-MFC-AGG-ID": "RyWBl1BlNaeLXqANzqKcgA_1777894623", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:07 +0400", "Subject": "[PATCH v2 19/46] hw/core/machine: free shim_filename on finalization", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-19-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=718;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=HkzWuVnjpE18HvhyvwlZdG6XDtkdNuA+nhZi8wBpL2I=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRs4Hm9zgRLx2kuLaxEm4HhimPiCJDmOl71p\n AzLhPQY/5yJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5d9JD/4scmNdG+cc6cR0bPnR/rX6WWnaMXCjPe5Kxo8Rbv0FA0IlejLziuEb/ujsrrYnyknPfMq\n Im3AIYiPRlQKVWh1V0BSDc8/k8EQm5kH9qrpQv7HYx5Uy+3bGrD0Xr9/8lnF0Hn0Of2UqEPd75n\n StesVQj68Z/JVzN+AvGtPSttrrv84csAESI+2AGWeE230NqQyDg+XkguUbYXWICmmxOK7iKYGcz\n A8wKPWUnlCFvgTMYVGa4o+gRUuUFbN6aXnaKSuJGapP4I7TOjsG1vo4U1gloFPPaMnUJiNb4YQg\n sYMFeXG9lGczuOeLoXXs+71UEKknaRSEBnFaoQBW6shGumDDep2DuBjiM7FlgHyXZ6sr8HnM/hp\n HGEMYgzsnCOYPgbpCViZsv5QgawkczFFsKGQEpjXtroAjErAzdJ1WbHuAH0BCsZ/rKQ7mEkB3Fy\n V/1298RyvaDVYZewmlwG2ZN9/ucICOqlH93HoMYzoQFXQ3fj9M8HQ99zxkI7HOq/11bIwm2KhTc\n /ihDfTCGt23TrB6h2KqDOC0InOQ201+zLrU1q9RqNlCIe2ymiUMH1CbBkA2lipt0KNWfG04KaGh\n nSjglhZQsEo039U+idcVsUnbu/EpHV9H31wiqQVwhF96Iq0ZzCXRcI7dCQx42K4Me/B1cyuLUuJ\n er88ryI+WFMX/+A==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "machine_set_shim allocates shim_filename via g_strdup, but\nmachine_finalize did not free it.\n\nFixes: a5bd044b1579 (\"x86/loader: add -shim option\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/core/machine.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/hw/core/machine.c b/hw/core/machine.c\nindex 1b661fd36ae..6a7fb312eb6 100644\n--- a/hw/core/machine.c\n+++ b/hw/core/machine.c\n@@ -1282,6 +1282,7 @@ static void machine_finalize(Object *obj)\n MachineState *ms = MACHINE(obj);\n \n machine_free_boot_config(ms);\n+ g_free(ms->shim_filename);\n g_free(ms->kernel_filename);\n g_free(ms->initrd_filename);\n g_free(ms->kernel_cmdline);\n", "prefixes": [ "v2", "19/46" ] }