Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232347/?format=api
{ "id": 2232347, "url": "http://patchwork.ozlabs.org/api/patches/2232347/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-18-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260504-qom-tests-v2-18-ef7e3dc94f7a@redhat.com>", "list_archive_url": null, "date": "2026-05-04T11:35:06", "name": "[v2,18/46] hw/i386/x86: free oem_id and oem_table_id on finalization", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9c1ac9b19416dcb4a7d18cc2be6ae62aad9a960a", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-18-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232347/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232347/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=B3Su6JUd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KQq0ghLz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:38:27 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrbt-0000xz-9Y; Mon, 04 May 2026 07:37:15 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbj-0000lD-Gs\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:04 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbi-00011p-4T\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:37:03 -0400", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-1ug8KojwM6ixqBUVbli2BA-1; Mon,\n 04 May 2026 07:36:57 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1812818005AC; Mon, 4 May 2026 11:36:57 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B13E030001A1; Mon, 4 May 2026 11:36:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894621;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eveSPPinlS5ge22zD59cWM5/VNbVy81aT0zg3hIugP0=;\n b=B3Su6JUd878QMeZfs5fvi4necCdywzng/ulAXJjbJX0jy+rKxaQkpJ+iFOFI25USH1iawB\n AoDHosbGJ9pPZMAe4pyHFAA4afQB+/bBzEMIeYCIiJSM8ojpcZoM2QNvWB4+HoBFypft5X\n JnBRHvT6mfUb4zEQNIUU/cdl6NR7IIQ=", "X-MC-Unique": "1ug8KojwM6ixqBUVbli2BA-1", "X-Mimecast-MFC-AGG-ID": "1ug8KojwM6ixqBUVbli2BA_1777894617", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:06 +0400", "Subject": "[PATCH v2 18/46] hw/i386/x86: free oem_id and oem_table_id on\n finalization", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-18-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1438;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=V+2eXo/TucBNqV2DxgpQIOrwZ4TdO+5VekaKqMhBHdM=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsmXMbrvbLPcc1njAZ4kl81Be3nHve/fEzC\n I0fbECuFI2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5cW8D/43mfpZX7a0IYtZxXdnRmUDOeMA7FkZg7PGh3wp/nxYgRGEk+tNZkey5crQz44XXyBQEzt\n WsJWJt0c3F8o3x7H8btkcpsQANNEWrPLfCWEH0CZdENquo+d0Oexg4KdOWM8+Tjo2FQT5xr2iOG\n DlN3y6YFJsiv5+nYUIVxKBosr4wqX4VzJSrZJ4a0fxoUK8iGQjUo6u29hvneagaYRTVT4LeSJbV\n ehZsmejowpUhKMhU9egvXWgKrwDki+WVrgp9BLNPvgWzgQt1Pfx31QUVTcqEb4cxzdq7LPPAHNx\n gSvq0QqvAhqFWUai0sDfo7NTCPleaImtbxaqMxN0qf/P57LpqRsD+7n6dJYjX3C6NjwYSq0s2U7\n Ht2b2NM32da05BbPfyl2QGv8DuzyhK3fQg3XauXTw9q9b7lZlFkKJTh0BW6OQ9qU/EEDeeMBMbg\n zVXk2/4nV7YMWi6V7Ok4NhTYaI12lQv0IFYLVHrrsp8Hiqh5p/EK1zPj2BYd6VrSHfuw6mcOOLH\n 5kmDGa1cInxFZiugR2p9Zm9Dl4k8k4w1McUlBp9FtI4CsZ2hG3mbPlHMx+9B2H0DPALxQawgKwE\n kU6LlfXGqPKJS4xm/T7eo5kfoHaqhwlrqWmpKFiJCO7L9/H8jKAl7oIjwtjvHJ8NEmH4h2SH+bJ\n yaN7wbZqUFgFhdQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "x86_machine_initfn allocates oem_id and oem_table_id via g_strndup,\nbut no instance_finalize existed for x86_machine_info, so these\nstrings were never freed when the object was destroyed.\n\nAdd x86_machine_finalize to release both fields.\n\nFixes: d07b22863b8e (\"acpi: Move setters/getters of oem fields to X86MachineState\")\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/i386/x86.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/hw/i386/x86.c b/hw/i386/x86.c\nindex 01872cba073..dc7f0d56b01 100644\n--- a/hw/i386/x86.c\n+++ b/hw/i386/x86.c\n@@ -372,6 +372,14 @@ static void x86_machine_initfn(Object *obj)\n x86ms->above_4g_mem_start = 4 * GiB;\n }\n \n+static void x86_machine_finalize(Object *obj)\n+{\n+ X86MachineState *x86ms = X86_MACHINE(obj);\n+\n+ g_free(x86ms->oem_id);\n+ g_free(x86ms->oem_table_id);\n+}\n+\n static void x86_machine_class_init(ObjectClass *oc, const void *data)\n {\n MachineClass *mc = MACHINE_CLASS(oc);\n@@ -445,6 +453,7 @@ static const TypeInfo x86_machine_info = {\n .abstract = true,\n .instance_size = sizeof(X86MachineState),\n .instance_init = x86_machine_initfn,\n+ .instance_finalize = x86_machine_finalize,\n .class_size = sizeof(X86MachineClass),\n .class_init = x86_machine_class_init,\n .interfaces = (const InterfaceInfo[]) {\n", "prefixes": [ "v2", "18/46" ] }