Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232336/?format=api
{ "id": 2232336, "url": "http://patchwork.ozlabs.org/api/patches/2232336/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-14-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260504-qom-tests-v2-14-ef7e3dc94f7a@redhat.com>", "list_archive_url": null, "date": "2026-05-04T11:35:02", "name": "[v2,14/46] net/colo-compare: guard finalize against uninitialized state", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "254ba2d89c43e8dd684cb911565fd1f037df7cb8", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-14-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232336/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BOEcFusA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KPM3Zf0z1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:37:11 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJrbi-0000gO-U8; Mon, 04 May 2026 07:37:03 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbN-0008VB-Ax\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:44 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJrbL-0000xB-HC\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:36:41 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-LlMReqR3NvK4PTAI2A0i8A-1; Mon,\n 04 May 2026 07:36:35 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B5E3C18002CA\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:36:34 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 58A7419560A6; Mon, 4 May 2026 11:36:32 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894596;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=+iCE38jqlJCBLLcHpTqZ9+JVULDCpuuOY0DmjcBZNX0=;\n b=BOEcFusAkH/VBPCTZyTn6XyY+uQ2jn5h9RFpbR63kbdCQqL6l1N7LXy/7jVyntL597skzM\n /7Mv3L9KZuf1luHA0bAAxk6fgW7FHADHPr7a/evWSKvSPf9RtD79WBj/QZCVqkwWg+eEJq\n XMsxxE8/CuGoL2Q3TG8b891hw7C1ccU=", "X-MC-Unique": "LlMReqR3NvK4PTAI2A0i8A-1", "X-Mimecast-MFC-AGG-ID": "LlMReqR3NvK4PTAI2A0i8A_1777894594", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:35:02 +0400", "Subject": "[PATCH v2 14/46] net/colo-compare: guard finalize against\n uninitialized state", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-14-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n peterx@redhat.com, Peter Xu <peterx@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3019;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=ZF3TTPjvQzahlqd48t2i0EXIpqN0l7MjdPJ+auYGt8Q=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsZoHtXsl7/p/bMftfDtmG6o5dxrTlnuorF\n 9Nn6p+gRZ+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5WhRD/9Io3z5CxnKgzdQzwLchLrExLXrbExVDg5J1QxcusG04SiVp3fdkomxEQqj78G8xIFzUXV\n zOogkSONWpW//0HsAgV/i+VbslwhJ6npnQYgkHKt9Dy/ayTMbNjhJyI1lUFiMBq88kONbj6m0vB\n qkBwfuyc0UCGQyyqhW0VCeUiYvgLXPuT3YH4rFDUkpP/QXuuM3BxZaMBzVkU9mySfxqesLgwj8k\n scJGFg3VoKT6T+CybUJ0Q3aUsimnx2y4d6mK831AJAcnpcrvh87HXejELRYguQqjDQL7VSBWYHf\n vb2zoRxUAxlwckF6AyyQT0zL5r6OFcQwYtqzOK5qhRfwQuRLcpRrK0QqA54R0ILvrc8InRg3SJz\n btDivouHrXiMYVawVDgyOpVu4sbauT52YC7XxsFUr1mPaqf/5BbJqL8wCSv92vJErw/47o7LYf/\n XnF5gLz4olifXRyDHZuzhzPpBEanI/Aqo3b1LiGwcBKIWUBQsRO8HYxQinj7yeyB5QRlx8nGsJH\n WKa3PvICT98X5c7VSfcZQlEvhzQfE8SW7AVnaEJCAZJlO61g67njaSxze81SCLVTcmtA+EvTkQZ\n do4BdXcPoVk+iX1Q8Q6oWYK037wrnhjnjVfAhd9zatCRtU+70TFmEumYZWLxdvL8Wcd2l3SM7Lb\n yOIsCS1DGEZOZjw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-24", "X-Spam_score": "-2.5", "X-Spam_bar": "--", "X-Spam_report": "(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "colo_compare_finalize() assumes the object was fully set up by\ncolo_compare_complete(), but a bare object_new() followed by\nobject_unref() skips the complete callback entirely.\n\nThis causes two crashes:\n- qemu_mutex_destroy on the static event_mtx which was never\n initialized (colo_compare_active is false)\n- qemu_bh_delete(NULL) and iothread dereference when s->iothread\n is NULL\n\nGuard the event_mtx teardown with colo_compare_active, and the\niothread-dependent cleanup with an s->iothread NULL check.\n\nThis is an alternative to patch \"colo-compare: Fix QMP\nqom-list-properties crashing\", sent earlier, hence the RFC.\n\nFixes: 45942b79b9f8 (\"net/colo-compare.c: Check that colo-compare is active\")\nCc: peterx@redhat.com\nAcked-by: Peter Xu <peterx@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n net/colo-compare.c | 31 +++++++++++++++----------------\n 1 file changed, 15 insertions(+), 16 deletions(-)", "diff": "diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex c356419d6a8..be819db06c9 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -1416,7 +1416,7 @@ static void colo_compare_finalize(Object *obj)\n break;\n }\n }\n- if (QTAILQ_EMPTY(&net_compares)) {\n+ if (colo_compare_active && QTAILQ_EMPTY(&net_compares)) {\n colo_compare_active = false;\n qemu_mutex_destroy(&event_mtx);\n qemu_cond_destroy(&event_complete_cond);\n@@ -1431,30 +1431,29 @@ static void colo_compare_finalize(Object *obj)\n }\n \n colo_compare_timer_del(s);\n+ g_clear_pointer(&s->event_bh, qemu_bh_delete);\n \n- qemu_bh_delete(s->event_bh);\n+ if (s->iothread) {\n+ AioContext *ctx = iothread_get_aio_context(s->iothread);\n \n- AioContext *ctx = iothread_get_aio_context(s->iothread);\n- AIO_WAIT_WHILE(ctx, !s->out_sendco.done);\n- if (s->notify_dev) {\n- AIO_WAIT_WHILE(ctx, !s->notify_sendco.done);\n- }\n+ AIO_WAIT_WHILE(ctx, !s->out_sendco.done);\n+ if (s->notify_dev) {\n+ AIO_WAIT_WHILE(ctx, !s->notify_sendco.done);\n+ }\n+\n+ /* Release all unhandled packets after compare thread exited */\n+ g_queue_foreach(&s->conn_list, colo_flush_packets, s);\n+ AIO_WAIT_WHILE(NULL, !s->out_sendco.done);\n \n- /* Release all unhandled packets after compare thead exited */\n- g_queue_foreach(&s->conn_list, colo_flush_packets, s);\n- AIO_WAIT_WHILE(NULL, !s->out_sendco.done);\n+ object_unref(OBJECT(s->iothread));\n+ }\n \n g_queue_clear(&s->conn_list);\n g_queue_clear(&s->out_sendco.send_list);\n if (s->notify_dev) {\n g_queue_clear(&s->notify_sendco.send_list);\n }\n-\n- if (s->connection_track_table) {\n- g_hash_table_destroy(s->connection_track_table);\n- }\n-\n- object_unref(OBJECT(s->iothread));\n+ g_clear_pointer(&s->connection_track_table, g_hash_table_destroy);\n \n g_free(s->pri_indev);\n g_free(s->sec_indev);\n", "prefixes": [ "v2", "14/46" ] }