Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232334/?format=api
{ "id": 2232334, "url": "http://patchwork.ozlabs.org/api/patches/2232334/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-5-ef7e3dc94f7a@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260504-qom-tests-v2-5-ef7e3dc94f7a@redhat.com>", "list_archive_url": null, "date": "2026-05-04T11:34:53", "name": "[v2,05/46] hw/pci-host/q35: handle NULL bus in pci-hole64 getters", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d6eaaa32b22c6cf14f0eb41175e642428b153673", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260504-qom-tests-v2-5-ef7e3dc94f7a@redhat.com/mbox/", "series": [ { "id": 502649, "url": "http://patchwork.ozlabs.org/api/series/502649/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502649", "date": "2026-05-04T11:34:48", "name": "Fix various QOM object life-cycle issues", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502649/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232334/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232334/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=adKFshqN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g8KP409kDz1yJV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 21:36:56 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wJraY-0007Y2-Ko; Mon, 04 May 2026 07:35:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraX-0007XT-TP\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:49 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wJraW-0000ny-Kd\n for qemu-devel@nongnu.org; Mon, 04 May 2026 07:35:49 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-VbhkPFRcMu2o00hZ1s_NJg-1; Mon,\n 04 May 2026 07:35:44 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EC2C4195608F\n for <qemu-devel@nongnu.org>; Mon, 4 May 2026 11:35:43 +0000 (UTC)", "from localhost (unknown [10.44.24.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A24ED1800347; Mon, 4 May 2026 11:35:42 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777894547;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CRg2XEz7g/q9Y9vnBcCYZpcSu3GsBjF6YOxJNwlUUiA=;\n b=adKFshqNToisbAbMGvgAiTxgCOIPJ4PbZbhbUM4tH7C69Ys36UpFMr0aG4UelWogAB5hny\n oRsFvQPfh2pYoBxpNJ6ab79YuqAyJiLL4XUeT/by8eHcb+6s03njmBx+8MQ5U/BFAPVWLM\n gQQpMV9bHdVpQz8fDeKVU2cMTB+G5ms=", "X-MC-Unique": "VbhkPFRcMu2o00hZ1s_NJg-1", "X-Mimecast-MFC-AGG-ID": "VbhkPFRcMu2o00hZ1s_NJg_1777894544", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 04 May 2026 15:34:53 +0400", "Subject": "[PATCH v2 05/46] hw/pci-host/q35: handle NULL bus in pci-hole64\n getters", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260504-qom-tests-v2-5-ef7e3dc94f7a@redhat.com>", "References": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "In-Reply-To": "<20260504-qom-tests-v2-0-ef7e3dc94f7a@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1851;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=/fxZ1GAbhmt7eqzcBY0CxzgAhlT5phl8zL1KjrOh2so=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp+IRsFAEBdR6ZsQVMihkZL7NzJXuLVMS1oXf5G\n vcsV3wnZhaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafiEbAAKCRDa6OEJdZac\n 5R77EACX8Tc21I9tc2XKTsnuryt3fSgO5EZKCd3wBC52QaydTFdj/MDT39BiJeyaPOa4ZAC/I1C\n rxQwUjN9gsR21ZhOpR9OHSUAc0sYQIrxzZqzic0v6We2DPx713dUFwOl1TVyHoWZ1UvCiTM2jLh\n HhHUExuB+P3Xw18ASWxHQG7AT5HO3aakoQqLXhzdb5STf4I1CkzIKfE7/q64hye6DlgSCXAwdcP\n kv2gmilbvixcMQ2/w74A4DDalwL9cLmZkIErw+MAEIkcQG1/kD0xVFmbch+AeePnhByZiwg4lJt\n 4dy3YEIqo29bk+T5/bxKKTB6S6CAPGEQBTgzmrGAqocr/G9BO/Psthhbhf1usgNLvpkm4zXOAsx\n CInIfLGbZSgBvgDpUxR5n38nDOpJpuvpuPifF9vgXc5535ARc5OZXnydYuQ1VSb/rmLPAgHub40\n 4WPsURpdsFtYxohNDjT3/eDtZ1Xt9XIISBbPBnfxCrZP/rVJxcVtO2hlGpaKbzCosxrLSp0Tp8f\n of9Ia1Yk6Cy1Y4eKCorK0v8GZHQHWlS+7E/s6+4O87pJ+bh3W9yC9coOSADkiCSqsyvJOfVazWZ\n pTZMqipZLC6KLWJqcWwLIlpoKmKInrEL/uMBGMLhH6pdfxqJpWj3kvl/PtOK+gOigN5nmV7EyPk\n 9neNP5linPspiBg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "8", "X-Spam_score": "0.8", "X-Spam_bar": "/", "X-Spam_report": "(0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When called on an unrealized Q35 host bridge (e.g. from\nqmp_qom_list_properties), h->bus is NULL since the root bus is only\ncreated during realize. Guard against this in both the\npci_hole64_start and pci_hole64_end getters.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/pci-host/q35.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c\nindex e85e4227b37..355e81bfa20 100644\n--- a/hw/pci-host/q35.c\n+++ b/hw/pci-host/q35.c\n@@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj, Visitor *v,\n const char *name, void *opaque,\n Error **errp)\n {\n- uint64_t hole64_start = q35_host_get_pci_hole64_start_value(obj);\n+ PCIHostState *h = PCI_HOST_BRIDGE(obj);\n+ uint64_t hole64_start;\n \n+ if (!h->bus) {\n+ error_setg(errp, \"PCI host bridge not realized\");\n+ return;\n+ }\n+ hole64_start = q35_host_get_pci_hole64_start_value(obj);\n visit_type_uint64(v, name, &hole64_start, errp);\n }\n \n@@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, Visitor *v,\n {\n PCIHostState *h = PCI_HOST_BRIDGE(obj);\n Q35PCIHost *s = Q35_HOST_DEVICE(obj);\n- uint64_t hole64_start = q35_host_get_pci_hole64_start_value(obj);\n+ uint64_t hole64_start;\n Range w64;\n uint64_t value, hole64_end;\n \n+ if (!h->bus) {\n+ error_setg(errp, \"PCI host bridge not realized\");\n+ return;\n+ }\n+ hole64_start = q35_host_get_pci_hole64_start_value(obj);\n pci_bus_get_w64_range(h->bus, &w64);\n value = range_is_empty(&w64) ? 0 : range_upb(&w64) + 1;\n hole64_end = ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL << 30);\n", "prefixes": [ "v2", "05/46" ] }