Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232209/?format=api
{ "id": 2232209, "url": "http://patchwork.ozlabs.org/api/patches/2232209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-5-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260503204936.3151124-5-sjg@chromium.org>", "list_archive_url": null, "date": "2026-05-03T20:49:22", "name": "[4/6] beaglev_fire: Quote no_of_overlays in design test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "db543b509d7b2f40559bfbc586557f887687e921", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260503204936.3151124-5-sjg@chromium.org/mbox/", "series": [ { "id": 502588, "url": "http://patchwork.ozlabs.org/api/series/502588/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502588", "date": "2026-05-03T20:49:18", "name": "test: Quote variables in 'test -n' expressions across boards", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502588/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232209/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=eoIeGfZV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"eoIeGfZV\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7xkQ0yRdz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 06:50:38 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1D9888464E;\n\tSun, 3 May 2026 22:50:23 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id C391A845E9; Sun, 3 May 2026 22:50:21 +0200 (CEST)", "from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n [IPv6:2607:f8b0:4864:20::333])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AD4FA8464E\n for <u-boot@lists.denx.de>; Sun, 3 May 2026 22:50:19 +0200 (CEST)", "by mail-ot1-x333.google.com with SMTP id\n 46e09a7af769-7dbd801138eso2096510a34.1\n for <u-boot@lists.denx.de>; Sun, 03 May 2026 13:50:19 -0700 (PDT)", "from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-696aacbb5bbsm1142940eaf.15.2026.05.03.13.50.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 13:50:15 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777841417; x=1778446217; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=t22RTy9ow7qG9FVqH3FHklvVYzJiN75+zTsxeybSjdw=;\n b=eoIeGfZVz5ZlXfsQZTvoXvdv6Ucg55hWezVOuof9hQMpVk3Au7hjXEDltK8ehhkInH\n wJrF2hybdnjJfg+IGAwNnHgj0tddHM0PhC3s9hX8FtDbLjRpebtIk4e6EsGGQjuiuKNo\n cFDnfP9/b6wApy255p9Rr1khu0yslcJT/dhbA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777841417; x=1778446217;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=t22RTy9ow7qG9FVqH3FHklvVYzJiN75+zTsxeybSjdw=;\n b=kG6cJHnvkhSAChUVkiNPC9S1V6dYQEqFuE+0viIXOqERTZg2URBHnRxvKiSdcB8207\n vlr0BALQzsvuBaZewG5ADnXUSNyHxHDYomEkLHO7AN4FVCZmGTsbs3rEJqBf2He1QvAQ\n wnMCTxj9jqQJKv7oa6uEicHoYGLAdsaMVKBZrffZLAtSgWsnlnQvspV0qz0tFBXyG3q0\n KUPRUXB2C3gp495JwPH1nBprvIox3r4/NfFlVDGSm+E1llBnodeg4CSiJTiFZq0bh6BT\n CXAs7LgpeQKsLXrTd/mSAuOU6y/ZQhaj282030RHZsoDfyeGwKbSBjKpDDhp8DysFzW0\n ZYwg==", "X-Gm-Message-State": "AOJu0YzQJ8cRkwLumAv72XBK0ACTuPy6o5122UaaKBxTY0iaEtMPcWfs\n jsy2Xr1kAiu8NEmTnWiO07K96m4tTWIIVuiCxC0vBMTYG0mdrHmfc9GdDuSveMF8lYyKcn3micT\n 1mCFJvA==", "X-Gm-Gg": "AeBDietUj8u6XQU5HRoFcn3fR6pIP1YCky+mIYSeYEgcmTManZR+F72ZZBsZt8/yH6F\n sI/y+nCAVRIY4tB9IvExXfxCkSRJG/Am94BYHxcXDYI0CryJsRZacyvnk8jddswmlQiN0qJM0eQ\n 1lSqGZzBc2rAtEIeeb6Ocb+C4WvW5mrfM86R3hckZ0vc0b5aLhMnMBdfCigKy3W/JHA3EyQR7+W\n pvg0W+Sx6sjn5LoxsfTkASt4xs1rnTz4vlMAmUGVEuKc90aBt2i/s4Zhc7xZ3nxYGoEn8hLQBx3\n cyQwmD9C3L8qAYLq50UKBZqInlPewYZZU0nxAsU/QfnEEbCp+o17eyl9eudFiDLvIyMhOUp/Lw/\n j3SDIMJt6Rrt76LTJJx4hf/LL0U+uKSAHoN4wOwWiOgHOjpNoBMp9uT3LpuoSpHSok3F2+JVVHg\n 3MHoLb+NJar6cbAsMuM7l+rWavgQu2", "X-Received": "by 2002:a05:6820:81ca:b0:694:8e28:fd7a with SMTP id\n 006d021491bc7-69696bc9801mr3101368eaf.25.1777841417479;\n Sun, 03 May 2026 13:50:17 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Simon Glass <sjg@chromium.org>, Cyril Jean <cyril.jean@microchip.com>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>,\n Rasmus Villemoes <ravi@prevas.dk>, Tom Rini <trini@konsulko.com>", "Subject": "[PATCH 4/6] beaglev_fire: Quote no_of_overlays in design test", "Date": "Sun, 3 May 2026 14:49:22 -0600", "Message-ID": "<20260503204936.3151124-5-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260503204936.3151124-1-sjg@chromium.org>", "References": "<20260503204936.3151124-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "On beaglev_fire, design_overlays gates an overlay-application loop\non:\n\n if test -n ${no_of_overlays}; then ...\n\nThe default state is \"no overlays\", i.e. no_of_overlays unset. The\nexpression then expands to 'test -n' with no operand and relies on a\nU-Boot 'test' quirk that treats a missing operand as false to skip\nthe loop.\n\nQuote the variable so an unset no_of_overlays expands to 'test -n \"\"'\nand the emptiness check is explicit.\n\nFixes: 8b0619579b22 (\"cmd: test: fix handling of single-argument form of test\")\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n include/configs/beaglev_fire.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/configs/beaglev_fire.h b/include/configs/beaglev_fire.h\nindex e3ee0f02f2d..8724a71504c 100644\n--- a/include/configs/beaglev_fire.h\n+++ b/include/configs/beaglev_fire.h\n@@ -30,7 +30,7 @@\n \n #define BOOTENV_DESIGN_OVERLAYS \\\n \t\"design_overlays=\" \\\n-\t\"if test -n ${no_of_overlays}; then \" \\\n+\t\"if test -n \\\"${no_of_overlays}\\\"; then \" \\\n \t\t\"setenv inc 1; \" \\\n \t\t\"setenv idx 0; \" \\\n \t\t\"fdt resize ${dtbo_size}; \" \\\n", "prefixes": [ "4/6" ] }