Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232051/?format=api
{ "id": 2232051, "url": "http://patchwork.ozlabs.org/api/patches/2232051/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260502141258.17128-2-atrajeev@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260502141258.17128-2-atrajeev@linux.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260502141258.17128-2-atrajeev@linux.ibm.com/", "date": "2026-05-02T14:12:58", "name": "[V3,2/2] tools/perf: Use scnprintf in buffer offset calculations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4060e1b4c6d1de37680723190d5b8e40faa424fa", "submitter": { "id": 90290, "url": "http://patchwork.ozlabs.org/api/people/90290/?format=api", "name": "Athira Rajeev", "email": "atrajeev@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260502141258.17128-2-atrajeev@linux.ibm.com/mbox/", "series": [ { "id": 502529, "url": "http://patchwork.ozlabs.org/api/series/502529/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=502529", "date": "2026-05-02T14:12:57", "name": "[V3,1/2] tools/perf: Fix the check for parameterized field in event term", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/502529/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232051/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2232051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-20381-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=mjND4II5;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20381-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=mjND4II5;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g78yv49fdz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 03 May 2026 00:13:43 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g78yp4DQKz30Jy;\n\tSun, 03 May 2026 00:13:38 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g78ym6YR7z2xlr\n\tfor <linuxppc-dev@lists.ozlabs.org>; Sun, 03 May 2026 00:13:36 +1000 (AEST)", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6424566H1990705;\n\tSat, 2 May 2026 14:13:27 GMT", "from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9x495rx-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSat, 02 May 2026 14:13:26 +0000 (GMT)", "from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 642E9gqu010896;\n\tSat, 2 May 2026 14:13:25 GMT", "from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dw9jy9bum-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tSat, 02 May 2026 14:13:25 +0000 (GMT)", "from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n\tby smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 642EDL8117236244\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tSat, 2 May 2026 14:13:21 GMT", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B7E6320040;\n\tSat, 2 May 2026 14:13:21 +0000 (GMT)", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A66432004B;\n\tSat, 2 May 2026 14:13:16 +0000 (GMT)", "from localhost.localdomain (unknown [9.124.223.37])\n\tby smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tSat, 2 May 2026 14:13:16 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777731218;\n\tcv=none;\n b=RARGHgdt/8hE9qz3SfGoItrSKjKgILe9AqvCKmjznqWD32EBEp4FgcTdZ8eoQ7K3nYSxpKNBCjTA/0HwpwuV3CkEYXitr7v/9bcAwjGLpwSGZdvO4VVJ9FhKqJ7M/RIS8sxgktYnTCjcP0smDDnmRmyKIKDYNVMUZhI2NF84lPf04drXQO3au1/CsQuQOdEQqVSK92snB8CDPUbdymC6PQ2ANa9pgFe9Ep+zNC7rFt7Skr7d0XxfuOGbFzErvBo9sC9jMwJYD3F/HsHe3IvF3EouP8dWZXUb+0M3oNqRT2BGtRxDssOEdtR+BpGNZG2eXEZ0l0rvkngQ6OHGOvzHng==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777731218; c=relaxed/relaxed;\n\tbh=Ydg775CRvfNHlgMYRYXLzfw4p/+tFci3I6hsY/NxtD4=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=iq1k02tXVRX7mpgGarOOdyp9E/t4quIDSrfIWDdIVSCRhk7DuXUb25VXdcAv/C9+GbfEI2a91qZXKw5kpEfVNY5UNjOkqBO9wdCzW58IQQjI+vZmCNLeAUBX9hLeeuhxAdcxw0HVX4JajkE0e1eZn1acQzxW8P2aGb0mzy5sLAVTonYA2/8i50f+w440j493sYY7MjOktUszw1U3HP6+Ysteo0ZXtZu890Emp4sVOVNDG3oXAcc62oa07qVMbm0Zx18effeH0vdi04kgN8Ga8+lcYQAouH/C7UYkTlgW/S4mbgFSqe82W5REuI1KEUQnC5nK87z2UjrWYafz+Dlpxw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=mjND4II5; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=atrajeev@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=Ydg775CRvfNHlgMYR\n\tYXLzfw4p/+tFci3I6hsY/NxtD4=; b=mjND4II5B9nRXhKcGHb2yjx+8b3PriXx3\n\tKmlZEHqPsdSBnhkSARQtagZ2YnTqBT8uo34CrLBoVbWc8T8w3aRf3A5+peEBpVKt\n\tzemhaNcfiZXnrfRcajqXxBV/1T9SZFd22d2Ob/+4OE1C+Ehphh6iluoh6VS3CfDd\n\tUxVYebdu98JLE7yO/x5zugjrnyMxMc8ZbTm06+eqGpNuDrwAJuB1KOn8r8CRWyNO\n\t8gGgFdPm9K/NK5ZIGpSciB1dEoGeMAcnIT5Kh2ksZP81Xspk5Ar0rhr17etOeeMA\n\t8QRTIA+4TCvn87BVMcQizxYGWDJudJpgeFnPFaMzkSaypSql1VFrQ==", "From": "Athira Rajeev <atrajeev@linux.ibm.com>", "To": "acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,\n mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com,\n irogers@google.com, namhyung@kernel.org", "Cc": "linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com,\n Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com", "Subject": "[PATCH V3 2/2] tools/perf: Use scnprintf in buffer offset\n calculations", "Date": "Sat, 2 May 2026 19:42:58 +0530", "Message-Id": "<20260502141258.17128-2-atrajeev@linux.ibm.com>", "X-Mailer": "git-send-email 2.39.5 (Apple Git-154)", "In-Reply-To": "<20260502141258.17128-1-atrajeev@linux.ibm.com>", "References": "<20260502141258.17128-1-atrajeev@linux.ibm.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNTAyMDE0MSBTYWx0ZWRfX0Ru1a0ga3SNJ\n dBeHR7dNkSVPP7yXyONN/vi6ZlcNJgpVkMwKaJYKByzwi6lkPbWqxaBH3Aju7T7/5LTNVlyZOlh\n 4X1USjaNtKousDsFDsV2E1aT7+Dvfs+jJ8tW7/0nLp6NdchzGEmAwJFHxbVvbjcmSSGWk/n3u/m\n 76/odiGD469ByG4OFEtUJT5SoQe9drkYEhilVjd66/ePV/pZ+fG4k3eATyYSR6SCg/wifxqJw8W\n v38A2tdnq0y0GRFP16MlIucayPlUi1b6A6uPU4VKULkOl7pJG3+omLZqX5L9eXYX5m3V0M5rbI9\n b5rhh1l/9Rky9T7t5ji2bT91SieZ9xgNvs1z7PunWte2aXMH8IDSMTgzNrNI32i5ZnXrt1+1vut\n XCtamtQvUUtOhrdqSraPW25TjmN5K/8nWVvHQZLNX7a7V6D18Nh6AOE8H1D0dm4E4zGJ3T6SZUj\n 1xknzi1Dm+rWvEX14pQ==", "X-Proofpoint-ORIG-GUID": "UKA1UlRdJkrQLMPjIjxI8tweLa9BSsOZ", "X-Proofpoint-GUID": "H8sXf3Z08zzM0dWGTgu9tVuBoJ0Hds9k", "X-Authority-Analysis": "v=2.4 cv=W7UIkxWk c=1 sm=1 tr=0 ts=69f60686 cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=1gu-19CejoU7_tioJ5wA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-02_03,2026-04-30_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0\n suspectscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2605020141", "X-Spam-Status": "No, score=0.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Replace snprintf with scnprintf in buffer offset calculations to\nensure the 'used' count will not exceed the \"len\".\n\nThe current logic in perf_pmu__for_each_event uses an unconditional\n+ 1 increment to buf_used to account for null terminators. This can\ncause a a stack buffer overflow in the subsequent scnprintf call.\nWhen the local stack buffer buf (1024 bytes) is full, buf_used can\nreach 1025. This causes the subsequent remaining space calculation\nsizeof(buf) - buf_used to underflow.\n\nUse sub_non_neg() to see if space actually existed, and only\nincrement the offset if remaning space is present.\n\nChanges includes:\n- Use sub_non_neg to check if space exists\n- Replacing snprintf with scnprintf to ensure the return value\nreflects the actual bytes written into the buffer.\n- Only increment buf_used by 1 if space exists\n- If a parameterized event uses a built-in perf keyword for its\nparameter name (eg, config=?), the lexer parses it as a predefined\nterm token, which sets term->config to NULL. Add check to use\nparse_events__term_type_str() if term->config is NULL.\n\nSigned-off-by: Athira Rajeev <atrajeev@linux.ibm.com>\n---\nChangelog:\nv2 -> v3:\n- Split the scnprintf related changes in separate patch\n- Handle the overflow issues and unconditional increment\nwrapped around sub_non_neg addressing review comment from Sashiko\n\n tools/perf/util/pmu.c | 46 ++++++++++++++++++++++++++++++++-----------\n 1 file changed, 35 insertions(+), 11 deletions(-)", "diff": "diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c\nindex 0b8d58543f17..4b9ade1a4cf9 100644\n--- a/tools/perf/util/pmu.c\n+++ b/tools/perf/util/pmu.c\n@@ -2129,15 +2129,19 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,\n \t\tpr_err(\"Failure to parse '%s' terms '%s': %d\\n\",\n \t\t\talias->name, alias->terms, ret);\n \t\tparse_events_terms__exit(&terms);\n-\t\tsnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n+\t\tscnprintf(buf, len, \"%.*s/%s/\", (int)pmu_name_len, pmu->name, alias->name);\n \t\treturn buf;\n \t}\n-\tused = snprintf(buf, len, \"%.*s/%s\", (int)pmu_name_len, pmu->name, alias->name);\n+\tused = scnprintf(buf, len, \"%.*s/%s\", (int)pmu_name_len, pmu->name, alias->name);\n \n \tlist_for_each_entry(term, &terms.terms, list) {\n+\t\tconst char *name = term->config;\n+\n+\t\tif (!name)\n+\t\t\tname = parse_events__term_type_str(term->type_term);\n \t\tif (term->type_val == PARSE_EVENTS__TERM_TYPE_STR)\n-\t\t\tused += snprintf(buf + used, sub_non_neg(len, used),\n-\t\t\t\t\t\",%s=%s\", term->config,\n+\t\t\tused += scnprintf(buf + used, sub_non_neg(len, used),\n+\t\t\t\t\t\",%s=%s\", name,\n \t\t\t\t\tterm->val.str);\n \t}\n \tparse_events_terms__exit(&terms);\n@@ -2201,6 +2205,7 @@ int perf_pmu__for_each_event(struct perf_pmu *pmu, bool skip_duplicate_pmus,\n \tint ret = 0;\n \tstruct hashmap_entry *entry;\n \tsize_t bkt;\n+\tsize_t size_rem, len;\n \n \tif (perf_pmu__is_tracepoint(pmu))\n \t\treturn tp_pmu__for_each_event(pmu, state, cb);\n@@ -2234,17 +2239,36 @@ int perf_pmu__for_each_event(struct perf_pmu *pmu, bool skip_duplicate_pmus,\n \t\t\t}\n \t\t\tbuf_used = strlen(buf) + 1;\n \t\t}\n+\n \t\tinfo.scale_unit = NULL;\n \t\tif (strlen(event->unit) || event->scale != 1.0) {\n-\t\t\tinfo.scale_unit = buf + buf_used;\n-\t\t\tbuf_used += snprintf(buf + buf_used, sizeof(buf) - buf_used,\n-\t\t\t\t\t\"%G%s\", event->scale, event->unit) + 1;\n+\t\t\t/* Check the remaining space */\n+\t\t\tsize_rem = sub_non_neg(sizeof(buf), buf_used);\n+\n+\t\t\tif (size_rem > 0) {\n+\t\t\t\tinfo.scale_unit = buf + buf_used;\n+\t\t\t\tlen = scnprintf(buf + buf_used, size_rem, \"%G%s\",\n+\t\t\t\t\t\tevent->scale, event->unit);\n+\t\t\t\t/*\n+\t\t\t\t * Increment buf_used by 1 only if\n+\t\t\t\t * it fits remaining space\n+\t\t\t\t */\n+\t\t\t\tbuf_used += min(len + 1, size_rem);\n+\t\t\t}\n \t\t}\n \t\tinfo.desc = event->desc;\n \t\tinfo.long_desc = event->long_desc;\n-\t\tinfo.encoding_desc = buf + buf_used;\n-\t\tbuf_used += snprintf(buf + buf_used, sizeof(buf) - buf_used,\n-\t\t\t\t\"%.*s/%s/\", (int)pmu_name_len, info.pmu_name, event->terms) + 1;\n+\t\tinfo.encoding_desc = NULL;\n+\n+\t\t/* Check the remaining space */\n+\t\tsize_rem = sub_non_neg(sizeof(buf), buf_used);\n+\t\tif (size_rem > 0) {\n+\t\t\tinfo.encoding_desc = buf + buf_used;\n+\t\t\tlen = scnprintf(buf + buf_used, size_rem, \"%.*s/%s/\",\n+\t\t\t\t\t(int)pmu_name_len, info.pmu_name, event->terms);\n+\t\t\tbuf_used += min(len + 1, size_rem);\n+\t\t}\n+\n \t\tinfo.str = event->terms;\n \t\tinfo.topic = event->topic;\n \t\tinfo.deprecated = perf_pmu_alias__check_deprecated(pmu, event);\n@@ -2254,7 +2278,7 @@ int perf_pmu__for_each_event(struct perf_pmu *pmu, bool skip_duplicate_pmus,\n \t}\n \tif (pmu->selectable) {\n \t\tinfo.name = buf;\n-\t\tsnprintf(buf, sizeof(buf), \"%s//\", pmu->name);\n+\t\tscnprintf(buf, sizeof(buf), \"%s//\", pmu->name);\n \t\tinfo.alias = NULL;\n \t\tinfo.scale_unit = NULL;\n \t\tinfo.desc = NULL;\n", "prefixes": [ "V3", "2/2" ] }