Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2232048/?format=api
{ "id": 2232048, "url": "http://patchwork.ozlabs.org/api/patches/2232048/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260502140021.69712-2-amachhiw@linux.ibm.com/", "project": { "id": 69, "url": "http://patchwork.ozlabs.org/api/projects/69/?format=api", "name": "QEMU powerpc development", "link_name": "qemu-ppc", "list_id": "qemu-ppc.nongnu.org", "list_email": "qemu-ppc@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260502140021.69712-2-amachhiw@linux.ibm.com>", "list_archive_url": null, "date": "2026-05-02T14:00:19", "name": "[v2,1/3] hw/ppc/spapr: Do not fallback to raw mode when KVM rejects compat", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8e7293fe4ebc8062916a27fb64e4f8df4f0606af", "submitter": { "id": 87864, "url": "http://patchwork.ozlabs.org/api/people/87864/?format=api", "name": "Amit Machhiwal", "email": "amachhiw@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260502140021.69712-2-amachhiw@linux.ibm.com/mbox/", "series": [ { "id": 502527, "url": "http://patchwork.ozlabs.org/api/series/502527/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=502527", "date": "2026-05-02T14:00:18", "name": "ppc/kvm: Handle CPU compatibility mode correctly for nested guests", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502527/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2232048/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2232048/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=B5/hIXYR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g78kX4dN4z1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 03 May 2026 00:03:00 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wJAui-0004mg-Tg; Sat, 02 May 2026 10:01:48 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <amachhiw@linux.ibm.com>)\n id 1wJAu2-0004gu-RE; Sat, 02 May 2026 10:01:12 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <amachhiw@linux.ibm.com>)\n id 1wJAty-0007XG-Gn; Sat, 02 May 2026 10:01:03 -0400", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 642DlT2F3118223; Sat, 2 May 2026 14:01:00 GMT", "from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9x494ub-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 02 May 2026 14:00:59 +0000 (GMT)", "from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 642Dshhx023830;\n Sat, 2 May 2026 14:00:58 GMT", "from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dw9hd1ay0-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 02 May 2026 14:00:58 +0000 (GMT)", "from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com\n [10.20.54.106])\n by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 642E0tpb15925758\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sat, 2 May 2026 14:00:55 GMT", "from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0707C20043;\n Sat, 2 May 2026 14:00:55 +0000 (GMT)", "from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 6F77220040;\n Sat, 2 May 2026 14:00:52 +0000 (GMT)", "from localhost.localdomain (unknown [9.124.223.28])\n by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Sat, 2 May 2026 14:00:52 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=I1hsOJZQR2XGOk7WI\n H8LLfPojJ5cB30a2SQsOUbn0oU=; b=B5/hIXYRIrRTAbaCOBNdaM47VUUXmu6U5\n 9+driFADe+ZVQUM81Zjb0tAcz8hJLdua8rXjtpslZqKtnQ0oKIu2luFIsSoJuG1e\n Zw6Zyth0IPVjMvyAhzrz9Adg+/LeutGrLhiplKYxzy2AmpkeH0hPGsRSIbz9zSPY\n vxJJ1LhfNSa8rmcaKZKaSnHzGgecAkRx6JDGrgGqhr1sUDWR+WcgNHkWt2bC4gX1\n V95fEERpBnZCRXQX2iI4B2hN0vynh3BP0QXthnBNrHYfFxvVQeSsLvlXYx1/TlWn\n CCr2+zyZHF2W8s6aBPSYvoHJmiTkxYX2zTjuXvj4xO2ZnqzZAF4Rw==", "From": "Amit Machhiwal <amachhiw@linux.ibm.com>", "To": "qemu-ppc@nongnu.org, Harsh Prateek Bora <harshpb@linux.ibm.com>", "Cc": "Amit Machhiwal <amachhiw@linux.ibm.com>,\n Vaibhav Jain <vaibhav@linux.ibm.com>,\n Nicholas Piggin <npiggin@gmail.com>, qemu-devel@nongnu.org", "Subject": "[PATCH v2 1/3] hw/ppc/spapr: Do not fallback to raw mode when KVM\n rejects compat", "Date": "Sat, 2 May 2026 19:30:19 +0530", "Message-ID": "<20260502140021.69712-2-amachhiw@linux.ibm.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260502140021.69712-1-amachhiw@linux.ibm.com>", "References": "<20260502140021.69712-1-amachhiw@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNTAyMDEzNiBTYWx0ZWRfX3lnf4UuAQzZr\n 88Zxu1CDrVJJc8rAVJNp5LhD2ddv+cQgbEiJQgCslYzoXSyF5GnSOYQluJiT4LRMkWSTrvMOcOD\n qWKWtvz5Y+SFbAhBFTSvfuSzmmjINswW5zmh9stcjr62HYqlnsCcOBKfqld9wSatXUst7bZSmUP\n q+ywFudsudGvxr0GQapkTxiXDldD8wuH6RlCafaCF/islu7NF/pe6aOM/Pu/gFJ4vhxoyCwy9qX\n LLZ+AsATWwejTiZD3nu3GL+/KGkFco9CtSwcNPj9un2uXqosQYg3KP1O3BmTUwXYwiGqNahqjRm\n fzt8drG2b9H4omznfz5HRZK8ZJKDRrnIrxbfk4RAKBLOieWK1mVO5oLfYMR5X/kPvfHLMADLPvO\n CGRysTSMAo9/XWTSYQEpgAQxPEOUAcJYepqC5wWpS43rmDL/N9SGZMd27lvRx45HmeAS0EICEMK\n 3UxuWVdfvPKx6XfYl7Q==", "X-Proofpoint-ORIG-GUID": "uUi8ylP4Z510A5kW9Q4PHNb7NCl6diaF", "X-Proofpoint-GUID": "1ml0mEtvr53PGUzCKLaAPe_puiHAYX2B", "X-Authority-Analysis": "v=2.4 cv=W7UIkxWk c=1 sm=1 tr=0 ts=69f6039b cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=i5GS84888sUNcPDMq4UA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-02_03,2026-04-30_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0\n suspectscore=0 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2605020136", "Received-SPF": "pass client-ip=148.163.156.1;\n envelope-from=amachhiw@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com", "X-Spam_score_int": "-26", "X-Spam_score": "-2.7", "X-Spam_bar": "--", "X-Spam_report": "(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-ppc@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-ppc.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-ppc>", "List-Post": "<mailto:qemu-ppc@nongnu.org>", "List-Help": "<mailto:qemu-ppc-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "During H_CLIENT_ARCHITECTURE_SUPPORT, QEMU attempts to set the requested\nCPU compatibility mode via ppc_set_compat_all(). If this fails, the\nexisting code may fall back to raw mode when supported by the guest.\n\nThe current logic treats all failures uniformly and tried to fall back\nto raw mode whenever possible. As a result, errors from KVM (e.g.\nkvmppc_set_compat() returning -EINVAL) are silently masked, making\ndebugging difficult and allowing the guest to proceed with an\nunsupported or incompatible configuration.\n\nWhen running with KVM, such failures indicate that the requested\ncompatibility level is not supported by the host. Do not fallback in\nthis case; instead, report the error and fail the CAS negotiation.\n\nThis makes the failure visible to the user and ensures that invalid\ncompatibility requests are rejected early rather than being hidden by\nfallback behavior. For example, the following error is now reported:\n\n qemu-system-ppc64: Unable to set CPU compatibility mode in KVM: Invalid argument\n\nFixes: cc7b35b169e9 (\"spapr: fallback to raw mode if best compat mode cannot be set during CAS\")\nSigned-off-by: Amit Machhiwal <amachhiw@linux.ibm.com>\n---\n hw/ppc/spapr_hcall.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c\nindex 032805a8d0db..de2ea6f5e579 100644\n--- a/hw/ppc/spapr_hcall.c\n+++ b/hw/ppc/spapr_hcall.c\n@@ -1204,6 +1204,15 @@ target_ulong do_client_architecture_support(PowerPCCPU *cpu,\n Error *local_err = NULL;\n \n if (ppc_set_compat_all(cas_pvr, &local_err) < 0) {\n+ /*\n+ * If KVM rejected the compat mode, do not fallback. This indicates\n+ * the host cannot support the requested level.\n+ */\n+ if (kvm_enabled()) {\n+ error_report_err(local_err);\n+ return H_HARDWARE;\n+ }\n+\n /* We fail to set compat mode (likely because running with KVM PR),\n * but maybe we can fallback to raw mode if the guest supports it.\n */\n", "prefixes": [ "v2", "1/3" ] }