Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2231562/?format=api
{ "id": 2231562, "url": "http://patchwork.ozlabs.org/api/patches/2231562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260430204330.3121003-3-mahesh.vaidya@altera.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260430204330.3121003-3-mahesh.vaidya@altera.com>", "list_archive_url": null, "date": "2026-04-30T20:43:30", "name": "[v2,2/2] PCI: altera: Fix resource leaks on probe failure", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "34ed890e31558b66844132a49c2119ea940fc2f0", "submitter": { "id": 92067, "url": "http://patchwork.ozlabs.org/api/people/92067/?format=api", "name": "Mahesh Vaidya", "email": "mahesh.vaidya@altera.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260430204330.3121003-3-mahesh.vaidya@altera.com/mbox/", "series": [ { "id": 502381, "url": "http://patchwork.ozlabs.org/api/series/502381/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=502381", "date": "2026-04-30T20:43:29", "name": "PCI: altera: Fix IRQ cleanup on probe failure", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502381/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231562/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231562/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-53544-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=altera.com header.i=@altera.com header.a=rsa-sha256\n header.s=selector2 header.b=kbzIOYAy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-53544-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com\n header.b=\"kbzIOYAy\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.46.119", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=altera.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=altera.com", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=altera.com;" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g65kT3VRqz1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 06:44:17 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2D7C7300DCDB\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 20:44:12 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C43D13AE6F5;\n\tThu, 30 Apr 2026 20:44:10 +0000 (UTC)", "from CO1PR03CU002.outbound.protection.outlook.com\n (mail-westus2azon11020119.outbound.protection.outlook.com [52.101.46.119])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 615453A75A2;\n\tThu, 30 Apr 2026 20:44:07 +0000 (UTC)", "from SA1PR03MB6498.namprd03.prod.outlook.com (2603:10b6:806:1c5::7)\n by BY5PR03MB5201.namprd03.prod.outlook.com (2603:10b6:a03:221::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.22; Thu, 30 Apr\n 2026 20:44:03 +0000", "from SA1PR03MB6498.namprd03.prod.outlook.com\n ([fe80::feea:da58:faeb:9ebc]) by SA1PR03MB6498.namprd03.prod.outlook.com\n ([fe80::feea:da58:faeb:9ebc%4]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 20:44:03 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777581850; cv=fail;\n b=nz0ff0A933P4cEjdr4BXiFe4AnvkcRc4ugsTTLmqJtW7d3e20IqbJDwrrzzZDeJAdqIPyjkrvKOnWxK9hm0P/mdP3xl5E326Fl+msE/S5AM+mwmShcYX7fQUHNWWirQYcJ/LjM1+kdd85KYSdHfryJ+DcKPh+w6AMZMJ7afV1RA=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=odLHQ84pCCzzH+paYzC3Cfufrbh6+qUdvP/SI0ujoftJnyM3nKjts4MxVepSiRhVfJDs/eAdRhTkMlvFXx2Y+Ad19ni7bIsuuhxQNKprVt4dbJQbbwujNT1D61bLTxZ5dFHTsQ+0Re/FJDjMPoCqoOBtrGRqY0I1ROp3B4ySiu9qpHniNsaPfzmozyi/pNDIhZfTqPyuOx3hSl1Q2uQP/GPYgOFg6cbFHningbMraQEY3xTK2LehD5+3nJayMDHLiSlVKofU+G7RMBIYaDmnmQCfPUr8ndq89bR2SL/nvgBIvk9h7p8i2lBOVx86sz7ZWURxXWcJt3Zxs4V6lbK/cw==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777581850; c=relaxed/simple;\n\tbh=fkML1gVmL5aiVlom+SHX5xzWqz/HEtLOGcO+1ECvkUI=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=LhqBGK4ipK/u7yA/kWnZlLIS5qPqRIoEB8xTWcSYnMx7k68SHBxyme3H+AcAQ3cjFIvZbTbRJsLTe73nuzdRyhhlDzvPVQdKdM65sbU4M+i9DbR9T+/PCbQcklH901piMJko2tZ0+8rPUzNQGiJqoBaqDYvhg97JoEtv+Fes1eg=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Z9NIoInk5PK6eKh9WrrG+OMbryDiooPwWHkkuIlY4xg=;\n b=reaRZ61y2I6PCwwW/Oew3+YtEBWxVCzTenPIlbvm1DOTvo9hlpwAO/+o8XG5Zwn1BB9cZyrdTwW7BYNWtRoYlMdsUQwCJz9B5tnYTXFO5xmKmzEsuQtFFWMJrzphrFuhkTln6HD0iMXhaowog9HUeICRn0OcXQt136ZX6+HkGPsIIIF3Mm2nJLsVouQBTl4+404x9VMISL7kpH6/GYrQW+wZ8XUnMLazT8dg2usdYX42oOHFl7KmwQABx2t8PWIUJvfMnBvVIzuf4dU37Ojo92zs0Sh1Pgg+lSqI5aZrIy2XwBE3MdJBTz/YNka8+2Oe2y4xSBSXZeGMcox7T2spHg==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=altera.com;\n spf=pass smtp.mailfrom=altera.com;\n dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com\n header.b=kbzIOYAy; arc=fail smtp.client-ip=52.101.46.119", "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com;\n dkim=pass header.d=altera.com; arc=none" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Z9NIoInk5PK6eKh9WrrG+OMbryDiooPwWHkkuIlY4xg=;\n b=kbzIOYAy5ClRzl2Yo+6U3VSOkhSckoSuNdPOKYG8p27Z9LljowxGhp7s3dCV+bxEI6J+kk2CTdNdKQoTtbBYFouYPi7H7BUPFOoj/z4pZ+NcNdpKuuRfTyMv9qT8qVYEfb7k+AU2Z+U2NLPjNYi2D0i0pOO78iMlQBz+lETh1Jk8iWj3zG5o1zQuuOYD1vJZ2ALzPKmZUF7HN/o9QvAXhcXfOMLiiRND3mQnAfc3HZU+NIgFVnSJbiqxnpyWAwxwTq3VmzmeapKmPzH9oESV9zdggsV/Iu+FiT5G89oOVIB2LCi+u9+6npSxVN+8AcyBimJ9Y4jjSc8i9sw82Di2nw==", "From": "Mahesh Vaidya <mahesh.vaidya@altera.com>", "To": "joyce.ooi@intel.com,\n\tlpieralisi@kernel.org,\n\tkwilczynski@kernel.org,\n\tmani@kernel.org,\n\trobh@kernel.org,\n\tbhelgaas@google.com,\n\tley.foon.tan@intel.com,\n\tdinguyen@kernel.org", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tsubhransu.sekhar.prusty@altera.com,\n\tpreetam.narayan@altera.com,\n\tcheryl.bansal@altera.com,\n\tstable@vger.kernel.org,\n\tMahesh Vaidya <mahesh.vaidya@altera.com>", "Subject": "[PATCH v2 2/2] PCI: altera: Fix resource leaks on probe failure", "Date": "Thu, 30 Apr 2026 13:43:30 -0700", "Message-Id": "<20260430204330.3121003-3-mahesh.vaidya@altera.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260430204330.3121003-1-mahesh.vaidya@altera.com>", "References": "<20260430204330.3121003-1-mahesh.vaidya@altera.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR02CA0012.apcprd02.prod.outlook.com\n (2603:1096:4:194::7) To SA1PR03MB6498.namprd03.prod.outlook.com\n (2603:10b6:806:1c5::7)", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA1PR03MB6498:EE_|BY5PR03MB5201:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c75a3e82-0981-4212-ff52-08dea6f936b3", "X-MS-Exchange-AtpMessageProperties": "SA", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|7416014|41320700013|366016|1800799024|18002099003|56012099003|22082099003|55112099003;", "X-Microsoft-Antispam-Message-Info": "\n\tFLWMp8t+p7PSRXf4ctqnLCLKKO2QBCKqOWr3SPXvWneiRnlQS9XzhHc+jrCNKw5zMcgYH2BFI2Q54F75hzc86bcy88AClHxCydLumnGLBpejYuuh+UpFu/r5nnT14hQfZTigtdCFZgmYUjrpLb/HFg7RZWzMJHlwIGjXCVEao6xgribnySLe7YgyhLfKp7y4L5jL6DkUxLIm9oXYOiagZ8EvB7wrWXRJtoNi9rxy1eWpcN6slcgQuGPgoHIdAQJ93qo0Dit9gBNKiClSvhhB3Loi+FeYpngSDEVIl12tpIuvON/gxO4433zxSlsuj1CBKVvt5Fr7LeynLxJEDXPHudune0qLJV3aNeZF+HXLJs4sy7ZeicQfSB+yvsCGW6BFRNWyqTTe2emEIuPDk5x89YC2sUwPmrRMmpUkhVNpYcGtmY8T1sjn6i6WOga1G5hmojMjfQOKbr4jgT2F0gC13Pxs0A5vshJ5KY96yaB5pNXMk6rTsxuBYBqFCG3DjTqojS6mHLnwZ9xoPJ16vnD50Tp8VVDC0wV28oP3lhB73f3wUX7uCk0w2okTo5uWEfw1r/CKLKlhTWFORq6YLT1vKyV5TvXIpoB1lC0plpzUO2h1jd60MFYqoBLuBKyvmCifJaKIOvMxXB0mFlppiVYSPl2R729hrAQsFT6bjQFuJUCNaNBoTh40EBEbw9Qhvq0Q", "X-Forefront-Antispam-Report": "\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR03MB6498.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(41320700013)(366016)(1800799024)(18002099003)(56012099003)(22082099003)(55112099003);DIR:OUT;SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n ldeTPxenXJJkKtdhK9CoeKpNeiLBZO6YEKwFDyty08vgX3F59D3GChUCQg4dslxbbK/yCtwofCZ5ccXcoewmVeMuG4a71NXEmfMVMK23Go9MflvsRrzNEcWooQasE23uEV2dE5h//pniXxPeDqFVFIGWWGjbSKPYGepxtiAREnEgl6hvDRfWuhrJtle2emzQ/Y7v/fr/xMTqQZ3FJP/xTViboAwTzUYU6hyHcOILNu9WHB3WjD32BwjwUJZlEA3aJYIu0Zgdx8eLKZ8Ye3rz0YVxDSkoPovKM25xlmfKLwHKAauq52PZiLy3U8JMhbknMRIRF7JYXHRJ/0d6uj2COjHybJgi5ZEjtXRHtdSemqk71U8zTM8/jgXr+gXktF227Fc5+oPCr35yNFMPs3Vk9TNbyjcrsy+zNEHPkTD+CykcXgIQE4rFeKZot4+IdpVKZxPK3d2wQHKefRW1GheCYCUUmH7MjADmn9vv/AbanYhmPsYE9cG43Dx1AACMYSq2X9y6DU302/UIryZYkEWIRpKQPobvuWvK+bEtIi/1gR9bGEJ5xXf1JKJfZUttR700Dh/jpEnZQLPRcuxx5jlTcs1z02uel7SH+wSb1M+55Y3w8Y/tEqxwxBtHVxBhpbWUgwsBGsutcrJ3ptegE/3boANumBkN5bRUgnqhFHQmSpkXu1pYA4kFw0CfGm3da+GRx2YBOpI5rs6jqfmtXVcuKfu/5OG9RdPfkUqltWDiixFx8GZO9dqDG7rcV7V8YOL2NYNaa5RbdKCQKmG5eAMIKEXVd5vrhhxSW1cbR+9mQFppYq4B4RSd17rXoKw55hdk5YWsieZBhbQEPX9RcuoOu+BoqzNb4zD2IfO39jTRfVkXG/9+GsicEfqV6wmfyfjk8XkUqUZUcB6ZfDqgnl8yfceP/EqBT4jTeyD+6aMtKIjC6BKSyvKssnBKiSWmnTOPkuZth68LRkxcHP0M/p+w3uut5j6thf2kMqh7pYm9gnjhDUcmnVoZHyoJ9/I4qXNxPlRPiRorIqfRyEDMxVRwo4pw4rpJ1aA3g2FVmWSpFDjnLCZ7g5X2q3F5bBjG3RUsK1//csAq5/0hjgck1LnrHUvsEaFiq5vaazviY3xwEUYNrHEd8BUkbDeme8DyM6Ji0Wg8PE7dk++6wlgy6b1klqBx9NxlFSDc/ui1r7hhGc/GuIAtbmOQ23KpagRUkcXyrQmf08KVCLQOzLjxI+bT2OuHpZETATtDaGkRiGYi+7oNitLIP1Gpfladl1AthNe7qmODqPoxdyKZJQhVXEbe4uyXUCrECIifP6fVSQVALtLDgk1jVCk7pdoicCIC7DZiIYN1GdI8ADjhiIFJr/aDZvwRMgSxS/FwgcP0ce1jIygZldz+AYMkW0AqNJkqIS/Bjn6bI2fww/zsHUiYum/pxFcKp5kRQRj9mBJDApUcCB+wb2kiacTMH9tQAr7UEeCVb8UQ7RbCxGTuxKeNGnc5LvxtiSsfCeSeee+mUrjvoYST8lNMyU/bi8znQo3JpNVLXt5+3yTrZc4uwsAjEY3YjgT9pj08KqEtiXQ5imQPL/eOroJgubYypQ7/LSH3kMCcE2bRDqPQCX8scvnAiHQRx25usLsp390vP80cf0kUaTH9XO6imePv3fI7lqbm8BuzSpDjZOZ9jb1bv7y07scc8e/jcnHDOOWAo+UiKVzoFax7FCw0yj6iQ3uyii0Cp5RCy91LRlYPFMdKdMphAYVnE5x8y3PdchE5zGY8CVsG87Q=", "X-OriginatorOrg": "altera.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c75a3e82-0981-4212-ff52-08dea6f936b3", "X-MS-Exchange-CrossTenant-AuthSource": "SA1PR03MB6498.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Apr 2026 20:44:03.0213\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fbd72e03-d4a5-4110-adce-614d51f2077a", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n VG9df+bwCVLJXmm74rViWemSNsf6QkR+Edx3fp9cxmQtK9xfHmcjCqDd0r5ODC33VZ8pfNJ6FR2LeG0LrzpClrKeKuSd4tPUp1VGWCeYcWg=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR03MB5201" }, "content": "The chained IRQ handler is installed during probe but is only removed\nfrom the remove path. If pci_host_probe() fails, the handler and INTx IRQ\ndomain remain installed even though the devm-managed host bridge storage\ncontaining struct altera_pcie will be released, leaving the handler with\na stale data pointer.\n\nInterrupts are also enabled before pci_host_probe() is called. If probe\nfails after that point, the controller interrupt source should be disabled\nbefore the chained handler and INTx domain are removed.\n\nInstall the chained handler only after the INTx domain has been created.\nDisable controller interrupts during IRQ teardown, and tear the IRQ setup\ndown if pci_host_probe() fails.\n\nFixes: c63aed7334c2 (\"PCI: altera: Use pci_host_probe() to register host\")\nCc: stable@vger.kernel.org\nReviewed-by: Subhransu S. Prusty <subhransu.sekhar.prusty@altera.com>\nSigned-off-by: Mahesh Vaidya <mahesh.vaidya@altera.com>\n---\n drivers/pci/controller/pcie-altera.c | 35 ++++++++++++++++++++++++++--\n 1 file changed, 33 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c\nindex 3d3519b8d88f..902ae2d81763 100644\n--- a/drivers/pci/controller/pcie-altera.c\n+++ b/drivers/pci/controller/pcie-altera.c\n@@ -864,8 +864,23 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)\n \treturn 0;\n }\n \n+static void altera_pcie_disable_irq(struct altera_pcie *pcie)\n+{\n+\tif (pcie->pcie_data->version == ALTERA_PCIE_V1 ||\n+\t pcie->pcie_data->version == ALTERA_PCIE_V2) {\n+\t\t/* Disable all P2A interrupts */\n+\t\tcra_writel(pcie, 0, P2A_INT_ENABLE);\n+\t} else if (pcie->pcie_data->version == ALTERA_PCIE_V3) {\n+\t\t/* Disable port-level interrupts (CFG_AER, etc.) */\n+\t\twritel(0, pcie->hip_base +\n+\t\t\t pcie->pcie_data->port_conf_offset +\n+\t\t\t pcie->pcie_data->port_irq_enable_offset);\n+\t}\n+}\n+\n static void altera_pcie_irq_teardown(struct altera_pcie *pcie)\n {\n+\taltera_pcie_disable_irq(pcie);\n \tirq_set_chained_handler_and_data(pcie->irq, NULL, NULL);\n \tirq_domain_remove(pcie->irq_domain);\n }\n@@ -890,7 +905,6 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)\n \tif (pcie->irq < 0)\n \t\treturn pcie->irq;\n \n-\tirq_set_chained_handler_and_data(pcie->irq, pcie->pcie_data->ops->rp_isr, pcie);\n \treturn 0;\n }\n \n@@ -1019,6 +1033,14 @@ static int altera_pcie_probe(struct platform_device *pdev)\n \t\treturn ret;\n \t}\n \n+\t/*\n+\t * The chained handler uses pcie->irq_domain, so install it\n+\t * only after the INTx domain has been created.\n+\t */\n+\tirq_set_chained_handler_and_data(pcie->irq,\n+\t\t\t\t\t pcie->pcie_data->ops->rp_isr,\n+\t\t\t\t\t pcie);\n+\n \tif (pcie->pcie_data->version == ALTERA_PCIE_V1 ||\n \t pcie->pcie_data->version == ALTERA_PCIE_V2) {\n \t\t/* clear all interrupts */\n@@ -1036,7 +1058,16 @@ static int altera_pcie_probe(struct platform_device *pdev)\n \tbridge->busnr = pcie->root_bus_nr;\n \tbridge->ops = &altera_pcie_ops;\n \n-\treturn pci_host_probe(bridge);\n+\tret = pci_host_probe(bridge);\n+\tif (ret)\n+\t\tgoto err_teardown_irq;\n+\n+\treturn 0;\n+\n+err_teardown_irq:\n+\taltera_pcie_irq_teardown(pcie);\n+\n+\treturn ret;\n }\n \n static void altera_pcie_remove(struct platform_device *pdev)\n", "prefixes": [ "v2", "2/2" ] }