Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2231362/?format=api
{ "id": 2231362, "url": "http://patchwork.ozlabs.org/api/patches/2231362/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430161230.3438973-2-rc@rexion.ai/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260430161230.3438973-2-rc@rexion.ai>", "list_archive_url": null, "date": "2026-04-30T16:12:29", "name": "[net-next,1/2] netfilter: nf_conntrack_irc: reject DCC port values above 65535", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4bf56180574768e28ab45e5c787dfec66c3b7734", "submitter": { "id": 93293, "url": "http://patchwork.ozlabs.org/api/people/93293/?format=api", "name": "HACKE-RC", "email": "rc@rexion.ai" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260430161230.3438973-2-rc@rexion.ai/mbox/", "series": [ { "id": 502338, "url": "http://patchwork.ozlabs.org/api/series/502338/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=502338", "date": "2026-04-30T16:12:29", "name": "netfilter: conntrack: validate parsed port values in IRC and Amanda helpers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502338/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231362/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-12344-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=rexion.ai\n header.i=@rexion.ai header.a=rsa-sha256 header.s=spacemail header.b=mMyqU/p0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12344-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key) header.d=rexion.ai\n header.i=@rexion.ai header.b=\"mMyqU/p0\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=66.29.159.73", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=rexion.ai" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5zt66jCHz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 02:20:30 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 213F530062F8\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 16:20:08 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A86FF46AEF5;\n\tThu, 30 Apr 2026 16:20:02 +0000 (UTC)", "from out-24.smtp.spacemail.com (out-24.smtp.spacemail.com\n [66.29.159.73])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F1121284883;\n\tThu, 30 Apr 2026 16:20:00 +0000 (UTC)", "from Kyren (unknown [49.207.224.37])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mail.spacemail.com (Postfix) with ESMTPSA id 4g5zj60wNfz2x9M;\n\tThu, 30 Apr 2026 16:12:41 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777566002; cv=none;\n b=Wby83+kt5TIJRs8N4IG5kZlmsJmq+723MHBfwN8vbrneQbmArQOuazces1NEgDmhKiQNJLNyeDZMgRRcj8beHOIY5n2vJBhK8mj1uGMj2Z6vAHa3GoSW0DYIiRtzMkdqXLBnYNY/bfW5Ck5BYLRL3vYObbyvnxyVrl5TZFj6pVM=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777566002; c=relaxed/simple;\n\tbh=qMi3Zh8tMpgOGRhba5YajMM1/TYq3OYdNtHXxKWll2U=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=WXQh+zAoTmrcFyQ2H/hrnGCgq+Q/djqg16942Vmc/L346QgkH6muEINIWOUXHGV0meZGL+LgJ9GgVsuako8skRQ723y8cfqz8V3CHv8Dgqnfmfcab2nS7fPs8GadSxPZ85jgBXOJe7NpX1P7e7nVGEQsMDVmn4+ZEUpBNB+FXgc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=rexion.ai;\n spf=pass smtp.mailfrom=rexion.ai;\n dkim=fail (0-bit key) header.d=rexion.ai header.i=@rexion.ai\n header.b=mMyqU/p0 reason=\"key not found in DNS\";\n arc=none smtp.client-ip=66.29.159.73", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=rexion.ai;\n\ts=spacemail; t=1777565566;\n\tbh=UywyWXjRXwdRrMrxTpfiqM3Z3AJy9XDsXMD3JflyTzo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mMyqU/p0CODGDACMclfDyzOU5nG90mDDNZBJhLdsl3hbB2q3qFksiNIb5CWAFy1Ru\n\t 1p6L6d3TQTNlyUmvUtZryiYqQ0Y/ra923lD+u+2DjJGCyE+Xg0iIUBkRsgUt4F+RvH\n\t Ua7FHTz74di7UjYzcqjHADh0RjfNvnPfoT2CYEI3IMjTZZ6TL1JUlDOTCLFwiR2k+s\n\t Fzy/ONjRcmwVqhn09e6bHKIl5w/QGdVjT5CrETVYGO0vyap3Vd5CaR3CEIaGYcai26\n\t OLPe2ZUF2SDaABDFaGVIcsDKSGbWQTfCU2cZACKnR5+arHDSrlE2xj/pw2wD1ygncA\n\t Pqmt1JPIqZmBg==", "From": "HACKE-RC <rc@rexion.ai>", "To": "Pablo Neira Ayuso <pablo@netfilter.org>,\n\tFlorian Westphal <fw@strlen.de>", "Cc": "Phil Sutter <phil@nwl.cc>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tSimon Horman <horms@kernel.org>,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tHACKE-RC <rc@rexion.ai>", "Subject": "[PATCH net-next 1/2] netfilter: nf_conntrack_irc: reject DCC port\n values above 65535", "Date": "Thu, 30 Apr 2026 21:42:29 +0530", "Message-ID": "<20260430161230.3438973-2-rc@rexion.ai>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260430161230.3438973-1-rc@rexion.ai>", "References": "<20260430161230.3438973-1-rc@rexion.ai>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Envelope-From": "rc@rexion.ai" }, "content": "parse_dcc() stores the return value of simple_strtoul() directly into\na u_int16_t pointer. simple_strtoul() returns unsigned long, so values\nabove 65535 are silently truncated when assigned to the u16 output\nparameter.\n\nUse an intermediate unsigned long variable and reject out-of-range\nvalues by returning -1, which causes the caller in help() to skip\nthe DCC command via the existing error path.\n\nThe dcc_port == 0 check in help() already rejects port 0, so this\nchange only adds the upper-bound check in the parser.\n\nFixes: 869f37d8e48f (\"[NETFILTER]: nf_conntrack/nf_nat: add IRC helper port\")\nSigned-off-by: HACKE-RC <rc@rexion.ai>\n---\n net/netfilter/nf_conntrack_irc.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/net/netfilter/nf_conntrack_irc.c b/net/netfilter/nf_conntrack_irc.c\nindex 522183b9a..ffaa7ab84 100644\n--- a/net/netfilter/nf_conntrack_irc.c\n+++ b/net/netfilter/nf_conntrack_irc.c\n@@ -68,6 +68,7 @@ static const char *const dccprotos[] = {\n static int parse_dcc(char *data, const char *data_end, __be32 *ip,\n \t\t u_int16_t *port, char **ad_beg_p, char **ad_end_p)\n {\n+\tunsigned long parsed_port;\n \tchar *tmp;\n \n \t/* at least 12: \"AAAAAAAA P\\1\\n\" */\n@@ -93,7 +94,11 @@ static int parse_dcc(char *data, const char *data_end, __be32 *ip,\n \t\tdata++;\n \t}\n \n-\t*port = simple_strtoul(data, &data, 10);\n+\tparsed_port = simple_strtoul(data, &data, 10);\n+\tif (parsed_port > 65535)\n+\t\treturn -1;\n+\n+\t*port = parsed_port;\n \t*ad_end_p = data;\n \n \treturn 0;\n", "prefixes": [ "net-next", "1/2" ] }