Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2231095/?format=api
{ "id": 2231095, "url": "http://patchwork.ozlabs.org/api/patches/2231095/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/fd53342fd0764dc033664d47f1e0e391cebfbbe5.1777546194.git.fweimer@redhat.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<fd53342fd0764dc033664d47f1e0e391cebfbbe5.1777546194.git.fweimer@redhat.com>", "list_archive_url": null, "date": "2026-04-30T10:52:02", "name": "[2/5] resolv: Check for inet_ntop failure in ns_sprintrrf", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "19719974d6b558b30e4bcbc4a70528977243d7ea", "submitter": { "id": 14312, "url": "http://patchwork.ozlabs.org/api/people/14312/?format=api", "name": "Florian Weimer", "email": "fweimer@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/fd53342fd0764dc033664d47f1e0e391cebfbbe5.1777546194.git.fweimer@redhat.com/mbox/", "series": [ { "id": 502273, "url": "http://patchwork.ozlabs.org/api/series/502273/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=502273", "date": "2026-04-30T10:51:34", "name": "Fixes for CVE-2026-5435, CVE-2026-6238", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502273/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2231095/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2231095/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "libc-alpha@sourceware.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "libc-alpha@sourceware.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=N0RUtAAg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=N0RUtAAg", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5rdL2JZsz1yGq\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 20:53:58 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 26302436F7D8\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 10:53:56 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 917C5436F7EF\n for <libc-alpha@sourceware.org>; Thu, 30 Apr 2026 10:52:08 +0000 (GMT)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-MlLrzIKQOIqbRP4adC5I-Q-1; Thu,\n 30 Apr 2026 06:52:07 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 35BBB195609E\n for <libc-alpha@sourceware.org>; Thu, 30 Apr 2026 10:52:06 +0000 (UTC)", "from fweimer-oldenburg.csb.redhat.com (unknown [10.44.48.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 8019D19560AB\n for <libc-alpha@sourceware.org>; Thu, 30 Apr 2026 10:52:04 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 26302436F7D8", "OpenDKIM Filter v2.11.0 sourceware.org 917C5436F7EF" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 917C5436F7EF", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 917C5436F7EF", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777546328; cv=none;\n b=FdHwhjQ5mz/bcyIZWNosBMw+H6/8XBTXbYKD6lcwzz9aiWbHAkbJxj2L11KglnjgdbTvfHzwhRnXHliwULIRz3OoUJGMqS0V5LwVr3h9XifrIX26pfEJ0q0b6ROlsA2/+dAzowozUMAvtqVUxijbVwE1iUtdNnoKTD9nX1diH4s=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777546328; c=relaxed/simple;\n bh=wjk/nEc4TJWroMTOR/qaFDwloBD8v8vuuiN7aCviLNU=;\n h=DKIM-Signature:From:To:Subject:Message-ID:Date:MIME-Version;\n b=i/KOJB07fHbcg7Bu+Y6B5s3ws3/auotPKgjahKv19v2TM/pG82BAleRP6IcY7cv5nkHkAs8/80lxIqPJepjVqkRcctaff6w1FVdymRhI0xEvlRawlPWxb4eY5gN6LBlbMvV39krsacin7v22Mwn3SvyWlq9MV0+NaqlLQRaP280=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777546328;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=lHWtMpvWjCDIPI01DojkTCNfZY7uGetdZ17gjLoRjfw=;\n b=N0RUtAAgZHUlO5J5tL9HeN4Wj/0GEsis8VaLz6vHwQBb7cE3luOqnakcTmCiwvXzG/NhGV\n bXQnrY3PfnqrlMMp5OS5RIEyFeqZVKBhCRKm2UIZWg8WGRTo7oSN9xLbAIFn1PRQ1x5WhO\n +a5jCWKGeHSqgEB8dDq9Z7QPksk4Jg4=", "X-MC-Unique": "MlLrzIKQOIqbRP4adC5I-Q-1", "X-Mimecast-MFC-AGG-ID": "MlLrzIKQOIqbRP4adC5I-Q_1777546326", "From": "Florian Weimer <fweimer@redhat.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH 2/5] resolv: Check for inet_ntop failure in ns_sprintrrf", "In-Reply-To": "<cover.1777546194.git.fweimer@redhat.com>", "Message-ID": "\n <fd53342fd0764dc033664d47f1e0e391cebfbbe5.1777546194.git.fweimer@redhat.com>", "References": "<cover.1777546194.git.fweimer@redhat.com>", "X-From-Line": "fd53342fd0764dc033664d47f1e0e391cebfbbe5 Mon Sep 17 00:00:00 2001", "Date": "Thu, 30 Apr 2026 12:52:02 +0200", "User-Agent": "Gnus/5.13 (Gnus v5.13)", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "U0DuafxFxyjkhnuCXtq9anngMPakwpvfSq8zmSwItbY_1777546326", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain", "X-BeenThere": "libc-alpha@sourceware.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Libc-alpha mailing list <libc-alpha.sourceware.org>", "List-Unsubscribe": "<https://sourceware.org/mailman/options/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>", "List-Archive": "<https://sourceware.org/pipermail/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-request@sourceware.org?subject=help>", "List-Subscribe": "<https://sourceware.org/mailman/listinfo/libc-alpha>,\n <mailto:libc-alpha-request@sourceware.org?subject=subscribe>", "Errors-To": "libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org" }, "content": "This makes the output more consistent (either failure or complete\noutput) and helps with systematic testing with varying buffer\nsizes.\n---\n resolv/ns_print.c | 18 +++++++++++-------\n 1 file changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/resolv/ns_print.c b/resolv/ns_print.c\nindex cef2212fd2..5701e3d0c5 100644\n--- a/resolv/ns_print.c\n+++ b/resolv/ns_print.c\n@@ -141,7 +141,8 @@ ns_sprintrrf(const u_char *msg, size_t msglen,\n \tcase ns_t_a:\n \t if (rdlen != (size_t)NS_INADDRSZ)\n \t\t\tgoto formerr;\n-\t\t(void) inet_ntop(AF_INET, rdata, buf, buflen);\n+\t\tif (inet_ntop (AF_INET, rdata, buf, buflen) == NULL)\n+\t\t return -1;\n \t\taddlen(strlen(buf), &buf, &buflen);\n \t\tbreak;\n \n@@ -308,10 +309,11 @@ ns_sprintrrf(const u_char *msg, size_t msglen,\n \n \tcase ns_t_aaaa:\n \t if (rdlen != (size_t)NS_IN6ADDRSZ)\n-\t\t\tgoto formerr;\n-\t\t(void) inet_ntop(AF_INET6, rdata, buf, buflen);\n-\t\taddlen(strlen(buf), &buf, &buflen);\n-\t\tbreak;\n+\t goto formerr;\n+\t if (inet_ntop (AF_INET6, rdata, buf, buflen) == NULL)\n+\t return -1;\n+\t addlen(strlen(buf), &buf, &buflen);\n+\t break;\n \n \tcase ns_t_loc: {\n \t\tchar t[255];\n@@ -400,7 +402,8 @@ ns_sprintrrf(const u_char *msg, size_t msglen,\n \t\t\tgoto formerr;\n \n \t\t/* Address. */\n-\t\t(void) inet_ntop(AF_INET, rdata, buf, buflen);\n+\t\tif (inet_ntop (AF_INET, rdata, buf, buflen) == NULL)\n+\t\t return -1;\n \t\taddlen(strlen(buf), &buf, &buflen);\n \t\trdata += NS_INADDRSZ;\n \n@@ -542,7 +545,8 @@ ns_sprintrrf(const u_char *msg, size_t msglen,\n \t\t\tif (rdata + pbyte >= edata) goto formerr;\n \t\t\tmemset(&a, 0, sizeof(a));\n \t\t\tmemcpy(&a.s6_addr[pbyte], rdata, sizeof(a) - pbyte);\n-\t\t\t(void) inet_ntop(AF_INET6, &a, buf, buflen);\n+\t\t\tif (inet_ntop (AF_INET6, &a, buf, buflen) == NULL)\n+\t\t\t return -1;\n \t\t\taddlen(strlen(buf), &buf, &buflen);\n \t\t\trdata += sizeof(a) - pbyte;\n \t\t}\n", "prefixes": [ "2/5" ] }