Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2230743/?format=api
{ "id": 2230743, "url": "http://patchwork.ozlabs.org/api/patches/2230743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430002046.59739-3-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260430002046.59739-3-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2026-04-30T00:20:01", "name": "[v3,02/47] target/arm: Implement FEAT_FAMINMAX for AdvSIMD", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ee9232df29455b761935f876ced05769c865caad", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260430002046.59739-3-richard.henderson@linaro.org/mbox/", "series": [ { "id": 502175, "url": "http://patchwork.ozlabs.org/api/series/502175/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502175", "date": "2026-04-30T00:20:06", "name": "target/arm: Implement FEAT_FP8", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/502175/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230743/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kmmuXFG0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Zhf16mTz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 10:25:54 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIF9M-0006JP-8P; Wed, 29 Apr 2026 20:21:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIF9I-0006Gk-3M\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:21:00 -0400", "from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIF9G-00065w-05\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 20:20:59 -0400", "by mail-pf1-x429.google.com with SMTP id\n d2e1a72fcca58-827270d50d4so333660b3a.3\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 17:20:57 -0700 (PDT)", "from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-834ed5cd3b8sm3461727b3a.16.2026.04.29.17.20.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 17:20:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777508457; x=1778113257; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oWIPSgFXM14xagFSaM0RuKbNAbnPwaHok4JiUn9LCMU=;\n b=kmmuXFG0ec6o9J+h+62LPzy5jCqsT5eBYG7ClZkBPGpoamCQ6pGKMNwjZsZ/kCu2Nu\n +Ad+FOxY/2QqujwoGTHPEozfa0qXErGMAYjF1+7f701GLhZEYM+vyoZYDp5m2PO+pMjS\n GxajvhH11yBuWQ2XYVgTCyPvXGs1lyCrvv5qGIf1N6DgeZTSJ9uq8gB/gaWkbv1GtY74\n 4M3ZyU2r3dK9H+roqjFis6q0CgoGYjhvZjKGriLBGEJHXB3ezZ8KLqDdnERWf0e5qnBb\n PKWRVZlQ7AQR/cTKAd5oD7LLl6HehsolmOL/L0QS6HseBrIX6ElIc4pRQm1XX8sB1h+9\n Dx0g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777508457; x=1778113257;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=oWIPSgFXM14xagFSaM0RuKbNAbnPwaHok4JiUn9LCMU=;\n b=IOi0QWkkwQetcMNtUybfW6Fz8kvLYcqZYQ1sTf6slDdO5bfsNQOzMllIUGNaPY/gda\n Wlv3CTuL3f87HQzjQSe9eoclYuao/maVk/kTndn3HSD3Kaf4P7Atlf+YRcxHcvcq/5V6\n Ysr0fen+4RpV2CeCvPwu4Vp+KGpcUE0H1gvlX7xid9kEcUJPwYlvjllXdnhGL8bYnE0Q\n CC7SEOAbCFAAjWFJ6pRUg/uue7Xd2T9nrmPZj3TW6HaYWQwnw9udyxZkmhL++/31L6oK\n XxHOVP2xnw+6hL2jPPLP99VxgmvnLf8VCweJi4il+LTWD1mktK8fn4o0NosOMyAGRqhG\n HGlQ==", "X-Gm-Message-State": "AOJu0Yyh1rWSpjAFGOme5IvS5io9lfqNWNvmud7LSEfBUnlZKcseonC7\n C6brkWmW4w6S40iMJ8Xdz9aPVvLQEl1yhvp8BCaV752JSvfH65QKNm4pXYCpH46QcOC5QgVuSvT\n mNMHx0TE=", "X-Gm-Gg": "AeBDieun0GhKlJGiVfzp9NhTWnxIUSPjKPt+YQO09qPbD1dumu6dL5HHBDLIBZFd/R/\n dppv9ZObzCjQEs/5qIN9Y8fqQbdkJftwLa0yV7Oa/QUxP3c3W5kK6pht7vjluny3nhvxYCuO7ML\n mt8h7d7GMs8wYgWtKjvJ0KLMh5d2HwMS2pfhTTxU3vtt4Z1bl0j3TYNQwyiOnGywjq0VLSLPFV8\n YTqGQMOUq8++PkKvcdmHHaoMOUYu0XvaZgWwkCwRWO8JtDDe6LBH2wuU3EmAoKyVYOGl1UadAnx\n /aeAW1ihu1Xe7ZxT4WtLMlicMcWu85a3TVW/pAtf+f7vjTuDAtZH76DEtNIKG09PuW04Ulb150h\n BnnEbciRx/ATBmcTlbmZ6AgQAIzlCMMgkk6hil8nhZlYSFxMbV12wdDVoJriddL6vnv/25oTkmy\n 8HBqAlK7esY4D3DKTK58KR+q2pnBLApk/+404Df7m/", "X-Received": "by 2002:a05:6a00:230b:b0:82f:7076:cf2b with SMTP id\n d2e1a72fcca58-834fdc49aabmr831549b3a.40.1777508456568;\n Wed, 29 Apr 2026 17:20:56 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org", "Subject": "[PATCH v3 02/47] target/arm: Implement FEAT_FAMINMAX for AdvSIMD", "Date": "Thu, 30 Apr 2026 10:20:01 +1000", "Message-ID": "<20260430002046.59739-3-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260430002046.59739-1-richard.henderson@linaro.org>", "References": "<20260430002046.59739-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::429;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n target/arm/cpu-features.h | 5 +++++\n target/arm/tcg/helper-a64-defs.h | 7 +++++++\n target/arm/tcg/vec_internal.h | 7 +++++++\n target/arm/tcg/translate-a64.c | 14 +++++++++++++\n target/arm/tcg/vec_helper64.c | 35 ++++++++++++++++++++++++++++++++\n target/arm/tcg/a64.decode | 5 +++++\n 6 files changed, 73 insertions(+)", "diff": "diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h\nindex d442bb98eb..f84b451626 100644\n--- a/target/arm/cpu-features.h\n+++ b/target/arm/cpu-features.h\n@@ -1053,6 +1053,11 @@ static inline bool isar_feature_aa64_ats1a(const ARMISARegisters *id)\n return FIELD_EX64_IDREG(id, ID_AA64ISAR2, ATS1A);\n }\n \n+static inline bool isar_feature_aa64_faminmax(const ARMISARegisters *id)\n+{\n+ return FIELD_EX64_IDREG(id, ID_AA64ISAR3, FAMINMAX) != 0;\n+}\n+\n static inline bool isar_feature_aa64_fp_simd(const ARMISARegisters *id)\n {\n /* We always set the AdvSIMD and FP fields identically. */\ndiff --git a/target/arm/tcg/helper-a64-defs.h b/target/arm/tcg/helper-a64-defs.h\nindex 3c3c5dddb7..215df1201b 100644\n--- a/target/arm/tcg/helper-a64-defs.h\n+++ b/target/arm/tcg/helper-a64-defs.h\n@@ -145,6 +145,13 @@ DEF_HELPER_FLAGS_5(gvec_fmulx_idx_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst,\n DEF_HELPER_FLAGS_5(gvec_fmulx_idx_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n DEF_HELPER_FLAGS_5(gvec_fmulx_idx_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n \n+DEF_HELPER_FLAGS_5(gvec_famax_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+DEF_HELPER_FLAGS_5(gvec_famin_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+DEF_HELPER_FLAGS_5(gvec_famax_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+DEF_HELPER_FLAGS_5(gvec_famin_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+DEF_HELPER_FLAGS_5(gvec_famax_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+DEF_HELPER_FLAGS_5(gvec_famin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32)\n+\n #ifndef CONFIG_USER_ONLY\n DEF_HELPER_2(exception_return, void, env, i64)\n #endif\ndiff --git a/target/arm/tcg/vec_internal.h b/target/arm/tcg/vec_internal.h\nindex c7ccb28b18..cc2691b2f6 100644\n--- a/target/arm/tcg/vec_internal.h\n+++ b/target/arm/tcg/vec_internal.h\n@@ -338,6 +338,13 @@ bfloat16 helper_sme2_ah_fmin_b16(bfloat16 a, bfloat16 b, float_status *fpst);\n float32 sve_f16_to_f32(float16 f, float_status *fpst);\n float16 sve_f32_to_f16(float32 f, float_status *fpst);\n \n+float16 float16_famax(float16, float16, float_status *);\n+float16 float16_famin(float16, float16, float_status *);\n+float32 float32_famax(float32, float32, float_status *);\n+float32 float32_famin(float32, float32, float_status *);\n+float64 float64_famax(float64, float64, float_status *);\n+float64 float64_famin(float64, float64, float_status *);\n+\n /*\n * Decode helper functions for predicate as counter.\n */\ndiff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c\nindex 9a27c4c6ec..3c6559964b 100644\n--- a/target/arm/tcg/translate-a64.c\n+++ b/target/arm/tcg/translate-a64.c\n@@ -6478,6 +6478,20 @@ static gen_helper_gvec_3_ptr * const f_vector_fminnmp[3] = {\n };\n TRANS(FMINNMP_v, do_fp3_vector, a, 0, f_vector_fminnmp)\n \n+static gen_helper_gvec_3_ptr * const f_vector_famax[3] = {\n+ gen_helper_gvec_famax_h,\n+ gen_helper_gvec_famax_s,\n+ gen_helper_gvec_famax_d,\n+};\n+TRANS_FEAT(FAMAX, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famax)\n+\n+static gen_helper_gvec_3_ptr * const f_vector_famin[3] = {\n+ gen_helper_gvec_famin_h,\n+ gen_helper_gvec_famin_s,\n+ gen_helper_gvec_famin_d,\n+};\n+TRANS_FEAT(FAMIN, aa64_faminmax, do_fp3_vector, a, 0, f_vector_famin)\n+\n static bool do_fmlal(DisasContext *s, arg_qrrr_e *a, bool is_s, bool is_2)\n {\n if (fp_access_check(s)) {\ndiff --git a/target/arm/tcg/vec_helper64.c b/target/arm/tcg/vec_helper64.c\nindex 249a257177..b5ad67b5e0 100644\n--- a/target/arm/tcg/vec_helper64.c\n+++ b/target/arm/tcg/vec_helper64.c\n@@ -140,3 +140,38 @@ void HELPER(simd_tblx)(void *vd, void *vm, CPUARMState *env, uint32_t desc)\n memcpy(vd, &result, 16);\n clear_tail(vd, oprsz, simd_maxsz(desc));\n }\n+\n+#define DO_FAMINMAX(NAME, TYPE, FN) \\\n+TYPE TYPE##_##NAME(TYPE a, TYPE b, float_status *s) \\\n+{ \\\n+ bool save_fz = get_flush_to_zero(s); \\\n+ bool save_fiz = get_flush_inputs_to_zero(s); \\\n+ int new_flags, save_flags = get_float_exception_flags(s); \\\n+ \\\n+ set_flush_to_zero(0, s); \\\n+ set_flush_inputs_to_zero(0, s); \\\n+ TYPE r = TYPE##_##FN(TYPE##_abs(a), TYPE##_abs(b), s); \\\n+ \\\n+ set_flush_to_zero(save_fz, s); \\\n+ set_flush_inputs_to_zero(save_fiz, s); \\\n+ new_flags = get_float_exception_flags(s); \\\n+ new_flags = (save_flags & float_flag_input_denormal_used) \\\n+ | (new_flags & ~float_flag_input_denormal_used); \\\n+ set_float_exception_flags(new_flags, s); \\\n+ \\\n+ return r; \\\n+}\n+\n+DO_FAMINMAX(famax, float16, max)\n+DO_FAMINMAX(famin, float16, min)\n+DO_FAMINMAX(famax, float32, max)\n+DO_FAMINMAX(famin, float32, min)\n+DO_FAMINMAX(famax, float64, max)\n+DO_FAMINMAX(famin, float64, min)\n+\n+DO_3OP(gvec_famax_h, float16_famax, float16)\n+DO_3OP(gvec_famin_h, float16_famin, float16)\n+DO_3OP(gvec_famax_s, float32_famax, float32)\n+DO_3OP(gvec_famin_s, float32_famin, float32)\n+DO_3OP(gvec_famax_d, float64_famax, float64)\n+DO_3OP(gvec_famin_d, float64_famin, float64)\ndiff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode\nindex 01b1b3e38b..666a293540 100644\n--- a/target/arm/tcg/a64.decode\n+++ b/target/arm/tcg/a64.decode\n@@ -1193,6 +1193,11 @@ RSUBHN 0.10 1110 ..1 ..... 01100 0 ..... ..... @qrrr_e\n PMULL_p8 0.00 1110 001 ..... 11100 0 ..... ..... @qrrr_b\n PMULL_p64 0.00 1110 111 ..... 11100 0 ..... ..... @qrrr_b\n \n+FAMAX 0.00 1110 110 ..... 00011 1 ..... ..... @qrrr_h\n+FAMAX 0.00 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd\n+FAMIN 0.10 1110 110 ..... 00011 1 ..... ..... @qrrr_h\n+FAMIN 0.10 1110 1.1 ..... 11011 1 ..... ..... @qrrr_sd\n+\n ### Advanced SIMD scalar x indexed element\n \n FMUL_si 0101 1111 00 .. .... 1001 . 0 ..... ..... @rrx_h\n", "prefixes": [ "v3", "02/47" ] }