Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2230624/?format=api
{ "id": 2230624, "url": "http://patchwork.ozlabs.org/api/patches/2230624/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-32-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260429222445.26301-32-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2026-04-29T22:24:28", "name": "[PULL,31/48] fpu: Constify frac{64,128,256}_* inputs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c177d6ce2b640ab2cdc94fc8cebb210fdd322fc8", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429222445.26301-32-richard.henderson@linaro.org/mbox/", "series": [ { "id": 502161, "url": "http://patchwork.ozlabs.org/api/series/502161/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502161", "date": "2026-04-29T22:23:57", "name": "[PULL,01/48] fpu: Drop parts_canonicalize", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502161/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230624/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cWyqMfJU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5X5W3q6Hz1yHZ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 08:28:47 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIDMH-0002W7-PT; Wed, 29 Apr 2026 18:26:17 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDME-000228-LT\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:14 -0400", "from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wIDMB-0005EN-UG\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:26:14 -0400", "by mail-pj1-x1035.google.com with SMTP id\n 98e67ed59e1d1-35fb16e56efso133352a91.2\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 15:26:11 -0700 (PDT)", "from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a2732502sm1888471a91.3.2026.04.29.15.26.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 15:26:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777501570; x=1778106370; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HWZQajC/tHGSK7fSPh9L60VVX/n9t/233b4QjeCHzU4=;\n b=cWyqMfJUGzwFAzmTWQQiJ5u8Gm3FKMyRushEXl49SyNBo4MFXVflr/9QNoH60DCoZJ\n uk3zEdtgFvHQiGSyqC38LfoTgJDb7sUE2Wi/m1hPNvlA0r7JrF0/MKcqn0zd9TpobgWS\n KMU5tPxruUeIUiOEeBH8dbY/I2xxague1L4ZR0k9jHc7Cvw8uS/t5k30DWiCzAqmluUt\n gAjBwrr8Ud+v+AkuThV81ibWc4B/SxIp6SUCrUTN/IzrxWj6GYPb9wiO71wKOuWo0tRZ\n i5GT49paIJwyFSSMzmWclHdHW3B4B2qXwxw3i9/eG9Mk934XBb7Fg72ynEWErgVap2Jq\n eBJg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777501570; x=1778106370;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=HWZQajC/tHGSK7fSPh9L60VVX/n9t/233b4QjeCHzU4=;\n b=MxkVgSgxEG6iFgZx+uGhKy/uqkNgW/N7RkOHKMimZuRYbkP3oepboCQknaGwT/hV+C\n ukhWydTPwT8ML4KUDM113pAkdv9esEeZr1LnmZMF3tIGfGnhazqAhSwSohX4yTAjWydB\n 4Jm+50bJsfprqrB69R59CCisjtuOOLOa2DdgL2cGo6c41uooLTDDj1I+mYqRbFgbiAEo\n hWmxOM4ryYP4LbsFiJLe4Lc0BmXrEziu548/B0cUbbBoVIQDTZPEw7/gwyewZKswJKXS\n 9AqKfuP2R3RlKoFL4Z57mixVU2KvUdy+0OR59UoOjojPY8k1O1LOH9VMuSeG+m1QXT+Z\n WlzA==", "X-Gm-Message-State": "AOJu0YxkPRaThOb3FLgWm5sqwmZWAG7guDfMv0wyPCd6Xjmi+ENxPr0n\n VmhoQsmkOQGqDM+O3B5q86KNpLnX2mc9/yT4TURK2FiBNMvmOMwvrUjlBEmphgkSHH+FCHsTE6m\n dngu1nGI=", "X-Gm-Gg": "AeBDieupqZurzwcIYRySccx7b+1giognfYapvB0xHxUbWvS08ONGE7QmFjFwr48prv+\n d9+/n4NZPuZx0RQi2ybUEiyrrMBrpnYkCrOEC36rPsV7kwrDvhlz7Rabc5RQ0VYr8xt+dQTwy4G\n /DcUzTlXbMr97Z2sF8JmmTqJAj90qbtxrbG4OJOBquFDzSDqZEz0ZhtXkThxR52BnJp968CnEEM\n 0nBW9t6HmstAKwJXmy+o/Aerbpog2vuFAYFm9m7F5QcwkHKgS4NhB7CWdKSFsHaZYnEzkJ++M0r\n O7rxnyaE384mv3G9Kr6hDS+1lyE789NWPSfISW6GbVAfQyoQtq67qDcP0/2vPURt4K7GrLd3EaQ\n qlWn12JSb5m0dHqLBC7/K1fSrlslDgReayuPo5Npb5ioRQpL9GJHxiQbzUnuJZX8ccgmCYWIIUj\n 0yFfipkMWP+gOaBuOAi8DcVLA+kBma6EsKprm6WWYj", "X-Received": "by 2002:a17:90b:270b:b0:359:f43d:4a6e with SMTP id\n 98e67ed59e1d1-364c2d88673mr235815a91.0.1777501570359;\n Wed, 29 Apr 2026 15:26:10 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "stefanha@redhat.com,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "Subject": "[PULL 31/48] fpu: Constify frac{64,128,256}_* inputs", "Date": "Thu, 30 Apr 2026 08:24:28 +1000", "Message-ID": "<20260429222445.26301-32-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260429222445.26301-1-richard.henderson@linaro.org>", "References": "<20260429222445.26301-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::1035;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 53 +++++++++++++++++++++++++++++--------------------\n 1 file changed, 31 insertions(+), 22 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex e462fb7d74..6cca31af30 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -774,12 +774,14 @@ static float128 QEMU_FLATTEN float128_pack_raw(const FloatParts128 *p)\n * Helper functions for softfloat-parts.c.inc, per-size operations.\n */\n \n-static bool frac64_add(FloatParts64 *r, FloatParts64 *a, FloatParts64 *b)\n+static bool frac64_add(FloatParts64 *r,\n+ const FloatParts64 *a, const FloatParts64 *b)\n {\n return uadd64_overflow(a->frac, b->frac, &r->frac);\n }\n \n-static bool frac128_add(FloatParts128 *r, FloatParts128 *a, FloatParts128 *b)\n+static bool frac128_add(FloatParts128 *r,\n+ const FloatParts128 *a, const FloatParts128 *b)\n {\n bool c = 0;\n r->frac_lo = uadd64_carry(a->frac_lo, b->frac_lo, &c);\n@@ -787,7 +789,8 @@ static bool frac128_add(FloatParts128 *r, FloatParts128 *a, FloatParts128 *b)\n return c;\n }\n \n-static bool frac256_add(FloatParts256 *r, FloatParts256 *a, FloatParts256 *b)\n+static bool frac256_add(FloatParts256 *r,\n+ const FloatParts256 *a, const FloatParts256 *b)\n {\n bool c = 0;\n r->frac_lo = uadd64_carry(a->frac_lo, b->frac_lo, &c);\n@@ -797,12 +800,12 @@ static bool frac256_add(FloatParts256 *r, FloatParts256 *a, FloatParts256 *b)\n return c;\n }\n \n-static bool frac64_addi(FloatParts64 *r, FloatParts64 *a, uint64_t c)\n+static bool frac64_addi(FloatParts64 *r, const FloatParts64 *a, uint64_t c)\n {\n return uadd64_overflow(a->frac, c, &r->frac);\n }\n \n-static bool frac128_addi(FloatParts128 *r, FloatParts128 *a, uint64_t c)\n+static bool frac128_addi(FloatParts128 *r, const FloatParts128 *a, uint64_t c)\n {\n c = uadd64_overflow(a->frac_lo, c, &r->frac_lo);\n return uadd64_overflow(a->frac_hi, c, &r->frac_hi);\n@@ -818,14 +821,14 @@ static void frac128_allones(FloatParts128 *a)\n a->frac_hi = a->frac_lo = -1;\n }\n \n-static FloatRelation frac64_cmp(FloatParts64 *a, FloatParts64 *b)\n+static FloatRelation frac64_cmp(const FloatParts64 *a, const FloatParts64 *b)\n {\n return (a->frac == b->frac ? float_relation_equal\n : a->frac < b->frac ? float_relation_less\n : float_relation_greater);\n }\n \n-static FloatRelation frac128_cmp(FloatParts128 *a, FloatParts128 *b)\n+static FloatRelation frac128_cmp(const FloatParts128 *a, const FloatParts128 *b)\n {\n uint64_t ta = a->frac_hi, tb = b->frac_hi;\n if (ta == tb) {\n@@ -847,7 +850,7 @@ static void frac128_clear(FloatParts128 *a)\n a->frac_hi = a->frac_lo = 0;\n }\n \n-static bool frac64_div(FloatParts64 *a, FloatParts64 *b)\n+static bool frac64_div(FloatParts64 *a, const FloatParts64 *b)\n {\n uint64_t n1, n0, r, q;\n bool ret;\n@@ -879,7 +882,7 @@ static bool frac64_div(FloatParts64 *a, FloatParts64 *b)\n return ret;\n }\n \n-static bool frac128_div(FloatParts128 *a, FloatParts128 *b)\n+static bool frac128_div(FloatParts128 *a, const FloatParts128 *b)\n {\n uint64_t q0, q1, a0, a1, b0, b1;\n uint64_t r0, r1, r2, r3, t0, t1, t2, t3;\n@@ -926,22 +929,24 @@ static bool frac128_div(FloatParts128 *a, FloatParts128 *b)\n return ret;\n }\n \n-static bool frac64_eqz(FloatParts64 *a)\n+static bool frac64_eqz(const FloatParts64 *a)\n {\n return a->frac == 0;\n }\n \n-static bool frac128_eqz(FloatParts128 *a)\n+static bool frac128_eqz(const FloatParts128 *a)\n {\n return (a->frac_hi | a->frac_lo) == 0;\n }\n \n-static void frac64_mulw(FloatParts128 *r, FloatParts64 *a, FloatParts64 *b)\n+static void frac64_mulw(FloatParts128 *r,\n+ const FloatParts64 *a, const FloatParts64 *b)\n {\n mulu64(&r->frac_lo, &r->frac_hi, a->frac, b->frac);\n }\n \n-static void frac128_mulw(FloatParts256 *r, FloatParts128 *a, FloatParts128 *b)\n+static void frac128_mulw(FloatParts256 *r,\n+ const FloatParts128 *a, const FloatParts128 *b)\n {\n mul128To256(a->frac_hi, a->frac_lo, b->frac_hi, b->frac_lo,\n &r->frac_hi, &r->frac_hm, &r->frac_lm, &r->frac_lo);\n@@ -1041,7 +1046,8 @@ static int frac256_normalize(FloatParts256 *a)\n return ret;\n }\n \n-static void frac64_modrem(FloatParts64 *a, FloatParts64 *b, uint64_t *mod_quot)\n+static void frac64_modrem(FloatParts64 *a, const FloatParts64 *b,\n+ uint64_t *mod_quot)\n {\n uint64_t a0, a1, b0, t0, t1, q, quot;\n int exp_diff = a->exp - b->exp;\n@@ -1124,7 +1130,7 @@ static void frac64_modrem(FloatParts64 *a, FloatParts64 *b, uint64_t *mod_quot)\n a->frac = a0 | (a1 != 0);\n }\n \n-static void frac128_modrem(FloatParts128 *a, FloatParts128 *b,\n+static void frac128_modrem(FloatParts128 *a, const FloatParts128 *b,\n uint64_t *mod_quot)\n {\n uint64_t a0, a1, a2, b0, b1, t0, t1, t2, q, quot;\n@@ -1353,12 +1359,14 @@ static void frac256_shrjam(FloatParts256 *a, int c)\n a->frac_hi = a0;\n }\n \n-static bool frac64_sub(FloatParts64 *r, FloatParts64 *a, FloatParts64 *b)\n+static bool frac64_sub(FloatParts64 *r,\n+ const FloatParts64 *a, const FloatParts64 *b)\n {\n return usub64_overflow(a->frac, b->frac, &r->frac);\n }\n \n-static bool frac128_sub(FloatParts128 *r, FloatParts128 *a, FloatParts128 *b)\n+static bool frac128_sub(FloatParts128 *r,\n+ const FloatParts128 *a, const FloatParts128 *b)\n {\n bool c = 0;\n r->frac_lo = usub64_borrow(a->frac_lo, b->frac_lo, &c);\n@@ -1366,7 +1374,8 @@ static bool frac128_sub(FloatParts128 *r, FloatParts128 *a, FloatParts128 *b)\n return c;\n }\n \n-static bool frac256_sub(FloatParts256 *r, FloatParts256 *a, FloatParts256 *b)\n+static bool frac256_sub(FloatParts256 *r,\n+ const FloatParts256 *a, const FloatParts256 *b)\n {\n bool c = 0;\n r->frac_lo = usub64_borrow(a->frac_lo, b->frac_lo, &c);\n@@ -1376,24 +1385,24 @@ static bool frac256_sub(FloatParts256 *r, FloatParts256 *a, FloatParts256 *b)\n return c;\n }\n \n-static void frac64_truncjam(FloatParts64 *r, FloatParts128 *a)\n+static void frac64_truncjam(FloatParts64 *r, const FloatParts128 *a)\n {\n r->frac = a->frac_hi | (a->frac_lo != 0);\n }\n \n-static void frac128_truncjam(FloatParts128 *r, FloatParts256 *a)\n+static void frac128_truncjam(FloatParts128 *r, const FloatParts256 *a)\n {\n r->frac_hi = a->frac_hi;\n r->frac_lo = a->frac_hm | ((a->frac_lm | a->frac_lo) != 0);\n }\n \n-static void frac64_widen(FloatParts128 *r, FloatParts64 *a)\n+static void frac64_widen(FloatParts128 *r, const FloatParts64 *a)\n {\n r->frac_hi = a->frac;\n r->frac_lo = 0;\n }\n \n-static void frac128_widen(FloatParts256 *r, FloatParts128 *a)\n+static void frac128_widen(FloatParts256 *r, const FloatParts128 *a)\n {\n r->frac_hi = a->frac_hi;\n r->frac_hm = a->frac_lo;\n", "prefixes": [ "PULL", "31/48" ] }