Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2230568/?format=api
{ "id": 2230568, "url": "http://patchwork.ozlabs.org/api/patches/2230568/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-6-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260429210830.594724-6-berrange@redhat.com>", "list_archive_url": null, "date": "2026-04-29T21:08:26", "name": "[5/9] qom: have object_set_props_keyval return bool", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9f366c800fd8a2223b0bea78d2db7a18f8981d5d", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260429210830.594724-6-berrange@redhat.com/mbox/", "series": [ { "id": 502152, "url": "http://patchwork.ozlabs.org/api/series/502152/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502152", "date": "2026-04-29T21:08:21", "name": "qom: misc cleanups / fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502152/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2230568/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2230568/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MgreAw6N;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5VLJ4GTFz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 30 Apr 2026 07:09:42 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wIC9P-0007QC-2r; Wed, 29 Apr 2026 17:08:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9N-0007Lp-0Q\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:53 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wIC9G-0004DX-VC\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:08:49 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-c2XQoc7CO3Csq3J2T-BeGw-1; Wed,\n 29 Apr 2026 17:08:45 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 36F2F1800366\n for <qemu-devel@nongnu.org>; Wed, 29 Apr 2026 21:08:44 +0000 (UTC)", "from berrange.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C3870300019F; Wed, 29 Apr 2026 21:08:42 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777496926;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gv7XNbd9kQXgqSxoNVB7sOMaqzg5QhpPsPiIElEcqmw=;\n b=MgreAw6NRvN6ktdqSYnxXckReqHZvsQuA1hgVangFsd67Vka4cK1k54MXhttvfBAiHkazn\n D8ym9HeI1W2POLD/Av75OD/+UvkZkxPPnuodBwEeqLopAacgLn6pwOg1ONInVIltUEv/B+\n vcFlSMGRqTpfF2amgKm/FzfdHQ0PlQc=", "X-MC-Unique": "c2XQoc7CO3Csq3J2T-BeGw-1", "X-Mimecast-MFC-AGG-ID": "c2XQoc7CO3Csq3J2T-BeGw_1777496924", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH 5/9] qom: have object_set_props_keyval return bool", "Date": "Wed, 29 Apr 2026 22:08:26 +0100", "Message-ID": "<20260429210830.594724-6-berrange@redhat.com>", "In-Reply-To": "<20260429210830.594724-1-berrange@redhat.com>", "References": "<20260429210830.594724-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This matches the convention established by the object_set_props and\nobject_set_propv methods.\n\nSigned-off-by: Daniel P. Berrangé <berrange@redhat.com>\n---\n include/qom/object.h | 4 +++-\n qom/object_interfaces.c | 13 +++++++++----\n 2 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/qom/object.h b/include/qom/object.h\nindex d841c338a2..20a04cc4a9 100644\n--- a/include/qom/object.h\n+++ b/include/qom/object.h\n@@ -924,8 +924,10 @@ bool type_print_class_properties(const char *type);\n *\n * For each key in the dictionary, parse the value string if needed,\n * then set the corresponding property in @obj.\n+ *\n+ * Returns: %true on success, %false on error.\n */\n-void object_set_props_from_keyval(Object *obj, const QDict *qdict,\n+bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n bool from_json, Error **errp);\n \n /**\ndiff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex 4377d65b76..50736b80c8 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -44,13 +44,14 @@ bool user_creatable_can_be_deleted(UserCreatable *uc)\n }\n }\n \n-static void object_set_props_from_qdict(Object *obj, const QDict *qdict,\n+static bool object_set_props_from_qdict(Object *obj, const QDict *qdict,\n Visitor *v, Error **errp)\n {\n+ ERRP_GUARD();\n const QDictEntry *e;\n \n if (!visit_start_struct(v, NULL, NULL, 0, errp)) {\n- return;\n+ return false;\n }\n for (e = qdict_first(qdict); e; e = qdict_next(qdict, e)) {\n if (!object_property_set(obj, e->key, v, errp)) {\n@@ -60,19 +61,23 @@ static void object_set_props_from_qdict(Object *obj, const QDict *qdict,\n visit_check_struct(v, errp);\n out:\n visit_end_struct(v, NULL);\n+\n+ return *errp == NULL;\n }\n \n-void object_set_props_from_keyval(Object *obj, const QDict *qdict,\n+bool object_set_props_from_keyval(Object *obj, const QDict *qdict,\n bool from_json, Error **errp)\n {\n+ bool ret;\n Visitor *v;\n if (from_json) {\n v = qobject_input_visitor_new(QOBJECT(qdict));\n } else {\n v = qobject_input_visitor_new_keyval(QOBJECT(qdict));\n }\n- object_set_props_from_qdict(obj, qdict, v, errp);\n+ ret = object_set_props_from_qdict(obj, qdict, v, errp);\n visit_free(v);\n+ return ret;\n }\n \n Object *user_creatable_add_type(const char *type, const char *id,\n", "prefixes": [ "5/9" ] }