Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2228346/?format=api
{ "id": 2228346, "url": "http://patchwork.ozlabs.org/api/patches/2228346/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426-gtk-clipboard-v3-2-09555aaeda34@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260426-gtk-clipboard-v3-2-09555aaeda34@gmail.com>", "list_archive_url": null, "date": "2026-04-26T07:52:34", "name": "[v3,2/2] ui/gtk: Keep GTK clipboard enabled", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1698b04d7e41072a10222ec2eff1689b2ab51057", "submitter": { "id": 4408, "url": "http://patchwork.ozlabs.org/api/people/4408/?format=api", "name": "Jindřich Makovička", "email": "makovick@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426-gtk-clipboard-v3-2-09555aaeda34@gmail.com/mbox/", "series": [ { "id": 501511, "url": "http://patchwork.ozlabs.org/api/series/501511/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501511", "date": "2026-04-26T07:52:32", "name": "Fix and re-enable GTK clipboard", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501511/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228346/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=d0lGR/dm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Jpv2WMXz1yJ1\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 17:53:25 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGuIJ-0000d0-3O; Sun, 26 Apr 2026 03:52:47 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <makovick@gmail.com>)\n id 1wGuID-0000bl-O5\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 03:52:42 -0400", "from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <makovick@gmail.com>)\n id 1wGuIB-0006NE-Rt\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 03:52:41 -0400", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-488ba840146so82500005e9.1\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 00:52:39 -0700 (PDT)", "from [192.168.0.10] ([2a03:ab00:1000:1b60:331a:b316:78f6:effc])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb74c68asm224080045e9.3.2026.04.26.00.52.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 00:52:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777189958; x=1777794758; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=/dB9Jl1UuY5f333X9zTcSj/D8VVe4daYWJBNZAwS8QI=;\n b=d0lGR/dmK13dtBXP97/Ym2kzDjvubkuRqwK5cyQrzA9GFo4QhotiAjBJWSK4L1S1y/\n z6p+D/wT04bsGjsk0qpwaGy4By9v9k2HWr6JydTKtfieSv4Abri0Fsj1Y8p9OBMfq4Tg\n KviQzf/8kGxM+VVQOLlGeURY4gtmPL0D3aE3C916N38/p1rNcKcBYve6HDhf29iAYxNV\n WjmhqO8JZC3BZbgH4TxVPGjZTP4AlFzZAtMZqfNGvLpHpxoX2rdD1fOdR6WBoXDK5g3M\n nbnrsjjJ1w7ZnmVcw33X046jQCTCoQVO81KHvxLMWKyuvgwAhP3U9/EJvSHhpRAQiF2N\n SIDw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777189958; x=1777794758;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=/dB9Jl1UuY5f333X9zTcSj/D8VVe4daYWJBNZAwS8QI=;\n b=CC7wYpOlyLAkl1i7+qRuIOyYY6f7olD6gmOykHs5COxJbylnPDqAHBdwcKsrMlMFFZ\n SSUKzgISEYxYPO2dK0YFLcRqNFrpv+C+4hdl8ANTZ5lfu1bXNxZao01zTVY7DjQjiBpD\n MxPItAyXFUK7Kzzz7cyREFhPEzszXL7sp5uHr1wvNmtgEPpoU6DaVsx5v2+bfyOG2CWi\n 8qAjGRgC7VIyzSAZaXARKRXkzEDkHifCWMj3kQEDvIvXucNY38Q1TDazPtSHLMAos5gA\n fPgHRtIeBIAFs+cU9VtSHBbaIbBMiByuU9ZFjDj3mlJHfrJLXDMMIhugDNTOTJ8tQqmF\n xi1A==", "X-Gm-Message-State": "AOJu0YzEhBFxqLlKM9g5go8EWADA05e3ZSsLQeHkFXeZaKGnN+0qQCdR\n IasyutBiWA5k8Ric5eUlnaKohQX5dcZWOkILOLc6sZetgaVdjBQXJXOyyexETv/y", "X-Gm-Gg": "AeBDievkgiLwriy3RBogx/feM/MexXAxd3dGPitepHJnYItqA3DfQGDoCPN/KJjKdas\n Bpc3wJSJEadXPcPgTHZIWbPuIZOsywqeMBspubg1T2u5zbbNJCKs6GQshtZw7hM6LjhZT9z4k5g\n M9bTWo8NBGhw7CenuZ9jzXZi2qtXwddVys+X0vUzJLVOOjjVMQCDOwA0dzwdsMgJ8k2AD2qeSR0\n uschjns2hGHVdwHyBkUmfcOmE9hvRDnwyhFLs4/9TT1zjmdc11TaoczPJD+BcNVtf440KGCLtqX\n vTXVFXlBJhB+ah79Q/gCUUsF36cw4v/hNgKdVWoPDbfQZTd+SFMo+R9+fLx7/Ed2k/jfQ93nzr+\n zHFQyGzi+iXn4wxvB5y+OGomDrg7tUGpROQPKm+Iz/2M+osSKJNWBNwm+ZhjXDToFZDpnepAal5\n S4j6hdf6efVdU05chFRfba9wwhlDjpT1XEl2GIQGk=", "X-Received": "by 2002:a05:600c:3b97:b0:488:af7f:7707 with SMTP id\n 5b1f17b1804b1-488fb769dbfmr581872345e9.18.1777189957887;\n Sun, 26 Apr 2026 00:52:37 -0700 (PDT)", "From": "=?utf-8?q?Jind=C5=99ich_Makovi=C4=8Dka?= <makovick@gmail.com>", "Date": "Sun, 26 Apr 2026 09:52:34 +0200", "Subject": "[PATCH v3 2/2] ui/gtk: Keep GTK clipboard enabled", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260426-gtk-clipboard-v3-2-09555aaeda34@gmail.com>", "References": "<20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com>", "In-Reply-To": "<20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Jindrich Makovicka <makovick@gmail.com>", "X-Mailer": "b4 0.14.3", "Received-SPF": "pass client-ip=2a00:1450:4864:20::334;\n envelope-from=makovick@gmail.com; helo=mail-wm1-x334.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Jindrich Makovicka <makovick@gmail.com>\n---\n meson.build | 4 ----\n meson_options.txt | 7 -------\n ui/gtk.c | 2 --\n ui/meson.build | 4 +---\n 4 files changed, 1 insertion(+), 16 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 096303f021..761c0436a3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1932,7 +1932,6 @@ endif\n gtk = not_found\n gtkx11 = not_found\n vte = not_found\n-have_gtk_clipboard = get_option('gtk_clipboard').enabled()\n \n if get_option('gtk') \\\n .disable_auto_if(not have_system) \\\n@@ -1954,8 +1953,6 @@ if get_option('gtk') \\\n method: 'pkg-config',\n required: get_option('vte'))\n endif\n- elif have_gtk_clipboard\n- error('GTK clipboard requested, but GTK not found')\n endif\n endif\n \n@@ -2475,7 +2472,6 @@ if glusterfs.found()\n endif\n config_host_data.set('CONFIG_GTK', gtk.found())\n config_host_data.set('CONFIG_VTE', vte.found())\n-config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)\n config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))\n config_host_data.set('CONFIG_LIBATTR', have_old_libattr)\n config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 31d5916cfc..286461129b 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -262,13 +262,6 @@ option('vnc_sasl', type : 'feature', value : 'auto',\n description: 'SASL authentication for VNC server')\n option('vte', type : 'feature', value : 'auto',\n description: 'vte support for the gtk UI')\n-\n-# GTK Clipboard implementation is disabled by default, since it may cause hangs\n-# of the guest VCPUs. See gitlab issue 1150:\n-# https://gitlab.com/qemu-project/qemu/-/issues/1150\n-\n-option('gtk_clipboard', type: 'feature', value : 'disabled',\n- description: 'clipboard support for the gtk UI (EXPERIMENTAL, MAY HANG)')\n option('xkbcommon', type : 'feature', value : 'auto',\n description: 'xkbcommon support')\n option('zstd', type : 'feature', value : 'auto',\ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex 9ebe7e8df0..5e63c502ed 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -2601,9 +2601,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)\n opts->u.gtk.show_tabs) {\n gtk_menu_item_activate(GTK_MENU_ITEM(s->show_tabs_item));\n }\n-#ifdef CONFIG_GTK_CLIPBOARD\n gd_clipboard_init(s);\n-#endif /* CONFIG_GTK_CLIPBOARD */\n \n /* GTK's event polling must happen on the main thread. */\n qemu_main = NULL;\ndiff --git a/ui/meson.build b/ui/meson.build\nindex 4e533d3046..6405e21d5d 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -111,9 +111,7 @@ if gtk.found()\n \n gtk_ss = ss.source_set()\n gtk_ss.add(gtk, vte, pixman, files('gtk.c'))\n- if have_gtk_clipboard\n- gtk_ss.add(files('gtk-clipboard.c'))\n- endif\n+ gtk_ss.add(files('gtk-clipboard.c'))\n gtk_ss.add(when: x11, if_true: files('x_keymap.c'))\n gtk_ss.add(when: opengl, if_true: files('gtk-gl-area.c'))\n gtk_ss.add(when: [x11, opengl], if_true: files('gtk-egl.c'))\n", "prefixes": [ "v3", "2/2" ] }