Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2228048/?format=api
{ "id": 2228048, "url": "http://patchwork.ozlabs.org/api/patches/2228048/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260424-case-sensitivity-v11-1-de5619beddaf@oracle.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260424-case-sensitivity-v11-1-de5619beddaf@oracle.com>", "list_archive_url": null, "date": "2026-04-25T01:53:03", "name": "[v11,01/15] fs: Move file_kattr initialization to callers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8399402ad232bd593fad6e92814fdac3177491c6", "submitter": { "id": 86689, "url": "http://patchwork.ozlabs.org/api/people/86689/?format=api", "name": "Chuck Lever", "email": "cel@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260424-case-sensitivity-v11-1-de5619beddaf@oracle.com/mbox/", "series": [ { "id": 501417, "url": "http://patchwork.ozlabs.org/api/series/501417/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=501417", "date": "2026-04-25T01:53:02", "name": "Exposing case folding behavior", "version": 11, "mbox": "http://patchwork.ozlabs.org/series/501417/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228048/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228048/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=OqGx=CY=vger.kernel.org=linux-ext4+bounces-16083-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gLgar0Jl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=oqgx=cy=vger.kernel.org=linux-ext4+bounces-16083-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.105.105.114 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gLgar0Jl;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16083-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"gLgar0Jl\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Xtb4fmVz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 11:53:59 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g2Xtb0vxDz4wB9\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 11:53:59 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4g2Xtb0phfz4whs; Sat, 25 Apr 2026 11:53:59 +1000 (AEST)", "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g2XtW57Knz4wB9\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 25 Apr 2026 11:53:55 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 926BD302DFB5\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 25 Apr 2026 01:53:34 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DE31623ABB9;\n\tSat, 25 Apr 2026 01:53:26 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38C199FAB;\n\tSat, 25 Apr 2026 01:53:26 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 16CBDC2BCB9;\n\tSat, 25 Apr 2026 01:53:24 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1777082039; cv=pass;\n\tb=OW9fFMPUJDRdnMFxu0hRZ6M5LuB83kW5xrJZWY65AckFRQh3sXhZYkcaDLKDvmMIVX8owfDgcWe0API2EZc/uxb7B0OQdMDEOc6BL9FqRFINGBgqmMzkBoY0yKk6d7DEKidfy0fLgRx8XdNW79DPnhkQkNQMFwpBnqIbNztOo4TCgwlQ40wWvxs7QhCAS6nzn6njF2hea1CotBp0U972twi9ThxBuO5MDbt131IMDRTRwxc9K6Q27yl12vZm/lV+SYu4hfvIaEN70hjiAa+4/tKyqWa3JomzA29EJnsA7THFIyl8vUaWMjW/EKPXgVXkBAMdq2c12/JU8QCfcaj1UQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777082006; cv=none;\n b=pXTfnLdS/pc5SBw9lZ1eboNj5cPCW/BeD598svVav6+1SVpdwoUER5JXNocVE9z6v9wErMpPhPSl8pQrKgIFbS9d/EmNCgquuDC/D3ZAvVsb/B35gjUMI305s5zWEdJWh9KDru2B4zqY2Ot3Tb6HAvnWUkL5CDjUVFD+r3e5+xU=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1777082039; c=relaxed/relaxed;\n\tbh=bLYGD8UhEfZ0gI1O0q/9fKsjTL83YjgnGhMcoMvuzIo=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=iaiFzyINLn8yC0TqDbGcYGMK+nXrz/AVAGGFhtv448rXGkevAnLWQAdrID4kmysaJ2KEOWiEmLQbxBofN1/kLSz1X6T1ZdKN+CEQiV7l7oLI+YcFTooslcOjxxDjrxCwg9Jbk9Mkmsjm4F8CANICVc9TPuyBWxZM5lUipVrwDDseHu3CotZEygg9pSPX4+i9QCs04f/SY1KdrHqY0Zl9IxXvdj5BgXWpDMp5wcMzfLKbAxSi1DHHUISiHt2LcV4ctn4KVga8qDFujxBtkoPa15txgykdAb/Xz7qSAxDHRDuWhpISTAMrbK8oF7o+/YvEyO7uCAVbIRCw5Q/LC3VY8Q==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777082006; c=relaxed/simple;\n\tbh=93lkf1HBQv1pjT23tKqszLwADekuVqw95GHVpFk/qSc=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=G6sepbULFPmcmAmoOgwvhsXlmWToFoO7nrOD/VoHF0G0eZ/zSHfODxEk5EKL4bjZjs0vPM/hcU0tXmNF633BC4DXBchEQDxk+TWJ6qXIEcBUAmGxggcLO5qGlHVX7BfDQ9m/3ulzkWcJG5KuRutJJBKJOBYslgObd39KSZGnUvw=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gLgar0Jl; dkim-atps=neutral;\n spf=pass (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16083-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=gLgar0Jl; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777082006;\n\tbh=93lkf1HBQv1pjT23tKqszLwADekuVqw95GHVpFk/qSc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=gLgar0JlfMzpbf4h91bIQ2/oFxbB7DQVGd6O1qEFahj9FGQOAfeyXajR/xwkwjAt+\n\t ihSFQ6DYf8y4gaEi8CH34lbpMLIkYx6hmSb0bVCOlrjLntSjKUThEH076NVG2YjU/x\n\t AEwjOo54XLJBzPOEixPYwdanXVwtZHgHcf6psGz5nZjZioUs/NrbIsNCQm63ji4U4r\n\t VJREGv7tZdYjV9lcrKYxPirABgUpJn23YTprhJFNlXTs6mX7/8oaE8mGfScEhADRQl\n\t IsmY+0rZm54pPYdQ2t48PsCb7AA/MyJCVNnJ3BXYbLvjMbkJoNY5FCgd4ibEr4xEAO\n\t ZPlhMkWL62A4Q==", "From": "Chuck Lever <cel@kernel.org>", "Date": "Fri, 24 Apr 2026 21:53:03 -0400", "Subject": "[PATCH v11 01/15] fs: Move file_kattr initialization to callers", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260424-case-sensitivity-v11-1-de5619beddaf@oracle.com>", "References": "<20260424-case-sensitivity-v11-0-de5619beddaf@oracle.com>", "In-Reply-To": "<20260424-case-sensitivity-v11-0-de5619beddaf@oracle.com>", "To": "Al Viro <viro@zeniv.linux.org.uk>,\n Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>", "Cc": "linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,\n linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,\n linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp,\n linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com,\n almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,\n glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,\n adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,\n pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com,\n trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org,\n hansg@kernel.org, senozhatsky@chromium.org,\n Chuck Lever <chuck.lever@oracle.com>, \"Darrick J. Wong\" <djwong@kernel.org>,\n Roland Mainz <roland.mainz@nrubsig.org>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3605;\n i=chuck.lever@oracle.com; h=from:subject:message-id;\n bh=AWgZwG1E8rlvIL3m0PCLX9DfISmeBrTqPl/lfHkVgk0=;\n b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp7B6QVc6wzpY9y1nPJJFj5Jdl4iXMAz76LGW6g\n QkQqdisSOGJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCaewekAAKCRAzarMzb2Z/\n l48ZD/95d8pCbGgiAP60eaV3lvhqpJjBSSgyy5uBrXc6hOSYY7Rn4m4SC1Lmsvv7v1z4LUWF1zI\n Ez9rxr0ebHLjWUnGXRzmXFmrsylzHuPqTBVeFSSAUNhZL1zVI5CH79+XChwlj+K8kWlmpyE/4Ad\n xE68yIWjWCTtMwfuo9u985OatxMY4Fh9AqB6FpRF21dmTUBI6JpT3RSr9DjiSCCIa3loQuHNUD4\n EpB0tp33RZUoFIDqosozztV0Z/YS5czglE6kL2loY9CX/sR4pbtmgqpe9zaD8TNsb7JESzaBIJ2\n 6ri4qY6CnkBm7zd9Rn2b/BWfCVl7X93O/HqukK3RRUadCopSGvibhD9iM/uzOwPpJKqincRl4/S\n 0lvSxRbuBosTWj+JDPDIXOvQfR/UWojct3gI7nkqAPhe1R8JIfZJdxrxWa4xziItVi5WXqVTLSS\n zuRANrBRobLYHPXza3AKZqd0Qk1KYWEy8/qeWe+++YRfcjlFlT6tt0FpMos+fsRbUxATRkbIqsY\n hGCmQQpvf7Q5rWYay7vCY6L/DvkcAuWh+QBab+0xU8OYIu2oPn15rml0RCC6Xs24uMTw+hTEjSr\n wXIkQuTJCnXk6bVxqkk31fdz5WxqggdoqLLhKWRzRVCpWAQFGtHpAQt1Woqhvb6cso9F7u3W5wC\n 4T7+ODkEGqSN0Ww==", "X-Developer-Key": "i=chuck.lever@oracle.com; a=openpgp;\n fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Chuck Lever <chuck.lever@oracle.com>\n\nfileattr_fill_xflags() and fileattr_fill_flags() memset the\nentire file_kattr struct before populating select fields, so\ncallers cannot pre-set fields in fa->fsx_xflags without having\ntheir values clobbered. Darrick Wong noted that a function\nnamed \"fill_xflags\" touching more than xflags forces callers\nto know implementation details beyond its apparent scope.\n\nDrop the memset from both fill functions and initialize at the\nentry points instead: ioctl_setflags(), ioctl_fssetxattr(),\nthe file_setattr() syscall, and xfs_ioc_fsgetxattra() now\ndeclare fa with an aggregate initializer. ioctl_getflags(),\nioctl_fsgetxattr(), and the file_getattr() syscall already\naggregate-initialize fa to pass flags_valid/fsx_valid hints\ninto vfs_fileattr_get().\n\nSubsequent patches rely on this so that ->fileattr_get()\nhandlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD,\nFS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill\nfunctions run.\n\nSuggested-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Jan Kara <jack@suse.cz>\nReviewed-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Roland Mainz <roland.mainz@nrubsig.org>\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\n---\n fs/file_attr.c | 12 ++++--------\n fs/xfs/xfs_ioctl.c | 2 +-\n 2 files changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/fs/file_attr.c b/fs/file_attr.c\nindex da983e105d70..f429da66a317 100644\n--- a/fs/file_attr.c\n+++ b/fs/file_attr.c\n@@ -15,12 +15,10 @@\n * @fa:\t\tfileattr pointer\n * @xflags:\tFS_XFLAG_* flags\n *\n- * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All\n- * other fields are zeroed.\n+ * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags).\n */\n void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->fsx_valid = true;\n \tfa->fsx_xflags = xflags;\n \tif (fa->fsx_xflags & FS_XFLAG_IMMUTABLE)\n@@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags);\n * @flags:\tFS_*_FL flags\n *\n * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags).\n- * All other fields are zeroed.\n */\n void fileattr_fill_flags(struct file_kattr *fa, u32 flags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->flags_valid = true;\n \tfa->flags = flags;\n \tif (fa->flags & FS_SYNC_FL)\n@@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tunsigned int flags;\n \tint err;\n \n@@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint err;\n \n \terr = copy_fsxattr_from_user(&fa, argp);\n@@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\ndiff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 46e234863644..ed9b4846c05f 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra(\n \txfs_inode_t\t\t*ip,\n \tvoid\t\t\t__user *arg)\n {\n-\tstruct file_kattr\tfa;\n+\tstruct file_kattr\tfa = {};\n \n \txfs_ilock(ip, XFS_ILOCK_SHARED);\n \txfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa);\n", "prefixes": [ "v11", "01/15" ] }