Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227948/?format=api
{ "id": 2227948, "url": "http://patchwork.ozlabs.org/api/patches/2227948/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260424145837.2218574-1-tkaminsk@redhat.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260424145837.2218574-1-tkaminsk@redhat.com>", "list_archive_url": null, "date": "2026-04-24T14:56:55", "name": "libstdc++: Disallow duration of cv-qualified types and references.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ab5807d40a236a2068a4af85a6afe2e7f602e704", "submitter": { "id": 90409, "url": "http://patchwork.ozlabs.org/api/people/90409/?format=api", "name": "Tomasz Kamiński", "email": "tkaminsk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260424145837.2218574-1-tkaminsk@redhat.com/mbox/", "series": [ { "id": 501379, "url": "http://patchwork.ozlabs.org/api/series/501379/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501379", "date": "2026-04-24T14:56:55", "name": "libstdc++: Disallow duration of cv-qualified types and references.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501379/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227948/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227948/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BEc/7/Uj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BEc/7/Uj", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2GN53vK0z1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 25 Apr 2026 01:00:05 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id A3C764BB58B0\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 15:00:03 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 721254BB58AB\n for <gcc-patches@gcc.gnu.org>; Fri, 24 Apr 2026 14:58:43 +0000 (GMT)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-Xgx3xVbNPIafXKyTVXhxgg-1; Fri,\n 24 Apr 2026 10:58:40 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 7B68519560B7; Fri, 24 Apr 2026 14:58:39 +0000 (UTC)", "from localhost (unknown [10.44.48.150])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id DF203180045E; Fri, 24 Apr 2026 14:58:38 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org A3C764BB58B0", "OpenDKIM Filter v2.11.0 sourceware.org 721254BB58AB" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 721254BB58AB", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 721254BB58AB", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777042723; cv=none;\n b=OaUy0kTtK8ahODThI5TVqORy3VlGzLOyzEjZPFHjtnskYNHWOU5KV7cA60uzwKXn3gOU65VVZuer74CR4RcXreUsSQETlkYb3gRYF1c7KMTolzTtJrfe8yTAZjax1MdvlspxiEoBm8FUYnAcepedF0gmYSKpUT7w8kTjcy2+XzY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777042723; c=relaxed/simple;\n bh=iXaYaQuULF7jCfbdV3OHEGQQib9GA0SemvcXm3n1z1c=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=JKWsUrbT12d0qCAakq+FA5Zi7YtllLTbAOrx1+fASv8AQea3cGgdCXloLdYbjRIYiqlxvj7TUHhlGdYIW9QPDhw+sZMdQLsv9V6vaWQeblqGMrz0zspbgd0LKYsT5McH63kSWwAB15L740E2cHEu20jc7d6CzKjbmtfEFPe3mv0=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777042723;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=N6GuT0znJQ3ZnP2iwNfdAHMGj5pmTwKHomVvETgYDLE=;\n b=BEc/7/Uj7KH/Z/YTZVUlAEx/gRxcG5yE2Ud6NFor0P9FyWdhXcxrA22+f5b4HS01JDZJBM\n obXBaf8qauOaJqryFdx44Mo1uLohcq+/zpANoGBb87UGeF7IOUAn7dSIuYdM/IwhmHd5/Q\n JvwS1sl4S4+BPLT+e5Bz6Obizi6MM9I=", "X-MC-Unique": "Xgx3xVbNPIafXKyTVXhxgg-1", "X-Mimecast-MFC-AGG-ID": "Xgx3xVbNPIafXKyTVXhxgg_1777042719", "From": "=?utf-8?q?Tomasz_Kami=C5=84ski?= <tkaminsk@redhat.com>", "To": "libstdc++@gcc.gnu.org,\n\tgcc-patches@gcc.gnu.org", "Subject": "[PATCH] libstdc++: Disallow duration of cv-qualified types and\n references.", "Date": "Fri, 24 Apr 2026 16:56:55 +0200", "Message-ID": "<20260424145837.2218574-1-tkaminsk@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "kJI1OaPJKfG5OwUP56zxmFUHqJnILUXkHYpk3Bztogc_1777042719", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "This implements LWG 4481, \"Disallow chrono::duration<const T, P>\",\nwhich was approved in Croydon 2026.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/chrono.h: Add static_assert requiring cv-unqualified\n\tnon-reference type.\n\t* testsuite/20_util/duration/io.cc: Remove test for duration\n\twith const rep.\n\t* testsuite/20_util/duration/requirements/typedefs_neg4.cc:\n\tNew test.\n---\nTesting on x86_64-linux. All *duration* tests passed in all standard modes.\nOK for trunk when all test passes?\n\n libstdc++-v3/include/bits/chrono.h | 4 ++++\n libstdc++-v3/testsuite/20_util/duration/io.cc | 14 --------------\n .../20_util/duration/requirements/typedefs_neg4.cc | 11 +++++++++++\n 3 files changed, 15 insertions(+), 14 deletions(-)\n create mode 100644 libstdc++-v3/testsuite/20_util/duration/requirements/typedefs_neg4.cc", "diff": "diff --git a/libstdc++-v3/include/bits/chrono.h b/libstdc++-v3/include/bits/chrono.h\nindex fd91505c16f..d639cfaa485 100644\n--- a/libstdc++-v3/include/bits/chrono.h\n+++ b/libstdc++-v3/include/bits/chrono.h\n@@ -514,6 +514,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n template<typename _Rep, typename _Period>\n class duration\n {\n+\t// _GLIBCXX_RESOLVE_LIB_DEFECTS\n+\t// 4481. Disallow chrono::duration<const T, P>\n+\tstatic_assert(is_same<_Rep, __remove_cvref_t<_Rep>>::value,\n+\t\t \"rep should be cv-unqualified object type\");\n \tstatic_assert(!__is_duration<_Rep>::value,\n \t\t \"rep cannot be a std::chrono::duration\");\n \tstatic_assert(__is_ratio<_Period>::value,\ndiff --git a/libstdc++-v3/testsuite/20_util/duration/io.cc b/libstdc++-v3/testsuite/20_util/duration/io.cc\nindex 6ada4fcfa84..463d9feb21f 100644\n--- a/libstdc++-v3/testsuite/20_util/duration/io.cc\n+++ b/libstdc++-v3/testsuite/20_util/duration/io.cc\n@@ -38,13 +38,6 @@ test01()\n ss << duration<char16_t>(126) << ' ';\n ss << duration<char32_t>(127) << ' ';\n VERIFY( ss.str() == \"121s 122s 123s 124s 125s 126s 127s \" );\n-\n- ss.str(\"\");\n- ss << std::hex << std::uppercase << duration<const char>(0x1A) << ' ';\n- ss << std::hex << std::uppercase << duration<const wchar_t>(0x2A) << ' ';\n- ss << std::hex << std::uppercase << duration<signed char>(0x3A) << ' ';\n- ss << std::scientific << duration<const double>(4.5) << ' ';\n- VERIFY( ss.str() == \"1As 2As 3As 4.500000E+00s \" );\n }\n \n void\n@@ -77,13 +70,6 @@ test02()\n ss << duration<char16_t>(126) << ' ';\n ss << duration<char32_t>(127) << ' ';\n VERIFY( ss.str() == L\"121s 122s 123s 124s 125s 126s 127s \" );\n-\n- ss.str(L\"\");\n- ss << std::hex << std::uppercase << duration<const char>(0x1A) << ' ';\n- ss << std::hex << std::uppercase << duration<const wchar_t>(0x2A) << ' ';\n- ss << std::hex << std::uppercase << duration<signed char>(0x3A) << ' ';\n- ss << std::scientific << duration<const double>(4.5) << ' ';\n- VERIFY( ss.str() == L\"1As 2As 3As 4.500000E+00s \" );\n #endif\n }\n \ndiff --git a/libstdc++-v3/testsuite/20_util/duration/requirements/typedefs_neg4.cc b/libstdc++-v3/testsuite/20_util/duration/requirements/typedefs_neg4.cc\nnew file mode 100644\nindex 00000000000..52a5d92cc8b\n--- /dev/null\n+++ b/libstdc++-v3/testsuite/20_util/duration/requirements/typedefs_neg4.cc\n@@ -0,0 +1,11 @@\n+// { dg-do compile { target c++11 } }\n+\n+#include <chrono>\n+\n+const int i = 10;\n+// Check if rep is a cv-unqualifed object type\n+std::chrono::duration<const int> d1(i); // { dg-error \"required from here\" }\n+std::chrono::duration<volatile int> d2(i); // { dg-error \"required from here\" }\n+std::chrono::duration<const int&> d3(i); // { dg-error \"required from here\" }\n+\n+// { dg-error \"rep should be cv-unqualified object type\" \"\" { target *-*-* } 0 }\n", "prefixes": [] }