Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227484/?format=api
{ "id": 2227484, "url": "http://patchwork.ozlabs.org/api/patches/2227484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-28-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423191958.1440-28-farosas@suse.de>", "list_archive_url": null, "date": "2026-04-23T19:19:41", "name": "[PULL,27/43] vmstate: Update max_elems early and check field compressable once", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9d2e2d8f978c730cd92652a0eed658edc0a02cf0", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-28-farosas@suse.de/mbox/", "series": [ { "id": 501236, "url": "http://patchwork.ozlabs.org/api/series/501236/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236", "date": "2026-04-23T19:19:14", "name": "[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501236/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227484/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227484/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=z4liShON;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=H0pUESxt;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=z4liShON;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=H0pUESxt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mJR0Zmxz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 05:25:11 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFzcN-0003OI-TC; Thu, 23 Apr 2026 15:21:45 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzcF-0002X5-DG\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:37 -0400", "from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzcD-00026E-IK\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:35 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 3882F5BD87;\n Thu, 23 Apr 2026 19:20:42 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 01EA4593A3;\n Thu, 23 Apr 2026 19:20:40 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id wB8OMAhx6mlJCwAAD6G6ig\n (envelope-from <farosas@suse.de>); Thu, 23 Apr 2026 19:20:40 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972042;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LL30Z+MBwjm49fC4Nr5CADY5IMbB82ISYMgKmmKxuMY=;\n b=z4liShONaU6QQ6hciT+8ERNq93Xu7+xGmlVIbTytXoU11tOEPzp3cuxYlDZU/SgWrI+i1X\n zoSB2eEJ4q0ku9Rrh48VnsRdJy9DLBhR7YKPtqrfalRJjYKpl/SJyjs+jBZZX7NNHwi0zo\n uWxwdPaewXJMWLp4uzD2xX8lJ6CahxY=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972042;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LL30Z+MBwjm49fC4Nr5CADY5IMbB82ISYMgKmmKxuMY=;\n b=H0pUESxtM0xeU3IIWdCoRSvHvUN+fNenE/EoU3PFGoYB7wcaxTwvhms97uhw0IKjLuKan1\n fpxBWd7ZftJMY/CA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972042;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LL30Z+MBwjm49fC4Nr5CADY5IMbB82ISYMgKmmKxuMY=;\n b=z4liShONaU6QQ6hciT+8ERNq93Xu7+xGmlVIbTytXoU11tOEPzp3cuxYlDZU/SgWrI+i1X\n zoSB2eEJ4q0ku9Rrh48VnsRdJy9DLBhR7YKPtqrfalRJjYKpl/SJyjs+jBZZX7NNHwi0zo\n uWxwdPaewXJMWLp4uzD2xX8lJ6CahxY=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972042;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=LL30Z+MBwjm49fC4Nr5CADY5IMbB82ISYMgKmmKxuMY=;\n b=H0pUESxtM0xeU3IIWdCoRSvHvUN+fNenE/EoU3PFGoYB7wcaxTwvhms97uhw0IKjLuKan1\n fpxBWd7ZftJMY/CA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>,\n Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>,\n Juraj Marcin <jmarcin@redhat.com>", "Subject": "[PULL 27/43] vmstate: Update max_elems early and check field\n compressable once", "Date": "Thu, 23 Apr 2026 16:19:41 -0300", "Message-ID": "<20260423191958.1440-28-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260423191958.1440-1-farosas@suse.de>", "References": "<20260423191958.1440-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]", "X-Spam-Score": "-2.80", "Received-SPF": "pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Peter Xu <peterx@redhat.com>\n\nQEMU has a trick in vmstate_save_vmsd_v(), where it will try to compress\nmultiple JSON entries into one with a count to avoid duplicated entries.\n\nThat only applies to the cases where vmsd_can_compress() should return\ntrue. For example, vmsd_desc_field_start() later (who will take the\nupdated max_elems as the last parameter) will ignore the value passed in\nwhen vmsd_can_compress() returns false.\n\nDo that check once at the start of loop, and use it to update max_elems, so\nthat max_elems keeps 1 for uncompressable VMSD fields, which is more\nstraightforward.\n\nThis also paves way to make this counter work for ptr marker VMSD fields\ntoo.\n\nNo functional change intended in this patch alone.\n\nReviewed-by: Fabiano Rosas <farosas@suse.de>\nReviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>\nSigned-off-by: Peter Xu <peterx@redhat.com>\nReviewed-by: Juraj Marcin <jmarcin@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20260401202844.673494-5-peterx@redhat.com\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/vmstate.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/vmstate.c b/migration/vmstate.c\nindex e29a8c3f49..05badef42f 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -556,7 +556,8 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n void *curr_elem = first_elem + size * i;\n const VMStateField *inner_field;\n bool is_null;\n- int max_elems = n_elems - i;\n+ /* maximum number of elements to compress in the JSON blob */\n+ int max_elems = vmsd_can_compress(field) ? (n_elems - i) : 1;\n \n old_offset = qemu_file_transferred(f);\n if (field->flags & VMS_ARRAY_OF_POINTER) {\n@@ -587,7 +588,8 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n * vs. nullptr). Search ahead for the next null/non-null element\n * and start a new compressed array if found.\n */\n- if (vmdesc && (field->flags & VMS_ARRAY_OF_POINTER) &&\n+ if (vmdesc && max_elems > 1 &&\n+ (field->flags & VMS_ARRAY_OF_POINTER) &&\n is_null != is_prev_null) {\n \n is_prev_null = is_null;\n@@ -626,7 +628,7 @@ static bool vmstate_save_vmsd_v(QEMUFile *f, const VMStateDescription *vmsd,\n }\n \n /* Compressed arrays only care about the first element */\n- if (vmdesc_loop && vmsd_can_compress(field)) {\n+ if (vmdesc_loop && max_elems > 1) {\n vmdesc_loop = NULL;\n }\n }\n", "prefixes": [ "PULL", "27/43" ] }