Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227479/?format=api
{ "id": 2227479, "url": "http://patchwork.ozlabs.org/api/patches/2227479/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-15-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423191958.1440-15-farosas@suse.de>", "list_archive_url": null, "date": "2026-04-23T19:19:28", "name": "[PULL,14/43] migration: VMStateInfo: introduce new handlers with errp", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "406e45db625c34eeccc5e67224641c19cb7b8285", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423191958.1440-15-farosas@suse.de/mbox/", "series": [ { "id": 501236, "url": "http://patchwork.ozlabs.org/api/series/501236/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501236", "date": "2026-04-23T19:19:14", "name": "[PULL,01/43] checkpatch: Allow spaces after all coroutine annotations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501236/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227479/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227479/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=1DVPc85R;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=1CrOfGtE;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=1DVPc85R;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=1CrOfGtE;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mHj2g5cz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 05:24:33 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFzcX-0003wB-Nv; Thu, 23 Apr 2026 15:21:53 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzc1-0002Ia-VH\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:27 -0400", "from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wFzbz-0001wR-Jq\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:21:21 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 9EF9E6A890;\n Thu, 23 Apr 2026 19:20:21 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9A19C593A3;\n Thu, 23 Apr 2026 19:20:20 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id yGSvGfRw6mlJCwAAD6G6ig\n (envelope-from <farosas@suse.de>); Thu, 23 Apr 2026 19:20:20 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972021;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xGdNtJD7CyO/idoRU9phWcfMReSkffagymXqK6GhVsU=;\n b=1DVPc85RtisrsI9NqjkZsVJ85y9wNPlHDbXcteboZoD2Ro34YmDgwh3N5qhjWEZO82XSYM\n JUwe+XnKzKqB4DKp1qi/LnFmkxlXNWi0Ze/rxYELYfg3dBxdxBHZ4emQoIemK7RvRWDSNL\n Rl7Z1t+9QtrmFaW6LurOx6hKFH6Wu9Y=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972021;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xGdNtJD7CyO/idoRU9phWcfMReSkffagymXqK6GhVsU=;\n b=1CrOfGtEwEk3Igzya62gtQTtbAdY9YywBHnIlnXoi58AZnnDYTGx93MyhC+inQEhnOAY5z\n lNJKFUuDdyqGV9AQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1776972021;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xGdNtJD7CyO/idoRU9phWcfMReSkffagymXqK6GhVsU=;\n b=1DVPc85RtisrsI9NqjkZsVJ85y9wNPlHDbXcteboZoD2Ro34YmDgwh3N5qhjWEZO82XSYM\n JUwe+XnKzKqB4DKp1qi/LnFmkxlXNWi0Ze/rxYELYfg3dBxdxBHZ4emQoIemK7RvRWDSNL\n Rl7Z1t+9QtrmFaW6LurOx6hKFH6Wu9Y=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1776972021;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xGdNtJD7CyO/idoRU9phWcfMReSkffagymXqK6GhVsU=;\n b=1CrOfGtEwEk3Igzya62gtQTtbAdY9YywBHnIlnXoi58AZnnDYTGx93MyhC+inQEhnOAY5z\n lNJKFUuDdyqGV9AQ==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "Subject": "[PULL 14/43] migration: VMStateInfo: introduce new handlers with errp", "Date": "Thu, 23 Apr 2026 16:19:28 -0300", "Message-ID": "<20260423191958.1440-15-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260423191958.1440-1-farosas@suse.de>", "References": "<20260423191958.1440-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-2.80", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_ALL(0.00)[]", "Received-SPF": "pass client-ip=2a07:de40:b251:101:10:150:64:1;\n envelope-from=farosas@suse.de; helo=smtp-out1.suse.de", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\n\nAdd new APIs with errp, to allow handlers report good\nerror messages. We'll convert existing handlers soon.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Peter Xu <peterx@redhat.com>\nLink: https://lore.kernel.org/qemu-devel/20260304212303.667141-13-vsementsov@yandex-team.ru\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n include/migration/vmstate.h | 17 ++++++++++++++---\n migration/vmstate.c | 4 ++++\n 2 files changed, 18 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 9d42cf7a64..65683d8d87 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -32,12 +32,16 @@\n typedef struct VMStateInfo VMStateInfo;\n typedef struct VMStateField VMStateField;\n \n-/* VMStateInfo allows customized migration of objects that don't fit in\n+/*\n+ * VMStateInfo allows customized migration of objects that don't fit in\n * any category in VMStateFlags. Additional information is always passed\n- * into get and put in terms of field and vmdesc parameters. However\n+ * into load and save in terms of field and vmdesc parameters. However\n * these two parameters should only be used in cases when customized\n * handling is needed, such as QTAILQ. For primitive data types such as\n- * integer, field and vmdesc parameters should be ignored inside get/put.\n+ * integer, field and vmdesc parameters should be ignored inside load/save.\n+ *\n+ * @get and @put are deprecated copies of @load and @save. For new interfaces\n+ * use @load and @save.\n */\n struct VMStateInfo {\n const char *name;\n@@ -46,6 +50,13 @@ struct VMStateInfo {\n int coroutine_mixed_fn (*put)(QEMUFile *f, void *pv, size_t size,\n const VMStateField *field,\n JSONWriter *vmdesc);\n+ bool coroutine_mixed_fn (*load)(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field,\n+ Error **errp);\n+ bool coroutine_mixed_fn (*save)(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field,\n+ JSONWriter *vmdesc,\n+ Error **errp);\n };\n \n enum VMStateFlags {\ndiff --git a/migration/vmstate.c b/migration/vmstate.c\nindex 8825aa3b1f..f16626d7d1 100644\n--- a/migration/vmstate.c\n+++ b/migration/vmstate.c\n@@ -170,6 +170,8 @@ static bool vmstate_load_field(QEMUFile *f, void *pv, size_t size,\n } else if (field->flags & VMS_VSTRUCT) {\n return vmstate_load_state(f, field->vmsd, pv, field->struct_version_id,\n errp) >= 0;\n+ } else if (field->info->load) {\n+ return field->info->load(f, pv, size, field, errp);\n }\n \n if (field->info->get(f, pv, size, field) < 0) {\n@@ -495,6 +497,8 @@ static bool vmstate_save_field(QEMUFile *f, void *pv, size_t size,\n return vmstate_save_state_v(f, field->vmsd, pv, vmdesc,\n field->struct_version_id,\n errp) >= 0;\n+ } else if (field->info->save) {\n+ return field->info->save(f, pv, size, field, vmdesc, errp);\n }\n \n if (field->info->put(f, pv, size, field, vmdesc) < 0) {\n", "prefixes": [ "PULL", "14/43" ] }