Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227444/?format=api
{ "id": 2227444, "url": "http://patchwork.ozlabs.org/api/patches/2227444/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-3-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423183212.468047-3-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-23T18:32:11", "name": "[2/3] system/ioport: Fix qom-list-properties crash on portio list obj", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d12109463e013f48a6466148b9f397468d6fa0e5", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-3-peterx@redhat.com/mbox/", "series": [ { "id": 501234, "url": "http://patchwork.ozlabs.org/api/series/501234/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501234", "date": "2026-04-23T18:32:10", "name": "Three small fixes over qom-list-properties crash", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501234/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227444/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aT8O5QIt;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Df92nuZ1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1l8P2JSJz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 04:33:07 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFyqq-0003dU-8R; Thu, 23 Apr 2026 14:32:36 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wFyqj-0003cW-Dh\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wFyqh-0001KY-2p\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:28 -0400", "from mail-qv1-f71.google.com (mail-qv1-f71.google.com\n [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-642-dP2DTSY1P128HbBspiyExg-1; Thu, 23 Apr 2026 14:32:24 -0400", "by mail-qv1-f71.google.com with SMTP id\n 6a1803df08f44-8a275472d89so106458876d6.1\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 11:32:24 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 11:32:22 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776969146;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=;\n b=aT8O5QItOrQg96kILQZ91bZ6F/EhYCdkB8sw8As4UyX64nTizdNf4P/0sXCMEsZP5fAkH6\n DzG8BFCzzgH9JrizBs1X1vhuWHIMhRhqZXPBJjp5T+HyL4vaF5OweXgXtBWjWL92hiMw4M\n qZW2W6NJ5qBNQ6ZcVfoa4PzsYV/5H5E=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776969144; x=1777573944; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=;\n b=Df92nuZ1fhwCHxzub0eWHTF/6sYYOi1eztP7I3zApvmEOg906erANy51grSsr69Sca\n P9DIHGyC9rndyzKMH4KMSlrQbkVtElovtRQks5m0I7qDJRnD+/VkVfXFLjwgFi40nI2D\n ym0z5cGjOqlGEWoVDTj2fKUBnIBoUe7FrzGhI1KB1yzX2EQhNbrXNwH786G+dzaVWhVv\n 10/mM9sKG6OpJiQtEhEcc29hAjsGhizYT1VqPagvT13TGWorByurjoANws9tD7O5YZq3\n s9jH6/evaXz3wXLzTn2BrfSY8RyV/KLvHCzMWvZYh4KADEdhEuaKDyWJvBsY8GCslsJb\n BWzg==" ], "X-MC-Unique": "dP2DTSY1P128HbBspiyExg-1", "X-Mimecast-MFC-AGG-ID": "dP2DTSY1P128HbBspiyExg_1776969144", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776969144; x=1777573944;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=O4TOxFz2OPjQ/+oQDmc3kby3Xa/zYowkiRjWGoIPwB0=;\n b=Akh1adFZCLZOi91wKSPWTa+xhPcYsEPnNbtaE2qPeaoXdFHHUgke9AjJaQns6ma/wv\n Li7KmuUUwm11zmaGsSbaQHUfFeMHTo6gr05T9lXFEKBDKS0Opr169c9uEG6LmYhPADiO\n mWMLRR3A+w4IC4wXmBWzXC/AyF9q+w5bGlBGfCoNmChBYrpT/ns9uea7c4rR3Zcxm4Ia\n CoiSdf6KRSENyUaSHLDG8ny9ROReLoSNUL3BuZC0So6MnOLKK+HorcAs/dBRqMGSUQpd\n 4rThjDrl3x2q4vDvwbecIPgc0ePN1Zg3BDhlm6OykfjSRYfL8vvqheeIbxTRD5N5mcRA\n xKFg==", "X-Gm-Message-State": "AOJu0YwG7a2L5udvEQJrvR0uwJBRctxxaPaDiHICcN2krxC0710fx3CB\n fHJS+l2yuyWlb9HwRCJiz8mpdkAV3cUzB/Ybdcn5st240oSKpYKFkUOWj4LDYqoP7em+b3Nt0FQ\n I5yy/tPhLyAwl+/V9L5dSdeWGbk/DGG6Evm5LphLB7Feu68IWPKbMvz6dZHelRyChh1W0k6EPCT\n mO1eYKCLUuk57IBScb1e7qIQvm9m6cNOPY2ftlFQ==", "X-Gm-Gg": "AeBDieuPlyOYortTIB0FyYhLC+s1IdXbSfhsmTSHGTHYt8v+j4AVa8GupWnAj7T8SZV\n hC3vE42SiWXpmBrR+xHEm9MVQaP4Fpcg38sYPcdleqaTV0pXQCu5oQTcfpGIuza3N+Y4Px6/hU3\n WVhAWjXpXWh5+9bdiDsbaKfmthGzdL3unQrIno7eRel/x/uLgba7saOy4ys6FhEordoC6EPyfzI\n TfECbqs0GFweB1enEvol0yFUUaRAiFB+doWZEAxIp8ZlzBGPeWmzcnZXYEFsAaY6y8OxS/eDbhH\n lJtonbP2SaNOXEoCFIM8+j0tZQYb7W7AFGi/cocaZpLm8d8jFfoTz70h2m7o5uXDl6oVvL6GVHg\n oE2SB5l/Rq+TX9DzgD8feQJXU34crQKJtDn8ZRgyNBs7TG2DXVx9rG2g=", "X-Received": [ "by 2002:a05:6214:27ef:b0:8a6:1216:fb78 with SMTP id\n 6a1803df08f44-8b02815a617mr443043396d6.46.1776969143589;\n Thu, 23 Apr 2026 11:32:23 -0700 (PDT)", "by 2002:a05:6214:27ef:b0:8a6:1216:fb78 with SMTP id\n 6a1803df08f44-8b02815a617mr443042586d6.46.1776969142872;\n Thu, 23 Apr 2026 11:32:22 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Li Zhijian <lizhijian@fujitsu.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, peterx@redhat.com,\n Zhang Chen <zhangckid@gmail.com>, Juraj Marcin <jmarcin@redhat.com>,\n Jason Wang <jasowang@redhat.com>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Markus Armbruster <armbru@redhat.com>", "Subject": "[PATCH 2/3] system/ioport: Fix qom-list-properties crash on portio\n list obj", "Date": "Thu, 23 Apr 2026 14:32:11 -0400", "Message-ID": "<20260423183212.468047-3-peterx@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423183212.468047-1-peterx@redhat.com>", "References": "<20260423183212.468047-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently qom-list-properties QMP command will crash when querying the\nportio list MR object. It's because its finalize() assumes full\ninitialization done in portio_list_add_1().\n\nProvide a simple fix for now to avoid the crash. There is chance for a\nlonger term fix, ideally MR should be initialized in instance_init().\n\nHowever that'll need more work, and that should also be done with cleaning\nthe hard-coded MR operations in portio_list_add_1(). To be explored.\n\nCc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>\nLink: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org\nReported-by: Markus Armbruster <armbru@redhat.com>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n system/ioport.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/system/ioport.c b/system/ioport.c\nindex 9209bff2ea..1a0e01fd06 100644\n--- a/system/ioport.c\n+++ b/system/ioport.c\n@@ -346,8 +346,15 @@ static void memory_region_portio_list_finalize(Object *obj)\n {\n MemoryRegionPortioList *mrpio = MEMORY_REGION_PORTIO_LIST(obj);\n \n- object_unref(&mrpio->mr);\n- g_free(mrpio->ports);\n+ /*\n+ * This check makes sure any random object_new() (without doing the\n+ * rest inits in portio_list_add_1()) will not crash when finalizing.\n+ * One example is QMP command qom-list-properties.\n+ */\n+ if (mrpio->ports) {\n+ object_unref(&mrpio->mr);\n+ g_free(mrpio->ports);\n+ }\n }\n \n static const TypeInfo memory_region_portio_list_info = {\n", "prefixes": [ "2/3" ] }