Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227443/?format=api
{ "id": 2227443, "url": "http://patchwork.ozlabs.org/api/patches/2227443/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-2-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423183212.468047-2-peterx@redhat.com>", "list_archive_url": null, "date": "2026-04-23T18:32:10", "name": "[1/3] colo-compare: Fix QMP qom-list-properties crashing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d47a7d27dbcc61e601b5ad0ff9e6c44947b04205", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423183212.468047-2-peterx@redhat.com/mbox/", "series": [ { "id": 501234, "url": "http://patchwork.ozlabs.org/api/series/501234/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501234", "date": "2026-04-23T18:32:10", "name": "Three small fixes over qom-list-properties crash", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501234/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227443/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227443/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dC3dMSN9;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=lEDmO0dW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1l8P2FZcz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 04:33:07 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFyqm-0003ct-Ok; Thu, 23 Apr 2026 14:32:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wFyqj-0003cX-Db\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wFyqg-0001KG-QQ\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 14:32:29 -0400", "from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-594-q7GmzJdINIiX8lA0q09KJQ-1; Thu, 23 Apr 2026 14:32:22 -0400", "by mail-qv1-f72.google.com with SMTP id\n 6a1803df08f44-89fa878662bso159775846d6.2\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 11:32:22 -0700 (PDT)", "from x1.com ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae92fc8sm160665566d6.40.2026.04.23.11.32.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 11:32:20 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776969145;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=;\n b=dC3dMSN97gvC+XrBkt5IBDUqj368FfbAFy5eDfgnUHuCAHk2Lqy61uuMSvDpm/qj1oUB6y\n skWhFoQ+0DF2zNp0oLE2++/yzCGwGE0mc7z7TqlHh2eB+SmVw5rFo+JT6AmEloyrwNlvsd\n ITuVvDXf1p0nkPZslTNRHFqpwAdG1qY=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776969142; x=1777573942; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=;\n b=lEDmO0dW8CoYcmNRsPpiLMoyWA914O9DFpU4dnFxd/s9UaFR7Yzjb/BLQKbza5J0hJ\n P6DpI7j8ALcAUc8unlBFuyaxnSwELTLsnewElbvwy6OR+wriXWDUfoI9cQrhsNrbAJoq\n gcGHP0IYYmbd5yGAMKfSuKqrHxa+mK5kpPtBvxmCpxVdiLsNn3YGfXHleLILHD13nlVj\n kPdSyxApyVJ96Ietiar5rIXoPMh8ZJuV2tOFsqmE9G+6pkVb9v+DmHYlqbDTv8P4U8qd\n GboEv/BniUr5yxMMc2iN6UfRylw/oTN3hzpRX9n3J9ywsxKURccPpIuWWhw3PKfb0sxg\n zU2Q==" ], "X-MC-Unique": "q7GmzJdINIiX8lA0q09KJQ-1", "X-Mimecast-MFC-AGG-ID": "q7GmzJdINIiX8lA0q09KJQ_1776969142", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776969142; x=1777573942;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8Y2Ve4V4QEYXRrJPSWkdiI5lVBGKfF9N/aa0OwJDsJY=;\n b=lms2/jdQk56PCcEoPBOY5O/HcFbLCV8fJbB4s3xsIseh6jE8yaseJazOI1FUI6rQm5\n fDd81ANr3SpnAlN8/+P8fXyR81Cldnfs9tiNZw5gqw1E26dLLj5mRghYXFdFXO/GDLx6\n BVOO/KXGObcgSRsS4XxcLA/Fz+cDrce0yWiVTY/sSn+plgHwXvNUhrrkSXwB2hAi5zc8\n XCPbG4SQjVF39t+qjWElcfVrndOpgCdYrQDEHQebhLRQiwZSXl2jCca3BTcZk2YF4KE+\n Lcv9FgeXpDiRMBYOzxHSOl/sf/BuV5k9qGNN8eW4Ahbhh5fecF327gAndBpY60kGqHfy\n 3dfg==", "X-Gm-Message-State": "AOJu0YxZAxRCB1lVDKNTa7IERoNxuW+LMCf8B86mSY61zaAkEng0s2Dy\n WSwzwKs5+TzlM8HIPEfB/u4AQAHFE6zWAGSaNvJoIz3PTTFGH8bDZsuT7uzaLAAAUFv97N9wPiW\n 251qTS2aVGaaHv2qcV0wOCsIl3w+LtPou4GU5N6NC0ZD/BMk5W3NC3gLFnTrLB3PkDsLzJPI/i/\n k6NuhkX811fLvoqJX6NCzZXluchi+SALWpUPqbPw==", "X-Gm-Gg": "AeBDieux1/xWeWia0v9otAon4TpkAqb+aulN6ivkLY3NCLEBNv3QroPb07d12hYeVQb\n 3iOuNN/COXjSvh8RHeChIEYXo1I/tUeLgMvKVF5Tbwv0WuH3toigRnS6pmBB+mpzxnZmq1udguz\n 5XIaezaLFwuVtHzMSb/sMH/MLSA8wqAbZyWxR5NvsDN+1gQHn66MyF8RN2BYfDI8aswvhaJWjNi\n FZHeBRvtF9phOLPVthE6WqjuS5+cN3+MLExFYByI8qGOZZ6aj8YtLDPfjv952j8kEuD9XvdodcI\n W52fKraSeysWdyjfy2cdpvq6gYgS/MEXtspHW4+/cI6NpIq7BtMaKcjbbIO6yfllSikyxrHnPNx\n VTFGUeKb8UWzHU2Eylxqwc16/8xXjI/iTSfYG700qw44LZY714NrKmDU=", "X-Received": [ "by 2002:a05:6214:4783:b0:8ac:b2e1:37a4 with SMTP id\n 6a1803df08f44-8b02812e432mr406399776d6.25.1776969141775;\n Thu, 23 Apr 2026 11:32:21 -0700 (PDT)", "by 2002:a05:6214:4783:b0:8ac:b2e1:37a4 with SMTP id\n 6a1803df08f44-8b02812e432mr406399176d6.25.1776969141260;\n Thu, 23 Apr 2026 11:32:21 -0700 (PDT)" ], "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Li Zhijian <lizhijian@fujitsu.com>,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, peterx@redhat.com,\n Zhang Chen <zhangckid@gmail.com>, Juraj Marcin <jmarcin@redhat.com>,\n Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>", "Subject": "[PATCH 1/3] colo-compare: Fix QMP qom-list-properties crashing", "Date": "Thu, 23 Apr 2026 14:32:10 -0400", "Message-ID": "<20260423183212.468047-2-peterx@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423183212.468047-1-peterx@redhat.com>", "References": "<20260423183212.468047-1-peterx@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Many of the colo_compare_finalize() code relies on complete() done in the\nfirst place, hence the crash. Fix it by detecting if complete() is\nexecuted, skip the rest when not.\n\nLink: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org\nReported-by: Markus Armbruster <armbru@redhat.com>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n net/colo-compare.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex c356419d6a..bae9d9c07a 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -1416,6 +1416,15 @@ static void colo_compare_finalize(Object *obj)\n break;\n }\n }\n+ /*\n+ * If this object is never visible (colo_compare_complete() not invoked\n+ * or failed), skip the rest. One path to trigger this is QMP command\n+ * qom-list-properties.\n+ */\n+ if (tmp != s) {\n+ qemu_mutex_unlock(&colo_compare_mutex);\n+ return;\n+ }\n if (QTAILQ_EMPTY(&net_compares)) {\n colo_compare_active = false;\n qemu_mutex_destroy(&event_mtx);\n", "prefixes": [ "1/3" ] }