Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227390/?format=api
{ "id": 2227390, "url": "http://patchwork.ozlabs.org/api/patches/2227390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423151946.1853943-2-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423151946.1853943-2-alex.bennee@linaro.org>", "list_archive_url": null, "date": "2026-04-23T15:19:45", "name": "[PULL,1/2] ui/sdl2: Fix assumption of EGL presence at runtime", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48e6ce04be2e6fd6077034523f34814613ed6754", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423151946.1853943-2-alex.bennee@linaro.org/mbox/", "series": [ { "id": 501209, "url": "http://patchwork.ozlabs.org/api/series/501209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501209", "date": "2026-04-23T15:19:44", "name": "[PULL,1/2] ui/sdl2: Fix assumption of EGL presence at runtime", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501209/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227390/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FivhKUr+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1ftF0b4hz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 01:20:37 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFvqS-0005VN-TV; Thu, 23 Apr 2026 11:20:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFvqO-0005UE-1y\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 11:19:56 -0400", "from mail-wm1-x343.google.com ([2a00:1450:4864:20::343])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFvqJ-0002DV-Mv\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 11:19:54 -0400", "by mail-wm1-x343.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so48811685e9.3\n for <qemu-devel@nongnu.org>; Thu, 23 Apr 2026 08:19:50 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a55dc9f58sm458714615e9.6.2026.04.23.08.19.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 08:19:47 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id B47615F941;\n Thu, 23 Apr 2026 16:19:46 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776957589; x=1777562389; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MlHoHlAON3iyzZqhc0+HDkMSFrxwv7bLaIY/p6YZfQc=;\n b=FivhKUr+ER8qrzK6h1+RYfSCdcKNOAmUwoXkx793KI7fKAA+i/KdwKV67jplbAxs7K\n V2sEWdO482eYLRct9V3Azd3WqfvSxmv69BhlwROFVsMsHPthz3t2sbZfPJ/3F91ge4v4\n zW8C+z/lctqfMABufJ+4SO5ShhpNd0GY8gMVB+sGUHGHmvjTwc+JC370SZc8ce60IYr9\n zGq0upA5FgofmPlHMNmUymxkDZhSnQY2CFgVE3gK+yyap2QXeQqzFRgD6HUEpArT0BYj\n oCWjgKlo83bqjM7BXge5bbytGtQahWt7siR2sIoem7c3AtXDyeJuztG6K9OmdJ/LYQGK\n w/QQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776957589; x=1777562389;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MlHoHlAON3iyzZqhc0+HDkMSFrxwv7bLaIY/p6YZfQc=;\n b=ZFUhTD9dVNNm/GUjq2ElNz38qT677bFicKqovl30CeFerRhNdJSDglr8ObH7pImi4b\n CUpvATsXiSC+krzS71LVnn0m4/1Ea7e8NSV/LmY8FyW3+Opwffu5qNlgJhTH7Lzjl2fq\n S+lpuM2OIBvl2hSAJzH3pxwDRVNsxIrlkVPrAXFehBnDKZFSJiOmNssw8IuvHiV5sdhI\n NCt+02axgTwQZ3Ap3buzUvjTZcbZf50K+l1RQK7bpcYaKXqDy8t409SLPLuH1i+EcbsW\n dsMWBizZubVBseg2W+6DJYIJPOyclqfAJHwgGnE8W/mFQ2IEgOqmSSNIJYOltQgHh937\n oUUQ==", "X-Gm-Message-State": "AOJu0YywcKSuW2V+jTFNWdb0lbqfATzb89WJe3A86EreiujOXPO5cD8X\n e75gHniktwDDwWMiHBcyTqzBi1VusCM6Y1D0nomV6yyaufcoFHeXLHgZAgULyda3PgU=", "X-Gm-Gg": "AeBDiesfDgWLGySjne82EsZCBBrhq6Fjp/V9rv6aDd/F8sj3eShH6E5glTyfdP235fC\n oUKhtH7VWQo+jX3am+5nmZP3fnQN39zc9LkhO4I5gU8OJli74SfYQXdgSkU5/iqEyUo9PQmY7OK\n yO8ElDfgBvLqXZOwvmgQ51N/IEpFzbo67Ej06+S205KcYgHnBUA3gR4cbtF79cAfvKyOchlLwf4\n Ab1Xd3juVBYZujsX8n7HO4/B38ubto12ed0aN1F3EtCzE6jwYXkuLtZrD7PhTFPec7kh1Dg/ShR\n H/AShYYNyZAcnd7WoxsXQhOeRMiK5f9TI0RDElxhc5tOzMOHeHQL9wrHAxhpRagdkU3/7/FRlH2\n kFO4CYcMe5MnuZD8dusYkwbn5fTwgnmpPGuXgUv4Cy2aNKDKSBRwCkqWN1xWZSYUIW7yr1vxkW6\n MWOrQTMLe/vePhMoLjuIoblOa0nRDz/jedHQ==", "X-Received": "by 2002:a05:600c:6206:b0:48a:599a:3716 with SMTP id\n 5b1f17b1804b1-48a599a3bfamr117429685e9.23.1776957589237;\n Thu, 23 Apr 2026 08:19:49 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Anthony Roberts <anthony.roberts@linaro.org>, qemu-stable@nongnu.org,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Marc-Andr?=\n\t=?utf-8?q?=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 1/2] ui/sdl2: Fix assumption of EGL presence at runtime", "Date": "Thu, 23 Apr 2026 16:19:45 +0100", "Message-ID": "<20260423151946.1853943-2-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260423151946.1853943-1-alex.bennee@linaro.org>", "References": "<20260423151946.1853943-1-alex.bennee@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::343;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x343.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Anthony Roberts <anthony.roberts@linaro.org>\n\nThe original commit had a section of code which worked on the assumption\nthat if OpenGL was enabled at build, it was present on the end user machine,\nand calls could be made to it. This is not always the case (such as Windows\non Arm devices).\n\nThis line should have also included a runtime check.\n\nThis commit moves the relevant line to inside a runtime check for OpenGL.\n\nFixes: 52053b7e0a0e (\"ui/sdl2: Implement dpy dmabuf functions\")\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3347\nCc: qemu-stable@nongnu.org\nSigned-off-by: Anthony Roberts <anthony.roberts@linaro.org>\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nMessage-ID: <20260409110256.684-1-anthony.roberts@linaro.org>\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>", "diff": "diff --git a/ui/sdl2.c b/ui/sdl2.c\nindex aaaede56e0e..987ad334bbe 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -120,15 +120,15 @@ void sdl2_window_create(struct sdl2_console *scon)\n \n scon->winctx = SDL_GL_CreateContext(scon->real_window);\n SDL_GL_SetSwapInterval(0);\n+\n+#ifdef CONFIG_OPENGL\n+ qemu_egl_display = eglGetCurrentDisplay();\n+#endif\n } else {\n /* The SDL renderer is only used by sdl2-2D, when OpenGL is disabled */\n scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0);\n }\n \n-#ifdef CONFIG_OPENGL\n- qemu_egl_display = eglGetCurrentDisplay();\n-#endif\n-\n sdl_update_caption(scon);\n }\n \n", "prefixes": [ "PULL", "1/2" ] }