Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227311/?format=api
{ "id": 2227311, "url": "http://patchwork.ozlabs.org/api/patches/2227311/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260423-case-sensitivity-v10-1-c385d674a6cf@oracle.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423-case-sensitivity-v10-1-c385d674a6cf@oracle.com>", "list_archive_url": null, "date": "2026-04-23T13:12:04", "name": "[v10,01/17] fs: Move file_kattr initialization to callers", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "8399402ad232bd593fad6e92814fdac3177491c6", "submitter": { "id": 86689, "url": "http://patchwork.ozlabs.org/api/people/86689/?format=api", "name": "Chuck Lever", "email": "cel@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260423-case-sensitivity-v10-1-c385d674a6cf@oracle.com/mbox/", "series": [ { "id": 501194, "url": "http://patchwork.ozlabs.org/api/series/501194/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=501194", "date": "2026-04-23T13:12:04", "name": "Exposing case folding behavior", "version": 10, "mbox": "http://patchwork.ozlabs.org/series/501194/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227311/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227311/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=eqU1=CW=vger.kernel.org=linux-ext4+bounces-16050-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=h2KYTlGy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=equ1=cw=vger.kernel.org=linux-ext4+bounces-16050-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c15:e001:75::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=h2KYTlGy;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16050-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"h2KYTlGy\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1c553yXnz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 23:14:49 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g1c503clTz4wLg\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 23:14:44 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4g1c503KTgz4wQx; Thu, 23 Apr 2026 23:14:44 +1000 (AEST)", "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g1c4w6gD3z4wLg\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 23 Apr 2026 23:14:40 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id F317D300EB4A\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 23 Apr 2026 13:12:30 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2E6053EFD14;\n\tThu, 23 Apr 2026 13:12:26 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF923BE64B;\n\tThu, 23 Apr 2026 13:12:25 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 82248C2BCB4;\n\tThu, 23 Apr 2026 13:12:23 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776950084; cv=pass;\n\tb=luvs9H1Ed4pkSmc0DxSUSzJr5mcNh+hvq6RRIQwIf+69Fmrmmt4IZzbbRam5dKYTZRp/fEWfe2S4XsyMNKqgNcCQeXZkf418H7JbycjTruA8EJe8wovCbKL4T/T2px62eF8UbLO+goSFXPPvmhoV9u5iy+K+V1A8ArCfZimFeXIE0hLWXcs6eeXbfA++nrgFkR/smMR/K7ix+NSWbsUwtaan7NW4psookvJYWMXrFV64UIM+cFQzM6LY4/QEbP1CyNsKzdBt/U3rV6JhFXhPhdwfBCvJ3wyeUMT+KK9Yzqs4ztfQ9mGZO+3ItzVhRb0CALPFlPQA+VXzZCa0Q8ppCQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776949945; cv=none;\n b=Gy0xywRp94AEQdVUoRYKnTnGtEy+8CeKFtRi0r7l6ptCBN3WGbks6M0CvknLJ2z+H+5UJyHnrFe9CKQSlBgslpEbNzVevYVEkd/khrYNNIrZKXHwnTipBoqf1hMTys62AlGMEQnsGE1TzucYMKJdnZaeJjV+BhvbTLsXFzGsYxA=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776950084; c=relaxed/relaxed;\n\tbh=31K4p9+/N/vwMThBtdtITu75dH7WNqb/vvnLPTJftnM=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=jwbc4WCc7bIww7DqAOfSKXx4AApbMXm3SCgKVpk72jCssJz4/Qg53qW41wdeaCUl9rBxzPMLL+nIoSTeL5Y5iwq3YSzW8PIw79EsBequop//3q95de+3R0H9RcjCCLGLKbKY2LAG/CisXabfV05Zdt24lEOCeBEGLYmxH5jVKHOAV0quYk36BuMpdMiAUo31S4Ls1PaHYhIOYs/aVbVgARjAwkcYNx+RfpsL02qHeBroNUKxW+S8Yr8UIIqUVzhDL4BnR2GLO+xNwa1Sz090VPi2GCyh82bSx5byLSEf5CB/nzKqIYie3Cle7Wq3lfIUNVTefGStKWkS8F6QmQYRbA==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776949945; c=relaxed/simple;\n\tbh=8UqRyDDayDThBQIQ3JhVpzhStC9FLBOMKCqvs54Qc/w=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=W/OuehlbvGfAHe/7Ac/86BHASN8kkc5SoxqkoAJ410klhQhc7uT9+DKJ/psn8+IlO8t30zdeKdBuaiR7F3wp45rCNW3NxQZpUAsMC3AdDHqZu1s4me7LWDV6yda/ZgTh49RJGwGuCZHBH3jjyCKKU81Z/EFD37IV5HCDCt03Pbc=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=h2KYTlGy; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16050-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=h2KYTlGy; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776949945;\n\tbh=8UqRyDDayDThBQIQ3JhVpzhStC9FLBOMKCqvs54Qc/w=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=h2KYTlGyNhnldToZ6KBhUMCCCZfpY6jBCDpO2/HSziszBWjHNEKeA/Y/tJQyGLBbc\n\t eIiKC7rIzdOQuu4yZkE0ReHAaqqZkQ/7atH1wYkXOfCt+fOrGNDMQzToYKivIFTBGh\n\t PwZwWsVBMTkfjxb2f9Ddn+cdnzSlRP1XLlz2KR/6bLW6WbdSQcfSzmIV6tmRaqyVDB\n\t ZSYqdrDROlpbtFcpZxxUpT8Af23YUxh37JMItVAWwY2U10lS9HO8aKoW9YQ4buS3fU\n\t nbpm4fEfuVgS7+ZEHQf7BSqN/9aYI+UqosP5IHbi6qn99J0FtQ9XY2v6b5f/G3u4QF\n\t TdONWt7dY/ZTw==", "From": "Chuck Lever <cel@kernel.org>", "Date": "Thu, 23 Apr 2026 09:12:04 -0400", "Subject": "[PATCH v10 01/17] fs: Move file_kattr initialization to callers", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260423-case-sensitivity-v10-1-c385d674a6cf@oracle.com>", "References": "<20260423-case-sensitivity-v10-0-c385d674a6cf@oracle.com>", "In-Reply-To": "<20260423-case-sensitivity-v10-0-c385d674a6cf@oracle.com>", "To": "Al Viro <viro@zeniv.linux.org.uk>,\n Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>", "Cc": "linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,\n linux-nfs@vger.kernel.org, linux-api@vger.kernel.org,\n linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp,\n linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com,\n almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,\n glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,\n adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,\n pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com,\n trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org,\n hansg@kernel.org, senozhatsky@chromium.org,\n Chuck Lever <chuck.lever@oracle.com>, \"Darrick J. Wong\" <djwong@kernel.org>", "X-Mailer": "b4 0.16-dev", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3551;\n i=chuck.lever@oracle.com; h=from:subject:message-id;\n bh=bvYDki24delKK+bT1VFKda9bd9+KlESsOU2uc3t1XJU=;\n b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp6hqzekdwvJSHCsI01uU5bkBgDmfma+vhsoir1\n hPF4SjFi6qJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCaeoaswAKCRAzarMzb2Z/\n l46TD/9pmKN2J9EUJXdHjWz8EwTvPYNEbnA1RJwnkVzDTI1/ByZZNw3LwtPEJwex/Oke8czPW41\n 2+KHN98jVc/LGETLoymSjYnqQe6x1ghlyRPAKOEDlwR78kERwpBVooRVN0PfnqglXF4C+rchO2c\n zfiYK7pOFpAhK3TCrUo0xic935TkyMvSQUI0rm3EaT7IwNHKk4XEFaLD19yL+JRatKxFxdf2bBy\n ObB9ErgS+g+bTdB9nneWa/wCOG2c4eDaMO6uCcKt1lU1zDCrvP3NCF2e7lHKiWZ+bDBJ6Xaw2/v\n ePlGjK9vGI4uFju+jAQ+VUwjEH0fdb164DC+pCdFfTe96U0wTXzkm3ikvc+NirIC0oGwI4OQrLq\n A44LvYPuXhpQl3PcDYEQSPH+8DutgHmo36uAD5YtirLorq60YZWI3ifM2faHr5J0JxrpetChpvV\n HQqK5FVOlyGUyowa5bOdnbOYeHXoXZEqrgF+g55FC7Q9gbbczjZC4SDn5RmNXkTq34IyItu1hdm\n ze9TZY7wo12trubTaefnit7n8wFMhjVJS+wZ/1DTREVk1JTdxsm3BA+moJh2aOlDHtq6Mam8HoM\n jDrAoGKgtsLGv+V7cSpCukcY2Hv05GCaGV4K1O6z5EVzPHY6iglTTzaEa5CIywY/5B4Ps16+R3/\n ZYVIIKT+yY8h0cw==", "X-Developer-Key": "i=chuck.lever@oracle.com; a=openpgp;\n fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Chuck Lever <chuck.lever@oracle.com>\n\nfileattr_fill_xflags() and fileattr_fill_flags() memset the\nentire file_kattr struct before populating select fields, so\ncallers cannot pre-set fields in fa->fsx_xflags without having\ntheir values clobbered. Darrick Wong noted that a function\nnamed \"fill_xflags\" touching more than xflags forces callers\nto know implementation details beyond its apparent scope.\n\nDrop the memset from both fill functions and initialize at the\nentry points instead: ioctl_setflags(), ioctl_fssetxattr(),\nthe file_setattr() syscall, and xfs_ioc_fsgetxattra() now\ndeclare fa with an aggregate initializer. ioctl_getflags(),\nioctl_fsgetxattr(), and the file_getattr() syscall already\naggregate-initialize fa to pass flags_valid/fsx_valid hints\ninto vfs_fileattr_get().\n\nSubsequent patches rely on this so that ->fileattr_get()\nhandlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD,\nFS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill\nfunctions run.\n\nSuggested-by: Darrick J. Wong <djwong@kernel.org>\nReviewed-by: Jan Kara <jack@suse.cz>\nReviewed-by: Darrick J. Wong <djwong@kernel.org>\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\n---\n fs/file_attr.c | 12 ++++--------\n fs/xfs/xfs_ioctl.c | 2 +-\n 2 files changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/fs/file_attr.c b/fs/file_attr.c\nindex da983e105d70..f429da66a317 100644\n--- a/fs/file_attr.c\n+++ b/fs/file_attr.c\n@@ -15,12 +15,10 @@\n * @fa:\t\tfileattr pointer\n * @xflags:\tFS_XFLAG_* flags\n *\n- * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All\n- * other fields are zeroed.\n+ * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags).\n */\n void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->fsx_valid = true;\n \tfa->fsx_xflags = xflags;\n \tif (fa->fsx_xflags & FS_XFLAG_IMMUTABLE)\n@@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags);\n * @flags:\tFS_*_FL flags\n *\n * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags).\n- * All other fields are zeroed.\n */\n void fileattr_fill_flags(struct file_kattr *fa, u32 flags)\n {\n-\tmemset(fa, 0, sizeof(*fa));\n \tfa->flags_valid = true;\n \tfa->flags = flags;\n \tif (fa->flags & FS_SYNC_FL)\n@@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tunsigned int flags;\n \tint err;\n \n@@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp)\n {\n \tstruct mnt_idmap *idmap = file_mnt_idmap(file);\n \tstruct dentry *dentry = file->f_path.dentry;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint err;\n \n \terr = copy_fsxattr_from_user(&fa, argp);\n@@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename,\n \tstruct path filepath __free(path_put) = {};\n \tunsigned int lookup_flags = 0;\n \tstruct file_attr fattr;\n-\tstruct file_kattr fa;\n+\tstruct file_kattr fa = {};\n \tint error;\n \n \tBUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0);\ndiff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c\nindex 46e234863644..ed9b4846c05f 100644\n--- a/fs/xfs/xfs_ioctl.c\n+++ b/fs/xfs/xfs_ioctl.c\n@@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra(\n \txfs_inode_t\t\t*ip,\n \tvoid\t\t\t__user *arg)\n {\n-\tstruct file_kattr\tfa;\n+\tstruct file_kattr\tfa = {};\n \n \txfs_ilock(ip, XFS_ILOCK_SHARED);\n \txfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa);\n", "prefixes": [ "v10", "01/17" ] }