Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2227036/?format=api
{ "id": 2227036, "url": "http://patchwork.ozlabs.org/api/patches/2227036/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423051804.362095-3-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260423051804.362095-3-jamin_lin@aspeedtech.com>", "list_archive_url": null, "date": "2026-04-23T05:18:08", "name": "[v4,02/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure and dead code", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "81b1b56ec07fff1abd622c0930d3d764361a0cac", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260423051804.362095-3-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 501145, "url": "http://patchwork.ozlabs.org/api/series/501145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501145", "date": "2026-04-23T05:18:08", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501145/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227036/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227036/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=SXe7GrCK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1PY12vQnz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 15:19:47 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFmSF-0007Q2-2R; Thu, 23 Apr 2026 01:18:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wFmSD-0007Ov-Df; Thu, 23 Apr 2026 01:18:21 -0400", "from mail-japaneastazlp170130007.outbound.protection.outlook.com\n ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wFmSB-0003Bi-UX; Thu, 23 Apr 2026 01:18:21 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by KUXPR06MB8534.apcprd06.prod.outlook.com (2603:1096:d10:9d::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Thu, 23 Apr\n 2026 05:18:08 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9846.021; Thu, 23 Apr 2026\n 05:18:08 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=mTxjvV9Qr9H+4nKB2N2FJU7iwrqefK9bGIbX7nqdmrdQFuQHVpRLBlyNTe6a+8kbkmcLBmrqj7ZxVvOyUWkRJujfIuCVokCxjRogGkQ5Oo+BmFBoJuN5SpgNDYwohFl2vgtp27bVaworXNVgJNdJjLN4CRWhmoDiEOpUnCv8hiKAwTZA8mkGWUouXMTiUFBPAZOCY4mCAR/3rQP8RE4je3O/HVwkvijUN43n574TgktJ/ZuUZztzKk5u+Q2N1p/M2r5EYeo8O5mtLcbmBb/opa25wfoQfwpdOAT+shvUnRCzPzj1WSISy1ox4rmb9Ve80qiMq40kA5X87kby6wlZ+w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=oCFEwtHBZ+mIU1V0QNyiXC1wsVKvlT2QfSiHUhROkWE=;\n b=w88nir0m80j7gVS+Yn2ym9DM6CsP0tGqN9zmKygXTCEBIBzR20yfVirbBpdK7vk/ObBMilShLGb0WnoMSNAc1ZmRC+1+KjIh2LU3AN+Mhdrkt/YJPiypkDSKhkgbZ+bt6TocIqWDHOU+Is2D+oJgladb8mNCrB6BlF3deeYOW+NWbvgmJumKXi8GgsGs/9HDNbBw0fZHT6efePgSXgPewmpLeck9juhLu5sQLP/pSGU4kKZDBTpOjoDHJvGI0u5vOO7sV9q2sceIxOPepQIj8FDmUyYFe1LXA898IlP4j+28my6zgZDMTnsNirjr4tj5o7T2pJEmwuIXACJsA3pnkg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=oCFEwtHBZ+mIU1V0QNyiXC1wsVKvlT2QfSiHUhROkWE=;\n b=SXe7GrCKZ5xEGp57n8k6FV6WGb6YBqtu+h3tIVSbLUUXi9hN0VXqMyNB2C/PpK+1rsS2VLBiSv/fG0wgb2FjihVecIWrYz05FN0ZskL13jOM8AzmleoBlohSKojWhAxK5MDQa8OK3QdrgcWiV/WywBkrZ5nULFuUm14D+b9+fAGjtXd8rHwXrKvaI7Y2iPxGuDmpPm3qKJncwoU6Tt0YwVImIItXIF/13KlUHfyzSyy2G8NTqGNtWfFoteeShQ7lpzPxAwJgLmJxdVeMk+V65Ylzgv6A14TAs989zoKJ8Af6UBLG+uRJwKm5ucvd4c0pXTsKuMFpC1mga4cIBqMpRQ==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "\"philmd@linaro.org\" <philmd@linaro.org>,\n \"peterx@redhat.com\" <peterx@redhat.com>,\n =?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>,\n \"nabihestefan@google.com\" <nabihestefan@google.com>,\n \"farosas@suse.de\" <farosas@suse.de>,\n =?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@redhat.com>", "Subject": "[PATCH v4 02/17] hw/usb/hcd-ehci: Remove unused EHCIfstn structure\n and dead code", "Thread-Topic": "[PATCH v4 02/17] hw/usb/hcd-ehci: Remove unused EHCIfstn\n structure and dead code", "Thread-Index": "AQHc0uCSUn71WarDskudEuJUK23SCg==", "Date": "Thu, 23 Apr 2026 05:18:08 +0000", "Message-ID": "<20260423051804.362095-3-jamin_lin@aspeedtech.com>", "References": "<20260423051804.362095-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260423051804.362095-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=SXe7GrCK;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|KUXPR06MB8534:EE_", "x-ms-office365-filtering-correlation-id": "3c02d483-1eb2-490e-1f82-08dea0f7b49a", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|38070700021|921020|18002099003|22082099003|56012099003;", "x-microsoft-antispam-message-info": "\n jYMCeZPgIrZDLl/Rfp9FkqYR1UQXbaWTPhLW3kIvqkDrJu5QU9xFL1QeUVg3mHJbXVuI/dEVTSIXkm1IvnL00rgm7CwAAWrvcYnIJsJE4JwGDgJPrCqyMFcYj7YAxx7eA0La3vGgDdM4HywuLO8rUcH8IjCHcTBxtFIDiS8xbm3OWZ9olAxIbo8HGKn6zDWgM9Rj+T8A1xUtSDtx9HTEuKWjoGpBMEmJXB2gQwjUtPh3I0LWouoXnaWybEN229bbnZmPjg+H2bkz2zzV6mIO2cKiPVjUln4DrtOb3K6NogoxrcjoG29IYayqTU+4kjKD1J2/73zkfQOFppYz09hqpRVJK5K5wsvyMrLjDBoIS/KhVU3bN2vTDutPiEneNg7YxPpVqdHKBfj89ncCY5WRm4S/EyrNhIQdUOjfM/wWikrkRfXhyzeV9fHUXfAB9jTUZS/oxFmjmz7K5Kj/U29wz4ApaZ/89XOD2ChZ8OXDpg5G8wJ2BX4StrhqjrFHr+deTApspdXgp6VFhf0S4yehlXfWMOURhhjNfZVRB1e+c5KqADkqLo8N3DZ6mzffi9fPufSCuoNjy1y4Uf5Jd3whu5WIH9wVxeOQhuVB53VG9j/FLCkyMuwk9pzauMobY+AqT9V9N5LEPqBs8QleinDRTpkCudFoH2hgHpXfFg+WflC0zHTDD7HeAsFDnGoQPqt7b+fyYtRFws+0WmmRq4IcHv+Yoikt9VOzBrljk0tDLI3TxWyDw8nAHBbscQqKVsVIuWy+Pq4BcekArQw23jIvvxjnBfyUb8aFLDSOI10unOJFk9+p960hkDIfMh7bFRaZ", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(38070700021)(921020)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?hWEG2gtptjOQ2yJ3gs+nGuh?=\n\t=?iso-8859-1?q?G5DC2nbXhcyn3tfSjmTQsOCg0y6pC6Gsd1sua/N7teydReXPFhOklIYDwQlZ?=\n\t=?iso-8859-1?q?M9GFoFVN3dvSje/gO5Kt3Ff7pmsiN6E2GusnO5UglU8DZPCtO1gMQBtJu+/9?=\n\t=?iso-8859-1?q?Jj37Dco9C5f02DnS2Z9MGzwziv0R0THxjdESPL5iovSFmntck30CIz2u5K10?=\n\t=?iso-8859-1?q?bRC37Pj3ho8Byc7Lou6zz0oGLxCiET8/hTQc5QyrptuAac4tJLX/VVnmwvSl?=\n\t=?iso-8859-1?q?VfhlHKmdhub4LpMmng4LIG2IyR+yIMtU+vr93esdmSxD0iDfU5fl/SWPL+Tu?=\n\t=?iso-8859-1?q?+n4rxtthXSr1C33Lc/G6eUT8qYeuJmJqj9q2HcjlSmfRedHtLOoxTmjofTOt?=\n\t=?iso-8859-1?q?BMobijGJJxfGq/3ckBxnHLPg7Z6nNXQo07uvQ+rFTFSwXVt1iguhmziyiTXb?=\n\t=?iso-8859-1?q?7EmaUDCk+AWPv2FjBPE3056zJqGz+oBbYaNdmVJjkH0UxmSxT39Nfi/V14zI?=\n\t=?iso-8859-1?q?yEYNFrkLIkTWB2jB9EkeImmyTOBowsjJawp7gkzyvB2ScG3kPjn2xPASb4Gu?=\n\t=?iso-8859-1?q?+9EIubFT3avXx2S9mDAUHEie4qMgMyZAQ/x9XKeEkNg5JgdYooMPWHvZoMlC?=\n\t=?iso-8859-1?q?dJBvhPQuceXEAxSlU6NBHjT4+ElMI9M/xQ49xTSxy4N/NVnQvFA3+DkNg1A6?=\n\t=?iso-8859-1?q?e3g79KJyJoCbvWVtx5fWhkbzqybWWv5U+OQ2jDTjSIkPzTPvF5HHB6azxWPO?=\n\t=?iso-8859-1?q?HSaSCV7Ft0tQO9wJI8ucsQywcyKKEoNhcAXR/bW6O3yxNPkU+OdOJ0y2EVu1?=\n\t=?iso-8859-1?q?V64sK2pN0rbPOQXUDP/sYQKnEeVgWXD4RbYbYqF9NOZHXXRQsl0vbmgydPAt?=\n\t=?iso-8859-1?q?dAQ5Y/Dl8qNqF4cjs2y97mJNGJE6okTaQe2lLOt1GmDfH7gr7uswBOYYShFO?=\n\t=?iso-8859-1?q?o4lkNHDGiE1E89DNC5ioPjygGppxwi+3VfyOYsNbeb49XFXyMiJRsSKnux47?=\n\t=?iso-8859-1?q?DNz7Alc/Z9BE+vXlvKXcXcUk7rLmMjlm7wTQJV1IRl5n/1dAe5srBIDMEGTH?=\n\t=?iso-8859-1?q?TNbJx1OSdUPWJ2q18eFF6+iShBjvov8xjLrGenD+7Jmq0cwPy9u4AiV9u/Z/?=\n\t=?iso-8859-1?q?mMe8gjmJkjcJWI1uz1J0vGU6PSc0YoSezH8Mzcoydb8dktkwsaWFnplC6fpT?=\n\t=?iso-8859-1?q?032J36/wYJ71ia2F9owaT0Hwyt1TJyPjRxmeOZd2Bw+8+iU4cL3uJzqK5vzk?=\n\t=?iso-8859-1?q?sU2h5tLKTZ2ozljWPL31NsuRKB/LVjBjNKJUJnEXGDlt/6it8XTM3BNdaIGZ?=\n\t=?iso-8859-1?q?tc3Nv39RN0p4Pg1JXI0wLclg7hKyd2xJKQCQxtP/jtp8wbZZOgvxC/8KDf1m?=\n\t=?iso-8859-1?q?7e7dvjqr4Dyr+RvsekoeqtIZZTOHToE6u88nL/YzJElD5oFNntpDqpWUe/Yb?=\n\t=?iso-8859-1?q?UgT3VXTFHl9VjN3zFSlQMDjCTPgUXFWV/PO64+6f9fWMwLHOSs+0sxvBBBXa?=\n\t=?iso-8859-1?q?R49CvnEQbG7Zo5jkLZkRPVQ2qFPQTVJeCitMouz6obA/kkMMGpDEnXGDtNC3?=\n\t=?iso-8859-1?q?H+eJUZANNfDVZrJdAAz+pGKdZsJI1AgunhuAjaP4EpMeNTpZzTMGmoKCFbwX?=\n\t=?iso-8859-1?q?TNNVn/xJ9WF/INX9PwaLNTWjXPYNTV0vR1haMUdOc9PUVAFJoby5M8sFGBPk?=\n\t=?iso-8859-1?q?Zm+QTyh8f07hdmK4VxoFvyIUCJ+ZUIykbzFylOc/ojcf10Zl6iSIFHPc3Ckg?=\n\t=?iso-8859-1?q?2EpUr20vsdVaI2mlEn0PI1+Zup/ZnaUEmzyK5f0oXsU5B5w=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n KQhfRy0NMQ07sJKGGyRHC9lJ6DPgxRdUzd9TTFTuT+DTduQm95EyvxC3ewKj540KsJ5yqCODjE7Nw2UdI8bfacElUe0G82TEWJQDHxopMlGVnMhp0Y66o14nHgLuoeeMa2AXdDWYRq2C1ocyTk4MlbUhESVLhcWZXWtuaopJioeZGUF6IHIyhaUjpKRppXje3mtnv6DVllwywVmd8jMRU8iqfiARBTSzUPJRl81IxfZvoMLwtT1RxaJlMJdc/RXgG1kpEk1MmI743sRF5rG6g1iwwZqW0AzfiaEWggTtMpwSjFY9iE1bqpNSSMbYD0w8zqZHmgl4CrJ5+BABhVCPbQ==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3c02d483-1eb2-490e-1f82-08dea0f7b49a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Apr 2026 05:18:08.0242 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n VXZbGn0QVy84FBm/z5ve9zr1f+527pgt4JPvchLmNZESZMxkRlUunfgOtpygQuHBSAxXgaWM5RP993hC2wkQDux6pjghlci8FTQ5AAx5c10=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "KUXPR06MB8534", "Received-SPF": "pass client-ip=2a01:111:f403:c405::7;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=TYDPR03CU002.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The EHCIfstn structure, defined according to EHCI spec section 3.7,\nis currently unused in the EHCI implementation. Remove it to reduce\nunused code and improve maintainability.\n\nAdditionally, drop a block of disabled (#if 0) code in\nehci_state_advqueue() that was never implemented. This code path\nis incomplete and has no functional impact.\n\nNo functional change.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\nReviewed-by: Cédric Le Goater <clg@redhat.com>\n---\n hw/usb/hcd-ehci.h | 7 -------\n hw/usb/hcd-ehci.c | 6 ------\n 2 files changed, 13 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 0ae8c06331..3aec0e047c 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -202,13 +202,6 @@ typedef struct EHCIqh {\n #define BUFPTR_SBYTES_SH 5\n } EHCIqh;\n \n-/* EHCI spec version 1.0 Section 3.7\n- */\n-typedef struct EHCIfstn {\n- uint32_t next; /* Standard next link pointer */\n- uint32_t backptr; /* Standard next link pointer */\n-} EHCIfstn;\n-\n enum async_state {\n EHCI_ASYNC_NONE = 0,\n EHCI_ASYNC_INITIALIZED,\ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 57f930b099..23167bf96f 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -1756,16 +1756,10 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* Section 4.10.2 - paragraph 3 */\n static int ehci_state_advqueue(EHCIQueue *q)\n {\n-#if 0\n /* TO-DO: 4.10.2 - paragraph 2\n * if I-bit is set to 1 and QH is not active\n * go to horizontal QH\n */\n- if (I-bit set) {\n- ehci_set_state(ehci, async, EST_HORIZONTALQH);\n- goto out;\n- }\n-#endif\n \n /*\n * want data and alt-next qTD is valid\n", "prefixes": [ "v4", "02/17" ] }