Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226958/?format=api
{ "id": 2226958, "url": "http://patchwork.ozlabs.org/api/patches/2226958/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/177689989348.3821152.13922579915019711363.stgit@frogsfrogsfrogs/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<177689989348.3821152.13922579915019711363.stgit@frogsfrogsfrogs>", "list_archive_url": null, "date": "2026-04-22T23:23:15", "name": "[2/3] libext2fs: always fsync the device when closing the unix IO manager", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "888007765a5c2f0c11ed323be4b164a944ac5e57", "submitter": { "id": 77032, "url": "http://patchwork.ozlabs.org/api/people/77032/?format=api", "name": "Darrick J. Wong", "email": "djwong@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/177689989348.3821152.13922579915019711363.stgit@frogsfrogsfrogs/mbox/", "series": [ { "id": 501126, "url": "http://patchwork.ozlabs.org/api/series/501126/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=501126", "date": "2026-04-22T23:23:00", "name": "[1/3] libext2fs: always fsync the device when flushing the cache", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501126/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226958/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=rSRh=CV=vger.kernel.org=linux-ext4+bounces-16003-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lW6hwf22;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=rsrh=cv=vger.kernel.org=linux-ext4+bounces-16003-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=104.64.211.4 arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lW6hwf22;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16003-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"lW6hwf22\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1Fdk4GPNz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 09:23:22 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g1Fdk3p3Hz4wCM\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 09:23:22 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4g1Fdk3lltz4wKB; Thu, 23 Apr 2026 09:23:22 +1000 (AEST)", "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g1Fdg1Gp6z4wCM\n\tfor <patchwork-incoming@ozlabs.org>; Thu, 23 Apr 2026 09:23:19 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 00BFA3004CA7\n\tfor <patchwork-incoming@ozlabs.org>; Wed, 22 Apr 2026 23:23:18 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BCD74352FA5;\n\tWed, 22 Apr 2026 23:23:16 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 806FE1D6DA9\n\tfor <linux-ext4@vger.kernel.org>; Wed, 22 Apr 2026 23:23:16 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 5AF79C19425;\n\tWed, 22 Apr 2026 23:23:16 +0000 (UTC)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776900202; cv=pass;\n\tb=TOcixFIzgWhJpVb4ifCnT0mFMfnWqDgNBhc//mAsQ4jW6kFVCij99gGanQmrM7VfbzjTcGZzJkMBuvBFF3RcZgFxnSejHiDCpTBa/kIt8VvwtGjWeFaEP8eJ2qhanJjDXreNX3nLrzvbvCzXeJIYFYnLXl3ZoBQXsYn5r1bs8c7Qa0fOh1LTZu+a4gAmszCvdcQHj+/hONFnSdq0WK/jETQ0R4A2OwnLOmHUFjykjmnSudAjARi3TJi6nEq1l4mcFD1g2MdZIxgOIdmz4LwLlSX2vKucMUcSS6cwRTLKvwEVHkJpWVCo9vxuYr0pnBE3TbGADHDO4kVgfX97X78hbw==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776900196; cv=none;\n b=uT/Gw1Wo66mu4+//yWVS24IkJOzumlCMRD9iLgPWWmp6PsgMHWHfOVkJV8JmKgX4j0BrtDdObJHGSMMbFdsWGf6VD++JHgdpfgqJX8usO2UnxyKZayaiq18wYlsBYgcO95F3pdl+6q97exebuUGLzxF93jl3p8D8HrTBcykCyUY=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776900202; c=relaxed/relaxed;\n\tbh=GfyB2arjNO3+aqpifGZZ2rnT17rZVR6BAIUgDn2yd68=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=YE2SMQEpn35CDCd0zqFjYIxL5rXONITisbIaLdEmSpicNpRj0wHJJ8x8Hwgu9MaBcjrCp9lnLhk0foA1TzsxW8mt1N8reMzrIwSZ0lso0m5NC5BYRCWmt7TqeBqtT5/ypSKg4llzUCrxKcUjcdgcPmyyaVtGoAVfvBMZzgAw8veR6FgECdtXjIjvPqEbVcFTrEg0R7NTEffjUcun11hbjPhlk9eaMhDQYYjTSqevzfKekkOdGquISn7fC8ZKCsQaJuxs/vzjtGPDH/qvbL6f6FlLyOUmuzO8/iVGa15Ebr1qTI5UYIfPTveZq9t/finUt5bZ8V6HKnNcf7p/LrYhVQ==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776900196; c=relaxed/simple;\n\tbh=tYjdQr2/vAzZdBYLwrROdv3cE7IwQkoXgESSj1yoLFI=;\n\th=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=g2Sv6vAwQLVWFqjAwiArzNybUK6fzUkzAlIhLqLIbxopALK33Dk8mFZgjwpNKGYMVSYgwsM7ndn5rIRr3Foq9ufoPYP0xs/uj/zhmJxX3IAkAFxS8Yg4Vdech5OA4VkkyHHIDsG6UlTJ7te86s5j8d9hAW5uaDXY5nLTmQEqQPI=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lW6hwf22; dkim-atps=neutral;\n spf=pass (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ext4+bounces-16003-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=lW6hwf22; arc=none smtp.client-ip=10.30.226.201" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776900196;\n\tbh=tYjdQr2/vAzZdBYLwrROdv3cE7IwQkoXgESSj1yoLFI=;\n\th=Date:Subject:From:To:Cc:In-Reply-To:References:From;\n\tb=lW6hwf22p8ueTXnaJc9iwpH9GVaXCBSRpIu7LN7Wg5SR9XcqK26/rKL/Jijt+sncO\n\t OmLKoS82LzvpBYqbIdlUjJfK/XOtR+psWPH9KneW7KpEQU0u80CqKPwYY4J3nF2hQG\n\t NaWEQzTPSgSpVgcBiJdO57S84vZVQMQjaNxHaO/qLuiVYECLQVas7JRcCFzcc9P1+o\n\t m5T9MiV2brx3QsID9kHBol39vOVmtyNajOVk9TtEUXeK3TC/K507WIIVCj2RLv5sD2\n\t GrXFg4xPqtGNZ+7JRkvikRBfGDzIevbfFyH//u8yir3bAiSbUN1Zs7LmzhbhJ/xWq3\n\t fWwtUR/jGiXRQ==", "Date": "Wed, 22 Apr 2026 16:23:15 -0700", "Subject": "[PATCH 2/3] libext2fs: always fsync the device when closing the unix\n IO manager", "From": "\"Darrick J. Wong\" <djwong@kernel.org>", "To": "tytso@mit.edu", "Cc": "linux-ext4@vger.kernel.org", "Message-ID": "<177689989348.3821152.13922579915019711363.stgit@frogsfrogsfrogs>", "In-Reply-To": "<177689989303.3821152.12873703999139555043.stgit@frogsfrogsfrogs>", "References": "<177689989303.3821152.12873703999139555043.stgit@frogsfrogsfrogs>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Darrick J. Wong <djwong@kernel.org>\n\nunix_close is the last chance that libext2fs has to report write\nfailures to users. Although it's likely that ext2fs_close already\ncalled ext2fs_flush and told the IO manager to flush, we could do one\nmore sync before we close the file descriptor. Also don't override the\nfsync's errno with the close's errno.\n\nSigned-off-by: \"Darrick J. Wong\" <djwong@kernel.org>\n---\n lib/ext2fs/unix_io.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/ext2fs/unix_io.c b/lib/ext2fs/unix_io.c\nindex b6feebef93fa5b..15d6d55ff7fdd4 100644\n--- a/lib/ext2fs/unix_io.c\n+++ b/lib/ext2fs/unix_io.c\n@@ -1213,10 +1213,16 @@ static errcode_t unix_close(io_channel channel)\n #ifndef NO_IO_CACHE\n \tretval = flush_cached_blocks(channel, data, 0);\n #endif\n+#ifdef HAVE_FSYNC\n+\t/* always fsync the device, even if flushing our own cache failed */\n+\tif (fsync(data->dev) != 0 && !retval)\n+\t\tretval = errno;\n+#endif\n \n \tunix_funlock(channel);\n \n-\tif (channel->manager != unixfd_io_manager && close(data->dev) < 0)\n+\tif (channel->manager != unixfd_io_manager && close(data->dev) < 0 &&\n+\t !retval)\n \t\tretval = errno;\n \tfree_cache(data);\n \tfree(data->cache);\n", "prefixes": [ "2/3" ] }