Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226940/?format=api
{ "id": 2226940, "url": "http://patchwork.ozlabs.org/api/patches/2226940/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-12-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422214225.2242-12-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-22T21:41:59", "name": "[v3,11/37] whpx: i386: IO port fast path cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "31475a5ad9d98230a9d0aa6d0b833df4a17e1e62", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-12-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 501116, "url": "http://patchwork.ozlabs.org/api/series/501116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501116", "date": "2026-04-22T21:41:48", "name": "[v3,01/37] target/i386: emulate: include name of unhandled instruction", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501116/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226940/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226940/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=f17MqGyU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CVb1L37z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 07:47:03 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFfLX-00082u-4j; Wed, 22 Apr 2026 17:42:59 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfLV-00081V-Dd\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:42:57 -0400", "from p-east2-cluster1-host3-snip4-10.eps.apple.com ([57.103.76.13]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfLT-0007FU-TI\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:42:57 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 47B5918000C7; Wed, 22 Apr 2026 21:42:50 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n A7D8C1800950; Wed, 22 Apr 2026 21:42:48 +0000 (UTC)" ], "X-ICL-Out-Info": "\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAU1fDl4fBBdGGVUERx5dVkAZGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCC0oCWQVZB14LSgdfGloAXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD", "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776894175; x=1779486175;\n bh=90DXebKcXq4ywVPqb9VJW4/s7sJzsLUwFClfg34UOKo=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=f17MqGyU9Xgv6xU4nwNDGxv4KvF/7Hp9WeaK2G15mWw/23V5+xom7iLsz/bc2bEn5PLtO7J9paJIlQCXRcU4aEetZtJFKEkSMlUSNeandO+3iJp0zVJmeS6WJKeYHXNNFr6Ronntl/aEVoIUYx93iJXaHW6J6HvLvdzlmRhEFZm/iQNs/FKMN0AT49Q29pXO1/N5jEvbpG5nIf/iDH8azaCVhzBD0NzxvHGU4RFfSNWEbBYZYG4EdOslmStX7p3g+sq4jVfqfeJ4oj6dZimqXYsmRtyBoFdMJospndhcVfWwwEbAcyHefTgrIVBhZURno6s+GlAgTF9ZcTni3tXMmA==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Roman Bolshakov <rbolshakov@ddn.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v3 11/37] whpx: i386: IO port fast path cleanup", "Date": "Wed, 22 Apr 2026 23:41:59 +0200", "Message-ID": "<20260422214225.2242-12-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "References": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-ORIG-GUID": "O8y9kfFCfmBiRkUtlYAO9Zo12uvLL97i", "X-Proofpoint-GUID": "O8y9kfFCfmBiRkUtlYAO9Zo12uvLL97i", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDIyMDIxMSBTYWx0ZWRfX31qEm/uhSh5F\n 42bs5uJP1abdyf9e0APnvam52AFfb49AXdCpH+m5GiuNFIVafCfoyQ+WQB5v4XwGty7z6MsWRaT\n hJwCAFb1ngRsb4yDCCtIjTXDXwHOJ/Cd6QoFJjsMNemdkWYVQfPo/E0qbuBxyHqxLzH9EZ1E8Yj\n Nzda+Fwtx/666VZiJdWGf5+7MCAOj2rtpGt5zmBPuiATETdrCvijlK6djgALOdYKfZPolMK+hhh\n pmGDMPheigraiUMECPCU84hqITZk0Wu/jEvUmFc5a4kiOhuwkkAAQZtMneNCf9qW9wo5iF1Ipt9\n G/9VH6EGHEGjziGbbkBpLEUaMa6By+E7e0pQNf2JWTlBEbRuZbGrSIg6Vve+gY=", "X-Authority-Info-Out": "v=2.4 cv=I8Nohdgg c=1 sm=1 tr=0 ts=69e940dd\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Vrzv6M8N8vcM0KmfSJEA:9", "Received-SPF": "pass client-ip=57.103.76.13;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "vmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex ab8e97787f..75f0f062d4 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -881,7 +881,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -909,13 +908,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n", "prefixes": [ "v3", "11/37" ] }