Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226928/?format=api
{ "id": 2226928, "url": "http://patchwork.ozlabs.org/api/patches/2226928/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-33-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422214225.2242-33-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-22T21:42:20", "name": "[v3,32/37] whpx: i386: don't increment eip on MSR access raising GPF", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c8e69434524cdbc152af214110d29b02b636f55d", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-33-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 501116, "url": "http://patchwork.ozlabs.org/api/series/501116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501116", "date": "2026-04-22T21:41:48", "name": "[v3,01/37] target/i386: emulate: include name of unhandled instruction", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501116/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226928/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=VhV2A0rG;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CSp14wRz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 07:45:30 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFfMK-0000Hc-Ec; Wed, 22 Apr 2026 17:43:48 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfM4-00007O-W9\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:36 -0400", "from p-east2-cluster5-host4-snip4-8.eps.apple.com ([57.103.79.61]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfM2-0007bV-HC\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:31 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 62B5B1800227; Wed, 22 Apr 2026 21:43:29 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n B312418000CF; Wed, 22 Apr 2026 21:43:27 +0000 (UTC)" ], "X-ICL-Out-Info": "\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAU1fDl4fBBdGGVUERx5dVkAZGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCC0oCWQVZB14LSgdfGlgBXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD", "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776894209; x=1779486209;\n bh=FA6Y8ttrbFxZ+orHRdeG19yDqOaDqIU7TL3dmM72EL0=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=VhV2A0rG1CM2s0JhDgK2wxbZqssXqlmfrBl27+Z9or6UH5SBQc7mJXo1zmHBUfWxleB8y5np5Niw8aGGmCaUmchJRMZh1iHbFcc4CAKHHz874qPY6CK2KAJOiQom83ese29L8o5GVnlauUxCp5IoQYXCMQI5+Yj+td8tRR57EDbwZJa/YnwLmNWAXwB75jLwWNZRzvbGukx/zV2QuYz/Rvo5U5EEuODE3RNZlSm7W+ih59qwexHsg5pMgIS+COGSxXar3bPgdats8pmLANNEdiaTZ4upY48uqIJspWP+cds/KHjyNsQrwWKERYPl9dzxsvemEnCn8r5KjTVdefSZDg==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Roman Bolshakov <rbolshakov@ddn.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v3 32/37] whpx: i386: don't increment eip on MSR access\n raising GPF", "Date": "Wed, 22 Apr 2026 23:42:20 +0200", "Message-ID": "<20260422214225.2242-33-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "References": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "FvcmyQmGWGUcg_VrlZabGRj3Nldl6dce", "X-Authority-Info-Out": "v=2.4 cv=JuP8bc4C c=1 sm=1 tr=0 ts=69e94101\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=N0YEvnU7VqbRQIRMxcMA:9", "X-Proofpoint-ORIG-GUID": "FvcmyQmGWGUcg_VrlZabGRj3Nldl6dce", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDIyMDIxMiBTYWx0ZWRfX8Dtrj6UB1Vro\n /rNnVb9R/2fdrxz4VkJmB3XWNNobH93bdXeHo3AbOPo9+tCqNJcxteqZGP1BhO234shC5nrQXa/\n oXQQ9oyai7ZUrcva1u8WeIB+HP1zUjGR04AsbRBQ/jyB+2I6hwOQwig0JOxqpvlxDlzyWpKp5QP\n xBNuACrHT72Vq3k/uj5U8FgazUnI7OKdfZ9zKmV9X0V2AFGD4gfxDYBumIz6+zh4avg6sITopS3\n 35DBHGsZwjIp/ispSKQHFBnHgTiQhS9Y7HeBym08Wpw2Cl20CW6jU5fji/QiR/0bD3pievCz1Yf\n nvGr1eCHXTeHmo3/FCcODbgay2x1Ma5AwTpoOowzmQiv0BsiU/n/YpjLAVbSU0=", "Received-SPF": "pass client-ip=57.103.79.61;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 6845f96ea6..830d8acd2b 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2240,6 +2240,7 @@ int whpx_vcpu_run(CPUState *cpu)\n WHV_REGISTER_NAME reg_names[3];\n UINT32 reg_count;\n bool is_known_msr = 0; \n+ bool raises_gpf = false;\n uint64_t val;\n \n if (vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite) {\n@@ -2272,6 +2273,7 @@ int whpx_vcpu_run(CPUState *cpu)\n is_known_msr = 1;\n if (val & MSR_IA32_APICBASE_RESERVED) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n if (!vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite) {\n /* Read path unreachable on Hyper-V */\n@@ -2281,6 +2283,7 @@ int whpx_vcpu_run(CPUState *cpu)\n int msr_ret = cpu_set_apic_base(X86_CPU(cpu)->apic_state, val);\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n } else {\n whpx_set_reg(cpu, WHvX64RegisterApicBase, reg);\n }\n@@ -2300,6 +2303,7 @@ int whpx_vcpu_run(CPUState *cpu)\n reg_values[1].Reg64 = val;\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n } else {\n bql_lock();\n@@ -2307,6 +2311,7 @@ int whpx_vcpu_run(CPUState *cpu)\n bql_unlock();\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n }\n }\n@@ -2356,6 +2361,13 @@ int whpx_vcpu_run(CPUState *cpu)\n \n if (!is_known_msr && !whpx->ignore_unknown_msr) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n+ }\n+\n+ /* When a GPF is raised, do not change Rip. */\n+ if (raises_gpf) {\n+ reg_values[0].Reg64 =\n+ vcpu->exit_ctx.VpContext.Rip;\n }\n \n hr = whp_dispatch.WHvSetVirtualProcessorRegisters(\n", "prefixes": [ "v3", "32/37" ] }