Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226920/?format=api
{ "id": 2226920, "url": "http://patchwork.ozlabs.org/api/patches/2226920/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-16-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422214225.2242-16-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-22T21:42:03", "name": "[v3,15/37] whpx: i386: fix CPUID[1:EDX].APIC reporting", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d74f1a39346ba8c0ce97fec82b0b73bd803b8120", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422214225.2242-16-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 501116, "url": "http://patchwork.ozlabs.org/api/series/501116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501116", "date": "2026-04-22T21:41:48", "name": "[v3,01/37] target/i386: emulate: include name of unhandled instruction", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501116/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226920/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226920/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=ZEFFTIwo;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CRq2t2wz1yDD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 07:44:39 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFfLm-00089l-QY; Wed, 22 Apr 2026 17:43:14 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfLd-00085K-V3\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:06 -0400", "from p-east2-cluster1-host3-snip4-10.eps.apple.com ([57.103.76.13]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wFfLa-0007IA-1P\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 17:43:04 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 477EA18006F2; Wed, 22 Apr 2026 21:42:58 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n 24748180020B; Wed, 22 Apr 2026 21:42:56 +0000 (UTC)" ], "X-ICL-Out-Info": "\n HUtFAUMHWwJACUgBTUQeDx5WFlZNRAJCTQFIHV8DWRxBAUkdXw9LVxQEFVwFVgZXFHkNXR1FDlYZWgxSD1sOHBZLWFUJCgZdGFgVVgl3HlwASx1XBFQfUxJVHR0LRUtAEwRJAU1fDl4fBBdGGVUERx5dVkAZGQJRHFYNV0NUBF9QSQxBUGxaAEcXSB1dGVlvUF0cDhhZG0AVXRFQGVYJXhUXHkFNWgJWTQVKA18BWwZCC0oCWQVZB14LSgdfGloEXVQXWwxaDlYwTBZDH1IPWxNNGVEBUkVUAgdYRxRHDg8TTAtHAlo0Vh9UGVoD", "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776894181; x=1779486181;\n bh=mZk1MRNsRZuauqJZJ5eYDVOD6iZiU/IQRXxLoFpZKvg=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=ZEFFTIwolrTE9xqAMkY6yJvef9mxi6zNeNLrlWdcxYKv58g5SF67XagvEmd/rKXkbmzkmKTfNtAJcVYcHnfZ3nhbajAATrNpBRBEvQyHKgJNcmnqYRC6BA4b2cmwmFBIkamW642nOcgfHSQy+KPe8kBwwTZH39pAhKd4fGx+aXbq9Lz0I3ENGul88ya2qeRk9xJgftiJRzCpqaxtii0NwtIKwgqe8mQI38uXUwCW4cirL4kj7ygWH2JpsbXMt7JB4lmlOgIlARo27Uxu32/FPn7hEMY5+/mXk/s5yxbMEAEY8P3/4xEQi47+UpWbizGkxghi6ptFWLC4m52Ss1D9Lw==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Mohamed Mediouni <mohamed@unpredictable.fr>,\n Roman Bolshakov <rbolshakov@ddn.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>,\n Peter Maydell <peter.maydell@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v3 15/37] whpx: i386: fix CPUID[1:EDX].APIC reporting", "Date": "Wed, 22 Apr 2026 23:42:03 +0200", "Message-ID": "<20260422214225.2242-16-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "References": "<20260422214225.2242-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDIyMDIxMiBTYWx0ZWRfX6IUwjBLcIwCC\n 3egNaICsctHJX/PgJbu3iN9XqwA6dSfuKmlk/AHCPEgKDfblBtHxAUG26TK/yean3FJPJ4I4sb8\n GECR3YU6MaCzdhmW42pofFMcVTchXIAKfD1Y/1Pwu8XQd2PX63cCwfVePL9ikd+bdWLeYB3PGR5\n 0GoNnPsZJoeVxVAjZDAli53bp4MuPj1wNl4c9lU9N2Pw355kq3xLRiqyj8smOdKCIE/ilyfEdng\n g4UjpFVI2DCAiBN1XrDbarcCAiUe7rb1i/uoxUdxsN7DKmRPs0RFDE6SLB4QNCBg+nGUIAsVKAq\n qzBxxdC71gGBaLtDKDrva1ShfhZWPMoyHenBTWZDApyU3WcdhiGJlkLqeWuKd0=", "X-Proofpoint-GUID": "5sXS-ZLVWminzvkXQct3kjCSt9o-a-F0", "X-Authority-Info-Out": "v=2.4 cv=VKrQXtPX c=1 sm=1 tr=0 ts=69e940e3\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=ljJ9V6m273jqBh-Cp98A:9", "X-Proofpoint-ORIG-GUID": "5sXS-ZLVWminzvkXQct3kjCSt9o-a-F0", "Received-SPF": "pass client-ip=57.103.76.13;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Hyper-V always has CPUID[1:EDX].APIC set, even when the APIC isn't enabled yet.\n\nWork around this by also using the APICBASE trap for kernel-irqchip=on.\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n include/system/whpx-common.h | 1 -\n target/i386/whpx/whpx-all.c | 34 ++++++++---------\n target/i386/whpx/whpx-apic.c | 71 ++++++++++++++++++++++++++++++++++--\n 3 files changed, 84 insertions(+), 22 deletions(-)", "diff": "diff --git a/include/system/whpx-common.h b/include/system/whpx-common.h\nindex 3406c20fec..79710e2fb3 100644\n--- a/include/system/whpx-common.h\n+++ b/include/system/whpx-common.h\n@@ -8,7 +8,6 @@ struct AccelCPUState {\n bool interruptable;\n bool ready_for_pic_interrupt;\n uint64_t tpr;\n- uint64_t apic_base;\n bool interruption_pending;\n /* Must be the last field as it may have a tail */\n WHV_RUN_VP_EXIT_CONTEXT exit_ctx;\ndiff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 012fa6d021..b055644580 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -139,7 +139,6 @@ static const WHV_REGISTER_NAME whpx_register_names[] = {\n #ifdef TARGET_X86_64\n WHvX64RegisterKernelGsBase,\n #endif\n- WHvX64RegisterApicBase,\n /* WHvX64RegisterPat, */\n WHvX64RegisterSysenterCs,\n WHvX64RegisterSysenterEip,\n@@ -420,7 +419,6 @@ void whpx_set_registers(CPUState *cpu, WHPXStateLevel level)\n r86 = !(env->cr[0] & CR0_PE_MASK);\n \n vcpu->tpr = cpu_get_apic_tpr(x86_cpu->apic_state);\n- vcpu->apic_base = cpu_get_apic_base(x86_cpu->apic_state);\n \n idx = 0;\n \n@@ -538,9 +536,6 @@ void whpx_set_registers(CPUState *cpu, WHPXStateLevel level)\n vcxt.values[idx++].Reg64 = env->kernelgsbase;\n #endif\n \n- assert(whpx_register_names[idx] == WHvX64RegisterApicBase);\n- vcxt.values[idx++].Reg64 = vcpu->apic_base;\n-\n /* WHvX64RegisterPat - Skipped */\n \n assert(whpx_register_names[idx] == WHvX64RegisterSysenterCs);\n@@ -575,6 +570,12 @@ void whpx_set_registers(CPUState *cpu, WHPXStateLevel level)\n error_report(\"WHPX: Failed to set virtual processor context, hr=%08lx\",\n hr);\n }\n+\n+ if (level >= WHPX_LEVEL_FULL_STATE) {\n+ WHV_REGISTER_VALUE apic_base = {};\n+ apic_base.Reg64 = cpu_get_apic_base(X86_CPU(cpu)->apic_state);\n+ whpx_set_reg(cpu, WHvX64RegisterApicBase, apic_base);\n+ }\n }\n \n static int whpx_get_tsc(CPUState *cpu)\n@@ -666,7 +667,7 @@ void whpx_get_registers(CPUState *cpu, WHPXStateLevel level)\n X86CPU *x86_cpu = X86_CPU(cpu);\n CPUX86State *env = &x86_cpu->env;\n struct whpx_register_set vcxt;\n- uint64_t tpr, apic_base;\n+ uint64_t tpr;\n HRESULT hr;\n int idx;\n int idx_next;\n@@ -798,13 +799,6 @@ void whpx_get_registers(CPUState *cpu, WHPXStateLevel level)\n env->kernelgsbase = vcxt.values[idx++].Reg64;\n #endif\n \n- assert(whpx_register_names[idx] == WHvX64RegisterApicBase);\n- apic_base = vcxt.values[idx++].Reg64;\n- if (apic_base != vcpu->apic_base) {\n- vcpu->apic_base = apic_base;\n- cpu_set_apic_base(x86_cpu->apic_state, vcpu->apic_base);\n- }\n-\n /* WHvX64RegisterPat - Skipped */\n \n assert(whpx_register_names[idx] == WHvX64RegisterSysenterCs);\n@@ -2082,8 +2076,7 @@ int whpx_vcpu_run(CPUState *cpu)\n val = X86_CPU(cpu)->env.apic_bus_freq;\n }\n \n- if (!whpx_irqchip_in_kernel() &&\n- vcpu->exit_ctx.MsrAccess.MsrNumber == MSR_IA32_APICBASE) {\n+ if (vcpu->exit_ctx.MsrAccess.MsrNumber == MSR_IA32_APICBASE) {\n is_known_msr = 1;\n if (!vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite) {\n /* Read path unreachable on Hyper-V */\n@@ -2233,6 +2226,13 @@ int whpx_vcpu_run(CPUState *cpu)\n } else {\n reg_values[2].Reg32 &= ~CPUID_EXT_X2APIC;\n }\n+\n+ /* CPUID[1:EDX].APIC is dynamic */\n+ if (env->features[FEAT_1_EDX] & CPUID_APIC) {\n+ reg_values[3].Reg32 |= CPUID_APIC;\n+ } else {\n+ reg_values[3].Reg32 &= ~CPUID_APIC;\n+ }\n }\n \n /* Dynamic depending on XCR0 and XSS, so query DefaultResult */\n@@ -2804,9 +2804,7 @@ int whpx_accel_init(AccelState *as, MachineState *ms)\n \n memset(&prop, 0, sizeof(WHV_PARTITION_PROPERTY));\n prop.X64MsrExitBitmap.UnhandledMsrs = 1;\n- if (!whpx_irqchip_in_kernel()) {\n- prop.X64MsrExitBitmap.ApicBaseMsrWrite = 1;\n- }\n+ prop.X64MsrExitBitmap.ApicBaseMsrWrite = 1;\n \n hr = whp_dispatch.WHvSetPartitionProperty(\n whpx->partition,\ndiff --git a/target/i386/whpx/whpx-apic.c b/target/i386/whpx/whpx-apic.c\nindex f26ecaf6e8..65629ca45f 100644\n--- a/target/i386/whpx/whpx-apic.c\n+++ b/target/i386/whpx/whpx-apic.c\n@@ -90,9 +90,70 @@ static void whpx_get_apic_state(APICCommonState *s,\n apic_next_timer(s, s->initial_count_load_time);\n }\n \n-static int whpx_apic_set_base(APICCommonState *s, uint64_t val)\n+static int apic_set_base_check(APICCommonState *s, uint64_t val)\n {\n- s->apicbase = val;\n+ /* Enable x2apic when x2apic is not supported by CPU */\n+ if (!cpu_has_x2apic_feature(&s->cpu->env) &&\n+ val & MSR_IA32_APICBASE_EXTD) {\n+ return -1;\n+ }\n+\n+ /*\n+ * Transition into invalid state\n+ * (s->apicbase & MSR_IA32_APICBASE_ENABLE == 0) &&\n+ * (s->apicbase & MSR_IA32_APICBASE_EXTD) == 1\n+ */\n+ if (!(val & MSR_IA32_APICBASE_ENABLE) &&\n+ (val & MSR_IA32_APICBASE_EXTD)) {\n+ return -1;\n+ }\n+\n+ /* Invalid transition from disabled mode to x2APIC */\n+ if (!(s->apicbase & MSR_IA32_APICBASE_ENABLE) &&\n+ !(s->apicbase & MSR_IA32_APICBASE_EXTD) &&\n+ (val & MSR_IA32_APICBASE_ENABLE) &&\n+ (val & MSR_IA32_APICBASE_EXTD)) {\n+ return -1;\n+ }\n+\n+ /* Invalid transition from x2APIC to xAPIC */\n+ if ((s->apicbase & MSR_IA32_APICBASE_ENABLE) &&\n+ (s->apicbase & MSR_IA32_APICBASE_EXTD) &&\n+ (val & MSR_IA32_APICBASE_ENABLE) &&\n+ !(val & MSR_IA32_APICBASE_EXTD)) {\n+ return -1;\n+ }\n+\n+ return 0;\n+}\n+\n+static int apic_set_base(APICCommonState *s, uint64_t val)\n+{\n+ if (apic_set_base_check(s, val) < 0) {\n+ return -1;\n+ }\n+\n+ s->apicbase = (val & MSR_IA32_APICBASE_BASE) |\n+ (s->apicbase & (MSR_IA32_APICBASE_BSP | MSR_IA32_APICBASE_ENABLE));\n+ if (!(val & MSR_IA32_APICBASE_ENABLE)) {\n+ s->apicbase &= ~MSR_IA32_APICBASE_ENABLE;\n+ cpu_clear_apic_feature(&s->cpu->env);\n+ }\n+\n+ /* Transition from disabled mode to xAPIC */\n+ if (!(s->apicbase & MSR_IA32_APICBASE_ENABLE) &&\n+ (val & MSR_IA32_APICBASE_ENABLE)) {\n+ s->apicbase |= MSR_IA32_APICBASE_ENABLE;\n+ cpu_set_apic_feature(&s->cpu->env);\n+ }\n+\n+ /* Transition from xAPIC to x2APIC */\n+ if (cpu_has_x2apic_feature(&s->cpu->env) &&\n+ !(s->apicbase & MSR_IA32_APICBASE_EXTD) &&\n+ (val & MSR_IA32_APICBASE_EXTD)) {\n+ s->apicbase |= MSR_IA32_APICBASE_EXTD;\n+ }\n+\n return 0;\n }\n \n@@ -235,6 +296,10 @@ static void whpx_apic_mem_write(void *opaque, hwaddr addr,\n static const MemoryRegionOps whpx_apic_io_ops = {\n .read = whpx_apic_mem_read,\n .write = whpx_apic_mem_write,\n+ .impl.min_access_size = 1,\n+ .impl.max_access_size = 4,\n+ .valid.min_access_size = 1,\n+ .valid.max_access_size = 4,\n .endianness = DEVICE_LITTLE_ENDIAN,\n };\n \n@@ -262,7 +327,7 @@ static void whpx_apic_class_init(ObjectClass *klass, const void *data)\n \n k->realize = whpx_apic_realize;\n k->reset = whpx_apic_reset;\n- k->set_base = whpx_apic_set_base;\n+ k->set_base = apic_set_base;\n k->set_tpr = whpx_apic_set_tpr;\n k->get_tpr = whpx_apic_get_tpr;\n k->post_load = whpx_apic_post_load;\n", "prefixes": [ "v3", "15/37" ] }