Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226845/?format=api
{ "id": 2226845, "url": "http://patchwork.ozlabs.org/api/patches/2226845/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-34-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-34-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:31", "name": "[PULL,33/48] hw/tpm: add PPI support to tpm-tis-device for ARM64 virt", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69dee4ae13e0fad782a0829c462fbffbff5d5408", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-34-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226845/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=S5aRNVlD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19JB0KL6z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:07:54 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdmW-0004jZ-HE; Wed, 22 Apr 2026 16:02:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdle-00043E-MC\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:01:51 -0400", "from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdlc-0002sX-Fc\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:01:50 -0400", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so58223355e9.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:01:47 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1c01cfsm487687685e9.10.2026.04.22.13.01.43\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:01:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888105; x=1777492905; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=XeUpuJAQM3HlSzusR90k2uWMnZf/9A9CoIWyson6H5w=;\n b=S5aRNVlD/Lm5Yl8ZY6eMj1aa+YCzf/bOse/SHftMyrmMtnkShC/+S9EN6IKwIHemxa\n PA15JmlhAvNyr6xoOTJ2wCqh5EhnpcDtLjaM5V2VumBf9Fl4scdr1bwFYysrCap1zBqz\n HM9x3HGG807DaY3PeF0mH5izwPPalHPeM4G4ZKzH2NiCpFEvKIvyY5uAMltopXdOWEJr\n QdeodnejOEa4eWtfMBK2XpiwCjuCMsxV8+1nyD8dnOsvEsqH7L7HDcQatJAPfiZXPbBx\n RxHwiQ39f9jnSMAWq+EJQzgOxPqTaiaPOguENSoJUHtoLylbLxS6ylIQmWfT5mL6IaUJ\n ea3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888105; x=1777492905;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=XeUpuJAQM3HlSzusR90k2uWMnZf/9A9CoIWyson6H5w=;\n b=s+4ikJ3iOVcAGi73+A/SBAst0VixkwqBV43DQo3YsnHwtxJBSBGIkvG1rKtY1ZFNa7\n AyDRki+VBONaotvKxlMLJYxeoE+Fqri2LMuybUoJyfR1QzcXzApJeQfr9FVTdHEXQfr1\n Vv0ia9DbvXpWCgltCayygBFH36LD4wnnTjFqohYSRWqdQvQ8QDXvW2+3BYOn6VFT371u\n Vc8P+Uifhy1kv5krHXHQIO0ih22WO0fiwqNpjBum9fV7fAySirpMG0MMPaEzDNQFAgoV\n j7VtnpQfw+vtGQaZV6wTPMPJJWtx64fpDJZDgEPjivBFb5t6mW8U/Fq1AFw+iY619g5G\n ABBA==", "X-Gm-Message-State": "AOJu0Yxb7mhTvnxm9J0mSefickQd6QV9nZ71hh83tjUdyiRzy/pJPKTd\n H3Xv7Fr+jZRIXr38LVUR20OHiPXdixhhOqp1Vtgeso90CTIauel3sCauHz0M6KtaDArJZ9qAH4K\n TaUdc+kk=", "X-Gm-Gg": "AeBDievlT3wrA+TV8thLtpVokGDSweTMJiIX3yX8BZM4HkBqp6WDHLEFupHnfPV9X9t\n lTgBOavktUQV7rjKav37XDiSc7nHq1mS9Hkygd/qkDYGfB5HVqxIpNJxoA5LKbytTmFHURdqDDi\n 0GyyOofsI1Hqs5/dVEFqMEUFjonynlfxu0StLft/EWXKSihaFHYalH099GhiF1rEIMQsl8RxNqn\n cwYGI37cWhY7ZOlriSooZSwD0sO803AdKMLzG3yDkLLHdyoBjRmwbydJKGR77DGkbXOMEhdhR1x\n N6Sotfswx2ccS65U9cnH4SvUx9Uphk1+3bUlAsayqyN2EOQvQc9nqhnSkOeU46SJIY7o28Zl3DO\n zlckhlJaWVOOtznjWBKvU98i6xiviRy2ZNZZzWO9m4IrrH7xt+J6b6Hrl74h3iXU3t7uSeE0O7x\n 1xYgAjsPN5+0YmRfNBznW7+rZn0k7c+wXoF4WmDF6Y0BE7NWYQiwKZn655lj6lUVGvWzJ6F+VKm\n PDUmWlg4Zw=", "X-Received": "by 2002:a05:600c:4f8c:b0:48a:58ae:993b with SMTP id\n 5b1f17b1804b1-48a58ae9faemr109182805e9.16.1776888104803;\n Wed, 22 Apr 2026 13:01:44 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 33/48] hw/tpm: add PPI support to tpm-tis-device for ARM64 virt", "Date": "Wed, 22 Apr 2026 21:57:31 +0200", "Message-ID": "<20260422195746.88865-34-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Mohammadfaiz Bawa <mbawa@redhat.com>\n\nAdd PPI memory region and ACPI _STA, _DSM to tpm-tis-sysbus so\nWindows 11 ARM64 guests no longer log Event ID 15 errors from\ntpm.sys on every boot.\n\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\nSigned-off-by: Mohammadfaiz Bawa <mbawa@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nMessage-ID: <20260327173209.148180-4-mbawa@redhat.com>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/arm/virt-acpi-build.c | 9 ++++++++-\n hw/tpm/tpm_tis_sysbus.c | 11 +++++++++++\n 2 files changed, 19 insertions(+), 1 deletion(-)", "diff": "diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c\nindex 591cfc993c6..5b5ac551f8c 100644\n--- a/hw/arm/virt-acpi-build.c\n+++ b/hw/arm/virt-acpi-build.c\n@@ -240,7 +240,8 @@ static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms)\n Aml *dev = aml_device(\"TPM0\");\n aml_append(dev, aml_name_decl(\"_HID\", aml_string(\"MSFT0101\")));\n aml_append(dev, aml_name_decl(\"_STR\", aml_string(\"TPM 2.0 Device\")));\n- aml_append(dev, aml_name_decl(\"_UID\", aml_int(0)));\n+ aml_append(dev, aml_name_decl(\"_UID\", aml_int(1)));\n+ aml_append(dev, aml_name_decl(\"_STA\", aml_int(0xF)));\n \n Aml *crs = aml_resource_template();\n aml_append(crs,\n@@ -248,6 +249,12 @@ static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms)\n (uint32_t)memory_region_size(sbdev_mr),\n AML_READ_WRITE));\n aml_append(dev, aml_name_decl(\"_CRS\", crs));\n+\n+ hwaddr ppi_base = platform_bus_get_mmio_addr(pbus, sbdev, 1);\n+ if (ppi_base != -1) {\n+ ppi_base += pbus_base;\n+ tpm_build_ppi_acpi(TPM_IF(sbdev), dev, ppi_base);\n+ }\n aml_append(scope, dev);\n }\n #endif\ndiff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c\nindex dd30344d5ac..6bec30c36fc 100644\n--- a/hw/tpm/tpm_tis_sysbus.c\n+++ b/hw/tpm/tpm_tis_sysbus.c\n@@ -30,6 +30,7 @@\n #include \"hw/core/sysbus.h\"\n #include \"tpm_tis.h\"\n #include \"qom/object.h\"\n+#include \"qemu/memalign.h\"\n \n struct TPMStateSysBus {\n /*< private >*/\n@@ -99,6 +100,7 @@ static void tpm_tis_sysbus_initfn(Object *obj)\n {\n TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(obj);\n TPMState *s = &sbdev->state;\n+ size_t host_page_size = qemu_real_host_page_size();\n \n memory_region_init_io(&s->mmio, obj, &tpm_tis_memory_ops,\n s, \"tpm-tis-mmio\",\n@@ -106,6 +108,12 @@ static void tpm_tis_sysbus_initfn(Object *obj)\n \n sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);\n sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq);\n+\n+ s->ppi.buf = qemu_memalign(host_page_size,\n+ ROUND_UP(TPM_PPI_ADDR_SIZE, host_page_size));\n+ memory_region_init_ram_device_ptr(&s->ppi.ram, obj, \"tpm-ppi\",\n+ TPM_PPI_ADDR_SIZE, s->ppi.buf);\n+ sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->ppi.ram);\n }\n \n static void tpm_tis_sysbus_realizefn(DeviceState *dev, Error **errp)\n@@ -122,6 +130,8 @@ static void tpm_tis_sysbus_realizefn(DeviceState *dev, Error **errp)\n error_setg(errp, \"'tpmdev' property is required\");\n return;\n }\n+\n+ vmstate_register_ram(&s->ppi.ram, dev);\n }\n \n static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data)\n@@ -132,6 +142,7 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data)\n device_class_set_props(dc, tpm_tis_sysbus_properties);\n dc->vmsd = &vmstate_tpm_tis_sysbus;\n tc->model = TPM_MODEL_TPM_TIS;\n+ tc->ppi_enabled = true;\n dc->realize = tpm_tis_sysbus_realizefn;\n device_class_set_legacy_reset(dc, tpm_tis_sysbus_reset);\n tc->request_completed = tpm_tis_sysbus_request_completed;\n", "prefixes": [ "PULL", "33/48" ] }