Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226842/?format=api
{ "id": 2226842, "url": "http://patchwork.ozlabs.org/api/patches/2226842/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-40-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-40-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:37", "name": "[PULL,39/48] ati-vga: mask out lock bit from CUR_OFFSET in cursor offset calculation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "083c16d3ae22e1a3db991289c314996f684c56ad", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-40-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226842/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=WD27lh2H;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19HK1sF2z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:07:09 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdmi-0005sG-MV; Wed, 22 Apr 2026 16:02:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdmO-0004jd-UU\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:42 -0400", "from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdmK-0003SH-DM\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:35 -0400", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-488d2079582so69044835e9.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:02:28 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4891c318636sm267252785e9.7.2026.04.22.13.02.25\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:02:25 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888146; x=1777492946; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=pGnenDifjZmzk41jK6DgouChFTKo2hRmu0GnXG1NcYs=;\n b=WD27lh2HevIww0OEyLa5om0jGcXZ64Va9czvRSW3veUzB4CpxRm9mr7kT/eoqxYpjA\n SA6P97xxh8Arcy8p0c5/mytjRFi96zGICAvzYKGPuVH33yv8LyKXNv/Jb+gt85L08izA\n yn5WHds3ZqDOlQYy2IiT+4Q+yMuwmEiaxFtRhnVnAu7ubly89esVRudwW8NQhHIIhGds\n TmCvcZ2fLHDIEQuwqN4nNVYw07TUf9ueH9YRYFPxckIDcIYdAfzxdqrsc7wsgTf1orMY\n tP/SMrRJXdOA1AvbnUo5ePM4NOvpeXRsRGX/gq4RjUYUZV++lqc8wgRDv2KVrVYqhWFk\n pvog==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888146; x=1777492946;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=pGnenDifjZmzk41jK6DgouChFTKo2hRmu0GnXG1NcYs=;\n b=rSiCqe8s6saV02/bkVVBxeFgJUguKA4s8GCjTsVI/E6KHhon21/EdC4E0HOEap2rt7\n ynO395T5GaHCxiJJ6S2yyCmsJ9oOlSJsGgKqJ6J3FOyCIC5ZBpVBXG5VzSpYw2SAPj3z\n 3hFABC7oeZahjp9lploU1LRPfxYjA238WzSOIC68qKcRk8rp44lkXpIPjIxLpdTVxCbu\n 2a/haELl1IPUfZGgeugqEYr5NCztsRKVgC3EeniYagIAwfB09x7opVW1MX/ZxnbakDfI\n wgq4WZ9Qb43aB/B3mZ+zZS7ntwwjOWaS/+OSN1KVYt3LRRCQUoPxxm4cNKvgpIEZa/5O\n yogw==", "X-Gm-Message-State": "AOJu0YwtvHt+cSpI/GuBY8ej3fv6l9Djm76UFszIE70lJ6i7Z8wSRwGw\n mbdueT7zS8QNrDJh/xAArcSgYoGbnehBnEFk7ywx52XKIwZdZgyNO5eTcpSoBPakEMmTYQ27XFU\n 4d04+dq4=", "X-Gm-Gg": "AeBDiet3TaTJv0Uyf6QiS0E827ZogUKNQdKTkgIpAJXLD2MpJSAjSyEjIXKPUkHlNML\n Hw3a9DJ+GkTtNSnBntOeGbep7RkOUQzlOVUvoRbQHz4cYqIq9Q0DiPJ4yI0Oo5r+sTcCMGF48I7\n WMPcHS/NEgsafzS2lse1AIBq2DU+9zz4DHwog0Y/smkjqXQP0On5haX/w8yRMCe3oWxsnfOH8jW\n rChOxhjsyv5VKodbIDxcLk7X19/I+XORx6R/xx0MOt5QXcVK4gP+OnrnlgIzMcjL/B71l4YZt/p\n /uJgrLsIL9gl5pVF1FdAHPOKc7VcGvQs/Hk33tU6NgBOBt9vXrALSbz65xEkeyk3iikYKqeYLcz\n aXXVSF+NAJM+2jMOOb9EKgUHwZS3sF6II/00DhUp3l2KAiUWFLuVgLQ/eI+5Q9NIX6VkEB/9L+6\n la/dtPF0ZZiSRQUAhtsh3I+bMIDi0FsD7YQVQv5mSAOFprB6rFF2d3b9R4Ils6xWJ31ayUzCcSR\n jh1r2pEybM=", "X-Received": "by 2002:a05:600c:1993:b0:489:e696:836f with SMTP id\n 5b1f17b1804b1-489e69686a7mr183865625e9.10.1776888146326;\n Wed, 22 Apr 2026 13:02:26 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 39/48] ati-vga: mask out lock bit from CUR_OFFSET in cursor\n offset calculation", "Date": "Wed, 22 Apr 2026 21:57:37 +0200", "Message-ID": "<20260422195746.88865-40-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Junjie Cao <junjie.cao@intel.com>\n\nBit 31 of CUR_OFFSET is the cursor lock bit, not part of the actual\ncursor address (bits 26:4). Although the callers already check for the\nlock bit and return early, mask it out with 0x07fffff0 when computing\nthe cursor source offset so the calculation only uses the address bits.\n\nSuggested-by: BALATON Zoltan <balaton@eik.bme.hu>\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\nMessage-ID: <20260414213523.1125859-2-junjie.cao@intel.com>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/display/ati.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 0489995d00b..3a7d45a8820 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -147,7 +147,7 @@ static void ati_cursor_define(ATIVGAState *s)\n return; /* Do not update cursor if locked or rendered by guest */\n }\n /* FIXME handle cur_hv_offs correctly */\n- srcoff = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ srcoff = (s->regs.cur_offset & 0x07fffff0) - (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n if (srcoff > s->vga.vram_size - 64 * 16) {\n return;\n@@ -176,13 +176,15 @@ static void ati_cursor_invalidate(VGACommonState *vga)\n if (s->cursor_size != size ||\n vga->hw_cursor_x != s->regs.cur_hv_pos >> 16 ||\n vga->hw_cursor_y != (s->regs.cur_hv_pos & 0xffff) ||\n- s->cursor_offset != s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ s->cursor_offset != (s->regs.cur_offset & 0x07fffff0) -\n+ (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16) {\n /* Remove old cursor then update and show new one if needed */\n vga_invalidate_scanlines(vga, vga->hw_cursor_y, vga->hw_cursor_y + 63);\n vga->hw_cursor_x = s->regs.cur_hv_pos >> 16;\n vga->hw_cursor_y = s->regs.cur_hv_pos & 0xffff;\n- s->cursor_offset = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ s->cursor_offset = (s->regs.cur_offset & 0x07fffff0) -\n+ (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n s->cursor_size = size;\n if (size) {\n", "prefixes": [ "PULL", "39/48" ] }