Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226840/?format=api
{ "id": 2226840, "url": "http://patchwork.ozlabs.org/api/patches/2226840/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-39-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-39-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:36", "name": "[PULL,38/48] ati-vga: fix unsigned integer overflow in cursor bounds checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cddd3feba53abe88b4ad029eb6946793d549d038", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-39-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226840/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226840/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Gvoey9Iy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19Gr641fz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:06:44 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdml-0006JK-J4; Wed, 22 Apr 2026 16:02:59 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdmA-0004cv-Su\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:28 -0400", "from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdm9-0003Nj-Cc\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:22 -0400", "by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso65391315e9.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:02:20 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb79ecb9sm196110925e9.8.2026.04.22.13.02.18\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:02:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888140; x=1777492940; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=RTP8G/3syFvWMTvC3Oy537xBcJoeDL0PeXldlkypUIc=;\n b=Gvoey9IyQXd2lSiVm+eAif12FzuPuDs+xHv0ixCT+1c9RBXK5pUwhIRt1zAY3nDcQM\n q7p+PpucF7vAzUUsk7yNCO9PgJNUw0w4H5PxA2vjoQjTx5N/byI0MHxMHUgd1rXxxng4\n r/Vt1y+d4C6dgeHpq7be9tEK9X25mIFlnCQXIUrhlzlO+iV17/MSHZCu7MUcZe4y5G84\n FYv0DQv1zCWQ8jINY262UC41Eqjd40XJsej+JNDVGmLCeveVL/7k1g4lECET7e2HytRC\n RW+mBeUmHU7EULufPUzY6D5s8pz52h/sg+6QQuwDG4ilomVT20bq/YkiO6KK8p0stbgl\n GnGQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888140; x=1777492940;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=RTP8G/3syFvWMTvC3Oy537xBcJoeDL0PeXldlkypUIc=;\n b=jQVqy8dzx0RIzC1RerTz9BslQxCsJtARhiQg1iqEi5VFCfoXnL+5R7QdJgF1DOFTLw\n Dmj6foq7/E8XBcjKr7EhGd7p8Z53/YEIW6RS7CeNDQYXpabKRMwMVwFvcziRGfUT9sOP\n oBLyN91ACacHVstAJJF58kwX1YxkQ9fHfKftugRy+BZMztXfBg47nl6IFFe9BY4MxujG\n D3WSztMbTYCakr9WuzwhFdZ1mTsRWtqj3ZPovDntvTSoab5g1bZZtnM7eA9YPVNcwHFe\n c8D33zMbHLql/s6+RoEB+dMMmyofla6Z7c5q90jF+vb7ahP8Y8CsCyuutsL/0T6DQuDH\n mUGw==", "X-Gm-Message-State": "AOJu0YwiVisCYLaaY++lBYvWdE+2hWgz0fIH/0e6sjuwXWf7jUwhr8Cr\n +68T7pAU9z01mBTfhThL9CMjXK9ZLvsZ3M84F1OiT2edaZTcBw8c3YRIUmBycBGXM2NWgkQWqqx\n uLyhA47U=", "X-Gm-Gg": "AeBDieuAoxrGLgAsAwr/0I1ieadJYpGekYuVJC80cRr20E4LBo4UaThvZyGnW7a2cJP\n Ye6banVb6qF8vaMSn6CE+G76o9XUijTcHi2AXTfkRtTN0s1ABDta7u3/yOtw0+6U0eU5CFzDT1q\n PxwcFovNJ0RC2u4FqEkQJy7d2hrGSFan4ioVhKt2XnInzMiCffCQPdbryEhg+wirgqSX+XTgUBo\n B/XjYbN+ufpMpcZCr+/0u/PHs6LHuKkFdlhBL5XeczdAla60aDBvN9pJQ7hc9FD0Rp5KdxgEaUi\n y7qvC5kpyXlF+AKF7YPopU1nwS5Dskt2eOcDYKlMXjEYYmwbZLDnNVWk4yJhH7OjZMWzGhucfmf\n rhaJJvUZhqB8HqGw9zHdG84lfHi7dxehryrW0y93RrutAKWFQD/KHU+hrWxbTERhILNRouW0wTB\n O7llunbCHQKV1nWZeGf3d1PAxUSgQQDSC2G3oXJLfFF4TwO5AmYCnd+nCgPDxMet4FAtbtjCcyC\n xBKK0Crjok=", "X-Received": "by 2002:a05:600c:8586:b0:489:e49:f766 with SMTP id\n 5b1f17b1804b1-4890e49f7d8mr161664245e9.17.1776888139542;\n Wed, 22 Apr 2026 13:02:19 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 38/48] ati-vga: fix unsigned integer overflow in cursor bounds\n checks", "Date": "Wed, 22 Apr 2026 21:57:36 +0200", "Message-ID": "<20260422195746.88865-39-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Junjie Cao <junjie.cao@intel.com>\n\nThe cursor bounds checks compare (srcoff + N) against vram_size, but\nboth sides are uint32_t so the addition can wrap past UINT32_MAX when\nsrcoff underflows from the cur_hv_offs subtraction, causing the check\nto be bypassed.\n\nRewrite the checks as (srcoff > vram_size - N) to avoid the\noverflow-prone addition, matching the style already used in\nati_mm_read() and ati_mm_write().\n\nCc: qemu-stable@nongnu.org\nFixes: 2f1fbe6ee9b5 (\"ati-vga: Make sure hardware cursor data is within vram\")\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\nMessage-ID: <20260414141458.1076014-1-junjie.cao@intel.com>\nReviewed-by: BALATON Zoltan <balaton@eik.bme.hu>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n hw/display/ati.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 88a5bbbf07a..0489995d00b 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -149,7 +149,7 @@ static void ati_cursor_define(ATIVGAState *s)\n /* FIXME handle cur_hv_offs correctly */\n srcoff = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n- if (srcoff + 64 * 16 > s->vga.vram_size) {\n+ if (srcoff > s->vga.vram_size - 64 * 16) {\n return;\n }\n for (int i = 0; i < 64; i++, srcoff += 16) {\n@@ -206,7 +206,7 @@ static void ati_cursor_draw_line(VGACommonState *vga, uint8_t *d, int scr_y)\n }\n /* FIXME handle cur_hv_offs correctly */\n srcoff = s->cursor_offset + (scr_y - vga->hw_cursor_y) * 16;\n- if (srcoff + 16 > s->vga.vram_size) {\n+ if (srcoff > s->vga.vram_size - 16) {\n return;\n }\n dp = &dp[vga->hw_cursor_x];\n", "prefixes": [ "PULL", "38/48" ] }