Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226835/?format=api
{ "id": 2226835, "url": "http://patchwork.ozlabs.org/api/patches/2226835/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-35-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-35-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:32", "name": "[PULL,34/48] physmem: Simplify dirty memory type checks with loop", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1a27096af6942f13f3a143c5de3edcbb67b603a7", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-35-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226835/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NbJiySVc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19CV5wwLz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:03:50 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdmh-0005eH-5R; Wed, 22 Apr 2026 16:02:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdlk-0004C1-MM\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:01:58 -0400", "from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdlh-00030G-RD\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:01:55 -0400", "by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488b3f8fa2bso61245335e9.1\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:01:53 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc1393f5sm437734615e9.9.2026.04.22.13.01.50\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:01:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888112; x=1777492912; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=XxTSWpAH8tY0MN9ilU96vSF7le76N/8yRt/4jboOEtI=;\n b=NbJiySVcpHHcDdapHKdEpVtf3KJ37AHphERUi7v1q6ttzBJ40hcF5iRP52t4llqo72\n YqSIcbBrubtxG8j35TcN2IX65y1HYGTS0ZQEjkKfSsbyJzlqVf8mVHJI+LyOY+wAUbTf\n 1cDC7olwpNFG3L4t8N0r9LIXhMNnNqZcVaGdhI1950cl7hCf3MBHViqhDRLvVsSovzHa\n sEeEW4wrm2M2OOM1szFNvAXW5doLFFaYF+P4XSs4Uo1zszuwM35pd4z2atYP689Gk31H\n +qSqOiml+qT4EI+iSlh3vY8gbZsAngafgL2xwgKFNknZpLiEekRFCRO7/OemeEzjtdo5\n gCjA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888112; x=1777492912;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=XxTSWpAH8tY0MN9ilU96vSF7le76N/8yRt/4jboOEtI=;\n b=UGPOCwPRmxR3sfXl+2A86a+W3iKBLUmAzE44pTGwa17m2A3S4hSIZmYv9hN74XB2RW\n WpeJv8CbwPvHpwXss0+JHmsCcLaanT/uoNhKRBZV8FaqEvnIfRE7RCP72d3gQQUBF5Nm\n kmBkNlOlQiWXcS3FpVepYmVIDdPHxYVX2Yx/bslnWs2ao3STmGLAFEw4g48BLNzrOZAK\n ReKVjgjw0mK36i0lVOT3Ji9wlebWwhis3X6K8wGdbyOEHzFvxKIE1o+HBNwWkm2KxDxK\n gyMKDMUDcHL3K+LmPEU9w8+yYBQyGm3SskQze9mbPDyTLIDt5siFeZpn6wkgSrvlTDch\n nXrA==", "X-Gm-Message-State": "AOJu0YwNKJ1WCQd6A6k95LfdepAyDhcME1Flcc2jgVTsc9BNSiZMqk2v\n 2haA1o1UUjn2/1gdqIm86KJvxyHTMKNVoaygwJEWdsiZknNxs5hoBfEdNEiOXTzhGXx22eioLnw\n 3dVCdwho=", "X-Gm-Gg": "AeBDievKL/zMcCgng8kV3KTup7Lx5BjGGYc5FGqlPvDjt1VbSX57xVDYezE/OLdyRQX\n on3hLVKgLwlU4LQVSGNIl3xSZtqCZC+D/GyTRoh94N7BK+GH58n9rYtNlk3VpKcyQj8XgvFQ3BK\n QDSOn/UYk9vzPChU9QBiFYdwAGNIzyos8JaPJPJvWoQMJLZOvwqf0u8nGv/YJYgnHclFgmrB/XC\n y04cekKqTdp0GGozEnttdBzO4UNPETbH9TSUaW/LFkUdt1o5KDuFF8AKqcQgoeARV9LhyriaP4c\n x/6fLlTr1Os8lTeKuXhPkXT22H/t24cCtCeTumYveL5cAFgaocC5OqwQKHHS7UmyzGHOJbFFftc\n z8e55PsTdkNdOnoIGNWnNXAoaOV4R622bA42qApY76dB1O6rJ+PAK1byxUtqAdxsPr4zjhpt2UL\n aFIThUxeI0OaTvPITP2+s4KzYOIDa3EEemd+nD88i8hJCUx4znwpUhgblgqLEfuFC+Q4Wjx8+IU\n aCHwzyokw4=", "X-Received": "by 2002:a05:600c:c112:b0:486:fe83:861c with SMTP id\n 5b1f17b1804b1-488fb896910mr276046575e9.7.1776888112032;\n Wed, 22 Apr 2026 13:01:52 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 34/48] physmem: Simplify dirty memory type checks with loop", "Date": "Wed, 22 Apr 2026 21:57:32 +0200", "Message-ID": "<20260422195746.88865-35-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Bin Guo <guobin@linux.alibaba.com>\n\nIn physical_memory_range_includes_clean(), we have three nearly identical\nif-statements checking different DIRTY_MEMORY types (VGA, CODE, MIGRATION).\nThis code duplication makes maintenance harder and increases the risk of\ninconsistencies when adding new dirty memory types.\n\nReplace the repetitive checks with a simple loop that iterates through\nall DIRTY_MEMORY_NUM types, checking only those specified in the mask.\nThis reduces code size and makes it easier to add new dirty memory types\nin the future.\n\nSigned-off-by: Bin Guo <guobin@linux.alibaba.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nMessage-ID: <20260401100005.20651-1-guobin@linux.alibaba.com>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n system/physmem.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/system/physmem.c b/system/physmem.c\nindex 4e26f1a1d42..c58d940e807 100644\n--- a/system/physmem.c\n+++ b/system/physmem.c\n@@ -981,17 +981,11 @@ uint8_t physical_memory_range_includes_clean(ram_addr_t start,\n {\n uint8_t ret = 0;\n \n- if (mask & (1 << DIRTY_MEMORY_VGA) &&\n- !physical_memory_all_dirty(start, length, DIRTY_MEMORY_VGA)) {\n- ret |= (1 << DIRTY_MEMORY_VGA);\n- }\n- if (mask & (1 << DIRTY_MEMORY_CODE) &&\n- !physical_memory_all_dirty(start, length, DIRTY_MEMORY_CODE)) {\n- ret |= (1 << DIRTY_MEMORY_CODE);\n- }\n- if (mask & (1 << DIRTY_MEMORY_MIGRATION) &&\n- !physical_memory_all_dirty(start, length, DIRTY_MEMORY_MIGRATION)) {\n- ret |= (1 << DIRTY_MEMORY_MIGRATION);\n+ for (int i = 0; i < DIRTY_MEMORY_NUM; i++) {\n+ if ((mask & (1 << i)) &&\n+ !physical_memory_all_dirty(start, length, i)) {\n+ ret |= (1 << i);\n+ }\n }\n return ret;\n }\n", "prefixes": [ "PULL", "34/48" ] }