Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226823/?format=api
{ "id": 2226823, "url": "http://patchwork.ozlabs.org/api/patches/2226823/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-37-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-37-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:34", "name": "[PULL,36/48] hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/ header", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "13693075255ee99b9dd7b54f5817383cc300913b", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-37-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226823/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bxRu+Pf/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19BV0FrCz1yHF\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:02:58 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdmc-0004th-HZ; Wed, 22 Apr 2026 16:02:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdlx-0004Sh-SR\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:11 -0400", "from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdlw-0003HI-0g\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:02:09 -0400", "by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-4891e86fabeso51121075e9.1\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:02:07 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4ffa8sm49166042f8f.35.2026.04.22.13.02.04\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:02:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888126; x=1777492926; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=7YIc9Uus+72qElGOAoitBrtXHx1hU376Lko1zKcoR6E=;\n b=bxRu+Pf/b96AcNdGrAC0Qh2L7gZwjrJy8sbwTGS6VjlN0s3NwW/cjAmmiyLs0MZnfB\n 9JLvwciKiCbN1J/5NKRO6QhwxcLLR4KqXFKQWY9lg2XpEbxjr/ldK5siZ+HwvlfGkklz\n 36rpKqIf+d1ZaSAvuD+m0A30gAnnJaICxjWSnmtNXOICivveRGCs1NPcH5o1A6i4+0yy\n X5N2QKUJ+9QU7nDOTuhuU+NJJqj2Oybt8+AEgZGbBD/De1oRpnyhvxvhgPbB5zIFZq7a\n J6dXEwuMdB4zYfxxO1zwb0wWYQvpB6otBF/ePUTXJTbRLl6ts0EHzmeOZpRfREjrCzV4\n I2zQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888126; x=1777492926;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=7YIc9Uus+72qElGOAoitBrtXHx1hU376Lko1zKcoR6E=;\n b=FhWw4pTbbWXvpcqdtVwvP5d5+hQmHwkhrOiCr/lfReC9+TPYhR4bDsC1hTQGqJFOHD\n SRMaFqlIFj9do6Yw2ptBg+Q52HfTad7devRGvBmBJ/q+HEbeZ/uEjWbCmeIgsKGFwQlJ\n QbE2Rb1YSokbN9qa38KLmzYISMnfcnSmShlqe2cSHhltnVM4tIrVuHqoOxFMGayP/RGz\n 3I9Coau6Hz/0Vvk/c2aAItuZloErec0SL6mAUgqcNvSmoHcXUdWpfCbq/bBi0Ofdlx1M\n 3KQk76PTmj7Iv2+Y3oyd6jGeQB1IKLv6EgAgpJaxSozyBOOdu64St4RfJmNljiYA2WXd\n 1law==", "X-Gm-Message-State": "AOJu0YwqQCjUsXiV1X318BQkns8HcxhMkzUJay2ep1cvFJKGgSMsXkDz\n 9M2BSuuI23TVcyj72xiJDMSb/Pz+9wX/ouiGUehsXwxC0H6jD5wh5/lGLXQVmtCLm4drkmmoLKn\n Q7Hcy5YM=", "X-Gm-Gg": "AeBDiesM95p6J1yF/qWUcCgIXep8sl2TTtRVe/TMT1u3C3n/20pqIbCi5rAHLgW5O4Z\n RqcdpAashTwrlmtcakF/AXymDTUQC9V80Si0I50WWoDIkGv36sF0/adn8D5QYkrrMbQIJlEMgcH\n gtSWl3x3cHTG0AlhufpHxao03B7+w0MbTqAZMeG+Ii9GoryguCvW0epGqOwLQ8EmlsI6reLu5UC\n U0+Z+c7I7jmeTDDhwoEWRWIbo7a2OWNGHt4gYLl6Ue8FKRy6jBSWx5kI7B5Bl1MxusZBx86sH2a\n 7R6TjreuMCMVnhxTHkrlNDpCcufylq62tDSdqVUJ7h7V82D9soja+jRhftavYdr2Id78sPeDNoe\n omBSAL1CYlt0OcM3lYJDLgpg4sQqKMcdO7UFRYpZ2iykFiuG1uBB/A1PSoxaVR3uaJ7zh6i88Wi\n N+jZse2MBeqKK8mMXPZSZ45N32tXA0VN4xwXv05Gu8PeNByK2b3ZYsAvkCiRgSOeaiWwTSpfPL0\n G7AROnd6BQ=", "X-Received": "by 2002:a05:600c:620c:b0:488:ae6c:42c6 with SMTP id\n 5b1f17b1804b1-488fb7786c2mr359567175e9.14.1776888125815;\n Wed, 22 Apr 2026 13:02:05 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 36/48] hw/arm/smmuv3: Avoid including CONFIG_DEVICES in hw/\n header", "Date": "Wed, 22 Apr 2026 21:57:34 +0200", "Message-ID": "<20260422195746.88865-37-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "By turning the inline functions into stubs we can avoid the\nuse of target-specific CONFIG_DEVICES include in a hw/ header,\nallowing to build the source files including it as common objects.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Thomas Huth <thuth@redhat.com>\nReviewed-by: Shameer Kolothum <skolothumtho@nvidia.com>\nMessage-Id: <20260410200031.18572-3-philmd@linaro.org>\n---\n hw/arm/smmuv3-accel.h | 42 ------------------------------\n hw/arm/smmuv3-accel-stubs.c | 52 +++++++++++++++++++++++++++++++++++++\n hw/arm/meson.build | 5 ++--\n 3 files changed, 55 insertions(+), 44 deletions(-)\n create mode 100644 hw/arm/smmuv3-accel-stubs.c", "diff": "diff --git a/hw/arm/smmuv3-accel.h b/hw/arm/smmuv3-accel.h\nindex 1ca2c80a933..85669d0e00e 100644\n--- a/hw/arm/smmuv3-accel.h\n+++ b/hw/arm/smmuv3-accel.h\n@@ -14,7 +14,6 @@\n #ifdef CONFIG_LINUX\n #include <linux/iommufd.h>\n #endif\n-#include CONFIG_DEVICES\n \n /*\n * Represents an accelerated SMMU instance backed by an iommufd vIOMMU object.\n@@ -41,7 +40,6 @@ typedef struct SMMUv3AccelDevice {\n SMMUv3AccelState *s_accel;\n } SMMUv3AccelDevice;\n \n-#ifdef CONFIG_ARM_SMMUV3_ACCEL\n bool smmuv3_accel_init(SMMUv3State *s, Error **errp);\n bool smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n Error **errp);\n@@ -53,45 +51,5 @@ bool smmuv3_accel_issue_inv_cmd(SMMUv3State *s, void *cmd, SMMUDevice *sdev,\n void smmuv3_accel_idr_override(SMMUv3State *s);\n bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp);\n void smmuv3_accel_reset(SMMUv3State *s);\n-#else\n-#include \"qapi/error.h\"\n-static inline bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n-{\n- error_setg(errp, \"accel=on support not compiled in\");\n- return false;\n-}\n-static inline bool\n-smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n- Error **errp)\n-{\n- return true;\n-}\n-static inline bool\n-smmuv3_accel_install_ste_range(SMMUv3State *s, SMMUSIDRange *range,\n- Error **errp)\n-{\n- return true;\n-}\n-static inline bool smmuv3_accel_attach_gbpa_hwpt(SMMUv3State *s, Error **errp)\n-{\n- return true;\n-}\n-static inline bool\n-smmuv3_accel_issue_inv_cmd(SMMUv3State *s, void *cmd, SMMUDevice *sdev,\n- Error **errp)\n-{\n- return true;\n-}\n-static inline void smmuv3_accel_idr_override(SMMUv3State *s)\n-{\n-}\n-static inline bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp)\n-{\n- return true;\n-}\n-static inline void smmuv3_accel_reset(SMMUv3State *s)\n-{\n-}\n-#endif\n \n #endif /* HW_ARM_SMMUV3_ACCEL_H */\ndiff --git a/hw/arm/smmuv3-accel-stubs.c b/hw/arm/smmuv3-accel-stubs.c\nnew file mode 100644\nindex 00000000000..70cef66966a\n--- /dev/null\n+++ b/hw/arm/smmuv3-accel-stubs.c\n@@ -0,0 +1,52 @@\n+/*\n+ * Stubs for accelerated SMMU instance backed by an iommufd vIOMMU object.\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"qapi/error.h\"\n+#include \"hw/arm/smmuv3.h\"\n+#include \"hw/arm/smmuv3-accel.h\"\n+\n+bool smmuv3_accel_init(SMMUv3State *s, Error **errp)\n+{\n+ error_setg(errp, \"accel=on support not compiled in\");\n+ return false;\n+}\n+\n+bool smmuv3_accel_install_ste(SMMUv3State *s, SMMUDevice *sdev, int sid,\n+ Error **errp)\n+{\n+ return true;\n+}\n+\n+bool smmuv3_accel_install_ste_range(SMMUv3State *s, SMMUSIDRange *range,\n+ Error **errp)\n+{\n+ return true;\n+}\n+\n+bool smmuv3_accel_attach_gbpa_hwpt(SMMUv3State *s, Error **errp)\n+{\n+ return true;\n+}\n+\n+bool smmuv3_accel_issue_inv_cmd(SMMUv3State *s, void *cmd, SMMUDevice *sdev,\n+ Error **errp)\n+{\n+ return true;\n+}\n+\n+void smmuv3_accel_idr_override(SMMUv3State *s)\n+{\n+}\n+\n+bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp)\n+{\n+ return true;\n+}\n+\n+void smmuv3_accel_reset(SMMUv3State *s)\n+{\n+}\ndiff --git a/hw/arm/meson.build b/hw/arm/meson.build\nindex b187b946f04..3be1252c4f1 100644\n--- a/hw/arm/meson.build\n+++ b/hw/arm/meson.build\n@@ -84,8 +84,9 @@ arm_common_ss.add(when: 'CONFIG_ARMSSE', if_true: files('armsse.c'))\n arm_common_ss.add(when: 'CONFIG_FSL_IMX7', if_true: files('fsl-imx7.c', 'mcimx7d-sabre.c'))\n arm_common_ss.add(when: 'CONFIG_FSL_IMX8MP', if_true: files('fsl-imx8mp.c'))\n arm_common_ss.add(when: 'CONFIG_FSL_IMX8MP_EVK', if_true: files('imx8mp-evk.c'))\n-arm_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmuv3.c'))\n-arm_ss.add(when: 'CONFIG_ARM_SMMUV3_ACCEL', if_true: files('smmuv3-accel.c'))\n+arm_common_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmuv3.c'))\n+arm_common_ss.add(when: 'CONFIG_ARM_SMMUV3_ACCEL', if_true: files('smmuv3-accel.c'))\n+stub_ss.add(files('smmuv3-accel-stubs.c'))\n arm_common_ss.add(when: 'CONFIG_FSL_IMX6UL', if_true: files('fsl-imx6ul.c', 'mcimx6ul-evk.c'))\n arm_common_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_soc.c'))\n arm_common_ss.add(when: 'CONFIG_XEN', if_true: files(\n", "prefixes": [ "PULL", "36/48" ] }