Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226812/?format=api
{ "id": 2226812, "url": "http://patchwork.ozlabs.org/api/patches/2226812/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-22-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-22-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:19", "name": "[PULL,21/48] hw/tpm: Remove CRBState::ppi_enabled field", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3104a4182bd380146aa79d5e5cb8052358ce9ac5", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-22-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226812/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=D/ph68DW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g198h4PBHz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:01:24 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdkZ-0007Dt-DM; Wed, 22 Apr 2026 16:00:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdkM-0006cF-Qt\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:00:35 -0400", "from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdkA-0001oQ-Aj\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:00:26 -0400", "by mail-wr1-x42f.google.com with SMTP id\n ffacd0b85a97d-43d7badbd7dso2916428f8f.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:00:17 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a174sm52513910f8f.18.2026.04.22.13.00.14\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:00:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888015; x=1777492815; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=tuztnUlSfQwod8ju5RlZjEzCQ50es7B6MliV5SRpEGk=;\n b=D/ph68DWIk0mu3pqOLptWGshCIi77ckQJ+AuL1fcyJkMhmcn3KmwyKjA22j1IUa0Wk\n SvAysXIcwvYJnc/L4CDkwFsBdMiZUeVOCPIAihz6GqUDM1H8i+WGQ+sAsmuy8bgDaj63\n yl5QAF+tqjG2J6itnbL1IrfvMYVaODoS1Gbz2sJejDUICzKXokWDt2Ub9DfUmCXlLCje\n bj7RsPnnam/aCv4t3IJXCGS3r3agOZUdz9ekRnfza3XUtx287Jt5ZKAaeJE+KWIwDEy0\n qarO4U0gEx7QuVIpvbCteSE1o9Y1+SndEa2N/cL+eIwY9JXkMcEFMSOJtf2tQmNy2KYm\n 5UPg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888015; x=1777492815;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=tuztnUlSfQwod8ju5RlZjEzCQ50es7B6MliV5SRpEGk=;\n b=EYoqNXRC+WlGs/4CjSwvw9lE7rvV/vvIBkDaGRpAXDerEyejz++fCqHyqnyxa2hpIG\n NTAvQgBK46sMuJsVsThkeZ4zvbM3vdVIl47gIBzuD1tjTUmEnAFp1OU48OD9GnilNTYH\n ae48LFUZKhj/nwPXQifOWoPc9ms3/wL6rZluhTZmDQ3QcXhWizue9cET5qQ1dlhFkcED\n 8pHMpGZMwIAucDZzsc3kWy0/4qfZ3+K0VQ8b/Xno4au94ERz2ZR5TvBty9dQZMWxlVer\n gNg9YclhRW42WUkC5ektRw9/EkyfiKrDyEoGeRjalP4dYmZ1smrTVFhFmOQ2EYaJeRtv\n 1Syw==", "X-Gm-Message-State": "AOJu0Yy/2Q600btoiIzJPimL0FYmf3NlTjnGYpWRViOfZwOz3FDtHjOx\n tjA9zdZJ066oEzjgSnMaVQ0FD2sgaM2tYiwcUY/GhvBvBg0foVMJqmbpAYLos3ZdIUEhhY7xo86\n QVyGmO7c=", "X-Gm-Gg": "AeBDieuHtdsewR7iOWouy01YkPugtskjkin7B/Vq62LhNJdGvVWFAMKU4Pygwcz+2lm\n Nm+i9BObva0b81Q4TOPN5ratUjJGGWnP6Eg+k66qqTLK/Xyq3KVAhuhY4tFHs+L5oMkVGnIhz6l\n w6Arl7N3BGGfZfxY8BBMNN+vGIc+yu/4f5MrYJyWzdhrdQNrMIqJwqGtQ+3U0MdEm2cAXAIBUAQ\n kKTJPFS7zfNbp+TDvsVpqwreF6R7rfFR1gbJzR2DAHIz/SX3TOugFpeeVuKZmC8PFPtZ1UY1SWT\n JDSY0VVdYPH5OQcgbD/KSzoTZ7qgVwG1Z7bXD2EV3mdEC/RAYPUOnXVkNeJwNJ0K8tFkhenEt9f\n dwP+ruerragsxqH11tKSJdVDk8ZTFRKbkCdCqppw82n0utHiLcZfmYJCkDDXY2csFZzD2Bt8xIk\n ON1wiKyESh/5VU5eB0wU4sKmM3H7L6jEXs+j8DpIUuXs+c5+fTzBG0uYDL2834okYUKmSMTvDPH\n Pg6s66xP3FjqItRGC2kcQ==", "X-Received": "by 2002:a05:6000:1ac7:b0:43c:ff58:35c2 with SMTP id\n ffacd0b85a97d-43fe3dc5eaemr38074018f8f.20.1776888015335;\n Wed, 22 Apr 2026 13:00:15 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 21/48] hw/tpm: Remove CRBState::ppi_enabled field", "Date": "Wed, 22 Apr 2026 21:57:19 +0200", "Message-ID": "<20260422195746.88865-22-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42f;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The CRBState::ppi_enabled boolean was only set in the\nhw_compat_3_1[] array, via the 'ppi=false' property.\nWe removed all machines using that array, and the array\nitself in commit a861ffef237 (\"hw/core/machine: Remove\nthe hw_compat_3_1[] array\"). We can safely remove the\nnow unused property. Since CRB devices always use PPI,\nsimplify removing the CRBState::ppi_enabled field.\nSet the generic TPMIfClass::ppi_enabled so ACPI subsystem\ncan keep checking its availability.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Stefan Berger <stefanb@linux.ibm.com>\nMessage-Id: <20260317120241.16320-4-philmd@linaro.org>\n---\n hw/tpm/tpm_crb.c | 13 ++++---------\n 1 file changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex 8723536f931..02701ab9480 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -43,7 +43,6 @@ struct CRBState {\n \n size_t be_buffer_size;\n \n- bool ppi_enabled;\n TPMPPI ppi;\n };\n typedef struct CRBState CRBState;\n@@ -228,16 +227,13 @@ static const VMStateDescription vmstate_tpm_crb = {\n \n static const Property tpm_crb_properties[] = {\n DEFINE_PROP_TPMBE(\"tpmdev\", CRBState, tpmbe),\n- DEFINE_PROP_BOOL(\"ppi\", CRBState, ppi_enabled, true),\n };\n \n static void tpm_crb_reset(void *dev)\n {\n CRBState *s = CRB(dev);\n \n- if (s->ppi_enabled) {\n- tpm_ppi_reset(&s->ppi);\n- }\n+ tpm_ppi_reset(&s->ppi);\n tpm_backend_reset(s->tpmbe);\n \n memset(s->regs, 0, sizeof(s->regs));\n@@ -303,10 +299,8 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n memory_region_add_subregion(get_system_memory(),\n TPM_CRB_ADDR_BASE + sizeof(s->regs), &s->cmdmem);\n \n- if (s->ppi_enabled) {\n- tpm_ppi_init(&s->ppi, get_system_memory(),\n- TPM_PPI_ADDR_BASE, OBJECT(s));\n- }\n+ tpm_ppi_init(&s->ppi, get_system_memory(),\n+ TPM_PPI_ADDR_BASE, OBJECT(s));\n \n if (xen_enabled()) {\n tpm_crb_reset(dev);\n@@ -325,6 +319,7 @@ static void tpm_crb_class_init(ObjectClass *klass, const void *data)\n dc->vmsd = &vmstate_tpm_crb;\n dc->user_creatable = true;\n tc->model = TPM_MODEL_TPM_CRB;\n+ tc->ppi_enabled = true;\n tc->get_version = tpm_crb_get_version;\n tc->request_completed = tpm_crb_request_completed;\n \n", "prefixes": [ "PULL", "21/48" ] }