Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226806/?format=api
{ "id": 2226806, "url": "http://patchwork.ozlabs.org/api/patches/2226806/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-25-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422195746.88865-25-philmd@linaro.org>", "list_archive_url": null, "date": "2026-04-22T19:57:22", "name": "[PULL,24/48] hw/ppc/spapr: Un-inline rtas_load/store() helpers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "db31a003aae892d2833987006c33a1e7e2cb1635", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422195746.88865-25-philmd@linaro.org/mbox/", "series": [ { "id": 501099, "url": "http://patchwork.ozlabs.org/api/series/501099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501099", "date": "2026-04-22T19:56:59", "name": "[PULL,01/48] hw/avr: Build as common unit files", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501099/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226806/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226806/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Rl0rpdet;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g19894t3Qz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 06:00:57 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFdkc-0007YA-Dx; Wed, 22 Apr 2026 16:00:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdkY-00078O-8V\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:00:42 -0400", "from mail-wr1-x430.google.com ([2a00:1450:4864:20::430])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wFdkW-000220-Br\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 16:00:41 -0400", "by mail-wr1-x430.google.com with SMTP id\n ffacd0b85a97d-43cfde3c3f3so6043485f8f.3\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 13:00:39 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4d5b1sm51645351f8f.30.2026.04.22.13.00.36\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Wed, 22 Apr 2026 13:00:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776888038; x=1777492838; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=C0apGIz1BwsAJXSXLn4sYhDjCgYgxotRdF6SHq/q5LM=;\n b=Rl0rpdetDc9SNcjJThYnSKt8JMjiN+VxIxUTDLrZn9BrYe3O5NmVV3HRtyH6YI17b0\n Mjmu1/w3sXziZRwvFzNZJiBsUwtGSRCv+L16PBe+6+yldtrn76DQU2Rq4FmIUIuEtrG7\n kkjh//2/SlGzP+HWQc1F3FhkB6V5VW4vrRqchimYeEgUR9q135rLvAG5khzQImYwSLLY\n UJuRgOLOUO+U1ir5nFSgKqsgidkw87YFetiiRkIhEwn+1ZG27UYhjWMCadhbGaq6CFMb\n xMCSKaJb1913dgXpKK4TDvDUW350hkJ2shLO+10AaMGfmkuShBOHe+0FVT64BH0csWRS\n of2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776888038; x=1777492838;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=C0apGIz1BwsAJXSXLn4sYhDjCgYgxotRdF6SHq/q5LM=;\n b=HdrzJxbroTTCDcXHpVJLjuddD6dp+KhvrlLa7Ua+CYubEZm+gpKGxJK5SZ0aqs/MsV\n 1OajTcTlgPxvA37BZjDVn+l6PZ+b1hZWDe6yyo9xD2KAt6Dj27pZJ8mFHBHJVvhcgMe0\n JyLJTXkG93b1v/wEvDUJ4+/Nw6o5gZQXfEL/KPMxy9Chp3HQIQULsDXKWq9x7h0Pu/tG\n ZjjdkOeWx0SFCZIoThBbCD7Ua3lNZ04ALvO8CEgcnLfvmAoLUo/F2QZsdPtwwtEEQvhi\n KAg6UUAmoNOGbS0CXRx18uCqFdBa7xe0vMIqqDRuB1VbemuNcdbFta/xBabt+GO3bMMZ\n kNkA==", "X-Gm-Message-State": "AOJu0Yz7UwZ+Akn6XL01VP5vl3/SoguDbX+ybsT0blIGuA9e5eHXx3He\n BUknhEPqKMeM51bS649APxgWsBFJxgLP5914VKsAfnVh8DHgc9LpRWnRSrFKQknhwDibptFT/QF\n RcT2cqtc=", "X-Gm-Gg": "AeBDiet9Rn4GvH63vTqzGXMeEiBqdmJ9gv9g2R/s8vlrCUv7Yy2NaCQ3M0yz/Nv0Vtk\n WDMbK4bcrRmmQYO1Ga1s3YoxiALBspVD2PIvdP5iqv7hflSQzKd9TE355WKM1kdlfTD0Q9usfDb\n B0XTT9YCjDlCaHLY+3xmp+XqxieKWcbdXflIoGdGGaSvJNUcOcUc+8FNAiKipVJuDyDoCtklXlw\n jR6OawFnSifcfEixSHfYUbL8bY2dJRkpdlrZ+vW4ESYGMOrQYyl3pN1kaXZPMEAVlE5wGgPvRUv\n Imtf/LNW9LkKBwx+ZiWhAFDGzJDF1HdRNLZr98NCkqBRwOgHVl0C0eVqTWlS0XK+vP37yoaDZFP\n I8xuxbCTE2qBMcz3HlmbRKWVboAEU46yxwwBNgF9OX8IJ8z6MtoOdtOCaIEZ4TJAfSu6FJQoiO1\n e4zRpO4PE2DP4niBcdFuRjdUSEbLRykoYxWdoHBsw/sPl0hX8W8VcE5OpGAsCE5Wv/0Ps6qI8BL\n qiB+g6FozM=", "X-Received": "by 2002:a05:6000:1889:b0:43d:7b7b:ab76 with SMTP id\n ffacd0b85a97d-43fe3dc54ddmr36976152f8f.10.1776888038039;\n Wed, 22 Apr 2026 13:00:38 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 24/48] hw/ppc/spapr: Un-inline rtas_load/store() helpers", "Date": "Wed, 22 Apr 2026 21:57:22 +0200", "Message-ID": "<20260422195746.88865-25-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422195746.88865-1-philmd@linaro.org>", "References": "<20260422195746.88865-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::430;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The 32-bit binary doesn't use these helpers, so don't need to\ncompile them. Rather than using 64-bit target #ifdef'ry in a\nglobal header, un-inline the calls since the helpers are called\nfrom I/O (cold) path.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>\nReviewed-by: Chinmay Rath <rathc@linux.ibm.com>\nAcked-by: Glenn Miles <milesg@linux.ibm.com>\nMessage-Id: <20260319111936.68041-2-philmd@linaro.org>\n---\n include/hw/ppc/spapr.h | 18 +++---------------\n hw/ppc/spapr_rtas.c | 15 +++++++++++++++\n 2 files changed, 18 insertions(+), 15 deletions(-)", "diff": "diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h\nindex b022f8dd25d..9acda15d4f6 100644\n--- a/include/hw/ppc/spapr.h\n+++ b/include/hw/ppc/spapr.h\n@@ -796,21 +796,9 @@ static inline uint64_t ppc64_phys_to_real(uint64_t addr)\n return addr & ~0xF000000000000000ULL;\n }\n \n-static inline uint32_t rtas_ld(target_ulong phys, int n)\n-{\n- return ldl_be_phys(&address_space_memory,\n- ppc64_phys_to_real(phys + 4 * n));\n-}\n-\n-static inline uint64_t rtas_ldq(target_ulong phys, int n)\n-{\n- return (uint64_t)rtas_ld(phys, n) << 32 | rtas_ld(phys, n + 1);\n-}\n-\n-static inline void rtas_st(target_ulong phys, int n, uint32_t val)\n-{\n- stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val);\n-}\n+uint32_t rtas_ld(target_ulong phys, int n);\n+uint64_t rtas_ldq(target_ulong phys, int n);\n+void rtas_st(target_ulong phys, int n, uint32_t val);\n \n typedef void (*spapr_rtas_fn)(PowerPCCPU *cpu, SpaprMachineState *sm,\n uint32_t token,\ndiff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c\nindex cb79ad34053..0871425237e 100644\n--- a/hw/ppc/spapr_rtas.c\n+++ b/hw/ppc/spapr_rtas.c\n@@ -52,6 +52,21 @@\n #include \"migration/blocker.h\"\n #include \"helper_regs.h\"\n \n+uint32_t rtas_ld(target_ulong phys, int n)\n+{\n+ return ldl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n));\n+}\n+\n+uint64_t rtas_ldq(target_ulong phys, int n)\n+{\n+ return (uint64_t)rtas_ld(phys, n) << 32 | rtas_ld(phys, n + 1);\n+}\n+\n+void rtas_st(target_ulong phys, int n, uint32_t val)\n+{\n+ stl_be_phys(&address_space_memory, ppc64_phys_to_real(phys + 4 * n), val);\n+}\n+\n static void rtas_display_character(PowerPCCPU *cpu, SpaprMachineState *spapr,\n uint32_t token, uint32_t nargs,\n target_ulong args,\n", "prefixes": [ "PULL", "24/48" ] }