Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226777/?format=api
{ "id": 2226777, "url": "http://patchwork.ozlabs.org/api/patches/2226777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.8@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.8@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T18:49:16", "name": "[v1,08/10] fab: Use a macro for the atomic/sync builtins case", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "21502c6af7bcae29e93d73e8e47a2a2f6d8dbfad", "submitter": { "id": 93219, "url": "http://patchwork.ozlabs.org/api/people/93219/?format=api", "name": "Andrew Pinski via Sourceware Forge", "email": "forge-bot+pinskia@forge-stage.sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.8@forge-stage.sourceware.org/mbox/", "series": [ { "id": 501092, "url": "http://patchwork.ozlabs.org/api/series/501092/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501092", "date": "2026-04-22T18:49:11", "name": "remove_fab", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501092/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g18cY4M4Gz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 05:37:01 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 06A4043B6C4C\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 19:36:52 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 7C908407FF72\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:50:43 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id E1FB443597\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:50:41 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 06A4043B6C4C", "OpenDKIM Filter v2.11.0 sourceware.org 7C908407FF72" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 7C908407FF72", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 7C908407FF72", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883843; cv=none;\n b=cpXtGsPkqN7xq04J/odRNwBykbQm7QtRT0g7xBXBOdSTKU8UGtE2nxqHfCQXbjNxjbMAmfSeENw13Ym6MWC78MI/GyeO5+kUsNl8zSE9XGYD9tje83az38U8oHX0rMeO6lIYZHqiv3mYMt2JBL15QJsfEgZAacQB5QYCcywy4fA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776883843; c=relaxed/simple;\n bh=oLjfyBH+qJav9NFZvdUQIUj2OngT1d8d/K0r0VZDpWU=;\n h=From:Date:Subject:To:Message-ID;\n b=bZAq5kH1fXsL9krUHIAsE2fqHE8hKBY+N8ZCvwaozQBnoxUbVmBhKyym7vZHp6Fc68H0B9cUPXDwnMQb+HThWV0HcjTkktMP+3eahNWALGVPhbjEVYDgrMp5Gm/y4qZ1nFDtlRJcw5YAsH8rd+ZlGj8/J0zS4ZKQJOC3M47Cz4c=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "Andrew Pinski via Sourceware Forge\n <forge-bot+pinskia@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 18:49:16 +0000", "Subject": "[PATCH v1 08/10] fab: Use a macro for the atomic/sync builtins case", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.8@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/84", "References": "\n <bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.0@forge-stage.sourceware.org>", "In-Reply-To": "\n <bmm.hhup4p5wp2.gcc.gcc-TEST.pinskia.84.1.0@forge-stage.sourceware.org>", "X-Patch-URL": "\n https://forge.sourceware.org/pinskia/gcc-TEST/commit/14cddbde10ad4b900495516442f21f2eb42bcae4", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>,\n pinskia@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n\nThis is a small cleanup to make it easier to move this part of fab to\nsomewhere else. And it makes it easier to understand which builtins are being\nused here and also less repeated code.\n\nBootstrapped and tested on x86_64-linux-gnu.\n\ngcc/ChangeLog:\n\n\t* tree-ssa-ccp.cc (CASE_ATOMIC): New defined.\n\t(CASE_ATOMIC_CMP0): New define.\n\t(CASE_ATOMIC_BIT_TEST_AND): New defined.\n\t(pass_fold_builtins::execute): Use CASE_ATOMIC, CASE_ATOMIC_CMP0,\n\tand CASE_ATOMIC_BIT_TEST_AND.\n\nSigned-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n---\n gcc/tree-ssa-ccp.cc | 171 +++++++++-----------------------------------\n 1 file changed, 35 insertions(+), 136 deletions(-)", "diff": "diff --git a/gcc/tree-ssa-ccp.cc b/gcc/tree-ssa-ccp.cc\nindex 2d16395ac68e..021eb22eadd6 100644\n--- a/gcc/tree-ssa-ccp.cc\n+++ b/gcc/tree-ssa-ccp.cc\n@@ -4065,85 +4065,45 @@ pass_fold_builtins::execute (function *fun)\n \t tree result = NULL_TREE;\n \t switch (DECL_FUNCTION_CODE (callee))\n \t\t{\n-\t\tcase BUILT_IN_ATOMIC_ADD_FETCH_1:\n-\t\tcase BUILT_IN_ATOMIC_ADD_FETCH_2:\n-\t\tcase BUILT_IN_ATOMIC_ADD_FETCH_4:\n-\t\tcase BUILT_IN_ATOMIC_ADD_FETCH_8:\n-\t\tcase BUILT_IN_ATOMIC_ADD_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_ADD_FETCH_CMP_0,\n-\t\t\t\t\t\t true);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_ADD_AND_FETCH_1:\n-\t\tcase BUILT_IN_SYNC_ADD_AND_FETCH_2:\n-\t\tcase BUILT_IN_SYNC_ADD_AND_FETCH_4:\n-\t\tcase BUILT_IN_SYNC_ADD_AND_FETCH_8:\n-\t\tcase BUILT_IN_SYNC_ADD_AND_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_ADD_FETCH_CMP_0,\n-\t\t\t\t\t\t false);\n-\t\t break;\n-\n-\t\tcase BUILT_IN_ATOMIC_SUB_FETCH_1:\n-\t\tcase BUILT_IN_ATOMIC_SUB_FETCH_2:\n-\t\tcase BUILT_IN_ATOMIC_SUB_FETCH_4:\n-\t\tcase BUILT_IN_ATOMIC_SUB_FETCH_8:\n-\t\tcase BUILT_IN_ATOMIC_SUB_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_SUB_FETCH_CMP_0,\n-\t\t\t\t\t\t true);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_SUB_AND_FETCH_1:\n-\t\tcase BUILT_IN_SYNC_SUB_AND_FETCH_2:\n-\t\tcase BUILT_IN_SYNC_SUB_AND_FETCH_4:\n-\t\tcase BUILT_IN_SYNC_SUB_AND_FETCH_8:\n-\t\tcase BUILT_IN_SYNC_SUB_AND_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_SUB_FETCH_CMP_0,\n-\t\t\t\t\t\t false);\n+#define CASE_ATOMIC(NAME) \t\t\t\\\n+\t\tcase BUILT_IN_##NAME##_1:\t\\\n+\t\tcase BUILT_IN_##NAME##_2:\t\\\n+\t\tcase BUILT_IN_##NAME##_4:\t\\\n+\t\tcase BUILT_IN_##NAME##_8:\t\\\n+\t\tcase BUILT_IN_##NAME##_16\n+#define CASE_ATOMIC_CMP0(ATOMIC, SYNC) \t\t\t\t\\\n+\t\tCASE_ATOMIC(ATOMIC_##ATOMIC):\t\t\t\\\n+\t\t optimize_atomic_op_fetch_cmp_0 (&i,\t\t\\\n+\t\t\t\t\t\t IFN_ATOMIC_##ATOMIC##_CMP_0, \\\n+\t\t\t\t\t\t true);\t\\\n+\t\t break;\t\t\t\t\t\\\n+\t\tCASE_ATOMIC(SYNC_##SYNC):\t\t\t\\\n+\t\t optimize_atomic_op_fetch_cmp_0 (&i,\t\t\\\n+\t\t\t\t\t\t IFN_ATOMIC_##ATOMIC##_CMP_0, \\\n+\t\t\t\t\t\t false);\t\\\n \t\t break;\n \n-\t\tcase BUILT_IN_ATOMIC_FETCH_OR_1:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_OR_2:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_OR_4:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_OR_8:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_OR_16:\n-\t\t optimize_atomic_bit_test_and (&i,\n-\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_SET,\n-\t\t\t\t\t\ttrue, false);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_OR_1:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_OR_2:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_OR_4:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_OR_8:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_OR_16:\n-\t\t optimize_atomic_bit_test_and (&i,\n-\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_SET,\n-\t\t\t\t\t\tfalse, false);\n-\t\t break;\n \n-\t\tcase BUILT_IN_ATOMIC_FETCH_XOR_1:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_XOR_2:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_XOR_4:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_XOR_8:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_XOR_16:\n-\t\t optimize_atomic_bit_test_and\n-\t\t\t(&i, IFN_ATOMIC_BIT_TEST_AND_COMPLEMENT, true, false);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_XOR_1:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_XOR_2:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_XOR_4:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_XOR_8:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_XOR_16:\n-\t\t optimize_atomic_bit_test_and\n-\t\t\t(&i, IFN_ATOMIC_BIT_TEST_AND_COMPLEMENT, false, false);\n+\t\tCASE_ATOMIC_CMP0(ADD_FETCH, ADD_AND_FETCH)\n+\t\tCASE_ATOMIC_CMP0(SUB_FETCH, SUB_AND_FETCH)\n+\t\tCASE_ATOMIC_CMP0(AND_FETCH, AND_AND_FETCH)\n+\t\tCASE_ATOMIC_CMP0(OR_FETCH, OR_AND_FETCH)\n+#define CASE_ATOMIC_BIT_TEST_AND(ATOMIC, SYNC, FN, AFTER) \t\t\t\\\n+\t\tCASE_ATOMIC(ATOMIC_##ATOMIC):\t\t\t\t\t\\\n+\t\t optimize_atomic_bit_test_and (&i,\t\t\t\t\\\n+\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_##FN,\t\\\n+\t\t\t\t\t\ttrue, AFTER);\t\t\t\\\n+\t\t break;\t\t\t\t\t\t\t\\\n+\t\tCASE_ATOMIC(SYNC_##SYNC):\t\t\t\t\t\\\n+\t\t optimize_atomic_bit_test_and (&i,\t\t\t\t\\\n+\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_##FN, \t\\\n+\t\t\t\t\t\tfalse, AFTER);\t\t\t\\\n \t\t break;\n+\t\tCASE_ATOMIC_BIT_TEST_AND(FETCH_OR, FETCH_AND_OR, SET, false)\n+\t\tCASE_ATOMIC_BIT_TEST_AND(FETCH_XOR, FETCH_AND_XOR, COMPLEMENT, false)\n+\t\tCASE_ATOMIC_BIT_TEST_AND(FETCH_AND, FETCH_AND_AND, RESET, false)\n \n-\t\tcase BUILT_IN_ATOMIC_XOR_FETCH_1:\n-\t\tcase BUILT_IN_ATOMIC_XOR_FETCH_2:\n-\t\tcase BUILT_IN_ATOMIC_XOR_FETCH_4:\n-\t\tcase BUILT_IN_ATOMIC_XOR_FETCH_8:\n-\t\tcase BUILT_IN_ATOMIC_XOR_FETCH_16:\n+\t\tCASE_ATOMIC(ATOMIC_XOR_FETCH):\n \t\t if (optimize_atomic_bit_test_and\n \t\t\t(&i, IFN_ATOMIC_BIT_TEST_AND_COMPLEMENT, true, true))\n \t\t break;\n@@ -4151,11 +4111,7 @@ pass_fold_builtins::execute (function *fun)\n \t\t\t\t\t\t IFN_ATOMIC_XOR_FETCH_CMP_0,\n \t\t\t\t\t\t true);\n \t\t break;\n-\t\tcase BUILT_IN_SYNC_XOR_AND_FETCH_1:\n-\t\tcase BUILT_IN_SYNC_XOR_AND_FETCH_2:\n-\t\tcase BUILT_IN_SYNC_XOR_AND_FETCH_4:\n-\t\tcase BUILT_IN_SYNC_XOR_AND_FETCH_8:\n-\t\tcase BUILT_IN_SYNC_XOR_AND_FETCH_16:\n+\t\tCASE_ATOMIC(SYNC_XOR_AND_FETCH):\n \t\t if (optimize_atomic_bit_test_and\n \t\t\t(&i, IFN_ATOMIC_BIT_TEST_AND_COMPLEMENT, false, true))\n \t\t break;\n@@ -4164,63 +4120,6 @@ pass_fold_builtins::execute (function *fun)\n \t\t\t\t\t\t false);\n \t\t break;\n \n-\t\tcase BUILT_IN_ATOMIC_FETCH_AND_1:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_AND_2:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_AND_4:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_AND_8:\n-\t\tcase BUILT_IN_ATOMIC_FETCH_AND_16:\n-\t\t optimize_atomic_bit_test_and (&i,\n-\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_RESET,\n-\t\t\t\t\t\ttrue, false);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_AND_1:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_AND_2:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_AND_4:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_AND_8:\n-\t\tcase BUILT_IN_SYNC_FETCH_AND_AND_16:\n-\t\t optimize_atomic_bit_test_and (&i,\n-\t\t\t\t\t\tIFN_ATOMIC_BIT_TEST_AND_RESET,\n-\t\t\t\t\t\tfalse, false);\n-\t\t break;\n-\n-\t\tcase BUILT_IN_ATOMIC_AND_FETCH_1:\n-\t\tcase BUILT_IN_ATOMIC_AND_FETCH_2:\n-\t\tcase BUILT_IN_ATOMIC_AND_FETCH_4:\n-\t\tcase BUILT_IN_ATOMIC_AND_FETCH_8:\n-\t\tcase BUILT_IN_ATOMIC_AND_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_AND_FETCH_CMP_0,\n-\t\t\t\t\t\t true);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_AND_AND_FETCH_1:\n-\t\tcase BUILT_IN_SYNC_AND_AND_FETCH_2:\n-\t\tcase BUILT_IN_SYNC_AND_AND_FETCH_4:\n-\t\tcase BUILT_IN_SYNC_AND_AND_FETCH_8:\n-\t\tcase BUILT_IN_SYNC_AND_AND_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_AND_FETCH_CMP_0,\n-\t\t\t\t\t\t false);\n-\t\t break;\n-\n-\t\tcase BUILT_IN_ATOMIC_OR_FETCH_1:\n-\t\tcase BUILT_IN_ATOMIC_OR_FETCH_2:\n-\t\tcase BUILT_IN_ATOMIC_OR_FETCH_4:\n-\t\tcase BUILT_IN_ATOMIC_OR_FETCH_8:\n-\t\tcase BUILT_IN_ATOMIC_OR_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_OR_FETCH_CMP_0,\n-\t\t\t\t\t\t true);\n-\t\t break;\n-\t\tcase BUILT_IN_SYNC_OR_AND_FETCH_1:\n-\t\tcase BUILT_IN_SYNC_OR_AND_FETCH_2:\n-\t\tcase BUILT_IN_SYNC_OR_AND_FETCH_4:\n-\t\tcase BUILT_IN_SYNC_OR_AND_FETCH_8:\n-\t\tcase BUILT_IN_SYNC_OR_AND_FETCH_16:\n-\t\t optimize_atomic_op_fetch_cmp_0 (&i,\n-\t\t\t\t\t\t IFN_ATOMIC_OR_FETCH_CMP_0,\n-\t\t\t\t\t\t false);\n-\t\t break;\n-\n \t\tdefault:;\n \t\t}\n \n", "prefixes": [ "v1", "08/10" ] }