Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226738/?format=api
{ "id": 2226738, "url": "http://patchwork.ozlabs.org/api/patches/2226738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.1@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.1@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T18:43:40", "name": "[v1,1/2] forwprop: Handle memcpy for copy prop [PR121418, PR121417]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2091d642c69a1f19cce7f09f5dfae6457e3a506e", "submitter": { "id": 93219, "url": "http://patchwork.ozlabs.org/api/people/93219/?format=api", "name": "Andrew Pinski via Sourceware Forge", "email": "forge-bot+pinskia@forge-stage.sourceware.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.1@forge-stage.sourceware.org/mbox/", "series": [ { "id": 501088, "url": "http://patchwork.ozlabs.org/api/series/501088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501088", "date": "2026-04-22T18:43:40", "name": "WIP: copypropv6a", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501088/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g180n3x7bz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 05:09:29 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 8F4EC42930AF\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 19:09:27 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id F0A664314EBA\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:44:37 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id C235943501\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 18:44:37 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 8F4EC42930AF", "OpenDKIM Filter v2.11.0 sourceware.org F0A664314EBA" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org F0A664314EBA", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org F0A664314EBA", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883478; cv=none;\n b=rwQ8d7YTB2C0C5HMFe5eJU2RPAv6q+YDMn0vHL1kbObeVaOEPDQJzAqoWTcvfgYJ/eIhDnnNIgqMLc/8OTxQmcuGkWsCC8MO9q57MBpM5p+mP1LC4V7T1FKAq/ho6X1Vh+q0763ll9Ieq3QCDJ/CIhYS24MSo0ZTJ7IxoX30j6Y=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776883478; c=relaxed/simple;\n bh=SjTVsTC4dja+QhC0xsqhQuPRODCdNPY//n/ExJuvWoQ=;\n h=From:Date:Subject:To:Message-ID;\n b=VhMrqKL1yit99qG5rWTOUOTJ/tuMG9YcME8mOx7B6cq7VZ5mCr4p0wNfyLnrr4f6lEGrocIk6cWQhvJLCev1zHB8ithiZiFErFZof/Qa9S9yI+QjjEe+xyf+XCyCSvocxcrd1NwXfnKyY+aMqVf9WVzO5vnGBhcOj/e8k14t1WI=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "Andrew Pinski via Sourceware Forge\n <forge-bot+pinskia@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 18:43:40 +0000", "Subject": "[PATCH v1 1/2] forwprop: Handle memcpy for copy prop [PR121418,\n PR121417]", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.1@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/76", "References": "\n <bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.0@forge-stage.sourceware.org>", "In-Reply-To": "\n <bmm.hhuoz4ezzq.gcc.gcc-TEST.pinskia.76.1.0@forge-stage.sourceware.org>", "X-Patch-URL": "\n https://forge.sourceware.org/pinskia/gcc-TEST/commit/eb3fd30754f6bb4026d0ae0da576dce45f9d577d", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>,\n pinskia@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "From: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n\nIt turns out easy to add support for memcpy copy prop when the memcpy\nhas changed into `MEM<char[N]>` copy.\nInstead of rejecting right out we need to figure out that\n`a` and `MEM<char[N]>[&a]` are equivalent in terms of address and size.\nAnd then create a VIEW_CONVER_EXPR from the original src to the new type.\n\nNote this also allows for `a.b` and `a` being considered equivalent if b is the\nonly field (PR 121751).\n\nChanges since v1:\n* v2: Move check for IMAG/REAL and BFR earlier.\n\nBootstrapped and tested on x86_64-linux-gnu.\n\n\tPR tree-optimization/121751\n\tPR tree-optimization/121418\n\tPR tree-optimization/121417\ngcc/ChangeLog:\n\n\t* tree-ssa-forwprop.cc (optimize_agr_copyprop_1): Allow for the same\n\taddress but different type accesses via a VCE.\n\ngcc/testsuite/ChangeLog:\n\n\t* gcc.dg/tree-ssa/copy-prop-aggregate-1.c: New test.\n\t* gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-1.c: New test.\n\t* gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-2.c: New test.\n\nSigned-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>\n---\n .../gcc.dg/tree-ssa/copy-prop-aggregate-1.c | 33 +++++++++++++++\n .../tree-ssa/copy-prop-aggregate-memcpy-1.c | 18 ++++++++\n .../tree-ssa/copy-prop-aggregate-memcpy-2.c | 20 +++++++++\n gcc/tree-ssa-forwprop.cc | 42 ++++++++++++++++++-\n 4 files changed, 112 insertions(+), 1 deletion(-)\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-1.c\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-1.c\n create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-2.c", "diff": "diff --git a/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-1.c b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-1.c\nnew file mode 100644\nindex 000000000000..1094c4d768bb\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-1.c\n@@ -0,0 +1,33 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-forwprop1-details -fdump-tree-optimized\" } */\n+/* PR tree-optimization/121751 */\n+\n+\n+struct s1\n+{\n+ int t[1024];\n+};\n+\n+struct s2 {\n+ struct s1 t;\n+};\n+\n+struct s3\n+{\n+ struct s2 t;\n+};\n+\n+void g(struct s3*);\n+\n+void f(struct s1 s)\n+{\n+ struct s2 removeme;\n+ removeme.t = s;\n+ struct s3 t1;\n+ t1.t = removeme;\n+ g(&t1);\n+}\n+\n+\n+/* { dg-final { scan-tree-dump-times \"after previous\" 1 \"forwprop1\" } } */\n+/* { dg-final { scan-tree-dump-not \"removeme \" \"optimized\" } } */\ndiff --git a/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-1.c b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-1.c\nnew file mode 100644\nindex 000000000000..5faf6d0bf9bb\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-1.c\n@@ -0,0 +1,18 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-forwprop1-details -fdump-tree-optimized\" } */\n+/* PR tree-optimization/121418 */\n+\n+struct s1\n+{\n+ unsigned char t[1024];\n+};\n+\n+struct s1 f(struct s1 a)\n+{\n+ struct s1 removeme1 = a;\n+ __builtin_memcpy (&removeme1, &a, sizeof(struct s1));\n+ return removeme1;\n+}\n+\n+/* { dg-final { scan-tree-dump-times \"after previous\" 1 \"forwprop1\" } } */\n+/* { dg-final { scan-tree-dump-not \"removeme1 \" \"optimized\" } } */\ndiff --git a/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-2.c b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-2.c\nnew file mode 100644\nindex 000000000000..b1ba30d0aba0\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/tree-ssa/copy-prop-aggregate-memcpy-2.c\n@@ -0,0 +1,20 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O1 -fdump-tree-forwprop1-details -fdump-tree-optimized\" } */\n+/* PR tree-optimization/121417 */\n+\n+struct s1\n+{\n+ unsigned char t[1024];\n+};\n+\n+struct s1 f(struct s1 a)\n+{\n+ struct s1 removeme1 = a;\n+ struct s1 removeme2;\n+ __builtin_memcpy (&removeme2, &removeme1, sizeof(struct s1));\n+ return removeme2;\n+}\n+\n+/* { dg-final { scan-tree-dump-times \"after previous\" 2 \"forwprop1\" } } */\n+/* { dg-final { scan-tree-dump-not \"removeme1 \" \"optimized\" } } */\n+/* { dg-final { scan-tree-dump-not \"removeme2 \" \"optimized\" } } */\ndiff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc\nindex 9c6f4b355d6d..c466d9464d37 100644\n--- a/gcc/tree-ssa-forwprop.cc\n+++ b/gcc/tree-ssa-forwprop.cc\n@@ -1434,8 +1434,48 @@ optimize_agr_copyprop_1 (gimple *stmt, gimple *use_stmt,\n /* If the new store is `src2 = src2;` skip over it. */\n if (operand_equal_p (src2, dest2, 0))\n return false;\n+ /* If the second src is not exactly the same as dest,\n+ try to handle it seperately; see it is address/size equivalent.\n+ Handles `a` and `a.b` and `MEM<char[N]>(&a)` which all have\n+ the same size and offsets as address/size equivalent.\n+ This allows copying over a memcpy and also one for copying\n+ where one field is the same size as the whole struct. */\n if (!operand_equal_p (dest, src2, 0))\n- return false;\n+ {\n+ /* A VCE can't be used with imag/real or BFR so reject them early. */\n+ if (TREE_CODE (src) == IMAGPART_EXPR\n+\t || TREE_CODE (src) == REALPART_EXPR\n+\t || TREE_CODE (src) == BIT_FIELD_REF)\n+\treturn false;\n+ poly_int64 offset1, offset2;\n+ tree base1 = get_addr_base_and_unit_offset (dest, &offset1);\n+ tree base2 = get_addr_base_and_unit_offset (src2, &offset2);\n+ /* The bases have been equivalent. */\n+ if (!base1 || !base2\n+\t || !operand_equal_p (base1, base2))\n+\treturn false;\n+ /* Offsets from the base needs to be the same. */\n+ if (!known_eq (offset1, offset2))\n+\treturn false;\n+ tree len1 = (TREE_CODE (dest) == COMPONENT_REF\n+\t ? DECL_SIZE_UNIT (TREE_OPERAND (dest, 1))\n+\t : TYPE_SIZE_UNIT (TREE_TYPE (dest)));\n+ tree len2 = (TREE_CODE (src2) == COMPONENT_REF\n+\t ? DECL_SIZE_UNIT (TREE_OPERAND (src2, 1))\n+\t : TYPE_SIZE_UNIT (TREE_TYPE (src2)));\n+ /* The sizes need to be constant. */\n+ if (!poly_int_tree_p (len1)\n+\t || !poly_int_tree_p (len1))\n+\treturn false;\n+ auto l1 = wi::to_poly_offset (len1);\n+ auto l2 = wi::to_poly_offset (len2);\n+ /* The sizes of the 2 accesses need to be the same. */\n+ if (!known_eq (l1, l2))\n+\treturn false;\n+ src = fold_build1_loc (gimple_location (use_stmt),\n+\t\t\t VIEW_CONVERT_EXPR,\n+\t\t\t TREE_TYPE (src2), src);\n+ }\n /* For 2 memory refences and using a temporary to do the copy,\n don't remove the temporary as the 2 memory references might overlap.\n Note t does not need to be decl as it could be field.\n", "prefixes": [ "v1", "1/2" ] }