Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2226639,
    "url": "http://patchwork.ozlabs.org/api/patches/2226639/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260422172659.24184-1-fw@strlen.de/",
    "project": {
        "id": 26,
        "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api",
        "name": "Netfilter Development",
        "link_name": "netfilter-devel",
        "list_id": "netfilter-devel.vger.kernel.org",
        "list_email": "netfilter-devel@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20260422172659.24184-1-fw@strlen.de>",
    "list_archive_url": null,
    "date": "2026-04-22T17:26:56",
    "name": "[nft] evaluate: zap useless 0-shifts",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "747c60e88e98d1acc7b3644b9ee0d47fb27917c4",
    "submitter": {
        "id": 1025,
        "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api",
        "name": "Florian Westphal",
        "email": "fw@strlen.de"
    },
    "delegate": {
        "id": 11902,
        "url": "http://patchwork.ozlabs.org/api/users/11902/?format=api",
        "username": "strlen",
        "first_name": "Florian",
        "last_name": "Westphal",
        "email": "fw@strlen.de"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260422172659.24184-1-fw@strlen.de/mbox/",
    "series": [
        {
            "id": 501051,
            "url": "http://patchwork.ozlabs.org/api/series/501051/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501051",
            "date": "2026-04-22T17:26:56",
            "name": "[nft] evaluate: zap useless 0-shifts",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/501051/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/2226639/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/2226639/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "\n <netfilter-devel+bounces-12140-incoming=patchwork.ozlabs.org@vger.kernel.org>",
        "X-Original-To": [
            "incoming@patchwork.ozlabs.org",
            "netfilter-devel@vger.kernel.org"
        ],
        "Delivered-To": "patchwork-incoming@legolas.ozlabs.org",
        "Authentication-Results": [
            "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12140-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)",
            "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30",
            "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de",
            "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"
        ],
        "Received": [
            "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g15kq3fwKz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 03:27:15 +1000 (AEST)",
            "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 255D130160D3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 17:27:11 +0000 (UTC)",
            "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 407073803E9;\n\tWed, 22 Apr 2026 17:27:10 +0000 (UTC)",
            "from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 330BF280331\n\tfor <netfilter-devel@vger.kernel.org>; Wed, 22 Apr 2026 17:27:08 +0000 (UTC)",
            "by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 401EF60890; Wed, 22 Apr 2026 19:27:05 +0200 (CEST)"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776878830; cv=none;\n b=s23gAJBCdecyXP4YGPRPt8jFkvUXiZnQx7br+F+KAuOng2aDtN8Ma3fHGnqz5PSaLNhGxSRvJTb8knVy4rP2iiddiZeoioq0A1ypo4EQr+xORtkVeEnligNEZAHa00JkMqtxihqEHlabj0+BNMqRIlUY7HUQj5EfZcWdYE1ECPI=",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776878830; c=relaxed/simple;\n\tbh=FpDKUg3wCPHyI/Ka/LtZoeI7/SXUpJyfYFIVnj0blMQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=CzqCx1EJWPW0bHWyeQpiCLUTFAwJMcL0NGU+IJbf9wcNwXtGIvyR/vBS3V5zK/IGkyvdNtAKf1VJiF+vaTpR3Ltbg6O9e15hOWDt5ZpA88CMEaCGd8gIRY2A+eBp5X+qupaMVAXC18VYv2Rr3rzCtPnZwBnURqn+OQ00Muj2K58=",
        "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30",
        "From": "Florian Westphal <fw@strlen.de>",
        "To": "<netfilter-devel@vger.kernel.org>",
        "Cc": "Florian Westphal <fw@strlen.de>",
        "Subject": "[PATCH nft] evaluate: zap useless 0-shifts",
        "Date": "Wed, 22 Apr 2026 19:26:56 +0200",
        "Message-ID": "<20260422172659.24184-1-fw@strlen.de>",
        "X-Mailer": "git-send-email 2.53.0",
        "Precedence": "bulk",
        "X-Mailing-List": "netfilter-devel@vger.kernel.org",
        "List-Id": "<netfilter-devel.vger.kernel.org>",
        "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>",
        "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit"
    },
    "content": "There is a (not yet applied) kernel patch that rejects 0-shifts,\nauto-suppress them at eval stage.\n\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n src/evaluate.c | 6 ++++++\n 1 file changed, 6 insertions(+)",
    "diff": "diff --git a/src/evaluate.c b/src/evaluate.c\nindex 482708ae6191..8bb7b6095309 100644\n--- a/src/evaluate.c\n+++ b/src/evaluate.c\n@@ -1454,6 +1454,12 @@ static int expr_evaluate_shift(struct eval_ctx *ctx, struct expr **expr)\n \t\t\t\t\t \"shifts exceeding %u bits are not supported\", UINT_MAX);\n \n \tshift = mpz_get_uint32(right->value);\n+\tif (shift == 0) {\n+\t\t*expr = expr_get(left);\n+\t\texpr_free(op);\n+\t\treturn 0;\n+\t}\n+\n \tif (ctx->stmt_len > left->len)\n \t\tmax_shift_len = ctx->stmt_len;\n \telse\n",
    "prefixes": [
        "nft"
    ]
}