Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226538/?format=api
{ "id": 2226538, "url": "http://patchwork.ozlabs.org/api/patches/2226538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/patch/20260422151750.3794520-1-liutong@iscas.ac.cn/", "project": { "id": 67, "url": "http://patchwork.ozlabs.org/api/projects/67/?format=api", "name": "OpenSBI development", "link_name": "opensbi", "list_id": "opensbi.lists.infradead.org", "list_email": "opensbi@lists.infradead.org", "web_url": "https://github.com/riscv/opensbi", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "https://github.com/riscv/opensbi/commit/{}" }, "msgid": "<20260422151750.3794520-1-liutong@iscas.ac.cn>", "list_archive_url": null, "date": "2026-04-22T15:17:50", "name": "lib: sbi_domain: reject zero-size and overflowing ranges in sbi_domain_check_addr_range", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "95baede69c0db1e56197308508f782dedc365ac2", "submitter": { "id": 93225, "url": "http://patchwork.ozlabs.org/api/people/93225/?format=api", "name": "liutong", "email": "liutong@iscas.ac.cn" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/opensbi/patch/20260422151750.3794520-1-liutong@iscas.ac.cn/mbox/", "series": [ { "id": 501031, "url": "http://patchwork.ozlabs.org/api/series/501031/?format=api", "web_url": "http://patchwork.ozlabs.org/project/opensbi/list/?series=501031", "date": "2026-04-22T15:17:50", "name": "lib: sbi_domain: reject zero-size and overflowing ranges in sbi_domain_check_addr_range", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501031/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226538/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qbajq1pg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g12t66YlYz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 01:18:21 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFZLA-0000000AQZk-25Yx;\n\tWed, 22 Apr 2026 15:18:12 +0000", "from smtp81.cstnet.cn ([159.226.251.81] helo=cstnet.cn)\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wFZL4-0000000AQVi-2Yp7\n\tfor opensbi@lists.infradead.org;\n\tWed, 22 Apr 2026 15:18:11 +0000", "from 3930813e24e9.home.arpa (unknown [124.16.138.129])\n\tby APP-03 (Coremail) with SMTP id rQCowAAnRNug5uhpD1rgDg--.1140S2;\n\tWed, 22 Apr 2026 23:17:55 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc\n\t:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=PJYs5YyTVuTvXYunUDt3CLAqMQXfXkeifOhdxZ9eGoY=; b=qbajq1pg8qj+Od\n\tSfwMak3HLAnS9k2WTWuTIBUr+juYEGP2AjMsKM3LvehKHaAokjAi6IuOD3J3pe0tOuvxBYNEPCTJg\n\tvnx1/3qhShzHbtdj/6an+6YRWXAYAJLo9Tu6rl1u5ZKmOHK7bWKrpYzWEbuCUeopDeBgk+/DhGDPa\n\txN98HAepAeqHxXHE9gc3C03WfV//jtyBApiYVJppefRDE6kWKsfCIgi/sEFcfeb1UBmAx7MAlSD4G\n\t0wUZK1gVLKs80xYJrQ8LGvRn+1Po/bjU+2sN3v/RSf6IAcG0qfpgqFRnFol7DWVyyTVkQj8d7XUvP\n\tAL7f7Cq9r7P2dCY7LhZg==;", "From": "liutong <liutong@iscas.ac.cn>", "To": "opensbi@lists.infradead.org", "Cc": "liutong <liutong@iscas.ac.cn>", "Subject": "[PATCH] lib: sbi_domain: reject zero-size and overflowing ranges in\n sbi_domain_check_addr_range", "Date": "Wed, 22 Apr 2026 23:17:50 +0800", "Message-Id": "<20260422151750.3794520-1-liutong@iscas.ac.cn>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "X-CM-TRANSID": "rQCowAAnRNug5uhpD1rgDg--.1140S2", "X-Coremail-Antispam": "1UD129KBjvJXoWrKF4DAF1xtF4ftr4rCr18AFb_yoW8JF45pF\n\tW3K3WUXrZ29r10yw1DKa4Fga40k3y0qw4jkay3AFZ3tw1kZr97CryrXa4q9w17ZFyfA3Wa\n\tva47Zrs8Zr45uaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUkI14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0\n\trVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02\n\t1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j\n\t6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s\n\t0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII\n\tjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr\n\t1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW5WwCF\n\t04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r\n\t18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vI\n\tr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr\n\t1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvE\n\tx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUUuHq7UUUUU==", "X-Originating-IP": "[124.16.138.129]", "X-CM-SenderInfo": "xolx301qj6x2xfdvhtffof0/", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260422_081807_029018_D74783DC ", "X-CRM114-Status": "UNSURE ( 8.42 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-4.2 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: `max = addr + size` is computed without overflow detection,\n and a size of zero is not rejected. In both cases the `while (addr < max)`\n loop executes zero times and the function falls through to `retur [...]\n Content analysis details: (-4.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [159.226.251.81 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]", "X-BeenThere": "opensbi@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<opensbi.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/opensbi/>", "List-Post": "<mailto:opensbi@lists.infradead.org>", "List-Help": "<mailto:opensbi-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/opensbi>,\n <mailto:opensbi-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"opensbi\" <opensbi-bounces@lists.infradead.org>", "Errors-To": "opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "`max = addr + size` is computed without overflow detection, and a\nsize of zero is not rejected. In both cases the `while (addr < max)`\nloop executes zero times and the function falls through to\n`return true` without actually checking any region against the\ndomain configuration.\n\nReject size == 0 and detect unsigned overflow of addr + size before\nentering the loop.\n\nFixes: eab48c33a12d (\"lib: sbi: Add sbi_domain_check_addr_range() function\")\nSigned-off-by: liutong <liutong@iscas.ac.cn>\n---\nApologies for the earlier non-standard submission; resending as a\nproper patch per docs/contributing.md.\n\n lib/sbi/sbi_domain.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c\nindex 7030848d..74a02057 100644\n--- a/lib/sbi/sbi_domain.c\n+++ b/lib/sbi/sbi_domain.c\n@@ -499,12 +499,17 @@ bool sbi_domain_check_addr_range(const struct sbi_domain *dom,\n \t\t\t\t unsigned long mode,\n \t\t\t\t unsigned long access_flags)\n {\n-\tunsigned long max = addr + size;\n+\tunsigned long max;\n \tconst struct sbi_domain_memregion *reg, *sreg;\n \n \tif (!dom)\n \t\treturn false;\n \n+\tif (!size || (addr + size) < addr)\n+\t\treturn false;\n+\n+\tmax = addr + size;\n+\n \twhile (addr < max) {\n \t\treg = find_region(dom, addr);\n \t\tif (!reg)\n", "prefixes": [] }