Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226250/?format=api
{ "id": 2226250, "url": "http://patchwork.ozlabs.org/api/patches/2226250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-24-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-24-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:24", "name": "[PULL,23/40] ui/console-vc: move cursor blinking logic into VT100 layer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fdf85b38dca778dd1cc3a15ac2b72d06fbf3a2d9", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-24-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226250/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KkieSX1i;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wrG3zwnz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:46:22 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV4S-0002Fj-CI; Wed, 22 Apr 2026 06:44:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV37-0007xY-J6\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:22 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV35-00035C-Tv\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:17 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-OZ_21210Oi-BKLIxDeRlUA-1; Wed,\n 22 Apr 2026 06:43:10 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0617318004AD; Wed, 22 Apr 2026 10:43:10 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0138919560AB; Wed, 22 Apr 2026 10:43:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854595;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=vBZDCxWeEWsopOwHYHH/b9wk35a3vQpMNOc6V6JsecE=;\n b=KkieSX1ih9KLA8/wK5VapObPvPkytwDEPEScYmC29NVlphNaCpT4clDCj351mpRiDrTOit\n u88K/7FT4O+uELD33VmzWorveLxNwE/mYLNM58S2D5ZxC3WKJFR+uNZDXDQQk9hOIMAFkL\n SIwyav0ogp4JlzhCxlSZEivnSz9z2tg=", "X-MC-Unique": "OZ_21210Oi-BKLIxDeRlUA-1", "X-Mimecast-MFC-AGG-ID": "OZ_21210Oi-BKLIxDeRlUA_1776854590", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 23/40] ui/console-vc: move cursor blinking logic into VT100\n layer", "Date": "Wed, 22 Apr 2026 14:40:24 +0400", "Message-ID": "<20260422104042.3936506-24-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nMaintain a list of QemuVT100 instances so the cursor timer can directly\niterate over them and call vt100_refresh(), instead of going through\nqemu_invalidate_text_consoles() which iterated over all consoles\n(including graphic ones) and called back into the generic display layer.\n\nThis removes the qemu_invalidate_text_consoles() function from\nconsole.c, further decoupling VT100 text rendering from the console\ncore.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/console.h | 1 -\n ui/console-priv.h | 2 +-\n ui/console-vc-stubs.c | 2 +-\n ui/console-vc.c | 28 +++++++++++++++++++++++-----\n ui/console.c | 19 +------------------\n 5 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/include/ui/console.h b/include/ui/console.h\nindex 788ff103ada..e2e5ff76ec1 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -416,7 +416,6 @@ void qemu_console_set_window_id(QemuConsole *con, int window_id);\n void qemu_console_resize(QemuConsole *con, int width, int height);\n DisplaySurface *qemu_console_surface(QemuConsole *con);\n void coroutine_fn qemu_console_co_wait_update(QemuConsole *con);\n-int qemu_invalidate_text_consoles(void);\n \n /* console-gl.c */\n #ifdef CONFIG_OPENGL\ndiff --git a/ui/console-priv.h b/ui/console-priv.h\nindex 2c2cfd99570..8bcdb79d914 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -36,7 +36,7 @@ struct QemuConsole {\n };\n \n void qemu_text_console_update_size(QemuTextConsole *c);\n-void qemu_text_console_update_cursor(void);\n+void vt100_update_cursor(void);\n void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym);\n \n #endif\ndiff --git a/ui/console-vc-stubs.c b/ui/console-vc-stubs.c\nindex 8a7f19c1f44..d911a82f263 100644\n--- a/ui/console-vc-stubs.c\n+++ b/ui/console-vc-stubs.c\n@@ -14,7 +14,7 @@ void qemu_text_console_update_size(QemuTextConsole *c)\n {\n }\n \n-void qemu_text_console_update_cursor(void)\n+void vt100_update_cursor(void)\n {\n }\n \ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex fca04fe57df..931693a7b0c 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -8,6 +8,7 @@\n #include \"qapi/error.h\"\n #include \"qemu/fifo8.h\"\n #include \"qemu/option.h\"\n+#include \"qemu/queue.h\"\n #include \"ui/console.h\"\n \n #include \"trace.h\"\n@@ -68,8 +69,13 @@ struct QemuVT100 {\n int update_y0;\n int update_x1;\n int update_y1;\n+\n+ QTAILQ_ENTRY(QemuVT100) list;\n };\n \n+static QTAILQ_HEAD(QemuVT100Head, QemuVT100) vt100s =\n+ QTAILQ_HEAD_INITIALIZER(vt100s);\n+\n typedef struct QemuTextConsole {\n QemuConsole parent;\n \n@@ -1042,20 +1048,28 @@ static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n return len;\n }\n \n-void qemu_text_console_update_cursor(void)\n+void vt100_update_cursor(void)\n {\n+ QemuVT100 *vt;\n+\n cursor_visible_phase = !cursor_visible_phase;\n \n- if (qemu_invalidate_text_consoles()) {\n- timer_mod(cursor_timer,\n- qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + CONSOLE_CURSOR_PERIOD / 2);\n+ if (QTAILQ_EMPTY(&vt100s)) {\n+ return;\n+ }\n+\n+ QTAILQ_FOREACH(vt, &vt100s, list) {\n+ vt100_refresh(vt);\n }\n+\n+ timer_mod(cursor_timer,\n+ qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + CONSOLE_CURSOR_PERIOD / 2);\n }\n \n static void\n cursor_timer_cb(void *opaque)\n {\n- qemu_text_console_update_cursor();\n+ vt100_update_cursor();\n }\n \n static void text_console_invalidate(void *opaque)\n@@ -1071,6 +1085,9 @@ static void text_console_invalidate(void *opaque)\n static void\n qemu_text_console_finalize(Object *obj)\n {\n+ QemuTextConsole *s = QEMU_TEXT_CONSOLE(obj);\n+\n+ QTAILQ_REMOVE(&vt100s, &s->vt, list);\n }\n \n static void\n@@ -1095,6 +1112,7 @@ qemu_text_console_init(Object *obj)\n {\n QemuTextConsole *c = QEMU_TEXT_CONSOLE(obj);\n \n+ QTAILQ_INSERT_HEAD(&vt100s, &c->vt, list);\n fifo8_create(&c->out_fifo, 16);\n c->vt.total_height = DEFAULT_BACKSCROLL;\n QEMU_CONSOLE(c)->hw_ops = &text_console_ops;\ndiff --git a/ui/console.c b/ui/console.c\nindex beaef4ad8b8..a7bd22515b9 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -752,7 +752,7 @@ void register_displaychangelistener(DisplayChangeListener *dcl)\n } else if (QEMU_IS_TEXT_CONSOLE(dcl->con)) {\n qemu_text_console_update_size(QEMU_TEXT_CONSOLE(dcl->con));\n }\n- qemu_text_console_update_cursor();\n+ vt100_update_cursor();\n }\n \n void update_displaychangelistener(DisplayChangeListener *dcl,\n@@ -1457,23 +1457,6 @@ int qemu_console_get_height(QemuConsole *con, int fallback)\n }\n }\n \n-int qemu_invalidate_text_consoles(void)\n-{\n- QemuConsole *s;\n- int count = 0;\n-\n- QTAILQ_FOREACH(s, &consoles, next) {\n- if (qemu_console_is_graphic(s) ||\n- !qemu_console_is_visible(s)) {\n- continue;\n- }\n- count++;\n- graphic_hw_invalidate(s);\n- }\n-\n- return count;\n-}\n-\n void qemu_console_resize(QemuConsole *s, int width, int height)\n {\n DisplaySurface *surface = qemu_console_surface(s);\n", "prefixes": [ "PULL", "23/40" ] }