Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226241/?format=api
{ "id": 2226241, "url": "http://patchwork.ozlabs.org/api/patches/2226241/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-37-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-37-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:37", "name": "[PULL,36/40] ui/vnc: fix vnc_display_init() leak on failure", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "59b99f404a01008487ab0ee3b643c6cd981d20f1", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-37-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226241/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NmGBmRDU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wqQ250Zz1yHB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:45:38 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV4R-00026l-Lp; Wed, 22 Apr 2026 06:44:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV4P-0001p1-7T\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:44:37 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV4N-0003L4-7F\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:44:36 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-UBTcyrbxMbiUtEQ_Bz0GFg-1; Wed,\n 22 Apr 2026 06:44:31 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5F5C31800579; Wed, 22 Apr 2026 10:44:30 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 529301800660; Wed, 22 Apr 2026 10:44:28 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854674;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=OoeOj7zf2VibhBKz1qVEpK6tjqVm1MUo6M6TiTkMnHU=;\n b=NmGBmRDU/axpOHVQ3NTpCIrEnSF/A9zHogjKrGypEX8AIeIBQ1fR5KuKSN9wqYViEvKlwL\n EWAHVhpco6m2fnIatPMoOCKiWKEj0anZ/0tU9xsHdm5vQ/2vIhIphRiWNVhTeEal5SyU0t\n bOVTid6okGF4A2gNP68sq4NSTMiaVpo=", "X-MC-Unique": "UBTcyrbxMbiUtEQ_Bz0GFg-1", "X-Mimecast-MFC-AGG-ID": "UBTcyrbxMbiUtEQ_Bz0GFg_1776854670", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 36/40] ui/vnc: fix vnc_display_init() leak on failure", "Date": "Wed, 22 Apr 2026 14:40:37 +0400", "Message-ID": "<20260422104042.3936506-37-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nDo not add the display state to the vnc list, if the initialization\nfailed. Add vnc_display_free(), to free the display state and associated\ndata in such case. The function is meant to be public and reused in the\nfollowing changes.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc.c | 33 +++++++++++++++++++++++++++++----\n 1 file changed, 29 insertions(+), 4 deletions(-)", "diff": "diff --git a/ui/vnc.c b/ui/vnc.c\nindex d5d92c0d99b..37ebd1a534a 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3424,6 +3424,8 @@ static void vmstate_change_handler(void *opaque, bool running, RunState state)\n update_displaychangelistener(&vd->dcl, VNC_REFRESH_INTERVAL_BASE);\n }\n \n+static void vnc_display_free(VncDisplay *vd);\n+\n void vnc_display_init(const char *id, Error **errp)\n {\n VncDisplay *vd;\n@@ -3433,8 +3435,9 @@ void vnc_display_init(const char *id, Error **errp)\n }\n vd = g_malloc0(sizeof(*vd));\n \n+ qemu_mutex_init(&vd->mutex);\n vd->id = g_strdup(id);\n- QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n+ vd->dcl.ops = &dcl_ops;\n \n QTAILQ_INIT(&vd->clients);\n vd->expires = TIME_MAX;\n@@ -3448,22 +3451,22 @@ void vnc_display_init(const char *id, Error **errp)\n }\n \n if (!vd->kbd_layout) {\n+ vnc_display_free(vd);\n return;\n }\n \n vd->share_policy = VNC_SHARE_POLICY_ALLOW_EXCLUSIVE;\n vd->connections_limit = 32;\n \n- qemu_mutex_init(&vd->mutex);\n vnc_start_worker_thread();\n \n- vd->dcl.ops = &dcl_ops;\n register_displaychangelistener(&vd->dcl);\n vd->kbd = qkbd_state_init(vd->dcl.con);\n vd->vmstate_handler_entry = qemu_add_vm_change_state_handler(\n &vmstate_change_handler, vd);\n-}\n \n+ QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n+}\n \n static void vnc_display_close(VncDisplay *vd)\n {\n@@ -3507,6 +3510,28 @@ static void vnc_display_close(VncDisplay *vd)\n #endif\n }\n \n+static void vnc_display_free(VncDisplay *vd)\n+{\n+ if (!vd) {\n+ return;\n+ }\n+\n+ assert(QTAILQ_EMPTY(&vd->clients));\n+\n+ vnc_display_close(vd);\n+ unregister_displaychangelistener(&vd->dcl);\n+ qkbd_state_free(vd->kbd);\n+ qemu_del_vm_change_state_handler(vd->vmstate_handler_entry);\n+ kbd_layout_free(vd->kbd_layout);\n+ qemu_mutex_destroy(&vd->mutex);\n+ if (QTAILQ_IN_USE(vd, next)) {\n+ QTAILQ_REMOVE(&vnc_displays, vd, next);\n+ }\n+ g_free(vd->id);\n+ g_free(vd);\n+}\n+\n+\n int vnc_display_password(const char *id, const char *password, Error **errp)\n {\n VncDisplay *vd = vnc_display_find(id);\n", "prefixes": [ "PULL", "36/40" ] }