Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226238/?format=api
{ "id": 2226238, "url": "http://patchwork.ozlabs.org/api/patches/2226238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-35-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-35-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:35", "name": "[PULL,34/40] ui/vnc: VncDisplay.id is not const", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3be6ad6ca7e4577bc38e698cc7914a10896d4784", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-35-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226238/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Iza8KCrX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wqF1ndzz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:45:29 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV4S-0002J8-LS; Wed, 22 Apr 2026 06:44:40 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV4I-0000ps-RZ\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:44:31 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV4C-0003HU-HV\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:44:28 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-skud3djgNAOvGnYBpIQpZA-1; Wed,\n 22 Apr 2026 06:44:19 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C92EE1956088; Wed, 22 Apr 2026 10:44:18 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 575A919560AB; Wed, 22 Apr 2026 10:44:16 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854663;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=qa4ZRXbb55roIjKCRf6D/q3tb4pr40RYyAXAB/YDbiM=;\n b=Iza8KCrXXkW8RE9yNE1ZcLDzbCaGOcLOeR57qoMRnBH/04tmg4PrXwrDI+uUbVcTLHlhz9\n gdfK8ntBSf2dtxxeCUwcreiLvU4ppvUwqEggDnCyxO041TXZZRImsIy4nyW5kwW5Pg/QIz\n pw+HWdpSpmVDroperMbhgglqRX4buoE=", "X-MC-Unique": "skud3djgNAOvGnYBpIQpZA-1", "X-Mimecast-MFC-AGG-ID": "skud3djgNAOvGnYBpIQpZA_1776854658", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 34/40] ui/vnc: VncDisplay.id is not const", "Date": "Wed, 22 Apr 2026 14:40:35 +0400", "Message-ID": "<20260422104042.3936506-35-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\ns/strdup/g_strdup to highlight the issue and be consistent with other\nallocations.\n\nThe next patch is going to introduce vnc_display_free() to take care of\ndeallocating it.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc.h | 2 +-\n ui/vnc.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/ui/vnc.h b/ui/vnc.h\nindex ec8d0c91b57..c5d678ac31e 100644\n--- a/ui/vnc.h\n+++ b/ui/vnc.h\n@@ -166,7 +166,7 @@ struct VncDisplay\n pixman_image_t *server; /* vnc server surface */\n int true_width; /* server surface width before rounding up */\n \n- const char *id;\n+ char *id;\n QTAILQ_ENTRY(VncDisplay) next;\n char *password;\n time_t expires;\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 23af83fd6c8..d5d92c0d99b 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3433,7 +3433,7 @@ void vnc_display_init(const char *id, Error **errp)\n }\n vd = g_malloc0(sizeof(*vd));\n \n- vd->id = strdup(id);\n+ vd->id = g_strdup(id);\n QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n \n QTAILQ_INIT(&vd->clients);\n", "prefixes": [ "PULL", "34/40" ] }