Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226223/?format=api
{ "id": 2226223, "url": "http://patchwork.ozlabs.org/api/patches/2226223/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-22-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-22-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:22", "name": "[PULL,21/40] ui/console-vc: decouple VT100 display updates via function pointer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "21eb47b73d83106b1ab361ba3696e7936f2ddd85", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-22-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226223/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=TYB5nqoW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wnW5gDgz1yHB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:43:59 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV3P-0008Nm-IE; Wed, 22 Apr 2026 06:43:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV2s-0007qZ-TB\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:06 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV2r-0002sL-1X\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:43:02 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-J4wsfUteMMG_Ce6c7WFEfg-1; Wed,\n 22 Apr 2026 06:42:58 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B863A18002C6; Wed, 22 Apr 2026 10:42:57 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9805E1800446; Wed, 22 Apr 2026 10:42:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854580;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=dAPEZqPVlqI/Ix+UbD+z6qbYzx34VN3hlz27RXGb1r4=;\n b=TYB5nqoWK71fnkddXacz5nGlBxrsIPM/gTHGDLwRFsxto7dhaummPoK2qM/xIyjhjbAxA+\n vaHI4KOM4ZgKAV6nw5tswVbfIvYuuf7EozGjPvZhXOyr+NLcBLuSwg5cDVbjJrhVVt7yZL\n bsni/4+EMU2zZXoCb6NB0UiFHthVWSI=", "X-MC-Unique": "J4wsfUteMMG_Ce6c7WFEfg-1", "X-Mimecast-MFC-AGG-ID": "J4wsfUteMMG_Ce6c7WFEfg_1776854577", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 21/40] ui/console-vc: decouple VT100 display updates via\n function pointer", "Date": "Wed, 22 Apr 2026 14:40:22 +0400", "Message-ID": "<20260422104042.3936506-22-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nReplace direct dpy_gfx_update() calls from the VT100 emulation code\nwith an indirect call through a new image_update function pointer in\nQemuVT100. This decouples the VT100 terminal emulation from the\nQEMU display layer, allowing different backends to provide their own\nimage update implementation.\n\nThe QemuVT100 typedef is changed to a forward-declared struct so the\nfunction pointer signature can reference QemuVT100 itself.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/console-vc.c | 28 ++++++++++++++++++++++------\n 1 file changed, 22 insertions(+), 6 deletions(-)", "diff": "diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex fb1c8866a03..bc8462f979e 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -47,8 +47,11 @@ enum TTYState {\n TTY_STATE_OSC,\n };\n \n-typedef struct QemuVT100 {\n+typedef struct QemuVT100 QemuVT100;\n+\n+struct QemuVT100 {\n pixman_image_t *image;\n+ void (*image_update)(QemuVT100 *vt, int x, int y, int width, int height);\n \n int width;\n int height;\n@@ -65,7 +68,7 @@ typedef struct QemuVT100 {\n int update_y0;\n int update_x1;\n int update_y1;\n-} QemuVT100;\n+};\n \n typedef struct QemuTextConsole {\n QemuConsole parent;\n@@ -221,6 +224,11 @@ static void vt100_show_cursor(QemuVT100 *vt, int show)\n }\n }\n \n+static void vt100_image_update(QemuVT100 *vt, int x, int y, int width, int height)\n+{\n+ vt->image_update(vt, x, y, width, height);\n+}\n+\n static void console_refresh(QemuTextConsole *s)\n {\n QemuVT100 *vt = &s->vt;\n@@ -250,7 +258,7 @@ static void console_refresh(QemuTextConsole *s)\n }\n }\n vt100_show_cursor(&s->vt, 1);\n- dpy_gfx_update(QEMU_CONSOLE(s), 0, 0, w, h);\n+ vt100_image_update(&s->vt, 0, 0, w, h);\n }\n \n static void console_scroll(QemuTextConsole *s, int ydelta)\n@@ -1028,9 +1036,9 @@ static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n }\n vt100_show_cursor(vt, 1);\n if (vt->update_x0 < vt->update_x1) {\n- dpy_gfx_update(QEMU_CONSOLE(s), vt->update_x0, vt->update_y0,\n- vt->update_x1 - vt->update_x0,\n- vt->update_y1 - vt->update_y0);\n+ vt100_image_update(vt, vt->update_x0, vt->update_y0,\n+ vt->update_x1 - vt->update_x0,\n+ vt->update_y1 - vt->update_y0);\n }\n return len;\n }\n@@ -1128,6 +1136,13 @@ void qemu_text_console_update_size(QemuTextConsole *c)\n dpy_text_resize(QEMU_CONSOLE(c), c->vt.width, c->vt.height);\n }\n \n+static void text_console_image_update(QemuVT100 *vt, int x, int y, int width, int height)\n+{\n+ QemuTextConsole *console = container_of(vt, QemuTextConsole, vt);\n+\n+ dpy_gfx_update(QEMU_CONSOLE(console), x, y, width, height);\n+}\n+\n static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n {\n ChardevVC *vc = backend->u.vc.data;\n@@ -1158,6 +1173,7 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n }\n \n dpy_gfx_replace_surface(QEMU_CONSOLE(s), qemu_create_displaysurface(width, height));\n+ s->vt.image_update = text_console_image_update;\n \n s->chr = chr;\n drv->console = s;\n", "prefixes": [ "PULL", "21/40" ] }