Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226221/?format=api
{ "id": 2226221, "url": "http://patchwork.ozlabs.org/api/patches/2226221/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-19-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-19-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:19", "name": "[PULL,18/40] ui/console-vc: vga_putcharxy()->vt100_putcharxy()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "583027280b909c067739766038ee1a6d53675dfc", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-19-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226221/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=F4tsUaR1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wms22hgz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:43:25 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV2f-0007V2-F1; Wed, 22 Apr 2026 06:42:49 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV2a-0007D5-2g\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:44 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV2Y-0002ko-Bo\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:43 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-9HgSc1RrOnC5YwcmeqVBiQ-1; Wed,\n 22 Apr 2026 06:42:40 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A2F4119560B2; Wed, 22 Apr 2026 10:42:39 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 58B3E19560AB; Wed, 22 Apr 2026 10:42:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854561;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1duRi/KO8QDaQUrsoWP79lqJXRWmTNZKahK23903zWo=;\n b=F4tsUaR1u+MeSl7HKuOZqmu/enQNrbOX+wJWWDipdbjtzGpB+3wo6yDrd7KFEvRCYznunt\n xSPBHepIZuur4rM94+E+VzQfDTLUHV2rxSNu3mHuQqTCgv0fJFWsUMRGTChke5vBOl44Y1\n 2T5JLNHf+1tq6k/OByrG3n1KP9tvtvg=", "X-MC-Unique": "9HgSc1RrOnC5YwcmeqVBiQ-1", "X-Mimecast-MFC-AGG-ID": "9HgSc1RrOnC5YwcmeqVBiQ_1776854559", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 18/40] ui/console-vc: vga_putcharxy()->vt100_putcharxy()", "Date": "Wed, 22 Apr 2026 14:40:19 +0400", "Message-ID": "<20260422104042.3936506-19-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nHave the character rendering function operate on QemuVT100 directly\ninstead of taking a QemuConsole and extracting the VT100 state\ninternally. This decouples glyph rendering from the console object,\ncontinuing the QemuVT100 abstraction introduced in the previous commits.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/console-vc.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 272240712ad..3d73bdf2982 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -154,14 +154,13 @@ static void image_bitblt(pixman_image_t *image,\n xs, ys, 0, 0, xd, yd, w, h);\n }\n \n-static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,\n- TextAttributes *t_attrib)\n+static void vt100_putcharxy(QemuVT100 *vt, int x, int y, int ch,\n+ TextAttributes *t_attrib)\n {\n static pixman_image_t *glyphs[256];\n- pixman_image_t *image = QEMU_TEXT_CONSOLE(s)->vt.image;\n pixman_color_t fgcol, bgcol;\n \n- assert(image);\n+ assert(vt->image);\n if (t_attrib->invers) {\n bgcol = color_table_rgb[t_attrib->bold][t_attrib->fgcol];\n fgcol = color_table_rgb[t_attrib->bold][t_attrib->bgcol];\n@@ -173,7 +172,7 @@ static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,\n if (!glyphs[ch]) {\n glyphs[ch] = qemu_pixman_glyph_from_vgafont(FONT_HEIGHT, vgafont16, ch);\n }\n- qemu_pixman_glyph_render(glyphs[ch], image,\n+ qemu_pixman_glyph_render(glyphs[ch], vt->image,\n &fgcol, &bgcol, x, y, FONT_WIDTH, FONT_HEIGHT);\n }\n \n@@ -216,9 +215,9 @@ static void console_show_cursor(QemuTextConsole *s, int show)\n if (show && cursor_visible_phase) {\n TextAttributes t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n t_attrib.invers = !(t_attrib.invers); /* invert fg and bg */\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch, &t_attrib);\n+ vt100_putcharxy(&s->vt, x, y, c->ch, &t_attrib);\n } else {\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch, &(c->t_attrib));\n+ vt100_putcharxy(&s->vt, x, y, c->ch, &(c->t_attrib));\n }\n invalidate_xy(s, x, y);\n }\n@@ -244,7 +243,7 @@ static void console_refresh(QemuTextConsole *s)\n for (y = 0; y < vt->height; y++) {\n c = vt->cells + y1 * vt->width;\n for (x = 0; x < vt->width; x++) {\n- vga_putcharxy(QEMU_CONSOLE(s), x, y, c->ch,\n+ vt100_putcharxy(vt, x, y, c->ch,\n &(c->t_attrib));\n c++;\n }\n@@ -590,7 +589,7 @@ static void vc_update_xy(VCChardev *vc, int x, int y)\n x = vt->width - 1;\n }\n c = &vt->cells[y1 * vt->width + x];\n- vga_putcharxy(QEMU_CONSOLE(s), x, y2, c->ch,\n+ vt100_putcharxy(vt, x, y2, c->ch,\n &(c->t_attrib));\n invalidate_xy(s, x, y2);\n }\n", "prefixes": [ "PULL", "18/40" ] }