Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226215/?format=api
{ "id": 2226215, "url": "http://patchwork.ozlabs.org/api/patches/2226215/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-11-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-11-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:11", "name": "[PULL,10/40] ui/vnc-jobs: narrow taking the queue lock", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e8f0f355b7f6dfe619ec71ff75765c9f72cd1b03", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-11-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226215/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QAy9etCl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wmS0f6Yz1yHB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:43:04 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV2M-0005vS-Rf; Wed, 22 Apr 2026 06:42:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV24-0005cU-9f\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:12 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV22-0002Om-Ps\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:42:12 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-wLJjZkMZMPqcr3NHYtL0zw-1; Wed,\n 22 Apr 2026 06:41:53 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id CE4CE195609E; Wed, 22 Apr 2026 10:41:50 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8F81D180047F; Wed, 22 Apr 2026 10:41:49 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854526;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Q1Kn6LTd7bvM3/pbm3eKeUmXgXG3x57/GzAM1f3WSL4=;\n b=QAy9etClxqBuKK95X/PS8sOHGHkaSe/r9MHVfR9hGOG/4nEUIxxwhixeIvUculShg8irTf\n gmyjRLFZvO22N8L+CCZcWzsWggg+t7sp0TfZw9b9SNHbqAtuiXPuxtSLGX/cHNZjnOucsS\n zGOyTfXC38ESQKGuLPJHmCUSyyfHXYQ=", "X-MC-Unique": "wLJjZkMZMPqcr3NHYtL0zw-1", "X-Mimecast-MFC-AGG-ID": "wLJjZkMZMPqcr3NHYtL0zw_1776854510", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 10/40] ui/vnc-jobs: narrow taking the queue lock", "Date": "Wed, 22 Apr 2026 14:40:11 +0400", "Message-ID": "<20260422104042.3936506-11-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nIt's not needed unless manipulating the queue.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vnc-jobs.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 28a4738f1ec..9c17d684c9e 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -83,26 +83,26 @@ VncJob *vnc_job_new(VncState *vs)\n \n assert(vs->magic == VNC_MAGIC);\n job->vs = vs;\n- vnc_lock_queue(queue);\n QLIST_INIT(&job->rectangles);\n- vnc_unlock_queue(queue);\n return job;\n }\n \n+/*\n+ * Do not call this after pushing the job.\n+ */\n int vnc_job_add_rect(VncJob *job, int x, int y, int w, int h)\n {\n VncRectEntry *entry = g_new0(VncRectEntry, 1);\n \n trace_vnc_job_add_rect(job->vs, job, x, y, w, h);\n+ assert(!QTAILQ_IN_USE(job, next));\n \n entry->rect.x = x;\n entry->rect.y = y;\n entry->rect.w = w;\n entry->rect.h = h;\n \n- vnc_lock_queue(queue);\n QLIST_INSERT_HEAD(&job->rectangles, entry, next);\n- vnc_unlock_queue(queue);\n return 1;\n }\n \n@@ -120,16 +120,21 @@ static void vnc_job_free(VncJob *job)\n g_free(job);\n }\n \n+/*\n+ * Push a job onto the queue. Ownership of the job is transferred.\n+ */\n void vnc_job_push(VncJob *job)\n {\n- vnc_lock_queue(queue);\n+ assert(!QTAILQ_IN_USE(job, next));\n+\n if (QLIST_EMPTY(&job->rectangles)) {\n vnc_job_free(job);\n } else {\n+ vnc_lock_queue(queue);\n QTAILQ_INSERT_TAIL(&queue->jobs, job, next);\n qemu_cond_broadcast(&queue->cond);\n+ vnc_unlock_queue(queue);\n }\n- vnc_unlock_queue(queue);\n }\n \n static bool vnc_has_job_locked(VncState *vs)\n", "prefixes": [ "PULL", "10/40" ] }