Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226206/?format=api
{ "id": 2226206, "url": "http://patchwork.ozlabs.org/api/patches/2226206/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-3-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422104042.3936506-3-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2026-04-22T10:40:03", "name": "[PULL,02/40] ui/spice-app: detect runtime directory creation failures", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0ebb9c0a39c706f82d252aa80a0b6aaf200184d5", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422104042.3936506-3-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 500973, "url": "http://patchwork.ozlabs.org/api/series/500973/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500973", "date": "2026-04-22T10:40:02", "name": "[PULL,01/40] ui/input-linux: close evdev fd when qemu_set_blocking fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500973/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226206/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226206/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ROjedMx3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0wlK0cJHz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 20:42:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFV1K-00040O-OY; Wed, 22 Apr 2026 06:41:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV16-0003uL-Ee\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:41:13 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wFV10-0002AU-Vv\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 06:41:09 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-643--6OBsdM7MSmQECLObJJVMA-1; Wed,\n 22 Apr 2026 06:41:01 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 719C4180034D; Wed, 22 Apr 2026 10:41:00 +0000 (UTC)", "from localhost (unknown [10.44.22.21])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C72B33000C15; Wed, 22 Apr 2026 10:40:58 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776854465;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4hqN1Kugycd4KH9Wqc6KEj3jfYJJzyW5nlCl72WtZig=;\n b=ROjedMx3Jb6Lis8OJXBw6zvHBG3BbtJIUK49rpqOt70D3UWXE2CpfrVbrwcszuI7xeO3ci\n DvUp8y4yr4XuG3DYkXepA1oYvarL5fjfxIx2ssjdicMkhT7dSHJ2MtCbuevoVXO9z3GDC/\n mQv85voS5YjD4voA+9bC5eKCeiWgUAM=", "X-MC-Unique": "-6OBsdM7MSmQECLObJJVMA-1", "X-Mimecast-MFC-AGG-ID": "-6OBsdM7MSmQECLObJJVMA_1776854460", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org, GuoHan Zhao <zhaoguohan@kylinos.cn>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 02/40] ui/spice-app: detect runtime directory creation failures", "Date": "Wed, 22 Apr 2026 14:40:03 +0400", "Message-ID": "<20260422104042.3936506-3-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "References": "<20260422104042.3936506-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: GuoHan Zhao <zhaoguohan@kylinos.cn>\n\nspice_app_display_early_init() creates the per-VM runtime directory\nwith g_mkdir_with_parents() before setting up the Spice socket. The\ncode checks for \"< -1\", but g_mkdir_with_parents() returns -1 on\nfailure, so the error path is never taken.\n\nThis lets spice-app continue after a directory creation failure and\ndefers the problem to later setup steps.\n\nCheck for \"< 0\" instead so the failure is reported immediately and\nspice-app exits before using an invalid runtime directory.\n\nFixes: d8aec9d9f129 (\"display: add -display spice-app launching a Spice client\")\nSigned-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nMessage-ID: <20260408031725.641417-1-zhaoguohan@kylinos.cn>\n---\n ui/spice-app.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/ui/spice-app.c b/ui/spice-app.c\nindex 9e55f273715..0df7325e679 100644\n--- a/ui/spice-app.c\n+++ b/ui/spice-app.c\n@@ -151,7 +151,7 @@ static void spice_app_display_early_init(DisplayOptions *opts)\n if (qemu_name) {\n app_dir = g_build_filename(g_get_user_runtime_dir(),\n \"qemu\", qemu_name, NULL);\n- if (g_mkdir_with_parents(app_dir, S_IRWXU) < -1) {\n+ if (g_mkdir_with_parents(app_dir, S_IRWXU) < 0) {\n error_report(\"Failed to create directory %s: %s\",\n app_dir, strerror(errno));\n exit(1);\n", "prefixes": [ "PULL", "02/40" ] }