Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2226090/?format=api
{ "id": 2226090, "url": "http://patchwork.ozlabs.org/api/patches/2226090/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422082214.10390-2-armenon@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422082214.10390-2-armenon@redhat.com>", "list_archive_url": null, "date": "2026-04-22T08:22:13", "name": "[v3,1/2] migration/vmstate: Add VMState support for GByteArray", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3b04128b99346d934265e98ff3fd584e5a591485", "submitter": { "id": 91136, "url": "http://patchwork.ozlabs.org/api/people/91136/?format=api", "name": "Arun Menon", "email": "armenon@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422082214.10390-2-armenon@redhat.com/mbox/", "series": [ { "id": 500941, "url": "http://patchwork.ozlabs.org/api/series/500941/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500941", "date": "2026-04-22T08:22:13", "name": "migration/vmstate: Add VMState support to safely migrate GByteArray", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/500941/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226090/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=g1Tv3AiK;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=TkoankDl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0sfc5gSTz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 18:22:48 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFSr1-0006PG-BQ; Wed, 22 Apr 2026 04:22:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wFSqr-0006N9-UP\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:30 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wFSqo-0006ar-T4\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:29 -0400", "from mail-pj1-f70.google.com (mail-pj1-f70.google.com\n [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-307-FVPFynTXO0qGkrhOe1enhA-1; Wed, 22 Apr 2026 04:22:24 -0400", "by mail-pj1-f70.google.com with SMTP id\n 98e67ed59e1d1-358e95e81aeso3467905a91.0\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 01:22:24 -0700 (PDT)", "from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fabeccesm5991459a91.6.2026.04.22.01.22.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 01:22:22 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776846146;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Joilcik9KtEdJZjq4mdYWkp4FhfcJg7uC8Vb6+X8nd4=;\n b=g1Tv3AiKU+/LpaTbO9o8Dy2rVshGLWiCnSV0aRU4G8uM1H3AM4FMzGIXekgH5p/H1rO1Dd\n leoAkkYwRpLMudjCdE0yrA7TJn/CnZReOu0eZzIKLIXPEvVbNc2OcDDmElVzbVYQlQcHBX\n 2nMK5UVg4MKqw9s85L/kvEmEcH6Mh20=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776846144; x=1777450944; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Joilcik9KtEdJZjq4mdYWkp4FhfcJg7uC8Vb6+X8nd4=;\n b=TkoankDlRhkHuvk3cAydhqza4XL19tcq+QB5dp8RUZ1FF/mZi6VjxL3PTt07s1haKk\n cXQ+meTPhSFvpKfMaV5YonfFRPjJYIqkobiP8eCezzbpH7U8T9SHOaxuxxEPzX4eHDuU\n VOQ8yS3yrdI98taCsdxSxCGAguWCBCwk+7R8gdiuNGaNSCULQO0YKjv7LkF8FIvzDNmk\n tbkB8xqRfPiNxJUeaW51Wj3LT9dGE/aXNYEbfr6jBrYyG4t6KHhrq7kADpI+dKKb9Vst\n oYPOZ3yYjeQJsolqWrd2dlQ6v97RuZWu+2IDhKR5NpzxFM+sG8iaAzUfiPGjN69cKUIT\n xigg==" ], "X-MC-Unique": "FVPFynTXO0qGkrhOe1enhA-1", "X-Mimecast-MFC-AGG-ID": "FVPFynTXO0qGkrhOe1enhA_1776846144", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776846144; x=1777450944;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Joilcik9KtEdJZjq4mdYWkp4FhfcJg7uC8Vb6+X8nd4=;\n b=m25LCpLtiWRQTCDh5qO4gFqx88f/ophYnR4RYRZdW7TEvjSAyhvel5Hh+pn3y0dHRH\n KpAxG2ZcfEhkPYExrhuP2uKX3r/nt3Fiy9XHoOUzTg+9V9NDL+hiFT/oZ51TuLKUYgYx\n cdLDiRDqPbYqWcmx8WfAYDTfayEN8g7RU3XGuJ6kNz8vFFEtVHQi2V++F77giqSJQpiA\n xujFn1qWPWR8xTvR37jOuHil3MfUtqw6GDQ+kAwZ/DngjMch42DajDC3SFok5OJpC/nt\n J3pA3SL5idadaXINBtIhSbbRnkQim5aC7ljJAfJnh1GP3iHFWmV0GD30ClrIJ+0atjc5\n 3oKA==", "X-Gm-Message-State": "AOJu0YwbVhxWC7534HL7qMZk7C3ZJUCQyKRWgPbpJ5xAsCSNJhmsew39\n kNZswlzfidYBaClHTsEE8Yo6ezUH0Ia+X341ev/kE8CJ0TG6TwUy9LxwJoM6Ig+3kAHN7wie+AX\n 3EzuIT5rS/K7lFESt27dH6OleA71CXTzchP7YrlhpdnNIi0phS1OpwAyY/Rw0vxaQWhY/A6cONP\n 8SOdp4pCmuv1nwrAbh3q1mMX/JmrVf9VaGnHtYpeg=", "X-Gm-Gg": "AeBDievx3kP5EX6iHKJNf/LdopPabUD1ghNqKq3VQuHFb0rrhxsjbmqWkj5HHbby78W\n ZRoX3rrLdavbOj/TQxRZeB8uJybiknT8n5ubskP2bCYPZQ0jjLpPutMMjGPExBeRZi5+zOawY3t\n juDBKciNKOV92lRVDraQsBggW2QwAqq4V3+j3+hhCllSO1MOBx61FW2aXG1MdNwuw0mpTPP2ENh\n CrFMHXsBbO2sfoCWVtb5gD9cRJqBCrQ1v4u5l+ro1HyxSsycpQQFCwTWT27ZOo8P9MW5cgQXmQW\n nxqai4dlKh87C95qmH/N6Ztb1Xkjao5eryZPsAlQA6rUitdM1psnSTbR+nfHL74/3ZdGqdNhpmf\n I8+/mycRq8lnRguYV7j4vVSqUk1Qwub7p5DbMSMl5fE/N6zpZ0kYAKHQV9NwPdCj2q6HLJTvayg\n ==", "X-Received": [ "by 2002:a17:90b:3d01:b0:35f:b75e:fff5 with SMTP id\n 98e67ed59e1d1-3614048b7admr24121777a91.22.1776846143685;\n Wed, 22 Apr 2026 01:22:23 -0700 (PDT)", "by 2002:a17:90b:3d01:b0:35f:b75e:fff5 with SMTP id\n 98e67ed59e1d1-3614048b7admr24121739a91.22.1776846143066;\n Wed, 22 Apr 2026 01:22:23 -0700 (PDT)" ], "From": "Arun Menon <armenon@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Arun Menon <armenon@redhat.com>", "Subject": "[PATCH v3 1/2] migration/vmstate: Add VMState support for GByteArray", "Date": "Wed, 22 Apr 2026 13:52:13 +0530", "Message-ID": "<20260422082214.10390-2-armenon@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260422082214.10390-1-armenon@redhat.com>", "References": "<20260422082214.10390-1-armenon@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Arun Menon <armenon@redhat.com>\n\nIn GLib, GByteArray is an object managed by the library. Currently,\nmigrating a GByteArray requires treating it as a raw C struct and using\nVMSTATE_VBUFFER_ALLOC_UINT32. For example, see vmstate_vdba in\nui/vdagent.c\n\nQEMU cannot pretend that GByteArray is a C struct and simply use\nVMS_ALLOC to g_malloc() the buffer. This is because, VMS_ALLOC blindly\noverwrites the data pointer with a newly allocated buffer, thereby\nleaking the previous memory. Besides, GLib tracks the array's capacity\nin a hidden alloc field. Bypassing GLib APIs leave this capacity out of\nsync with the newly allocated buffer, potentially leading to heap buffer\noverflows during subsequent g_byte_array_append() calls.\n\nThis commit introduces VMSTATE_GBYTEARRAY which uses specific library\nAPI calls (g_byte_array_set_size()) to safely resize and populate the\nbuffer.\n\nSigned-off-by: Arun Menon <armenon@redhat.com>\nFix-Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/migration/vmstate.h | 10 ++++++++++\n migration/vmstate-types.c | 37 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 47 insertions(+)", "diff": "diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h\nindex 62c2abd0c4..f503a40ec0 100644\n--- a/include/migration/vmstate.h\n+++ b/include/migration/vmstate.h\n@@ -265,6 +265,7 @@ extern const VMStateInfo vmstate_info_bitmap;\n extern const VMStateInfo vmstate_info_qtailq;\n extern const VMStateInfo vmstate_info_gtree;\n extern const VMStateInfo vmstate_info_qlist;\n+extern const VMStateInfo vmstate_info_g_byte_array;\n \n #define type_check_2darray(t1,t2,n,m) ((t1(*)[n][m])0 - (t2*)0)\n /*\n@@ -892,6 +893,15 @@ extern const VMStateInfo vmstate_info_qlist;\n .start = offsetof(_type, _next), \\\n }\n \n+#define VMSTATE_GBYTEARRAY(_field, _state, _version) { \\\n+ .name = (stringify(_field)), \\\n+ .version_id = (_version), \\\n+ .size = sizeof(GByteArray), \\\n+ .info = &vmstate_info_g_byte_array, \\\n+ .flags = VMS_SINGLE, \\\n+ .offset = vmstate_offset_pointer(_state, _field, GByteArray), \\\n+}\n+\n /* _f : field name\n _f_n : num of elements field_name\n _n : num of elements\ndiff --git a/migration/vmstate-types.c b/migration/vmstate-types.c\nindex 89cb211472..e3a47e60b1 100644\n--- a/migration/vmstate-types.c\n+++ b/migration/vmstate-types.c\n@@ -942,3 +942,40 @@ const VMStateInfo vmstate_info_qlist = {\n .get = get_qlist,\n .put = put_qlist,\n };\n+\n+static int get_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field)\n+{\n+ GByteArray **byte_array = (GByteArray **)pv;\n+ uint32_t len = qemu_get_be32(f);\n+\n+ assert(*byte_array != NULL);\n+\n+ g_byte_array_set_size(*byte_array, len);\n+ if (len > 0) {\n+ qemu_get_buffer(f, (*byte_array)->data, len);\n+ }\n+ return 0;\n+}\n+\n+static int put_g_byte_array(QEMUFile *f, void *pv, size_t size,\n+ const VMStateField *field, JSONWriter *vmdesc)\n+{\n+ GByteArray *byte_array = *(GByteArray **)pv;\n+ uint32_t len;\n+ assert(byte_array != NULL);\n+\n+ len = byte_array ? byte_array->len : 0;\n+ qemu_put_be32(f, len);\n+ if (len > 0) {\n+ qemu_put_buffer(f, byte_array->data, len);\n+ }\n+\n+ return 0;\n+}\n+\n+const VMStateInfo vmstate_info_g_byte_array = {\n+ .name = \"GByteArray\",\n+ .get = get_g_byte_array,\n+ .put = put_g_byte_array,\n+};\n", "prefixes": [ "v3", "1/2" ] }