Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2225838/?format=api
{ "id": 2225838, "url": "http://patchwork.ozlabs.org/api/patches/2225838/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260421163031.704-6-alifm@linux.ibm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421163031.704-6-alifm@linux.ibm.com>", "list_archive_url": null, "date": "2026-04-21T16:30:29", "name": "[v14,5/7] vfio-pci/zdev: Add a device feature for error information", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e4df313d610e0ec48c023f4358bb1e678f86303c", "submitter": { "id": 73785, "url": "http://patchwork.ozlabs.org/api/people/73785/?format=api", "name": "Farhan Ali", "email": "alifm@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260421163031.704-6-alifm@linux.ibm.com/mbox/", "series": [ { "id": 500852, "url": "http://patchwork.ozlabs.org/api/series/500852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=500852", "date": "2026-04-21T16:30:25", "name": "Error recovery for vfio-pci devices on s390x", "version": 14, "mbox": "http://patchwork.ozlabs.org/series/500852/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225838/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225838/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-52859-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=tYF/H0OI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52859-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"tYF/H0OI\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0ScY6BJNz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 02:34:37 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 54F53308315C\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 16:31:14 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 616DA37FF4C;\n\tTue, 21 Apr 2026 16:30:51 +0000 (UTC)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9543537CD4C;\n\tTue, 21 Apr 2026 16:30:49 +0000 (UTC)", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63LCsms82037597;\n\tTue, 21 Apr 2026 16:30:42 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dm2h9mg51-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 16:30:42 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63LGKN2C019186;\n\tTue, 21 Apr 2026 16:30:41 GMT", "from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dmm9q1ksm-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 21 Apr 2026 16:30:41 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n\tby smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63LGUev131851118\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 21 Apr 2026 16:30:40 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2873158054;\n\tTue, 21 Apr 2026 16:30:40 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0E4075805A;\n\tTue, 21 Apr 2026 16:30:39 +0000 (GMT)", "from IBM-D32RQW3.ibm.com (unknown [9.61.248.17])\n\tby smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 21 Apr 2026 16:30:38 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776789051; cv=none;\n b=g1wZNsnL/PBzv1VXrcE+N9I3XMPArh+k7CJJKn8wcOkDYLa8QMZ0PZ6o6O+uKuof7qQOZuBnJFIREsQP9Sdhq2qtLLkJtg0Ulb3VpfXqtiHtIXsAuSoLgps3x3+eP+p65zXoAf6ckNIbOnHyKUoxdFBcsxmydpQEhkulmawU0cg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776789051; c=relaxed/simple;\n\tbh=eiJrB5o9TZHJJ9HAMSy4/jT0X60NhIPg1P4PGgCUZXk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=gMCEUFZArnh5zWB+LoIedud4pItVVe0LkCeK5KxzyOFkU5S7/1wdclRW6GZA1Phz+5aC8XwxHMbYtNrUvx1JmtCCh7ZKD9olhfreOZz6R+ong5zZoTd/RGKOC4AN92j2BNamQwLClG7wVt1YpRrRd+m+xkEOHBPxl/Yjt3eCaq8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=tYF/H0OI; arc=none smtp.client-ip=148.163.158.5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=u5vmS2PtUA7pd+9JN\n\tAtk4kukSpva1fgCV6pdm1ydphQ=; b=tYF/H0OINj4u4u85NyZIyllBqcCq0pjeU\n\tYxRujMWZl5NCWQeeslh+Wydu5OHbVObo7+ydydeCO+0o4rLjVadWtBVcoiVjI49B\n\t+IueEvm1IYr+iepWZcUa6T2IdgoTPRWm6nAFrm9W7X6q6ahABwfkQ0/FwZwFSjp5\n\t9JQuZ9oUx3WyFawUIXcDLONIJJb+YwLySc+Sm6WuMi4TYAyXqLN6H2C+OoC8kBTm\n\tW0h+V4PVUv0oaCCtSEH5LKNCPsE6iIUyKXABQ5YV3qTPf39GpvXY3dOX/DG0CNCu\n\tbqDdAlPGaRyJIZuHBWErGgURKgHOfO2pfCyFWelfbYYMqXI0PvSbw==", "From": "Farhan Ali <alifm@linux.ibm.com>", "To": "linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org", "Cc": "helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n alifm@linux.ibm.com, schnelle@linux.ibm.com, mjrosato@linux.ibm.com", "Subject": "[PATCH v14 5/7] vfio-pci/zdev: Add a device feature for error\n information", "Date": "Tue, 21 Apr 2026 09:30:29 -0700", "Message-ID": "<20260421163031.704-6-alifm@linux.ibm.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260421163031.704-1-alifm@linux.ibm.com>", "References": "<20260421163031.704-1-alifm@linux.ibm.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-ORIG-GUID": "Y2D0O8dydVFHz1qhCWQkjU-NruMsLYeb", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDIxMDE2MiBTYWx0ZWRfX0QxDb317dh3l\n zLPm2lTn+S6SRUEzR1KiU83ubYMhZwomp/UV8veg/dNJWBeIoVGaR1+M5TP+4j1Qs0B5R2c6y08\n uMMteBnL0twGr7m1W4Up5uyasq1ABzQH2yKhJVdoKtj3i4cGfdsJ3o67K3yJrAUR1XjQSfggP5h\n nMXnB8UR7CHfHdw4t/WOSn4i9K1hxLzx5e85YW83oqgb7Z1u6uuq5qxs7z8GDO5tDGioiST4vw8\n +D4z1w4GaGSe7OJPTKdRm1IHXCINQq0ZJzfIGPPiPqtBcSSGA4fdGbg/0mJLRpX6z60C2HTayTh\n 5D2DuxjFfc2oOWKZPY8N8oLm0Rsvgpot1UrfwXkcuhNSraGjk0COvsXBptAZR/bSC+pAKAFzjqh\n fCBpo6BknanWeEgyucDs1dxFT2B/Z/d5IoD+Q1qklbpuSa+R1AH2tGKYx9lp21cSWk8g5x3y/qb\n JftdsgmRUo8NkOiFdAQ==", "X-Authority-Analysis": "v=2.4 cv=XLYAjwhE c=1 sm=1 tr=0 ts=69e7a632 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=sIuuyFDGXZ7lsjPJAw8A:9", "X-Proofpoint-GUID": "Y2D0O8dydVFHz1qhCWQkjU-NruMsLYeb", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 adultscore=0\n priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0\n suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000\n definitions=main-2604210162" }, "content": "For zPCI devices, we have platform specific error information. The platform\nfirmware provides this error information to the operating system in an\narchitecture specific mechanism. To enable recovery from userspace for\nthese devices, we want to expose this error information to userspace. Add a\nnew device feature to expose this information.\n\nReviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>\nSigned-off-by: Farhan Ali <alifm@linux.ibm.com>\n---\n arch/s390/include/asm/pci.h | 2 ++\n arch/s390/pci/pci_event.c | 19 ++++++++++++++++\n drivers/vfio/pci/vfio_pci_core.c | 2 ++\n drivers/vfio/pci/vfio_pci_priv.h | 9 ++++++++\n drivers/vfio/pci/vfio_pci_zdev.c | 39 ++++++++++++++++++++++++++++++++\n include/uapi/linux/vfio.h | 29 ++++++++++++++++++++++++\n 6 files changed, 100 insertions(+)", "diff": "diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h\nindex 9a6a4eb9d7c1..b1858d512fec 100644\n--- a/arch/s390/include/asm/pci.h\n+++ b/arch/s390/include/asm/pci.h\n@@ -360,6 +360,8 @@ int zpci_clear_error_state(struct zpci_dev *zdev);\n int zpci_reset_load_store_blocked(struct zpci_dev *zdev);\n void zpci_start_mediated_recovery(struct zpci_dev *zdev);\n void zpci_stop_mediated_recovery(struct zpci_dev *zdev);\n+int zpci_get_pending_error(struct zpci_dev *zdev,\n+\t\t\t struct zpci_ccdf_err *ccdf);\n \n #ifdef CONFIG_NUMA\n \ndiff --git a/arch/s390/pci/pci_event.c b/arch/s390/pci/pci_event.c\nindex c279a9f50a64..227a939fcad3 100644\n--- a/arch/s390/pci/pci_event.c\n+++ b/arch/s390/pci/pci_event.c\n@@ -74,6 +74,25 @@ static void zpci_store_pci_error(struct pci_dev *pdev,\n \tzdev->pending_errs.count++;\n }\n \n+int zpci_get_pending_error(struct zpci_dev *zdev,\n+\t\t\t struct zpci_ccdf_err *ccdf)\n+{\n+\tint head = 0;\n+\n+\tguard(mutex)(&zdev->pending_errs_lock);\n+\n+\tif (!zdev->pending_errs.count)\n+\t\treturn -ENOMSG;\n+\n+\thead = zdev->pending_errs.head % ZPCI_ERR_PENDING_MAX;\n+\tmemcpy(ccdf, &zdev->pending_errs.err[head],\n+\t\tsizeof(struct zpci_ccdf_err));\n+\tzdev->pending_errs.head++;\n+\tzdev->pending_errs.count--;\n+\treturn 0;\n+}\n+EXPORT_SYMBOL_GPL(zpci_get_pending_error);\n+\n void zpci_start_mediated_recovery(struct zpci_dev *zdev)\n {\n \tguard(mutex)(&zdev->pending_errs_lock);\ndiff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c\nindex ad52abc46c04..5403730786a1 100644\n--- a/drivers/vfio/pci/vfio_pci_core.c\n+++ b/drivers/vfio/pci/vfio_pci_core.c\n@@ -1534,6 +1534,8 @@ int vfio_pci_core_ioctl_feature(struct vfio_device *device, u32 flags,\n \t\treturn vfio_pci_core_feature_token(vdev, flags, arg, argsz);\n \tcase VFIO_DEVICE_FEATURE_DMA_BUF:\n \t\treturn vfio_pci_core_feature_dma_buf(vdev, flags, arg, argsz);\n+\tcase VFIO_DEVICE_FEATURE_ZPCI_ERROR:\n+\t\treturn vfio_pci_zdev_feature_err(device, flags, arg, argsz);\n \tdefault:\n \t\treturn -ENOTTY;\n \t}\ndiff --git a/drivers/vfio/pci/vfio_pci_priv.h b/drivers/vfio/pci/vfio_pci_priv.h\nindex fca9d0dfac90..4e7162234a2e 100644\n--- a/drivers/vfio/pci/vfio_pci_priv.h\n+++ b/drivers/vfio/pci/vfio_pci_priv.h\n@@ -93,6 +93,8 @@ int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,\n \t\t\t\tstruct vfio_info_cap *caps);\n int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev);\n void vfio_pci_zdev_close_device(struct vfio_pci_core_device *vdev);\n+int vfio_pci_zdev_feature_err(struct vfio_device *device, u32 flags,\n+\t\t\t void __user *arg, size_t argsz);\n #else\n static inline int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,\n \t\t\t\t\t struct vfio_info_cap *caps)\n@@ -107,6 +109,13 @@ static inline int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev)\n \n static inline void vfio_pci_zdev_close_device(struct vfio_pci_core_device *vdev)\n {}\n+\n+static inline int vfio_pci_zdev_feature_err(struct vfio_device *device,\n+\t\t\t\t\t u32 flags, void __user *arg,\n+\t\t\t\t\t size_t argsz)\n+{\n+\treturn -ENOTTY;\n+}\n #endif\n \n static inline bool vfio_pci_is_vga(struct pci_dev *pdev)\ndiff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c\nindex 0658095ac5b1..679d9fb44692 100644\n--- a/drivers/vfio/pci/vfio_pci_zdev.c\n+++ b/drivers/vfio/pci/vfio_pci_zdev.c\n@@ -141,6 +141,45 @@ int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,\n \treturn ret;\n }\n \n+int vfio_pci_zdev_feature_err(struct vfio_device *device, u32 flags,\n+\t\t\t void __user *arg, size_t argsz)\n+{\n+\tstruct vfio_device_feature_zpci_err err = {};\n+\tstruct vfio_pci_core_device *vdev;\n+\tstruct zpci_ccdf_err ccdf = {};\n+\tstruct zpci_dev *zdev;\n+\tint ret;\n+\n+\tvdev = container_of(device, struct vfio_pci_core_device, vdev);\n+\tzdev = to_zpci(vdev->pdev);\n+\tif (!zdev)\n+\t\treturn -ENODEV;\n+\n+\tret = vfio_check_feature(flags, argsz, VFIO_DEVICE_FEATURE_GET,\n+\t\t\t\t sizeof(err));\n+\tif (ret != 1)\n+\t\treturn ret;\n+\n+\tret = zpci_get_pending_error(zdev, &ccdf);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\terr.fh = ccdf.fh;\n+\terr.fid = ccdf.fid;\n+\terr.ett = ccdf.ett;\n+\terr.mvn = ccdf.mvn;\n+\terr.dmaas = ccdf.dmaas;\n+\terr.q = ccdf.q;\n+\terr.rw = ccdf.rw;\n+\terr.faddr = ccdf.faddr;\n+\terr.pec = ccdf.pec;\n+\n+\tif (copy_to_user(arg, &err, sizeof(err)))\n+\t\treturn -EFAULT;\n+\n+\treturn 0;\n+}\n+\n int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev)\n {\n \tstruct zpci_dev *zdev = to_zpci(vdev->pdev);\ndiff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h\nindex 5de618a3a5ee..e78f53ab561a 100644\n--- a/include/uapi/linux/vfio.h\n+++ b/include/uapi/linux/vfio.h\n@@ -1534,6 +1534,35 @@ struct vfio_device_feature_dma_buf {\n */\n #define VFIO_DEVICE_FEATURE_MIG_PRECOPY_INFOv2 12\n \n+/**\n+ * VFIO_DEVICE_FEATURE_ZPCI_ERROR feature provides PCI error information to\n+ * userspace for vfio-pci devices on s390x. On s390x, PCI error recovery\n+ * involves platform firmware and notification to operating system is done\n+ * by architecture specific mechanism. Exposing this information to\n+ * userspace allows it to take appropriate actions to handle an\n+ * error on the device.\n+ */\n+\n+struct vfio_device_feature_zpci_err {\n+\t__u32 flags;\t\t\t/* Indicate feature in non CCDF reserved space */\n+\t__u32 reserved1;\n+\t__u32 fh;\t\t\t/* function handle */\n+\t__u32 fid;\t\t\t/* function id */\n+\t__u32 ett\t\t: 4;\t/* expected table type */\n+\t__u32 mvn\t\t: 12;\t/* MSI vector number */\n+\t__u32 dmaas\t\t: 8;\t/* DMA address space */\n+\t__u32 reserved2\t\t: 6;\n+\t__u32 q\t\t\t: 1;\t/* event qualifier */\n+\t__u32 rw\t\t: 1;\t/* read/write */\n+\t__u64 faddr;\t\t\t/* failing address */\n+\t__u32 reserved3;\n+\t__u16 reserved4;\n+\t__u16 pec;\t\t\t/* PCI event code */\n+\t__u8 reserved5[28];\t\t/* Non CCDF reserved space */\n+};\n+\n+#define VFIO_DEVICE_FEATURE_ZPCI_ERROR 13\n+\n /* -------- API for Type1 VFIO IOMMU -------- */\n \n /**\n", "prefixes": [ "v14", "5/7" ] }