Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2225656/?format=api
{ "id": 2225656, "url": "http://patchwork.ozlabs.org/api/patches/2225656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260421113416.4040274-3-yangerkun@huawei.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421113416.4040274-3-yangerkun@huawei.com>", "list_archive_url": null, "date": "2026-04-21T11:34:15", "name": "[PATH,6.6,2/3] ext4: get rid of ppath in ext4_force_split_extent_at()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "ec0062cd055fc02aac22736bfce6658b8c4558ac", "submitter": { "id": 75707, "url": "http://patchwork.ozlabs.org/api/people/75707/?format=api", "name": "Yang Erkun", "email": "yangerkun@huawei.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260421113416.4040274-3-yangerkun@huawei.com/mbox/", "series": [ { "id": 500784, "url": "http://patchwork.ozlabs.org/api/series/500784/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=500784", "date": "2026-04-21T11:34:14", "name": "fix potential ext4 null pointer", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500784/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225656/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=ai4h=CU=vger.kernel.org=linux-ext4+bounces-15953-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=ai4h=cu=vger.kernel.org=linux-ext4+bounces-15953-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=fail (p=quarantine dis=none) header.from=huawei.com", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15953-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=45.249.212.56", "smtp.subspace.kernel.org;\n dmarc=fail (p=quarantine dis=none) header.from=huawei.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=huaweicloud.com" ], "Received": [ "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0LJH7169z1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 21:50:07 +1000 (AEST)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4g0LJH5x19z4wC3\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 21:50:07 +1000 (AEST)", "by gandalf.ozlabs.org (Postfix)\n\tid 4g0LJH5rwLz4wCJ; Tue, 21 Apr 2026 21:50:07 +1000 (AEST)", "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4g0LJC6gTKz4wC3\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 21 Apr 2026 21:50:03 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 52BDA300EF9A\n\tfor <patchwork-incoming@ozlabs.org>; Tue, 21 Apr 2026 11:47:22 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 38EF2363097;\n\tTue, 21 Apr 2026 11:47:22 +0000 (UTC)", "from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com\n [45.249.212.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C926A378822\n\tfor <linux-ext4@vger.kernel.org>; Tue, 21 Apr 2026 11:47:18 +0000 (UTC)", "from mail.maildlp.com (unknown [172.19.163.198])\n\tby dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4g0LDS4gMGzKHMls\n\tfor <linux-ext4@vger.kernel.org>; Tue, 21 Apr 2026 19:46:48 +0800 (CST)", "from mail02.huawei.com (unknown [10.116.40.252])\n\tby mail.maildlp.com (Postfix) with ESMTP id B920040602\n\tfor <linux-ext4@vger.kernel.org>; Tue, 21 Apr 2026 19:47:07 +0800 (CST)", "from huaweicloud.com (unknown [10.50.87.129])\n\tby APP3 (Coremail) with SMTP id _Ch0CgAHtL21Y+dp_aHLBA--.55420S6;\n\tTue, 21 Apr 2026 19:47:07 +0800 (CST)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1776772207; cv=pass;\n\tb=FS+YdjA4mXAVlSLosblUjV4pyLg99oSNM0wVD24fP/q1L988wy2ZNkT7oAncQbpcg8S2etZwjKIdxoH51QFFfY/IwYGZEwJcbygs+mnhw8HiMNG39/gB9meBXYrWgdHPWm7LRPK31QyhErJqUco4WaYKABM+BDzTJJQvQWJ3jmCrGFHTZ1W2cbmKJmi6BIFmfJWCTUWzS0LnS2ctkcZuavO0sPt2DPYbNngZy/tDrEYU8iR/a9QtmQARLC7t6a2jvVKS4r1hvpb9Aw0icvtwxoHb9uMbngRYcxtqJC4lzpFN/DU5vVTampbeLsTEbrcjr9HXeMi6U4vfmdylmdORYg==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776772042; cv=none;\n b=Fgae5Qlo99mlw15O213pZlGWWWDfIBhg9qfWwuBdb9Qbudp9aV5qdq7tGPzfLZTCi+C8mjyhHpgH54BRe0UTdgxwXZO/M3fKuUZa/1+cqPa2vNdJ2NSrlM1OtxrBRPNTwGdSA7K+5SP8tU247ZqHdudtm/RfNkIHR3UdTh6TleE=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1776772207; c=relaxed/relaxed;\n\tbh=aUDLm6euMVglPz0uIOiDgB42pcDKVNvxz1raLBSxQ3o=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=TI2NEVyIr/aU0x3OSS/zmHfWXrY9GoFRZEToxGM6wPS4Mjj8YtMxW7/9SBHF4hdemVCENqH0X/fM5jPTaUzcND3upA7xNfqCmyIzXbnJUJsA7e8zc7JBmNhzybw7AO9sCAWPrmWmBoqqADDJxnB2nq6O65tr9ODyUkiY7E6m9tvZmsziwrrtT9NijPNtK1+IOOlIwpkn+TZ29PKAGHSc3lqr8QlWCVh9i0syTs9fDubBfa9t5yctsFOtGE4nEa3tJIu9golo9KpOvRtejAhexWp39LRj+w1mBN5Bw48CSwKZGanVYMNdBhRFNWLbjVDMcYNqVZ0uS4ExDAjdosZ7ow==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776772042; c=relaxed/simple;\n\tbh=EXIpyePpkEcn2m5uABMFMAm/ipu1E/AN4eD7mtstiiw=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=qFruAu/wyouI9zjYIrowe6taDGMQul+s4h8/wsNzknX2strf03TceN4LIk951sw/XXvQDkbfRoS+W15z4HAshQGq8ksyvptK62Ka8ad0i5Xax8zJb9eBu8YrLsJGB/849lG/0nJFTNQF2qgaYoBMnHDDR1skhFMRfEpBpAhuSCo=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=fail (p=quarantine dis=none) header.from=huawei.com;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-15953-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=fail (p=quarantine dis=none) header.from=huawei.com;\n spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56" ], "From": "Yang Erkun <yangerkun@huawei.com>", "To": "stable@kernel.org,\n\tlinux-ext4@vger.kernel.org", "Cc": "tytso@mit.edu,\n\tlibaokun@linux.alibaba.com,\n\tadilger.kernel@dilger.ca,\n\tojaswin@linux.ibm.com,\n\tritesh.list@gmail.com,\n\tjack@suse.cz,\n\tgregkh@linuxfoundation.org,\n\tsashal@kernel.org,\n\tyangerkun@huawei.com,\n\tyi.zhang@huawei.com,\n\tzhangxiaoxu5@huawei.com", "Subject": "[PATH 6.6 2/3] ext4: get rid of ppath in ext4_force_split_extent_at()", "Date": "Tue, 21 Apr 2026 19:34:15 +0800", "Message-Id": "<20260421113416.4040274-3-yangerkun@huawei.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20260421113416.4040274-1-yangerkun@huawei.com>", "References": "<20260421113416.4040274-1-yangerkun@huawei.com>", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "_Ch0CgAHtL21Y+dp_aHLBA--.55420S6", "X-Coremail-Antispam": "1UD129KBjvJXoW3Ar47Gr48Aw47GFy5Wr18AFb_yoW7XF1fpr\n\t13CFn7Gr95Kas0grWIq3W7Zr1aka1UGrWUGr97Gas5GF1qqw1F9F17t3WrtFy5trW8ua4a\n\tyr4I9r15W3W5ta7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n\t9KBjDU0xBIdaVrnRJUUUmvb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2\n\t6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUXw\n\tA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS\n\tw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV\n\tWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_\n\tGcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx\n\t0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4UJVWxJr1lOx8S6xCaFVCjc4AY\n\t6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS14\n\tv26r1q6r43MxAIw28IcxkI7VAKI48JMxAIw28IcVAKzI0EY4vE52x082I5MxC20s026xCa\n\tFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_Jr\n\tWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j\n\t6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr\n\t0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUv\n\tcSsGvfC2KfnxnUUI43ZEXa7IU1jXdUUUUUU==", "Sender": "yangerkun@huaweicloud.com", "X-CM-SenderInfo": "51dqwvhunx0q5kxd4v5lfo033gof0z/", "X-Spam-Status": "No, score=0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDMARC_QUAR,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "From: Baokun Li <libaokun1@huawei.com>\n\n[ Upstream commit f07be1c367369636d7d338d7994473d6eae283c5 ]\n\nThe use of path and ppath is now very confusing, so to make the code more\nreadable, pass path between functions uniformly, and get rid of ppath.\n\nTo get rid of the ppath in ext4_force_split_extent_at(), the following is\ndone here:\n\n * Free the extents path when an error is encountered.\n\nNo functional changes.\n\nSigned-off-by: Baokun Li <libaokun1@huawei.com>\nReviewed-by: Jan Kara <jack@suse.cz>\nReviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>\nTested-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>\nLink: https://patch.msgid.link/20240822023545.1994557-17-libaokun@huaweicloud.com\nSigned-off-by: Theodore Ts'o <tytso@mit.edu>\nSigned-off-by: Yang Erkun <yangerkun@huawei.com>\n---\n fs/ext4/extents.c | 69 ++++++++++++++++++++++++++---------------------\n 1 file changed, 38 insertions(+), 31 deletions(-)", "diff": "diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c\nindex 300bf2289bc1..0406dac7fbf1 100644\n--- a/fs/ext4/extents.c\n+++ b/fs/ext4/extents.c\n@@ -329,27 +329,20 @@ static inline int ext4_ext_space_root_idx(struct inode *inode, int check)\n \treturn size;\n }\n \n-static inline int\n+static inline struct ext4_ext_path *\n ext4_force_split_extent_at(handle_t *handle, struct inode *inode,\n-\t\t\t struct ext4_ext_path **ppath, ext4_lblk_t lblk,\n+\t\t\t struct ext4_ext_path *path, ext4_lblk_t lblk,\n \t\t\t int nofail)\n {\n-\tstruct ext4_ext_path *path = *ppath;\n \tint unwritten = ext4_ext_is_unwritten(path[path->p_depth].p_ext);\n \tint flags = EXT4_EX_NOCACHE | EXT4_GET_BLOCKS_PRE_IO;\n \n \tif (nofail)\n \t\tflags |= EXT4_GET_BLOCKS_METADATA_NOFAIL | EXT4_EX_NOFAIL;\n \n-\tpath = ext4_split_extent_at(handle, inode, path, lblk, unwritten ?\n+\treturn ext4_split_extent_at(handle, inode, path, lblk, unwritten ?\n \t\t\tEXT4_EXT_MARK_UNWRIT1|EXT4_EXT_MARK_UNWRIT2 : 0,\n \t\t\tflags);\n-\tif (IS_ERR(path)) {\n-\t\t*ppath = NULL;\n-\t\treturn PTR_ERR(path);\n-\t}\n-\t*ppath = path;\n-\treturn 0;\n }\n \n static int\n@@ -2890,11 +2883,12 @@ int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start,\n \t\t\t * fail removing space due to ENOSPC so try to use\n \t\t\t * reserved block if that happens.\n \t\t\t */\n-\t\t\terr = ext4_force_split_extent_at(handle, inode, &path,\n-\t\t\t\t\t\t\t end + 1, 1);\n-\t\t\tif (err < 0)\n+\t\t\tpath = ext4_force_split_extent_at(handle, inode, path,\n+\t\t\t\t\t\t\t end + 1, 1);\n+\t\t\tif (IS_ERR(path)) {\n+\t\t\t\terr = PTR_ERR(path);\n \t\t\t\tgoto out;\n-\n+\t\t\t}\n \t\t} else if (sbi->s_cluster_ratio > 1 && end >= ex_end &&\n \t\t\t partial.state == initial) {\n \t\t\t/*\n@@ -5772,17 +5766,21 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1,\n \t\t/* Prepare left boundary */\n \t\tif (e1_blk < lblk1) {\n \t\t\tsplit = 1;\n-\t\t\t*erp = ext4_force_split_extent_at(handle, inode1,\n-\t\t\t\t\t\t&path1, lblk1, 0);\n-\t\t\tif (unlikely(*erp))\n+\t\t\tpath1 = ext4_force_split_extent_at(handle, inode1,\n+\t\t\t\t\t\t\t path1, lblk1, 0);\n+\t\t\tif (IS_ERR(path1)) {\n+\t\t\t\t*erp = PTR_ERR(path1);\n \t\t\t\tgoto finish;\n+\t\t\t}\n \t\t}\n \t\tif (e2_blk < lblk2) {\n \t\t\tsplit = 1;\n-\t\t\t*erp = ext4_force_split_extent_at(handle, inode2,\n-\t\t\t\t\t\t&path2, lblk2, 0);\n-\t\t\tif (unlikely(*erp))\n+\t\t\tpath2 = ext4_force_split_extent_at(handle, inode2,\n+\t\t\t\t\t\t\t path2, lblk2, 0);\n+\t\t\tif (IS_ERR(path2)) {\n+\t\t\t\t*erp = PTR_ERR(path2);\n \t\t\t\tgoto finish;\n+\t\t\t}\n \t\t}\n \t\t/* ext4_split_extent_at() may result in leaf extent split,\n \t\t * path must to be revalidated. */\n@@ -5798,17 +5796,21 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1,\n \n \t\tif (len != e1_len) {\n \t\t\tsplit = 1;\n-\t\t\t*erp = ext4_force_split_extent_at(handle, inode1,\n-\t\t\t\t\t\t&path1, lblk1 + len, 0);\n-\t\t\tif (unlikely(*erp))\n+\t\t\tpath1 = ext4_force_split_extent_at(handle, inode1,\n+\t\t\t\t\t\t\tpath1, lblk1 + len, 0);\n+\t\t\tif (IS_ERR(path1)) {\n+\t\t\t\t*erp = PTR_ERR(path1);\n \t\t\t\tgoto finish;\n+\t\t\t}\n \t\t}\n \t\tif (len != e2_len) {\n \t\t\tsplit = 1;\n-\t\t\t*erp = ext4_force_split_extent_at(handle, inode2,\n-\t\t\t\t\t\t&path2, lblk2 + len, 0);\n-\t\t\tif (*erp)\n+\t\t\tpath2 = ext4_force_split_extent_at(handle, inode2,\n+\t\t\t\t\t\t\tpath2, lblk2 + len, 0);\n+\t\t\tif (IS_ERR(path2)) {\n+\t\t\t\t*erp = PTR_ERR(path2);\n \t\t\t\tgoto finish;\n+\t\t\t}\n \t\t}\n \t\t/* ext4_split_extent_at() may result in leaf extent split,\n \t\t * path must to be revalidated. */\n@@ -5974,24 +5976,29 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start,\n \t\text4_ext_get_actual_len(ex) != len) {\n \t\t/* We need to split this extent to match our extent first */\n \t\tdown_write(&EXT4_I(inode)->i_data_sem);\n-\t\tret = ext4_force_split_extent_at(NULL, inode, &path, start, 1);\n+\t\tpath = ext4_force_split_extent_at(NULL, inode, path, start, 1);\n \t\tup_write(&EXT4_I(inode)->i_data_sem);\n-\t\tif (ret)\n+\t\tif (IS_ERR(path)) {\n+\t\t\tret = PTR_ERR(path);\n \t\t\tgoto out;\n+\t\t}\n \n \t\tpath = ext4_find_extent(inode, start, path, 0);\n \t\tif (IS_ERR(path))\n \t\t\treturn PTR_ERR(path);\n+\n \t\tex = path[path->p_depth].p_ext;\n \t\tWARN_ON(le32_to_cpu(ex->ee_block) != start);\n \n \t\tif (ext4_ext_get_actual_len(ex) != len) {\n \t\t\tdown_write(&EXT4_I(inode)->i_data_sem);\n-\t\t\tret = ext4_force_split_extent_at(NULL, inode, &path,\n-\t\t\t\t\t\t\t start + len, 1);\n+\t\t\tpath = ext4_force_split_extent_at(NULL, inode, path,\n+\t\t\t\t\t\t\t start + len, 1);\n \t\t\tup_write(&EXT4_I(inode)->i_data_sem);\n-\t\t\tif (ret)\n+\t\t\tif (IS_ERR(path)) {\n+\t\t\t\tret = PTR_ERR(path);\n \t\t\t\tgoto out;\n+\t\t\t}\n \n \t\t\tpath = ext4_find_extent(inode, start, path, 0);\n \t\t\tif (IS_ERR(path))\n", "prefixes": [ "PATH", "6.6", "2/3" ] }