Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2225633/?format=api
{ "id": 2225633, "url": "http://patchwork.ozlabs.org/api/patches/2225633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openwrt/patch/20260421094730.2864478-1-erik.r.karlsson@gmail.com/", "project": { "id": 45, "url": "http://patchwork.ozlabs.org/api/projects/45/?format=api", "name": "OpenWrt development", "link_name": "openwrt", "list_id": "openwrt-devel.lists.openwrt.org", "list_email": "openwrt-devel@lists.openwrt.org", "web_url": "http://openwrt.org/", "scm_url": "git://git.openwrt.org/openwrt.git", "webscm_url": "https://dev.openwrt.org/browser", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260421094730.2864478-1-erik.r.karlsson@gmail.com>", "list_archive_url": null, "date": "2026-04-21T09:47:30", "name": "[mdnsd] service: do not leak uninitialized data in SRV record", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "796e0bd62eefcce03a33ea13bf9347b2ea31e454", "submitter": { "id": 82056, "url": "http://patchwork.ozlabs.org/api/people/82056/?format=api", "name": "Erik Karlsson", "email": "erik.r.karlsson@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openwrt/patch/20260421094730.2864478-1-erik.r.karlsson@gmail.com/mbox/", "series": [ { "id": 500771, "url": "http://patchwork.ozlabs.org/api/series/500771/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openwrt/list/?series=500771", "date": "2026-04-21T09:47:30", "name": "[mdnsd] service: do not leak uninitialized data in SRV record", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500771/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225633/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=leAmmo1u;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ZCcNpPd+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0HfD2glWz1yJG\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 19:50:27 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wF7iY-00000008Mgs-1p0n;\n\tTue, 21 Apr 2026 09:48:30 +0000", "from mail-lf1-x132.google.com ([2a00:1450:4864:20::132])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wF7iU-00000008Mg6-2SDI\n\tfor openwrt-devel@lists.openwrt.org;\n\tTue, 21 Apr 2026 09:48:27 +0000", "by mail-lf1-x132.google.com with SMTP id\n 2adb3069b0e04-5a402b2d102so4712760e87.3\n for <openwrt-devel@lists.openwrt.org>;\n Tue, 21 Apr 2026 02:48:25 -0700 (PDT)", "from erik-ThinkPad-T14-Gen-4.lan\n ([2001:9b1:925b:6407:7e38:cdcc:8a93:f0d3])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4185ad0b8sm3560963e87.15.2026.04.21.02.48.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 02:48:23 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc\n\t:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=0ZE57J414VwaWsbqz//jkQidaeenAsbHuvn1d2DLeCE=; b=leAmmo1uEGGH01\n\tdkMgkBAKeriG44c4yWgnTcNeH9tGyXAyvfWJK+O9+6+RJqHMJtLPvRzUvXaUxx7jY8iBYCQKPsh64\n\tIf87TuxLhUhvJhnpGAcf5KtYbOShn5W9UOZmT9Yd67WPg3xSOuvKpnajoWXNgH3DywZ82dZczRwL0\n\tRWt699MA6QYzvv6S0x3IO5usXSOZfca6xFMby5baSSqBTSOLTLuqASAeOzrtIwUKzASJPGXujk91w\n\t9MGwCTCaGFYDCS50X5gqBHIIPHC7g8TU0GES7MYxSeXca0xJ4pCZdJRGN7YTegXJpNBPrwSDPg6zu\n\tyz6poC1qrtmF0YNCqTCQ==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776764904; x=1777369704;\n darn=lists.openwrt.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=F34D4QY9d7o/zqw3L1XEBtzyEkeQySdWyPEFc0yBObg=;\n b=ZCcNpPd+vMNNFqStylbiK7xogJ4rpDuI3fNvFJgEtxR29Y5EhLP0ID9RCqPivNeCdm\n wpR10kjvPikQFowhiOfiXAxZoUl6dc9hII4nBkVyGtoAMoF3Qa014B2innopi5loqc29\n 3ULkCYJf8LSHC+lqNf6YS8e7olMAGUk82WksLK1N/cz8t4eMzhre4TTEtSG5GeWXP+FD\n OQdfJx/S86LUzy4CUk6Hg77f7Uk4G7fatINtUesBFJy/6so3oGdVe2u5ataRB+bBHi+i\n NjLiQT1UObAVhpe0sbb8lOl5e361nBCvuMe5OP2c+gff5kIH0J4ZLmyjmQHogeBHPMqk\n UPvw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776764904; x=1777369704;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=F34D4QY9d7o/zqw3L1XEBtzyEkeQySdWyPEFc0yBObg=;\n b=qw8ywU+MenXZ2krQ4h5EDpzwpxnc7I+IvDdW6LbJzAf+5XkLio+GwKdfaF3P5IJK2F\n 2Pr55Yc2x5pBfGCLDFH5FwlJ7CDuMZRYS7Ul9bVjzq5bi45VmEIQ8Dd7nhDf+Jesf5Ju\n VOWZJvaiQyKKqlFNJGjByrSruhUwqNNoUSIfriX0huh3flllLvHwQhomikhCjqFoamDJ\n Q4s2r8ic6meEU/3VGBYPbnGMuCa146EQtFpra0gh0mmZwrimml0ipVUnOTZLRpUKyvlc\n A7+bdg6rB3I9tNtuTqw+bCxB6pPhm0zNrP0bZfl2M3maT6U4Mi6RuL2mOsOXzKouP1eS\n jhkQ==", "X-Gm-Message-State": "AOJu0YxSUH6iQ9anoRE9HXUIzmhjG/Wml7qEJyL3OvxswYsOO9L9u6MH\n\ttkFlThlRhERHOC9YyjSYOj0xaacM3XIWvtlpHlFp5pJMWz7ckhKYjCe9", "X-Gm-Gg": "AeBDieuqTNQFGgTtBYRlaSIZyIY1Ejrqr34FP8PT/srakBLcZVFs1XfQ9PGLWXHyVCG\n\tjBb24GzBezdiCE/c/ubPpwZ0Vdio9LK0oYo7JfOXUy238WVg69fvLwVQWiSrS8AA2sEsfGk+uw1\n\t4YGiTelIt1rTmN4vVWeRM4u7Q4Tm+7vZt9kBwcFEzx5n0a9fCMEGv3h7jKBfGzEgbreJKosiat/\n\tR8TJw57hKOXD+hZAaaactQ/RU+77GAxNcIlCrfrmJUhjTSsVnVuUYyjf+rs45qZp9zrnppPSOtZ\n\tZTASETFbS66yVqnFqcM58spgXFLbcPvlEx0m7e/xd3CJNndWm0z/H4hrSi0Wy/ChjZesNRmUTuy\n\trbHKi/Sy6M14P7y8u2MuJHe1yrLCNWfZv85I1K75sQIiL2IcaiFTlKsI0eo1FAGpdWi7a5mHjKY\n\tmJWBBo7Mwrth8AHPF0coU5Nkq0jA38jyTjAXteg4lNgE5pxEZwy+tNomAADcugRnra", "X-Received": "by 2002:a05:6512:234f:b0:5a4:304:43c9 with SMTP id\n 2adb3069b0e04-5a4172ca2femr6478145e87.14.1776764903709;\n Tue, 21 Apr 2026 02:48:23 -0700 (PDT)", "From": "Erik Karlsson <erik.r.karlsson@gmail.com>", "To": "john@phrozen.org", "Cc": "openwrt-devel@lists.openwrt.org,\n\tErik Karlsson <erik.karlsson@iopsys.eu>", "Subject": "[PATCH mdnsd] service: do not leak uninitialized data in SRV record", "Date": "Tue, 21 Apr 2026 11:47:30 +0200", "Message-ID": "<20260421094730.2864478-1-erik.r.karlsson@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260421_024826_629772_E1C4FEBA ", "X-CRM114-Status": "UNSURE ( 9.49 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Erik Karlsson The priority and weight fields will be\n set to zero in accordance with behavior prior to introduction of the bug\n where calloc was used and in accordance with RFC 6763 Section 5 which\n prescribes\n priorit [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [2a00:1450:4864:20:0:0:0:132 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [erik.r.karlsson(at)gmail.com]", "X-BeenThere": "openwrt-devel@lists.openwrt.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "OpenWrt Development List <openwrt-devel.lists.openwrt.org>", "List-Unsubscribe": "<https://lists.openwrt.org/mailman/options/openwrt-devel>,\n <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe>", "List-Archive": "<http://lists.openwrt.org/pipermail/openwrt-devel/>", "List-Post": "<mailto:openwrt-devel@lists.openwrt.org>", "List-Help": "<mailto:openwrt-devel-request@lists.openwrt.org?subject=help>", "List-Subscribe": "<https://lists.openwrt.org/mailman/listinfo/openwrt-devel>,\n <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"openwrt-devel\" <openwrt-devel-bounces@lists.openwrt.org>", "Errors-To": "\n openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org" }, "content": "From: Erik Karlsson <erik.karlsson@iopsys.eu>\n\nThe priority and weight fields will be set to zero in accordance with\nbehavior prior to introduction of the bug where calloc was used and in\naccordance with RFC 6763 Section 5 which prescribes priority and weight\nof zero for a single SRV record.\n\nFixes: cef25024 (\"fix excessive stack usage\")\nSigned-off-by: Erik Karlsson <erik.karlsson@iopsys.eu>\n---\n service.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/service.c b/service.c\nindex 441ec2e..1b52dfe 100644\n--- a/service.c\n+++ b/service.c\n@@ -20,6 +20,7 @@\n #include <inttypes.h>\n #include <stdio.h>\n #include <time.h>\n+#include <string.h>\n \n #include <libubus.h>\n #include <libubox/uloop.h>\n@@ -98,6 +99,7 @@ service_add_srv(const char *name, struct service *s, int ttl)\n \tif (len <= sizeof(*sd))\n \t\treturn;\n \n+\tmemset(sd, 0, sizeof(*sd));\n \tsd->port = cpu_to_be16(s->port);\n \tdns_packet_answer(name, TYPE_SRV, mdns_buf, len, ttl);\n }\n", "prefixes": [ "mdnsd" ] }